linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Barry Song <21cnbao@gmail.com>,
	akpm@linux-foundation.org, linux-mm@kvack.org
Cc: mhocko@suse.com, fengbaopeng@honor.com, gaoxu2@honor.com,
	hailong.liu@oppo.com, kaleshsingh@google.com,
	linux-kernel@vger.kernel.org, lokeshgidra@google.com,
	ngeoffray@google.com, shli@fb.com, surenb@google.com,
	yipengxiang@honor.com, yuzhao@google.com, minchan@kernel.org,
	Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH RFC] mm: mglru: provide a separate list for lazyfree anon folios
Date: Tue, 17 Sep 2024 14:02:18 +0200	[thread overview]
Message-ID: <92f97c8e-f23d-4c6e-9f49-230fb4e96c46@redhat.com> (raw)
In-Reply-To: <20240914063746.46290-1-21cnbao@gmail.com>

On 14.09.24 08:37, Barry Song wrote:
> From: Barry Song <v-songbaohua@oppo.com>
> 
> This follows up on the discussion regarding Gaoxu's work[1]. It's
> unclear if there's still interest in implementing a separate LRU
> list for lazyfree folios, but I decided to explore it out of
> curiosity.
> 
> According to Lokesh, MADV_FREE'd anon folios are expected to be
> released earlier than file folios. One option, as implemented
> by Gao Xu, is to place lazyfree anon folios at the tail of the
> file's `min_seq` generation. However, this approach results in
> lazyfree folios being released in a LIFO manner, which conflicts
> with LRU behavior, as noted by Michal.
> 
> To address this, this patch proposes maintaining a separate list
> for lazyfree anon folios while keeping them classified under the
> "file" LRU type to minimize code changes. These lazyfree anon
> folios will still be counted as file folios and share the same
> generation with regular files. In the eviction path, the lazyfree
> list will be prioritized for scanning before the actual file
> LRU list.
> 

What's the downside of another LRU list? Do we have any experience on that?

-- 
Cheers,

David / dhildenb



  parent reply	other threads:[~2024-09-17 12:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-14  6:37 Barry Song
2024-09-15  0:58 ` wang wei
2024-10-16  2:54   ` Barry Song
2024-09-17 12:02 ` David Hildenbrand [this message]
2024-09-20  1:23   ` Barry Song
2024-09-23 22:19     ` Minchan Kim
2024-09-23 22:38       ` Barry Song
2024-09-24 20:12         ` Minchan Kim
2024-10-15 10:03     ` 回复: " gaoxu
2024-10-15 20:10       ` Barry Song
2024-10-16  1:25         ` 回复: " gaoxu
2024-09-18  6:19 ` gaoxu
2024-09-20  1:17   ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92f97c8e-f23d-4c6e-9f49-230fb4e96c46@redhat.com \
    --to=david@redhat.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengbaopeng@honor.com \
    --cc=gaoxu2@honor.com \
    --cc=hailong.liu@oppo.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lokeshgidra@google.com \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=ngeoffray@google.com \
    --cc=shli@fb.com \
    --cc=surenb@google.com \
    --cc=v-songbaohua@oppo.com \
    --cc=yipengxiang@honor.com \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox