From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CE36CF9C72 for ; Mon, 23 Sep 2024 16:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 235966B0088; Mon, 23 Sep 2024 12:01:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5596B0089; Mon, 23 Sep 2024 12:01:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 086B16B008A; Mon, 23 Sep 2024 12:01:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DBB116B0088 for ; Mon, 23 Sep 2024 12:01:37 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 86B714147C for ; Mon, 23 Sep 2024 16:01:37 +0000 (UTC) X-FDA: 82596468234.25.8B219C0 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 5A6794001C for ; Mon, 23 Sep 2024 16:01:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LUpM55EJ; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727107177; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qEml613ScxlbxV2rYvuLeC1V8WRj6hDYMm4pZjj0Dbk=; b=fj+A0jN9a6fbnYuGlIzpqXn2fS5pvottAzUNvZ2jKnMlZOzddAnRegVcUDpxOGF4I/ge9M 5I2AHLHpLx9yfQqPcpxdy50Nd59g/2WGu+YKuEwbW2uzV89tmJ608ogQpv6/3Spa5HcvhB Rm9nYgr8Df9L0mJ/OBHMB+/ry1LHc20= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727107177; a=rsa-sha256; cv=none; b=ThpqRssKkKjVbVdbFg1LP3chEWrcU6GiTutRei+VS7P7d+UxTUiiRo221UimHGjJofORxS pWa0XScpiICdrOdKyTXhQMY3gGpoCAzfGrG7wsEgLwzrBO9yaf+ONTIjdyBoa8yKDvMUnI asIljM5GGZXnKx5ODMfXJj3A28FMTUQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=LUpM55EJ; spf=pass (imf07.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-829f7911eecso263312839f.1 for ; Mon, 23 Sep 2024 09:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727107294; x=1727712094; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qEml613ScxlbxV2rYvuLeC1V8WRj6hDYMm4pZjj0Dbk=; b=LUpM55EJUkHB41vTcjQjKCSoVt+tSzD5gf0/kk1paV5jKgKkL6+cVd9vgnwNNbRWBr nmDsSY4JJrPnSwiicY5+gUvqUUWMJohsr1hfzP3xvR5XMWtWQa/enmjupvrD6rBqoZwf DKMPHUc3VV0PFTRy1py65HST6Yn8CeMZzlF3w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727107294; x=1727712094; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qEml613ScxlbxV2rYvuLeC1V8WRj6hDYMm4pZjj0Dbk=; b=NYvy9QQOPrGYv61HVNKShhRjrujtz4uLVLJyreuTxOC6k0OJ1dYCOpKFbOzEsRrBdG 61THVgARf2Ih6BNTNGExBWLhgwb5bf9CYzGDSoS4j6DtBqRglq7KtWlf04oSRkT1YAEZ clqN97JVAkD4uK+f9jbYqqav3KZtVOeiiUTQkYz/wwRyVfbSe1X9qO/Mv1KbP/1dXYuf qgS0oYx+tseGmdneNJAbpQ2nZSJJ69roWaXSky/TuZFXn57iyrMGRj+8Rk7ViZp6Lcdm ykJmxjlc9PMsGLzgO0vUuKuHkmmexzsA2T4YMNQfz3wzTfUctg98v8M29VLi7EheK4/1 yrmA== X-Forwarded-Encrypted: i=1; AJvYcCVkfZNiihpI/2h8Eu+z83TNYLkg57+R0gZDIoAGMc8IzujX61bvESK/8uGVwkbw6q26/Ke7hsN5wQ==@kvack.org X-Gm-Message-State: AOJu0YzCP8prwwcRx80AmcmQcDzviYj17yREOWumOMuQUx3q9LstAvox tvMqtL/oE0j4AG7HcUAGtZREeV0Hf8w53zYoxAC9wSptqKrnzrh2KVEGSdRjE84= X-Google-Smtp-Source: AGHT+IH1YGCGJJ3r++ctoT2ootUH7ze8FehY9Z9KUJuVPkNr2J3rM+XTA+PCfIdF8RFkh6IHB4QBAg== X-Received: by 2002:a05:6602:6d08:b0:82c:ec62:6602 with SMTP id ca18e2360f4ac-8320b328ce5mr990358739f.12.1727107294259; Mon, 23 Sep 2024 09:01:34 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-82d492b9676sm562541739f.33.2024.09.23.09.01.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 09:01:33 -0700 (PDT) Message-ID: <92f63189-851c-44d1-951e-6a6c39eb223f@linuxfoundation.org> Date: Mon, 23 Sep 2024 10:01:32 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] kselftests: mm: Fix wrong __NR_userfaultfd value To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , David Hildenbrand , John Hubbard Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240923053836.3270393-1-usama.anjum@collabora.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240923053836.3270393-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5A6794001C X-Stat-Signature: p9mugb1xtbin61uwp8aq1d1axt3cc435 X-HE-Tag: 1727107295-840398 X-HE-Meta: U2FsdGVkX1/fDR5vQsBdtvKTq+TrBrDvE6J2v3r9HgtiHvlq8U/6H0W1TKEWmw32whv9v+b+rV46wv2ewRRHdcpbcymKNcDkV232QAHy+e07Rlc44ehovsNJCSwtFhLZddSLOj4ZgYOQ4iNCou3kOTyjXOnH2s2jCC04tIHNJ/H91zNtKVzAaIKZnT4UI/2ngXVGq/yqRiSUmXpzfyICth9l/e8RCCpKh0pWpttBUM4/tHwd1vmuwHlIi/I4dXyOTmutZRCwq1/wzof3gmW314FRoOqLr2E8kaQSkzu5CmpJ67MCWwGXCcictI8PDPJMvmx7Evow74Xj2rIuHbSoVNwNi7r9jZcgweCHgbvsePRYGy6P8u0YbudJoj7dPRqFlepaZnm8dakFAXofVg1fwiCFceLaHmzdslgLfnsa7EqG2WbGefmg2dAzXgOOa6wxODeVVlUBu46itS2SfFKtWydRGTEoF10pe+fl0/oBbtlIRXUA0/syTlhXwqUYXTyL22uU6mRVvpCpLhk4Oo+M91H/rVtKjADQTaXiKbr1KLF/AHukPdX34SdyF9PpBsKW9IYghR9Xlg1cVxSMeJlVhGTfQ0y03OWkTn/euzF4LJnp78s3PIxtjoxeBK0hxeVAdpj7V3zpkOOPAjNyXhCMK85OIP/uTvqAKnCGp9hOqWLHUoYQ/qY7h1VPKO5BHimcwPEWNA1W8C57OwryNDmrKurO9289xY+HngB+bTlz+wG2KIaAU7tDvsQQLQnNrxKItJfl3fC8r6J8CK4QLsEo+6rT8sOXVUFpguKM7w9ON7vOuGFdtMQEvMDXrJTlJr47POi08q/Nb9LgmDFp9NI3l7Rmo/fLIsonMuocBOAYhkrHIncTlsJimTsbreQ7CZ65W96q/QBcQbEjBvbCQ3Ncr2BbR+N0tuboFXE5/CtjUPDllkIlleRWQNATCcMfZVcUDKq5p39iVrfkD93zS0d o7E9ipM9 KBSSq1ZCuxbDqxgXkbxL/CwnYgn1N43ttBqBNgZFzljZdK4tpeJZ5Y3ese45oCvIwPUNQTj5V7A2dHzzJHUqGdm+vNlSo2NQ7ff2z97uUo2u7t6NyywJXEwJLVr0qbmZFXNH1hWM1dUihvHnLKukaA3k9B8TJeKH7ol8YS7T6v2ThiLUBMd/7zDLBY2EG5CwboRKTZOlY015M/nva1AK1AXpr4rPMr5jia74nY+/zzxklgkuor2QvBRP8vAfSDU/6pVDLdm5y0QE1Uw8GX2eWTSJTIVe9RmufUI5Mb2pM7BaPbjmZ+HzfVmFjRVhL5p1FxOV5hCntI8HCTcR3k3ImChZZ8EVzyGsnFglIRyj67UuT2E0Qd/ZowT1MSIW+Tk/0xXj587a/fm2B4UB9dTP14Sq+96OloiMz9jGBXIiCksQSNOVs2HpjINIAGmoaBU1SjHk5/SaD6AUNdEAtGQFXze54CllZ84XsgjMzbT4BuBoqVW7yclDkGQbqCMOueRd9MQ9x9/f9RTjvJ7s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001330, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/22/24 23:38, Muhammad Usama Anjum wrote: > grep -rnIF "#define __NR_userfaultfd" > tools/include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > arch/x86/include/generated/uapi/asm/unistd_32.h:374:#define > __NR_userfaultfd 374 > arch/x86/include/generated/uapi/asm/unistd_64.h:327:#define > __NR_userfaultfd 323 > arch/x86/include/generated/uapi/asm/unistd_x32.h:282:#define > __NR_userfaultfd (__X32_SYSCALL_BIT + 323) > arch/arm/include/generated/uapi/asm/unistd-eabi.h:347:#define > __NR_userfaultfd (__NR_SYSCALL_BASE + 388) > arch/arm/include/generated/uapi/asm/unistd-oabi.h:359:#define > __NR_userfaultfd (__NR_SYSCALL_BASE + 388) > include/uapi/asm-generic/unistd.h:681:#define __NR_userfaultfd 282 > > The number is dependent on the architecture. The above data shows that: > x86 374 > x86_64 323 > > The value of __NR_userfaultfd was changed to 282 when > asm-generic/unistd.h was included. It makes the test to fail every time > as the correct number of this syscall on x86_64 is 323. Fix the header > to asm/unistd.h. > > Fixes: a5c6bc590094 ("selftests/mm: remove local __NR_* definitions") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/pagemap_ioctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/pagemap_ioctl.c b/tools/testing/selftests/mm/pagemap_ioctl.c > index fc90af2a97b80..bcc73b4e805c6 100644 > --- a/tools/testing/selftests/mm/pagemap_ioctl.c > +++ b/tools/testing/selftests/mm/pagemap_ioctl.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include Thank you. Reviewed-by: Shuah Khan thanks, -- Shuah