linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "tonnylu(陆志刚)" <tonnylu@tencent.com>
To: "mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "hzhongzhang(张昊中)" <hzhongzhang@tencent.com>,
	"knightzhang(张宗明)" <knightzhang@tencent.com>,
	"tonnylu(陆志刚)" <tonnylu@tencent.com>
Subject: [PATCH] mm/hugetlb: avoid looping to the same hugepage if !pages and
Date: Thu, 29 Aug 2019 04:32:57 +0000	[thread overview]
Message-ID: <92ec02283213415ebde233679373b0b3@tencent.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

This change greatly decrease the time of mmaping a file in hugetlbfs.
With MAP_POPULATE flag, it takes about 50 milliseconds to mmap an
existing 128GB file in hugetlbfs. With this change, it takes less
then 1 millisecond.

Signed-off-by: Zhigang Lu <tonnylu@tencent.com>
Reviewed-by: Haozhong Zhang <hzhongzhang@tencent.com>
Reviewed-by: Zongming Zhang <knightzhang@tencent.com>
---
mm/hugetlb.c | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 6d7296d..2df941a 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -4391,6 +4391,17 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
                          break;
                   }
            }
+
+            if (!pages && !vmas && !pfn_offset &&
+                (vaddr + huge_page_size(h) < vma->vm_end) &&
+                (remainder >= pages_per_huge_page(h))) {
+                   vaddr += huge_page_size(h);
+                   remainder -= pages_per_huge_page(h);
+                   i += pages_per_huge_page(h);
+                   spin_unlock(ptl);
+                   continue;
+            }
+
same_page:
            if (pages) {
                   pages[i] = mem_map_offset(page, pfn_offset);
--
1.8.3.1


[-- Attachment #2: Type: text/html, Size: 6643 bytes --]

                 reply	other threads:[~2019-08-29  4:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=92ec02283213415ebde233679373b0b3@tencent.com \
    --to=tonnylu@tencent.com \
    --cc=hzhongzhang@tencent.com \
    --cc=knightzhang@tencent.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox