From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77B1EB64DA for ; Wed, 14 Jun 2023 08:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 083E26B0075; Wed, 14 Jun 2023 04:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 033C36B0078; Wed, 14 Jun 2023 04:42:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3E928E0002; Wed, 14 Jun 2023 04:42:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D5DA86B0075 for ; Wed, 14 Jun 2023 04:42:19 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A8808B0078 for ; Wed, 14 Jun 2023 08:42:19 +0000 (UTC) X-FDA: 80900711598.20.65CB4CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 6EB9F1A000B for ; Wed, 14 Jun 2023 08:42:17 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V80kHZkm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686732137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Owpi2SX75vf893dHZP5yFIiV94ajm8nG5xJNVjgQKe4=; b=nBF/+cAbS8iPyybMbAzYjPtFov+Vrdfnwt0nhHgBuKOKh5M151oGdfzeuJKnD3LS8iUgSS wbJbRAGjgrQ9i1JMgQrq4qmdAAcBaqa2VP5kjcRHTp5BwJ2BtISkLjMZoYy8AvaGGTGpEN tJRkLUlY0GZ8N1toEN1YbUHQeexOua8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V80kHZkm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686732137; a=rsa-sha256; cv=none; b=UMl2hN/VyzZSGXJpBd8DA+NdkAV6JYhg0IN0yrMPq/9GCVYCY88+HMZaO334w91erVV/Fh BzaDDXxWK86sO7Dm0wUxP+T3mHl5HbaqYHsI75TjSa5g+4Vi/4W48eKd0fNOcOc/JfHVFv 3wAw30Nv2I955nsoTFl0oQmBLUxrPQ4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686732136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Owpi2SX75vf893dHZP5yFIiV94ajm8nG5xJNVjgQKe4=; b=V80kHZkmQzFuD7/QbnH/fnBywShDlXRV7PloEnOuZtwiwJpCmNQ4zABAICGhr7cQ7gJwRo mZysfRSH7D+4zhfVpbxaYnlHxn4gb9Da4ZmB0hUqI8QSkw8QhSDLyk7xMMWd6Uj7FwxBYl l/xnTz3vXl8pgnsIBzamJWoQWQibokQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Tr6OmCpuOkyJJxdvrszAvw-1; Wed, 14 Jun 2023 04:42:15 -0400 X-MC-Unique: Tr6OmCpuOkyJJxdvrszAvw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f739a73ba4so1392575e9.3 for ; Wed, 14 Jun 2023 01:42:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686732119; x=1689324119; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Owpi2SX75vf893dHZP5yFIiV94ajm8nG5xJNVjgQKe4=; b=X0DBNuvmNA6PoXnq6qTTtrGhiKTIma195XiVhMzOi2mbTWU2bmWUNwUvDBzi7oRGGA B183GlzdwoljghDrJFRh3ZX0LZsklHmIrMmz7Km1dpdUCkvaa1r1/6M1CRZtAUzGDYEb tCNBpTZj9xZmN3AF2FJp3ySbtLlWRSfq4aVDL2pykMFQ/0dVE4fOs3//m28VN8rHP4h5 Kq297z8NyaHOKi/OlWVlL5nRzh849d4jiz8mEatCMkyY2jy6ftqBx70tFuin+KtrG1jJ qvjIyT/VNMRD1EniUq6n9IiI7xdqiPFRIu30Ye5PAZmtENzQE5FJsSjqeTImv6DVFkXL +GEw== X-Gm-Message-State: AC+VfDyAQ5mmYyafnqTw24vbtnELiCZM9361QpEhTqYQNfsgpZHjTJIZ TdD/okF4n9uoSLVoh3GUpDuAwfcQZNkersJDr6axRLHnNuLlGxVY4RXXba/TcxyKaEMa1yqFffV 2Xfq5IHHMkyY= X-Received: by 2002:a05:600c:cb:b0:3f7:3a19:b951 with SMTP id u11-20020a05600c00cb00b003f73a19b951mr9127587wmm.21.1686732119190; Wed, 14 Jun 2023 01:41:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xTsl2WxsuwLu6DEpYmKAKYfFg1ToBVlcsmvbKJZjuhF+SpmKYqxIgztujYVuB7TtcnwaPug== X-Received: by 2002:a05:600c:cb:b0:3f7:3a19:b951 with SMTP id u11-20020a05600c00cb00b003f73a19b951mr9127575wmm.21.1686732118831; Wed, 14 Jun 2023 01:41:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id 17-20020a05600c22d100b003f8044b3436sm16370815wmg.23.2023.06.14.01.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 01:41:58 -0700 (PDT) Message-ID: <92bb89b1-23a2-668d-a5fa-6306336241a0@redhat.com> Date: Wed, 14 Jun 2023 10:41:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm: page_io: Prefer 'unsigned int' to bare use of 'unsigned' To: hexingwei001@208suo.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230614071804.13110-1-panzhiai@cdjrlc.com> <1e132a6416d673e285af610ff185fa5f@208suo.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <1e132a6416d673e285af610ff185fa5f@208suo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: wkjbgzwxm6ru9w3rb57hpdfjcjp9rcuq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6EB9F1A000B X-HE-Tag: 1686732137-128773 X-HE-Meta: U2FsdGVkX1+ZUARx2MtgImY/6IPuwLC82YqqFQ/HN+ANud+bYp2XOBHOtPn/NFrEWt83hkcd1VSrt4g5HZBQ7aBsMFB0M9Fc/7Rf724VV4jPDAY590ypDoGZdG+sTkIt01D/VBH1CKsp3YoMw6FidRhfykmeqWpHQZDUoYp1X6AxcfUompsrgaDC25YNVjjouozeTy5lIj4KZaaoaGHmoKUIwwb8l6k9vp1E0SUg5v0socNaRxBcKS+cNTqRgb1mnkKNYEMmKqkTIuJOrzRPbuBcRKNCinpKyWvR+zdGk8+2xUdjbUVS27jxnaPjsqlsUUu+N09j5C6I7lSRzWMbgq3s8Ca/QzYA5ZQQaQbWW6pCH1S7zz5V/gMLdMNEuXz2gAh59z0qJKv/4PnJuRTCs5giuiEZW7zkyJNsTbeDWdqk3mZK7vcs5DF15dC8r6XQBSYRIF5gXopjPbXRK41Cvx5sLO0Wo+6i7W/as8EEjueZ24UKieURIXx6qv9ssc4Q2TNnwtJ71tfnBF/8oWAubsKo0ZkxuvfcRrt8ehx8vclYUomhX0Ufn4JfWKVXj/nA7vtpfNYY5ndiZ0QvjjhFwyCRnStj+Ht+cVCXX3RcBX53aIvXCZScUynEfzPxKUpVcKqMAjJunzg/AOdixdbQ/P9r9YmjyJUnHktghyc51nY93BT8yHvSaHmD82ptK3XOJanfBC/+fE7ham1FncaaPm+mx0mMGW6JoOB2EQJhZX8J2Bj3wv7C30Er5rKV0r4JFa44broaqKZmOg+gTEixs+v0aHfIHmm4tNuiSKS5SSqFIbmrIEYy5VYw0bb+J4AhjGcsh7ZB3X/+z9sg3Lf8vWmTtLf3a7eM/HJsxRAbk045rJykxj02qZgYLoC4dZP5LCzPn9y/GDP6WGeRrQ63T2b7uDe7gOO1S8Y9xE1WXNnE+SbsuscnlUwgYmCg0GRvzx/XMFIiKPeUEkn3k0V jwTAk+bW xvoAUu2Tw7aYFHRBt8m0AqvDQtOu/hR0ehjbGnXN3LxHtZ300BVD4ykzhY77Yia8zntiU3zLjFOmxo/XKGXaB6dGdzLLf4geoGUld+PbvZyAt0rVYmY5eroRtrDesAD07wFa1rRdiPw8U9wG9MAZkYb2McJ/Ygm/GHej+8C+6coAkoLphTE1j/nSB7JJNJ10awUFHwMiCJKcTVZnfLHI4AymTVgf2jjkIMFx59YgzvUvZjWGB55ZFc+6mf1/5XxM7XnXiqrczPapZBDxSspnA++WEjkGv+WVdD8pyV4ZwQAgUeROS+EJfJNMZde3BkUrOwqWwvqXJ13nDV1nQGcaVxMk8cID4RFKOLLRYnCp5Q/lOD6pjLhK7PaJvjPsfFhyuOGwEpH6lgaF5CnXrQQQw4qnJe7v21rFAiVfGpGxyTzcy+S75OU6EZIkMv9QjY6n+u3x0zC73UcBIYrPCLBSW9/Pnik+3HVmRTUa1q9na/HeoHWsj6jtb1a59xZzBSWVnNZrd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.06.23 09:23, hexingwei001@208suo.com wrote: > Fix the following checkpatch warning: > > mm/page_io.c:87: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:89: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > mm/page_io.c:109: WARNING: Prefer 'unsigned int' to bare use of > 'unsigned'. > > Signed-off-by: Xingwei He > --- > mm/page_io.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index 684cd3c7b59b..138f73386612 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -84,9 +84,9 @@ int generic_swapfile_activate(struct swap_info_struct > *sis, > { > struct address_space *mapping = swap_file->f_mapping; > struct inode *inode = mapping->host; > - unsigned blocks_per_page; > + unsigned int blocks_per_page; > unsigned long page_no; > - unsigned blkbits; > + unsigned int blkbits; > sector_t probe_block; > sector_t last_block; > sector_t lowest_block = -1; > @@ -106,7 +106,7 @@ int generic_swapfile_activate(struct > swap_info_struct *sis, > last_block = i_size_read(inode) >> blkbits; > while ((probe_block + blocks_per_page) <= last_block && > page_no < sis->max) { > - unsigned block_in_page; > + unsigned int block_in_page; > sector_t first_block; > > cond_resched(); > Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb