From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19EDC433E2 for ; Tue, 15 Sep 2020 11:03:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7338121D43 for ; Tue, 15 Sep 2020 11:03:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="opnPO/r4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7338121D43 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D10F66B00BD; Tue, 15 Sep 2020 07:03:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C99316B00BE; Tue, 15 Sep 2020 07:03:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3C61900017; Tue, 15 Sep 2020 07:03:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A1986B00BD for ; Tue, 15 Sep 2020 07:03:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 51E348249980 for ; Tue, 15 Sep 2020 11:03:43 +0000 (UTC) X-FDA: 77265010326.13.net56_5203f3627110 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id ED7F918140B70 for ; Tue, 15 Sep 2020 11:03:42 +0000 (UTC) X-HE-Tag: net56_5203f3627110 X-Filterd-Recvd-Size: 5591 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Sep 2020 11:03:42 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id r7so4365306ejs.11 for ; Tue, 15 Sep 2020 04:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=tf9aVEsdXq4hvSPyIfdqowWXQx44PZPondYe5kmz/4k=; b=opnPO/r49FBHXTZplwVibG1zx7WYGIg0k+7HzzemOWXPDTJAPb5OaPiQofB6VKHYOx ZWmCKlUgo/+KApsc/iM6Oyr4UPU+GkFsE1rxiRcjVFtsKyclzVS7L2eDdFUTpqHIZqYr tcrG+95v6XQBOR5ouXG6EKOILLHlseliNnS4GFlamKMXnY6Hd9PfygI9TdpOShLPoWCj XjxK8ROzbHIFXcOM1WGnatlEBXSKtkwCTunXSooQ9yv0kiF07dJpWLVw0p8Jx9SWdPhn HoXYJLSHNaN5AAz5V5Iao4eX4tBfm4tc98ouvb12ri5RA8DAjAKotawpUjfV3h6JHuYB gBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=tf9aVEsdXq4hvSPyIfdqowWXQx44PZPondYe5kmz/4k=; b=MqU0tuNSxvGva0V7Rmuzwyv69cmI89Yt9dThhLfTtynNo9BsWmaF+kjSmkLlgxF6uS h7PNbMM6O4xpvZ6Ubpv9qNSiCrbYegn1/8tO2uDe6jDMBJBl3O+61czSPBxNhj8iH2LP OY+6lnhXdOkxniWA35Y7Bpd9rwg1swfxD9yI7AIkogOZHtpJampkr69Uidku9rhTq6Nb 5PJgYbtwj/PWa73td2j7auZZy6ziFpG+/51OA+9Zw4CbeTvXJFbNVfh95jSDZI39o5he 22dPM4uw2AbhoZmY+r79A9MqDbXnWzTCoR3VSFjFhpeeKuGmgfuc65ZIofsmMBQci6Pn 1hig== X-Gm-Message-State: AOAM531KbzHArjrVAmbDUd2HVlLA8vQXZf7qGiwf9A0lViolu2bmFXVQ 11IRMSnfDr2Z8TKrm1eQzBI= X-Google-Smtp-Source: ABdhPJxfW0HVgypcFl09FE5Qg1TZt4Ht/6KefSB8Cm0t+kwNcgrEBFWDZzSO/WzygzmfhzF4uCiGjg== X-Received: by 2002:a17:906:9491:: with SMTP id t17mr20156636ejx.253.1600167821140; Tue, 15 Sep 2020 04:03:41 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id ks21sm9916283ejb.63.2020.09.15.04.03.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Sep 2020 04:03:40 -0700 (PDT) Reply-To: christian.koenig@amd.com Subject: Re: [PATCH 1/2] drm/shmem-helpers: revert "Redirect mmap for imported dma-buf" To: Daniel Vetter Cc: Andrew Morton , Linux Kernel Mailing List , dri-devel , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Linux MM , "open list:DMA BUFFER SHARING FRAMEWORK" References: <20200914132920.59183-1-christian.koenig@amd.com> <20200914132920.59183-2-christian.koenig@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <92b77d29-ae9b-b9cd-4e03-f193aa386cae@gmail.com> Date: Tue, 15 Sep 2020 13:03:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: ED7F918140B70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Am 15.09.20 um 12:39 schrieb Daniel Vetter: > On Mon, Sep 14, 2020 at 3:29 PM Christian K=C3=B6nig > wrote: >> This reverts commit 26d3ac3cb04d171a861952e89324e347598a347f. >> >> We need to figure out if dma_buf_mmap() is valid or not first. >> >> Signed-off-by: Christian K=C3=B6nig > The trouble is that doing dma-buf mmap by looking at the struct pages > behind the sg list and just inserting those into userspace doesn't > really work any better. You still won't get the unmap_mapping_range > and hence pte shoot-down. So maybe dma_buf_mmap forwarding doesn't > work, but this doesn't make it any better. Good point. Question is what should we do? Return -EPERM? > > Also commit message should probably explain a bit the context here, > not a lot of people have been in our private discussion on this. Well, that's certain true. Christian. > -Daniel > >> --- >> drivers/gpu/drm/drm_gem_shmem_helper.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/= drm_gem_shmem_helper.c >> index 0a952f27c184..cd727343f72b 100644 >> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c >> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c >> @@ -594,9 +594,6 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj,= struct vm_area_struct *vma) >> /* Remove the fake offset */ >> vma->vm_pgoff -=3D drm_vma_node_start(&obj->vma_node); >> >> - if (obj->import_attach) >> - return dma_buf_mmap(obj->dma_buf, vma, 0); >> - >> shmem =3D to_drm_gem_shmem_obj(obj); >> >> ret =3D drm_gem_shmem_get_pages(shmem); >> -- >> 2.17.1 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > >