From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5F4C27C52 for ; Thu, 6 Jun 2024 08:36:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B30896B00A9; Thu, 6 Jun 2024 04:35:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADEAC6B00AA; Thu, 6 Jun 2024 04:35:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 958496B00AB; Thu, 6 Jun 2024 04:35:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 786866B00A9 for ; Thu, 6 Jun 2024 04:35:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E59954061A for ; Thu, 6 Jun 2024 08:35:58 +0000 (UTC) X-FDA: 82199805996.02.179AEE6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 98E2C180016 for ; Thu, 6 Jun 2024 08:35:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=agkyIPbx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HwlqLsx9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=agkyIPbx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HwlqLsx9; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717662956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BzafF/9Ae7kwGLcFiDETjPkS0+rFEzBvXkCkAibKgTc=; b=pORYGWdA1ro4ogk8VwQShw9FIXzJHoHx0TSUm7o2b0nLh/VPT2MRRz+pPCqiTXS28ZeVfz QooSB5/H46sAK59raf6DJwZ4CnIPZ+Vs+MTBhkQ8ymqLaOm7stJQndatz+Wi2Pkpcd0+Kt r9I+vS0ZUB+0drqzaxqTl/thGe81Ltk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=agkyIPbx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HwlqLsx9; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=agkyIPbx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HwlqLsx9; spf=pass (imf24.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717662956; a=rsa-sha256; cv=none; b=NimroR+wTCZx2oCEADmScESOmjGmghJwrwR7MTgF2/kU2SnVFWqPf/3L0G42AfdZgD80lL 6fZCplYiGGS2ezEBlXsOOD1kwz08ozjycvsiS4pkDQekYVRONPQFWtNqIp3Z5sjk9ATgFz o9yBmfODqA+z8DsQHJqFCHBfyXktJCc= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2372221AD8; Thu, 6 Jun 2024 08:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717662955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BzafF/9Ae7kwGLcFiDETjPkS0+rFEzBvXkCkAibKgTc=; b=agkyIPbxV5sqySyeSJKi0WwMVxNnSWccTchSc1ZfdKkxZ33Hh3AswsgnxGlghLTg1TzL/r YhZlzxR5ictqBUr/EtyclIbXwIoy3axtYI6MSMzWND9BzvJ2fkO93v8YPQAyzwjaS4BjrS gFx9/l1sfRFHY0dlAH+0BFLDI5O+vSA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717662955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BzafF/9Ae7kwGLcFiDETjPkS0+rFEzBvXkCkAibKgTc=; b=HwlqLsx9CFHArZX9omzlrLX1LewRuyXUfaK4kfZHM/VYfhJlYqRuHzhvwPGUmWVSJMLxve 9wWweS287Vhpg0AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717662955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BzafF/9Ae7kwGLcFiDETjPkS0+rFEzBvXkCkAibKgTc=; b=agkyIPbxV5sqySyeSJKi0WwMVxNnSWccTchSc1ZfdKkxZ33Hh3AswsgnxGlghLTg1TzL/r YhZlzxR5ictqBUr/EtyclIbXwIoy3axtYI6MSMzWND9BzvJ2fkO93v8YPQAyzwjaS4BjrS gFx9/l1sfRFHY0dlAH+0BFLDI5O+vSA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717662955; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BzafF/9Ae7kwGLcFiDETjPkS0+rFEzBvXkCkAibKgTc=; b=HwlqLsx9CFHArZX9omzlrLX1LewRuyXUfaK4kfZHM/VYfhJlYqRuHzhvwPGUmWVSJMLxve 9wWweS287Vhpg0AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0C58B13A1E; Thu, 6 Jun 2024 08:35:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id tnS3Aut0YWb9ZQAAD6G6ig (envelope-from ); Thu, 06 Jun 2024 08:35:55 +0000 Message-ID: <92b759d3-ab88-4471-8698-d80296b1148b@suse.cz> Date: Thu, 6 Jun 2024 10:35:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] slab: delete useless RED_INACTIVE and RED_ACTIVE Content-Language: en-US To: Chengming Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240605-b4-slab-debug-v2-0-c535b9cd361c@linux.dev> <20240605-b4-slab-debug-v2-3-c535b9cd361c@linux.dev> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240605-b4-slab-debug-v2-3-c535b9cd361c@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 98E2C180016 X-Stat-Signature: p8819g7gsksez4ak9f1xjad3oaso35to X-HE-Tag: 1717662956-953695 X-HE-Meta: U2FsdGVkX1+A7uGtcHc6stzwIXysLIAT9/gu3UVGZNVpMttYhtwxvefgD0MYemqNCs55tqNnPN3xeJRatMBROOdihHxshgYpne3xm76LxwfnKkTn54k1PbaZ1zwD3AgeWMVkR1pYNnpX7tEKv8hqZN1ZowasRHPzhol94RUDzNjDjcA9GEybmojFZARQJ4xJLfjZxbUeaQZ/tki7rv7yxrA7E8ILDsFxe6WmGSIDK4dG4i0U8IygLdZA2uqJrW8zGyzz1zvEWY6SqgNp+yJKLHVcByLRdIY58V3qaI/hVGUEXTLUbSSwrgD08H8meLtKIA/r6tAS6RSsxTbSegQ0z0xcce4ruUB3+isFFjcjXhZrSt0+5lmFD6WJ60jXJVixoBef7sOAPxa0YVmWXnqXlrgi3qxJOYlSHmUSC53EwZIacd5gY+z4/e5E4Hgd9Eww8xH5rOJweN3zf/rVZjPBRmJ8yNgCkaB2QDdhDeGIICOIWEagO0AoCUspR88HmQrrH9CH/cgFNliEGT3OAy2XCbfKV0ITvYMe5YKzuezMjrZiuIIQx7phbNZXD6Cmrb/zjnybjMu+nI68FEc9Har3VAsf8aVS8MCjGWbEgMrv6S7+NdvbXWhhBjgdJxqRB4XiiMazQ2ot+ePWARyxRxp7ZGQa6ZJQ3dI1WOW+OA2LSeIIidh8jghyzhTOg9XOZchiRSE2snEaUBPUaqN+KT578XkeEL5kAJM+qrT6X49kmtskgXf1gRjVXvK/5UyR0MlGjtCAfsKtvqn7SYBZkmLdjRq2naAdXuvAPxH0Th/hn2p8mXGOtu4igv/6rGiVvFZugNb/6LyOjAmJkgf8ti9rVObonlYEinngk/eF7j+VL2YOIV4hqA5aitROPoiVyI+yqZO4G3tssy1IJfuJG30StuR+U/0nwOoigZuV3mA57HHPu7ddgAsF7MXZNquVHgzPlSq/D55ZBcTCVVFQpEg LWTEbIzM 4Ceub9Ys7jRKYL7seejBE5u7Oce9v/DYwmO29fRwBq4S0u+0YFvKeLoaM4I5vYeeRWfeMd67yjqOSymAHSChnMqiSOo0tV/KTY4NsTpKB+ufYqfDedV7vQ0haCEbmVOUPw4s1QlM3evA0EOZ3pzLOU9WRBY4oagbohq2iPLIFRKrkxg9ayTT2f03d0ZyWQWIGojkW4puHAOAA1zXgrucVR22I/GBy4D+GHhRJoBQMPjE/EWJZQV2YvwFw76QlzuY0juMxCgpv2ANXit3yApsooLDkSAsnY2cxf7Yq70nSPxjv+HTq+gOCy5mt8BmBmRlHE90DMCyYeDJgLdrdCPYjHkAG8JDonGERPIWELUwBhwqOopkWBoKJ2Yv2oPjeSUsDsTmc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/24 9:13 AM, Chengming Zhou wrote: > These seem useless since we use the SLUB_RED_INACTIVE and SLUB_RED_ACTIVE, > so just delete them, no functional change. > > Signed-off-by: Chengming Zhou Reviewed-by: Vlastimil Babka > --- > include/linux/poison.h | 7 ++----- > mm/slub.c | 4 ++-- > tools/include/linux/poison.h | 7 ++----- > 3 files changed, 6 insertions(+), 12 deletions(-) > > diff --git a/include/linux/poison.h b/include/linux/poison.h > index 1f0ee2459f2a..9c1a035af97c 100644 > --- a/include/linux/poison.h > +++ b/include/linux/poison.h > @@ -38,11 +38,8 @@ > * Magic nums for obj red zoning. > * Placed in the first word before and the first word after an obj. > */ > -#define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ > -#define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ > - > -#define SLUB_RED_INACTIVE 0xbb > -#define SLUB_RED_ACTIVE 0xcc > +#define SLUB_RED_INACTIVE 0xbb /* when obj is inactive */ > +#define SLUB_RED_ACTIVE 0xcc /* when obj is active */ > > /* ...and for poisoning */ > #define POISON_INUSE 0x5a /* for use-uninitialised poisoning */ > diff --git a/mm/slub.c b/mm/slub.c > index 704c662227e6..0bab0f041ab2 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1214,8 +1214,8 @@ static int check_bytes_and_report(struct kmem_cache *s, struct slab *slab, > * Padding is extended by another word if Redzoning is enabled and > * object_size == inuse. > * > - * We fill with 0xbb (RED_INACTIVE) for inactive objects and with > - * 0xcc (RED_ACTIVE) for objects in use. > + * We fill with 0xbb (SLUB_RED_INACTIVE) for inactive objects and with > + * 0xcc (SLUB_RED_ACTIVE) for objects in use. > * > * object + s->inuse > * Meta data starts here. > diff --git a/tools/include/linux/poison.h b/tools/include/linux/poison.h > index 2e6338ac5eed..e530e54046c9 100644 > --- a/tools/include/linux/poison.h > +++ b/tools/include/linux/poison.h > @@ -47,11 +47,8 @@ > * Magic nums for obj red zoning. > * Placed in the first word before and the first word after an obj. > */ > -#define RED_INACTIVE 0x09F911029D74E35BULL /* when obj is inactive */ > -#define RED_ACTIVE 0xD84156C5635688C0ULL /* when obj is active */ > - > -#define SLUB_RED_INACTIVE 0xbb > -#define SLUB_RED_ACTIVE 0xcc > +#define SLUB_RED_INACTIVE 0xbb /* when obj is inactive */ > +#define SLUB_RED_ACTIVE 0xcc /* when obj is active */ > > /* ...and for poisoning */ > #define POISON_INUSE 0x5a /* for use-uninitialised poisoning */ >