From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E73AC5479D for ; Tue, 10 Jan 2023 00:47:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA218E0003; Mon, 9 Jan 2023 19:47:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C446F8E0001; Mon, 9 Jan 2023 19:47:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD3B8E0003; Mon, 9 Jan 2023 19:47:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9C0D68E0001 for ; Mon, 9 Jan 2023 19:47:54 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 78674C1B97 for ; Tue, 10 Jan 2023 00:47:54 +0000 (UTC) X-FDA: 80337052068.21.C9CD21B Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf18.hostedemail.com (Postfix) with ESMTP id 9756A1C0010 for ; Tue, 10 Jan 2023 00:47:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d7pBJGbz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673311672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x2ZsKiR9JNRoyUSYRvF73VIXXNpjlJA6qiqd7zTU7Fs=; b=RE1/TVZ/kVZ1TnUpR4FWT0xAiqJK1OKAUOm9gvFjJYKu594zTbJZS3YL0LQvHdZQ9QYlFl R/P8iOAN+USDZIGYr7Mo9JF2plDXPKX4hdA4MQK5RRmqzPRVVwXMqNYatcE3zu6PH5R6PT pdeUWmsDN0bSuqqIp7EfrFE6t/aftc8= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=d7pBJGbz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf18.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673311672; a=rsa-sha256; cv=none; b=1JaSX4gBxaQM4bjchOj4BveaMyTZpC48gS72jScctdXLAFof6WyaFNQfwvSh/4GJyr8W5/ gANPqdaitmgeYOOen535SPnGEJfqErujUIPNl3zXfmAdGEqpDbzzSwDj4zPoumqtWXyie4 j7RETb1wG+RHkrovaQ3/lknvQcvS/SY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673311672; x=1704847672; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=kJrgFIiO0EJ7JBX4KpNKPUFXIMxxSwX89FkEpf5AOOc=; b=d7pBJGbzRUIW8XkfBMnxGbIEqgDZFa7gTmrc9e1ABKkmZu56chV7DCnL OnuYWsXcbhln/UEaETI9saw3X8sw9xBwPkpTZi6QzrKxgDBfPsDipwOPx xfbnC3nXYfQRWUtH1roDIj0qObmuShupTg/3MIhcYY90Rl1oHrvU1BkUX bNySnJLVWEotVHdern3QKVr64mmvQ+yVqoTZMS1STFY/e7RW23dVF3q1y cmPMjfi6y+pbTIG2lcnFYBPdd/T2A/hHqBi2cTNwhG33F9ZUmsbqRwyyJ xmXYL9LWq5LXg9plHskgwW8XPuJx6hBJjtsVm9wAzMhQm6Wdh5VqXmXqk A==; X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="321722857" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="321722857" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 16:47:51 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10585"; a="656856149" X-IronPort-AV: E=Sophos;i="5.96,313,1665471600"; d="scan'208";a="656856149" Received: from swapnadi-mobl2.amr.corp.intel.com (HELO [10.209.29.117]) ([10.209.29.117]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2023 16:47:50 -0800 Message-ID: <92aba287-c839-8841-a9f7-28a2c0b3097a@intel.com> Date: Mon, 9 Jan 2023 16:47:50 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 08/16] x86/virt/tdx: Add placeholder to construct TDMRs to cover all TDX memory regions Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <81b814f096513e69e3099ab2b54034deadf8d7fd.camel@intel.com> From: Dave Hansen In-Reply-To: <81b814f096513e69e3099ab2b54034deadf8d7fd.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9756A1C0010 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: h88wfazpiw61gk7ss1rojjk55rz4dsk8 X-HE-Tag: 1673311672-972364 X-HE-Meta: U2FsdGVkX18LE88pxA/mC5ALL4BNQzC4hopfEbD0pVSFLoU+cT6+3FbM48suoPCgheroWWM8FdEoZjnrj7pxmeYxi0zm2dn9DkWD+ih+Bs7UizP51HrqLPEbjqvOAjI0IbpPJCRYTnEmUtNckbc1C8KTbplMmLX7/ERcQmg5aRuStS7VEoY95G3xjj8JhuqMIe/jXQ97/bzylTsh0TF0lhrxeSAHY1j8mPKSxEK6EiYo79s63xtSslABVr+76Mv7rmH8NmoL2Z4Z/2OW2vED6bua2ZYy7JTKc8BKAxxXnNU6je9PgVKkMZdZYcReI9D+TEl9xTEx9wKt/2+r+Pj96N7OaMWVEjpWL5QgPmBxiiNcWu/YUdr8314KUthQVQS08srKhaHCOk3ceGHvfEBNRcJCmiR0LiZAjT5EOAAAsO2JByGtE3rom2tQ3/vdRCFY2p24nnOPTwqsqvcrIWTa3QNYX9XPYbaf5zRFQ8gb1ezH1V67Nx1oIT8p8cD5Il/ApniPmMLWVy1zcP7qA75YzJIeMZE2gfvZeFmDBRSHYV73Zhe3+EpyK9EveL+ClSlBV6JG4HRTEcYac0oAGswlXaTkFCz5i7YH7D8KEZKTYeJuVDv91n47HoRvSFI1AciUrTaOu+MhECHxj9XMZ+owZC+KeJiZ6NlmHvIJH5WzmI3uexOgf7voNi9Mnb9MkMLHV0rBq5vgtY+1DIaVW7SoP7o9LO5dNQjpzOYA3m4du9pBdGZ4lETSvv5PCM/x8Qr8WLg6IjQrqhBx4k8Babqy/detaZ+Eq1xnbV1+Cjj/s4mWdOTq2LzBfYTIskSNEWjCf5pzI2Tmqg5z4L2HeJWKkZQ6QzjDltz3N/jgfgnlUQcp3TBpcKufxtQS02Uey547aaf3RynX5Ybli+GeTLSgFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/9/23 16:40, Huang, Kai wrote: > On Fri, 2023-01-06 at 11:24 -0800, Dave Hansen wrote: ... >> Also, tdmr_sz and max_tdmrs can both be derived from 'sysinfo'. Do they >> really need to be stored here? > > It's not mandatory to keep them here. I did it mainly because I want to avoid > passing 'sysinfo' as argument for almost all functions related to constructing > TDMRs. I don't think it hurts readability that much. On the contrary, it makes it more clear what data is needed for initialization. >> If so, I think I'd probably do something >> like this with the structure: >> >> struct tdmr_info_list { >> struct tdmr_info *tdmrs; >> int nr_consumed_tdmrs; // How many @tdmrs are in use >> >> /* Metadata for freeing this structure: */ >> int tdmr_sz; // Size of one 'tdmr_info' (has a flex array) >> int max_tdmrs; // How many @tdmrs are allocated >> }; >> >> Modulo whataver folks are doing for comments these days. > > Looks nice to me. Will use. A slight thing is 'tdmr_sz' is also used to get > the TDMR at a given index, but not just freeing the structure. > > Btw, is C++ style comment "//" OK in kernel code? It's OK with me, but I don't think there's much consensus on it. Probably best to stick with normal arch/x86 style for now.