From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB98C3DA6D for ; Tue, 20 May 2025 08:59:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E33C96B0095; Tue, 20 May 2025 04:59:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E0C406B0096; Tue, 20 May 2025 04:59:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D219A6B0098; Tue, 20 May 2025 04:59:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B56786B0095 for ; Tue, 20 May 2025 04:59:07 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4C87F1A08DA for ; Tue, 20 May 2025 08:59:07 +0000 (UTC) X-FDA: 83462686734.08.D327DB9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id F1C32C0009 for ; Tue, 20 May 2025 08:59:04 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L0MQIwzH; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747731545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rEo9wHsAVDAmF8UKbhSkQByUjmKCHbkHnot0Hl7ePQI=; b=bgcXrfTkaBjDXVR3tIB/S33koR3UK+uLIt89joUoO5Z1eRU3RD8kuSQ4P6vY+x9TzvkvvR YR+nvgqGzKzedERrjJv9mM2xwbUMUA5r968bUZHTCjytfjZ4NzRo00b8A6KEetoKO4RcPT Jw/tYaqng6JsNREkydkwsAsMEKhDhU0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747731545; a=rsa-sha256; cv=none; b=HP7LbgyZh0SdGOAf3pnc5ULLmkJILy8KbsKP+h1gFLCRHAR91Ro8pj9SEVR9lrgfTeKB44 pZB4v10lSkRZumaq51pwBBXpbYfR5zwls7vMohb6ZJRIERSeOcr3bbqjKOGWkjLvfFOJr9 JULn3AMZeFhfN6exJA6eBoYzsQ/Klb0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L0MQIwzH; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747731544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rEo9wHsAVDAmF8UKbhSkQByUjmKCHbkHnot0Hl7ePQI=; b=L0MQIwzHXTB/78B9BSjwWSZHEIkQdXMDTSIW9Bux50S2lJ0qzwxzCcsjs1aYbEX4m6S/3R dNsl8tvaqbhcrS6lEMBYWC5ejUc1uBMr8FGfM1vzd7K+vJXHXwRFsErmyYiftUW79sw2lx Df8hP8rcBzsa4DHjkWzyNCXW4rswxI0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-Bfxtq3acNtafjkAZivgtyA-1; Tue, 20 May 2025 04:59:02 -0400 X-MC-Unique: Bfxtq3acNtafjkAZivgtyA-1 X-Mimecast-MFC-AGG-ID: Bfxtq3acNtafjkAZivgtyA_1747731542 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442dc6f0138so30132145e9.0 for ; Tue, 20 May 2025 01:59:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747731541; x=1748336341; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rEo9wHsAVDAmF8UKbhSkQByUjmKCHbkHnot0Hl7ePQI=; b=l01Kid4F9S9NKzGp7EbGBuYui3HUS/2VzHzXnpb+n3hQ+yPg0QrY5x/BcAWSiDneV7 h2xEvS3Jc32vpHMOcma2vmKYJ+cgNWEo5MLYhLvUXB4G6lMHxtANg58/+4psPioujnz0 pN+7TRS4+cXQ/rApLEpHFH4OceVEVMOl/fieeckJH9d55+bKDrjc7tNPB6uJO9HDlZrB IZIvZEWAfwATefeeM5auuRceI5Pmnzydac+3ehN7TowHdDfeSPa9vmzUt/3tUI6gE+r/ OCi9wFC3LI9+pB0NAa8aNcuGvRGMKy1xqLB3QH5fUmZSq3AmLMNRrKXOdqmuylnSpiPv yYgw== X-Forwarded-Encrypted: i=1; AJvYcCXbrSiEV1eTi+wmYt4elEegm7OiiBoI5f3eaiyoyGW5mDiR+xBBI/dLd69F/uUkwXaXKLHrommL4g==@kvack.org X-Gm-Message-State: AOJu0YyIJ8qrs0RqfSSpowD/zrkA10UMOnQk/GePw/aKhbSPuZ7eNHml 4AeoB2z4WOXMW6wyAbdZ1TaEQ9uYwL66F3rYFHTEtupOKrjnytuPnFaj6z6VNk2mrbt9xqzmFi1 k7wUbjJLDGVB88C0FsL8DfVId+cjAV239/KQhFP1icrpeXpgqGZDQ X-Gm-Gg: ASbGncvXiViw0VmbO+5mQgD5CUzV9StucmxNcZ7Zocved50/PLpBAgadQ0rfNinVmRr Q2SyqxeKce97OtTP971s9VCy9QfajsMqpituaLCJCxzkKCvYoKjxV6raW8yoplCxStGZN6F7Mif Ey7MsuoRh1qPEOzPvQU8Tr1QbIF0j2L0TQ/+7Brb7dJTfQBuG0wNRaz2AHiBrAtXQOB7d9i52Ct JlT2WuHBWDUqD3l5lKKN8D+SGE7g3jB+f6cFvHbzVsKQ9XXT48zJrY+5w/sNZgv1bJoYbIWGDBC v2zRojtD7SD67e2KaQF8lWnCfY53sDHknVW6EicTn2Ihm2OZPqy0Q7mPquUeZE+JAXX6iOLJ1iz mVWgAzTCXy0pupTaV/z82N7yjaozC6BeR/LFgDJM= X-Received: by 2002:a05:600c:a014:b0:43d:ac5:11ed with SMTP id 5b1f17b1804b1-442fd66f08emr137207245e9.24.1747731541568; Tue, 20 May 2025 01:59:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJeg33tWEhPUjIDGe+ZTJb6dNwDJQ14UoIRa1KY9x5N1fVhioznneX6EK33bsRMzFQbRU4TA== X-Received: by 2002:a05:600c:a014:b0:43d:ac5:11ed with SMTP id 5b1f17b1804b1-442fd66f08emr137206995e9.24.1747731541164; Tue, 20 May 2025 01:59:01 -0700 (PDT) Received: from ?IPV6:2003:d8:2f16:e400:525a:df91:1f90:a6a8? (p200300d82f16e400525adf911f90a6a8.dip0.t-ipconnect.de. [2003:d8:2f16:e400:525a:df91:1f90:a6a8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f23c07bfsm22910795e9.23.2025.05.20.01.59.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 01:59:00 -0700 (PDT) Message-ID: <92868969-5f65-4e50-84c1-c50fe18656e8@redhat.com> Date: Tue, 20 May 2025 10:58:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] mm/page_isolation: remove migratetype from move_freepages_block_isolate() To: Zi Yan Cc: Oscar Salvador , Johannes Weiner , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250509200111.3372279-1-ziy@nvidia.com> <20250509200111.3372279-3-ziy@nvidia.com> <63ba9fe3-e384-4396-bd86-fe62150ed1ab@redhat.com> <3E4832BC-C0B0-47E0-AA89-A8DE5A63286A@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <3E4832BC-C0B0-47E0-AA89-A8DE5A63286A@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YofK6XQDQfTTL97ky9fhFNAIPtX2UJB8gb18WSEHNvQ_1747731542 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bqt4znyxpnrtfipemij3tkdu65m84bqc X-Rspamd-Queue-Id: F1C32C0009 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747731544-137885 X-HE-Meta: U2FsdGVkX19IWAogZEMMuckah7zuaKm8yHonGOEpm1TNilxMHbnZ+bl52yy28vTJXMw76mLS43rpTkgdXxSxOS3oYF+1my1Vui83XH2zP5PC9aXbQ2Xh24iEoVyb+X6RJtr6RymAE8RAklj78m+FrFKaTim97l5OBTA5tdG7QxxEtK0Y7weWyt93BPE76Xvwq/6LaSS8s5TVEtEEngUBvbJptLZOWsxTy0IpNGyCsfVkRqZ1NVpUrJtbqMLvAkNC77HMGlN6N2tcpS3XWMWEgrBClHA/gIy4KnDziLXtSTrub1o0TdukBQBMvKV1OjKuOSawFBbrng8c5Yx8P8+iPi1ta+tNs6vhO0TVz+TJJrQ8K2DROhZnIQPbA1l68LJ2d6PG/+x87lBTnda7tMzGcdpOJxib9nmmiJGaXTXvUPzH81s2GEnDSW2EAXHo6YOu5Au/FBmzbPWl27RxrWVyhNk8MLk1FPaz8t9glMfC5IAM+UfC2fHUezRVEOr/WPEAk48Y782JHHAWB62/wCK8+xYyEXMjH3LzT9W1N1uPjrUnYJJByuJx2zy1MH+9S9/Jso8SOCA5zBNlyGuDpATee3lobngC4v9ADHqATY1SeWVPRlJ2a670syEfhb65gpUAazNUVWDhp6lhjpF3V0wJEXEmDoT5VR5mhQFVKVBXpwVbRDyJRkn8azfA5wDDIA1pSTbDkyc+Kr5Y0+isFjmTeQva7EEuVtSP47PBc4yliiuVBrZ3vL/k/bet305K+iYGjCRb4x0DEu9RwnU1BoXa5yA1fy1pRuJ+d1jKTpyAzZBZZ4WFQXAQB2g5Po3AKaxYY9Icp2xUF6iSLH8OkGhtjSfEPdEGfitaKR/s9A+hjXRSoJEF5vhMvQpOBmRIU9DhmugLViO3bhF+FgNNh09lS/tkZY3nAGiByuCEKU/y1jO8LoLgFGXsCeuO92IjKVTieHF/e9i2i+H2nIQ/WTs 9bwCH0kQ Zsq+GVx4sApSuqHbOfxsBAHMJohbkgZhHGhiIx2SBtgqvbo2LxrCOgl+HqE0r5DNAd890cCeN54AW/mOSvHLIqgQEkxYrJbLwd2txgwSIR6FQJqYq30ZsIcRQNkfOVFdM8+TnxWo6LYkaq98bypng2uoq7n5hcUDt7CgCD1t92FvQiz8TlLwXc7Jt8K+lFeXIh4Ukwv+IWows5Pzlsw2k2Jaudcd/nIptjRI20z8t8OPOzwCzI4pfwWcI+gj+9siPPfbEFiSwHn8BLnA6cV2cdTKaPSaYOAmUvJ6m8Xc7+SEvNr3EZDgcUk0suehJKWJ9/Jf8TysoisycJK18prABwkttt0rFr0BiYYyT9uQNcsOo6vVCs2CXT4NVrJZCgNPin+jmPzpQC2TGHpFbwGpJD2aRh8yC9xk40TOY49NrLiYOsSQ1TNNj6BqrR9/OTzQliseFrp2uSP1G5F2rtS3VvFk2m4cfWWZ9dSMY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.05.25 01:06, Zi Yan wrote: > On 19 May 2025, at 4:21, David Hildenbrand wrote: > >> On 09.05.25 22:01, Zi Yan wrote: >>> Since migratetype is no longer overwritten during pageblock isolation, >>> moving pageblocks to and from MIGRATE_ISOLATE no longer needs migratetype. >>> >>> Add MIGRATETYPE_NO_ISO_MASK to allow read before-isolation migratetype >>> when a pageblock is isolated. It is used by move_freepages_block_isolate(). >>> >>> Add pageblock_isolate_and_move_free_pages() and >>> pageblock_unisolate_and_move_free_pages() to be explicit about the page >>> isolation operations. Both share the common code in >>> __move_freepages_block_isolate(), which is renamed from >>> move_freepages_block_isolate(). >>> >>> Make set_pageblock_migratetype() only accept non MIGRATE_ISOLATE types, >>> so that one should use set_pageblock_isolate() to isolate pageblocks. >>> >>> Two consequential changes: >>> 1. move pageblock migratetype code out of __move_freepages_block(). >>> 2. in online_pages() from mm/memory_hotplug.c, move_pfn_range_to_zone() is >>> called with MIGRATE_MOVABLE instead of MIGRATE_ISOLATE and all affected >>> pageblocks are isolated afterwards. Otherwise, all online pageblocks >>> will have non-determined migratetype. >>> >>> Signed-off-by: Zi Yan >>> --- >>> include/linux/mmzone.h | 4 +- >>> include/linux/page-isolation.h | 5 ++- >>> mm/memory_hotplug.c | 7 +++- >>> mm/page_alloc.c | 73 +++++++++++++++++++++++++--------- >>> mm/page_isolation.c | 27 ++++++++----- >>> 5 files changed, 82 insertions(+), 34 deletions(-) >>> >>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >>> index 7ef01fe148ce..f66895456974 100644 >>> --- a/include/linux/mmzone.h >>> +++ b/include/linux/mmzone.h >>> @@ -107,8 +107,10 @@ static inline bool migratetype_is_mergeable(int mt) >>> extern int page_group_by_mobility_disabled; >>> #ifdef CONFIG_MEMORY_ISOLATION >>> -#define MIGRATETYPE_MASK ((BIT(PB_migratetype_bits) - 1) | PB_migrate_isolate_bit) >>> +#define MIGRATETYPE_NO_ISO_MASK (BIT(PB_migratetype_bits) - 1) >>> +#define MIGRATETYPE_MASK (MIGRATETYPE_NO_ISO_MASK | PB_migrate_isolate_bit) >>> #else >>> +#define MIGRATETYPE_NO_ISO_MASK MIGRATETYPE_MASK >>> #define MIGRATETYPE_MASK (BIT(PB_migratetype_bits) - 1) >>> #endif >>> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h >>> index 898bb788243b..b0a2af0a5357 100644 >>> --- a/include/linux/page-isolation.h >>> +++ b/include/linux/page-isolation.h >>> @@ -26,9 +26,10 @@ static inline bool is_migrate_isolate(int migratetype) >>> #define REPORT_FAILURE 0x2 >>> void set_pageblock_migratetype(struct page *page, int migratetype); >>> +void set_pageblock_isolate(struct page *page); >>> -bool move_freepages_block_isolate(struct zone *zone, struct page *page, >>> - int migratetype); >>> +bool pageblock_isolate_and_move_free_pages(struct zone *zone, struct page *page); >>> +bool pageblock_unisolate_and_move_free_pages(struct zone *zone, struct page *page); >>> int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, >>> int migratetype, int flags); >>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>> index b1caedbade5b..c86c47bba019 100644 >>> --- a/mm/memory_hotplug.c >>> +++ b/mm/memory_hotplug.c >>> @@ -1178,6 +1178,7 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, >>> const int nid = zone_to_nid(zone); >>> int ret; >>> struct memory_notify arg; >>> + unsigned long isol_pfn; >>> /* >>> * {on,off}lining is constrained to full memory sections (or more >>> @@ -1192,7 +1193,11 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, >>> /* associate pfn range with the zone */ >>> - move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_ISOLATE); >>> + move_pfn_range_to_zone(zone, pfn, nr_pages, NULL, MIGRATE_MOVABLE); >>> + for (isol_pfn = pfn; >>> + isol_pfn < pfn + nr_pages; >>> + isol_pfn += pageblock_nr_pages) >>> + set_pageblock_isolate(pfn_to_page(isol_pfn)); >> >> Can we move that all the way into memmap_init_range(), where we do the >> set_pageblock_migratetype()? >> >> The MIGRATE_UNMOVABLE in mhp_init_memmap_on_memory() is likely fine: all >> pages in that pageblock will be used for the memmap. Everything is unmovable, >> but no free pages so ... nobody cares? :) > > My approach is similar, but a new init_pageblock_migratetype() like > below. Then, I added "bool isolate" instead of replacing the existing > "int migratetype". The advantage is that it saves a call to > set_pfnblock_flags_mask() for each pageblock. Like the alternative > you suggested below. > > +void __meminit init_pageblock_migratetype(struct page *page, int migratetype, > + bool isolate) > +{ > + if (unlikely(page_group_by_mobility_disabled && > + migratetype < MIGRATE_PCPTYPES)) > + migratetype = MIGRATE_UNMOVABLE; > + > +#ifdef CONFIG_MEMORY_ISOLATION > + if (migratetype == MIGRATE_ISOLATE) { > + VM_WARN(1, > + "Set isolate=true to isolate pageblock with a migratetype"); > + return; > + } > + if (isolate) > + migratetype |= PB_migrate_isolate_bit; > +#endif > + set_pfnblock_flags_mask(page, (unsigned long)migratetype, > + page_to_pfn(page), MIGRATETYPE_MASK); > +} > + See my other reply on maybe introducing a "struct pageblock_info" where we embed these things, to decouple the actual migratetype from flags. -- Cheers, David / dhildenb