From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27CA3C6FA8E for ; Fri, 3 Mar 2023 01:42:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA1E16B0071; Thu, 2 Mar 2023 20:42:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A51AD6B0072; Thu, 2 Mar 2023 20:42:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91A576B0073; Thu, 2 Mar 2023 20:42:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8231E6B0071 for ; Thu, 2 Mar 2023 20:42:45 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4C5701407FB for ; Fri, 3 Mar 2023 01:42:45 +0000 (UTC) X-FDA: 80525887890.14.409191F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf11.hostedemail.com (Postfix) with ESMTP id A656240004 for ; Fri, 3 Mar 2023 01:42:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677807763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jJ9vFDmwhkCurbA4a39amNxywdZH9hVeSwT2A2Yk0vQ=; b=FAv2AqE3H6ltT4GMbKCsEdk3qQczI88b2YQhU701vq+WaKSqnvQs9I9cvX7wcYaFjonTsD fxBTIhOHrGVAzXKgR5na5c6P8v1Mm37ELNnRcRiQVigeNQkU1cVdz0bsnwnhzlKK2REqcq N+/hwYkJug8+cr1YEVky/iJ0HLfy9gI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf11.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677807763; a=rsa-sha256; cv=none; b=TOkEtHB4B6FBRmcezF3mG6ZDIe857vxWeJmxLrBM8HMG49NeJxiJm2UfXIP65SxlQmQi28 ZR9+ugS/fPZLX9JFw7HC0F/zqrl/9qRCJOBgJQm+cYQmgQRq+ODdQ1L+Za8x4s7Du4DkRy tEcsGZF8yaNJQpMPNy8pxZczLRjEaBI= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PSW10095hzrS80; Fri, 3 Mar 2023 09:41:56 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 09:42:04 +0800 Message-ID: <927fbb66-ee80-2ec4-60d1-1cda23b3cb19@huawei.com> Date: Fri, 3 Mar 2023 09:42:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next] mm/damon/paddr: minor refactor of damon_pa_pageout() Content-Language: en-US To: SeongJae Park CC: Andrew Morton , , , References: <20230302164706.85999-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20230302164706.85999-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A656240004 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: cmhc7xg953om3997rx8ietfdr7mn3oiz X-HE-Tag: 1677807761-144533 X-HE-Meta: U2FsdGVkX18ldkMVYmK2PoWwBGEX81ePY/JIPvdlGxua5iwQCkQyewbmWdcgxSDNvlR4+EWFLSlLKZ3D5MovFa0Bzc0ZLDSxpWfSHPb7BOcH2Dl8OUEzc7G4nvMhzglNW0WH0sp+mqAKAeIRhcQR0iIGrkRkyrXZjjryN4G08xVI2Rqbup5NXhFn5/2lWZQ+GUaC95fe/b2CVngVa5+ejYMs0p7Qyr6Mh1yT0Zfri+NPzicfT41L4t976pTMBrqq9zONh+CXheX9rtSjPhwKju7nzX5ZEvkJ7MEWIU5wMqAbyGHaZ3ttOP0fmzCqpaCfEvJ+MWeWi/Hz1GFiR0JextMe+rbxKNpVfib8YI1yEto1XTc3e5AxcCNwW0mJvTSYtE9C/nFwL0ETUVKjlFb6GweTHsv4S3komstmyVmnPJcL+C7oERC2P4gwzzJvm7x53oPozC+NctkNdsmweiuCdj1U7QcBZ9ebDhxlQkemrT34x0ZytfkbJ6vg7d31E3/7Tet/t9IlzWlt/wI/fSwjtB3Ru7ox2GxuxCtS9OlD+F874j4KUcF3iVilPAO3McRsCG80MQyBkMpBfnOzl2nENH2fzlKI/yuW/ofYFx63ASZTY11pO9rLwzUIvc/HonF7/k+hbxedbbCyg3jADdxQGFSbGp1XLnJXtGWaZe/T7rs2jd28zL5NGFUFD4e3AI++V/Ahk1tlenr9H15DEAzRrsSN92oj3o0xI9ytVWSV1CKcNaJcCM3eQzajCjNJEZYL0hGdbRVNXS5wZrbTgLukvsIVpBzXMWBdxqPJnL+bt56L3Qn8JRhXoiNjR6bsTqegHiYMrjg3DjnybHjxxlUAM3cXvN5CG7NlEhKbRXJ2HpKw/LuhD+a7JYNyOcs8PmgpNqEpXw+9u58kO6NkQzRbXxeQQN9YxxARHmLo/H1q3hKTOnEFnbUHmvoyKK2u9qT8QtXP5BmMt77/p5c2v+u 4gyr4NFn ZP6ugbYqmdZ7EfCBjHXapX9DIayVHWHxmkZ0+r1abyprwjCUtgWO9g2RXU9y0mKDbiNx/UBukVn69uq8l1CwBGrOrEMZhBKy+QV8GjPalumAUjzhgJzbFLGbXarN6ZDydzJ6XW7e2SOA9SnNZfw0MhHCjeNm9E5ORXko5K1VE5G0oyT/xsG3nXczf/n7l2+w5oSn2siIX1MZN6SoKkFRsUG2wEDqf2/CxZEwHpcVkUVNbkgzr82xN9OQrgXR3YGKAFx178O218N/bTSV08TLgjO5jUoB51w8gl9IeeaKYBghRLOU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/3 0:47, SeongJae Park wrote: > Hi Kefeng, > > On Thu, 2 Mar 2023 22:49:26 +0800 Kefeng Wang wrote: > >> Omit two lines by converting if(!folio_isolate_lru()) to >> if(folio_isolate_lru()). >> >> Signed-off-by: Kefeng Wang >> --- >> mm/damon/paddr.c | 12 +++++------- >> 1 file changed, 5 insertions(+), 7 deletions(-) >> >> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c >> index 6c655d9b5639..a557f3c9300f 100644 >> --- a/mm/damon/paddr.c >> +++ b/mm/damon/paddr.c >> @@ -246,14 +246,12 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) >> >> folio_clear_referenced(folio); >> folio_test_clear_young(folio); >> - if (!folio_isolate_lru(folio)) { >> - folio_put(folio); >> - continue; >> + if (folio_isolate_lru(folio)) { >> + if (folio_test_unevictable(folio)) >> + folio_putback_lru(folio); >> + else >> + list_add(&folio->lru, &folio_list); >> } >> - if (folio_test_unevictable(folio)) >> - folio_putback_lru(folio); >> - else >> - list_add(&folio->lru, &folio_list); >> folio_put(folio); >> } > > This looks ok to me, thank you for your effort! Nevertheless, I don't like > increasing depth as much as number of lines. The > more-than-3-levels-of-indentation[1] warning is not always right, but this 4 > levels of indentation is not making me so exciting. > > What do you think about adding put_continue label and using it, not only here, > but also above part? For example: > > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -239,21 +239,18 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) > if (!folio) > continue; > > - if (damos_pa_filter_out(s, folio)) { > - folio_put(folio); > - continue; > - } > + if (damos_pa_filter_out(s, folio)) > + goto put_continue; > > folio_clear_referenced(folio); > folio_test_clear_young(folio); > - if (!folio_isolate_lru(folio)) { > - folio_put(folio); > - continue; > - } > + if (!folio_isolate_lru(folio)) > + goto put_continue; > if (folio_test_unevictable(folio)) > folio_putback_lru(folio); > else > list_add(&folio->lru, &folio_list); > +put_continue: > folio_put(folio); > } > applied = reclaim_pages(&folio_list); > > It omits three lines. It looks good, will update, thanks > > $ git diff --stat > mm/damon/paddr.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > [1] https://docs.kernel.org/process/coding-style.html#indentation > > > Thanks, > SJ > >> applied = reclaim_pages(&folio_list); >> -- >> 2.35.3 >> >>