From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5766E64AB1 for ; Tue, 3 Dec 2024 14:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40A606B00A0; Tue, 3 Dec 2024 09:17:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39D436B00A2; Tue, 3 Dec 2024 09:17:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E6E96B00A3; Tue, 3 Dec 2024 09:17:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ECA026B00A0 for ; Tue, 3 Dec 2024 09:17:29 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 9BC6E1C7001 for ; Tue, 3 Dec 2024 14:17:29 +0000 (UTC) X-FDA: 82853850492.29.F46B4BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id B27E84001D for ; Tue, 3 Dec 2024 14:17:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aiTjhfFy; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733235441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0UJPIXjVniWobB5oSIOB8j5neo8aFF+B6iIK+MqXr4=; b=mkAfm6AG2ZEnQ+ToixBF+8OjUDvU8TmRHqHiTGzKWMb4tFtBT1O251szeDqf35E21k4BnQ ljnGJP826HcBl+sDlLfLOQ8/kQrzaLExHOrNuCfhnR2veTML1heSdrefZ58sIs+dhfHB01 l7jZTGRnpHm0pPbmd46JbZfZ6SVqsO4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733235441; a=rsa-sha256; cv=none; b=AU9+yryb/igtk18HluyldkT55S45/R1qpQtRu7EDw1CPUiQFBHVZU11li7Owk4FQyg9HAw LWCUyPVFBq0L5LYLXuUrtaSqL9W5YM5T+RVSCbHD1DJjnB3qV56K0gqonABbfV6fDLTF2t IDgf5phmrtZXkJo6Jkx4Y0v6Iysn74E= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aiTjhfFy; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733235446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g0UJPIXjVniWobB5oSIOB8j5neo8aFF+B6iIK+MqXr4=; b=aiTjhfFyid9rLP4cYZqzQJH1YHSP1biymJ60P43U2butvYKnTkgIgt4VzkfKDZ0a8Gucz5 N/rD0ix/xI+ivAYafl8ae22KwBVOpJukwqYGy9JJFZ52hcW6XlgXi53RGCZ60kJF1NpZYi OCZUxNqSysPDAocOsSHdfv0l5YW5z0w= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-82vrgsNUMcGDBGIjd-mPcQ-1; Tue, 03 Dec 2024 09:17:25 -0500 X-MC-Unique: 82vrgsNUMcGDBGIjd-mPcQ-1 X-Mimecast-MFC-AGG-ID: 82vrgsNUMcGDBGIjd-mPcQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43498af7937so45776665e9.1 for ; Tue, 03 Dec 2024 06:17:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733235444; x=1733840244; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g0UJPIXjVniWobB5oSIOB8j5neo8aFF+B6iIK+MqXr4=; b=qxXgwlfpKBGbst+49aAK0azuve/5rE7UwAW5VqhvgvgZfVI8iVVI2Jvz4DNWSTpTN7 e0PNFWROXBcJoWbWFowaSlyMI/Zu8fI31FzTqWQDt40GFsWg6M+hHZgKg4GOPYXL/igJ F8bRyY4MNTkzmgRgcEqVclBASYSQH6ccPkQRpzMRkH/okFFzMjVQlBvaiIbVWWLMQEkv MyFvfr7clKR2NWoj8lkBh3O4wDqYbLC3DlkfE5ZQ79shJATGBqBAgsj7Dh+I0b2vbN7+ sSoEfvWZaMFXsIQBHnrn0PmXZbx3Bq5Ap9yTdp15I87/Kobi9OxaT6Bw363B0kMCOsKp 4TvQ== X-Forwarded-Encrypted: i=1; AJvYcCXqW/46vvDVmZUmJCcMrzreQHb+DAs7HM9Yd/IJ7mMqqZb2JqwOUxOI7ybNs726ro9q9/z7xHoNvA==@kvack.org X-Gm-Message-State: AOJu0YysDELoxQ7W0HAJR40M16k4Huh9mhFXlotVVXPlknOpVKVcMIFk gXQoVUswjoL8HT8cJLXiXAVW2x50oLeOO5yMhwvFWPizhjn5IY7mQZcMMeEnymY/Jd8F3Vvxb8f 7taMdsFPYa1hbva18Efro6IhNDmsFPN+2/WKgoNOUuTkUUetf X-Gm-Gg: ASbGncsC1dpk+5hn5fSAJfQhac6oJPBA1wzOv+mTRbSsD6qq+VFBiJaCArnepFtnYUM UilC0TdtKPzMGIHsUAnac748EewGfVFf5P/C1qbMDzuX8OzgUoUS1N4zhdeflRfFGn/ACC/N6Nv qvGb7YFLW9zC34NtuIuzIpqwj6bafhQyRVvDleq7PgsUe+dhg9RfwARwUnkYKAxlu++zK12h38n bjVDn0xvYXHro7EwUwwAoafP99IS74bbSvlYiA7Mb2USqQsKkH4yQ06f2hVrpSuY3dv/vareTIs kc2Cli3ycZvUTyTqSsi6553KiB44/ueu4gRNgPZ8XK5+POpW0tcBtVK8F3agKfK2EHp/bJrZvvv cbQ== X-Received: by 2002:a05:6000:480a:b0:385:f638:c68a with SMTP id ffacd0b85a97d-385fd3f1977mr2515544f8f.30.1733235444163; Tue, 03 Dec 2024 06:17:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGhcUleiGCjb0A8/C4qqTKwVZtO0c2SrVd/eJu0hedjuQq3Mrw7NR6qnhgdPIt2KyefdK9MXQ== X-Received: by 2002:a05:6000:480a:b0:385:f638:c68a with SMTP id ffacd0b85a97d-385fd3f1977mr2515526f8f.30.1733235443794; Tue, 03 Dec 2024 06:17:23 -0800 (PST) Received: from ?IPV6:2003:cb:c746:1b00:fd9e:c26c:c552:1de7? (p200300cbc7461b00fd9ec26cc5521de7.dip0.t-ipconnect.de. [2003:cb:c746:1b00:fd9e:c26c:c552:1de7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0dbe4e6sm189502935e9.14.2024.12.03.06.17.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 06:17:22 -0800 (PST) Message-ID: <926c6f86-82c6-41bb-a24d-5418163d5c5e@redhat.com> Date: Tue, 3 Dec 2024 15:17:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] smaps: count large pages smaller than PMD size to anonymous_thp To: Wenchao Hao , Andrew Morton , Matthew Wilcox , Oscar Salvador , Muhammad Usama Anjum , Andrii Nakryiko , Ryan Roberts , Peter Xu , Barry Song <21cnbao@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20241203134949.2588947-1-haowenchao22@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241203134949.2588947-1-haowenchao22@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aoLpkFiVrTxJgl1f79P3XuDk9HUMWOT8b264DToGSGU_1733235444 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B27E84001D X-Stat-Signature: 418g9kwz51d3pe7ib8hmarasp6unt1g5 X-Rspam-User: X-HE-Tag: 1733235430-331164 X-HE-Meta: U2FsdGVkX1/2NFjYNKHiP9qQaiDt4TaKS2qi7xgEs9EWC3KEmbpxnQpefWcx6BE2NiJVCw3X+9uhXFoa+bCPANmIL6BuXdF17OnQxgd0wyPPr1n8D1z4A8XVQR1tiinBDJQBbEvPypFVY39DWFGEBkWvXBGakS8ZPf3kraYl8UduD9NceC1HbDRmNMFmMvEZnQu6Tn7FAOy1YtfKBc7x3miBttKLI+HZjHeIYb2WRAYq/k04bKv8vEk3YTypLsZK5G4/bYiXDjK++ElJsE74Yt9okKF5E8KVZgcN/HVDcUAptuNZtXTW2IHSR4b0C+063uz+VrwrcA71AtTZAEbgfYGwgB31PgKJRwqP6fNPw7CJKmgtqA0jzikYZZ6w0xq94bJHpqblVMsRlb4jlSmKpzJyGPIF8sDx1BXw3haBReM5AzOrZ1BnJbY3XPmSSyJN2Zrzac5hDpa40HjJheF5JuYUBztVMxYvSN+EmIBYY75R5v2SLS2P62CX3KEGbJw1WPXSbGTVlbboINj/J2WtJGRlrVKki6Zj/kfWvJ/L478N5RZMFkP3LdtjQGYDGbd9fXEDzd9WskW5qZNIbr6sM5LvJeRquICYIPqqfbfu9tRcfX+lhb4yrBLdhe/bD2atdrX9x3UOMcagCtTabGPKqjV33SBtFRLjkX3awooDQe7VO/h4tKVkxRk6PNKRYKBHoT1HWeT+T9yI/CfuxEmkLTBXRCyeweklzpU6eE71K8+VFhUwKadl7M/K3KqzhvUu4192AMeJRXd3OAidNFPFq1QXjDwCvFmrKMmuzFOk6YwCOO2elS1AoXl7+pbvGoxOxKRhBJtxjDddXu/BqITfnWC3+x6YKVigifyt6iUO6HJTdnreEOgMhMWBNMLfwrd1W0Z0CxCVF8P4uRZbaPGV/hRa986VUwWAOV4GmR61PAytxyOrCR2MaceO+ko+9L2BdTee4WXRoNjU04o1UVT E9xGMu75 Eytmw/pqi7Uz6V6WlEi1f4hMRmo3pB7CDCqQDU9oiqYL89cvlANjya9m9LEjTc07UUxVs/vEqOHk8clRraQHOBL+pQDEOASbXdTUxGZ6XGgbjL0eUGhWqwq0FmRTHnTat+4lp5zKv3BzZ4r4kOln+/Q978ckY/XQ6pbWE7cRt3SZ0NBzzRY/kYUeKZ7wN+MOkBLjBu/H02HKoryEh1vfSY/7PsSiLhW97fY9i4qOLFgPNWwHLlvknQEI/q7MJUVJLRzTW1nUaqQGaHdDNrpLoekyZc6u38Ghsd7Vqwog5ECpDGbH/0FI84hnT++snPKjnePZMSRgDVTkSut4dC17tysiP72y7JWsd4zxyLR2Y5+FnKcxlzOfXZA7eRHa7oKk6+n0KOPTQiT1PJfFdeuZPG2l1J3O7vZJ1B/UrVA6XRRVu0zX7gsqVWIkupMaVLgGVQHqEqyHs+1orXgsn9eRMp548iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.12.24 14:49, Wenchao Hao wrote: > Currently, /proc/xxx/smaps reports the size of anonymous huge pages for > each VMA, but it does not include large pages smaller than PMD size. > > This patch adds the statistics of anonymous huge pages allocated by > mTHP which is smaller than PMD size to AnonHugePages field in smaps. > > Signed-off-by: Wenchao Hao > --- > fs/proc/task_mmu.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 38a5a3e9cba2..b655011627d8 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -717,6 +717,12 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > if (!folio_test_swapbacked(folio) && !dirty && > !folio_test_dirty(folio)) > mss->lazyfree += size; > + > + /* > + * Count large pages smaller than PMD size to anonymous_thp > + */ > + if (!compound && PageHead(page) && folio_order(folio)) > + mss->anonymous_thp += folio_size(folio); > } > > if (folio_test_ksm(folio)) I think we decided to leave this (and /proc/meminfo) be one of the last interfaces where this is only concerned with PMD-sized ones: Documentation/admin-guide/mm/transhuge.rst: The number of PMD-sized anonymous transparent huge pages currently used by the system is available by reading the AnonHugePages field in ``/proc/meminfo``. To identify what applications are using PMD-sized anonymous transparent huge pages, it is necessary to read ``/proc/PID/smaps`` and count the AnonHugePages fields for each mapping. (Note that AnonHugePages only applies to traditional PMD-sized THP for historical reasons and should have been called AnonHugePmdMapped). -- Cheers, David / dhildenb