From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154EEC369CB for ; Wed, 23 Apr 2025 11:03:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79346B009C; Wed, 23 Apr 2025 07:03:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B25606B00A0; Wed, 23 Apr 2025 07:03:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A14BC6B00A1; Wed, 23 Apr 2025 07:03:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84B966B009C for ; Wed, 23 Apr 2025 07:03:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BAAE9BB3C3 for ; Wed, 23 Apr 2025 11:03:29 +0000 (UTC) X-FDA: 83365022538.20.6C2CFB0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id B75F11C000F for ; Wed, 23 Apr 2025 11:03:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745406208; a=rsa-sha256; cv=none; b=h26Km7zDhCUV1ERA/QQnZQ0aDM0Lzg37S6vmlaMCVzwpvnsnOf8xqsQfZaamO7qB4/jk55 aTR14wLCmB3tj9aaEelX2PFiKttVothxVp29YcZT9d5lFAjzQCYZhzZGE1O8NgeMwWopHo O5hWf9eREkPrkNnLRkQuwzT9bBhMUcc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf18.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745406208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tYNf57Rqaw/AhiPHSI6xriF4M6vsueXVCWtgykhzWHI=; b=dVL2miY4wEff4fBnH5Fittje05qHkv6szDUXxwftaoMAC99y3xp0z7PNbRLRcpnjLlo/C1 IvdJ0Lw7YCA2LRavG1Ckis4YqLtax83YhX7kQ1fn8x+xCnCU6Pc+nRCDM6j29TmRZsLuWu WrImWURETtd1pl7pF4UTapM0q95tP6U= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ED73D1063; Wed, 23 Apr 2025 04:03:21 -0700 (PDT) Received: from [10.163.76.60] (unknown [10.163.76.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B6A393F66E; Wed, 23 Apr 2025 04:03:23 -0700 (PDT) Message-ID: <9260687a-0126-412c-aff2-9a5b358eaca9@arm.com> Date: Wed, 23 Apr 2025 16:33:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: compaction_test: Support platform with huge mount of memory To: Feng Tang , Andrew Morton , Shuah Khan , Sri Jayaramappa , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: baolin.wang@linux.alibaba.com References: <20250423103645.2758-1-feng.tang@linux.alibaba.com> Content-Language: en-US From: Dev Jain In-Reply-To: <20250423103645.2758-1-feng.tang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B75F11C000F X-Stat-Signature: 4dpnud48e4dk675mj6z3mjzejwt6uqck X-Rspam-User: X-HE-Tag: 1745406207-203761 X-HE-Meta: U2FsdGVkX19BLYiTh7VqC1hTXsusiu7CgfkIVjcmMvPJ9XqW5LFfPJSglMkaS4f5K1ybNTjJYU7ElaOwe2FL632EgIe+Me4Dv0gIa5EryDiOXxuyBbEcOWbxgtwh5fDfCdq0anCHeaCdmh8TQawevc7UtzGMUiM/wh0+de6t6U9Fh8VGeVr5zlWUJyNEqsycMWUZ7PuaZf+FjS/SSLQ+ZihQ1eb9hc02OVUlUoIWQ4V7sMNqgI+kUdXah5wfkKlcrxE+mmT4/uQpirN5+5jQRVX1G5X6DW50pz+5NvhOLOCIXfFzEtVG5c85hdQf7STr7pB4SrKVxrGt3P3zMdE8ELfvcdmm4FL+AOJZ2felR5s2/mpbEZ6dpKoUAWxan+Vh2qxpH4c661QNK+BPCFuzXmIqYB4JEIbc9zX1TSFhvb5hbW9pa+Dy2aoFOrUObuoGEOlMpKIW6H/k1qUQ7FcbD2wcMPxnQPtL/DOpxhzuqkbpGY32w2dKaeSKIqgXMLqQ23471/MLS5t9CPZfrf8QA4cbmZbAAg1elcbaMLweW800ithHkpF9Bd9nrLgChJQ5esQzBVGQaCl+PIA+584j1wYvrRSevo9Fa//fB5G3D5Gi2ZVvlW7xX8kLct6bkoST0jn8trlF9VeWLkkRHvasrr1yvvMsOjD+cmyCVwL+ANpSa8ifSmtlF63up1Z09/0oJnf6dak6YxzKJheBNfJ8okIotTPR576JkREQEFUw2lWxFAkyOionxdmKbt2VazLFr/38rqu5kcrGsjawfm33a04va26yl2zkPh/KMC49ke8O41YK+nh4JS1dYn6j77cAtU42X+q8pUuC+pXg2x8/dcfNVDAPpNvuJau13PG6758vlRuBTnbWbXUpYllYzN4VC0dF1RY9eQbFe27DZAGd9KuteTlZ7bswVbD68DSOXLGEoVzPXqTFrZRFjlFOq7yDqDmc/OJTRSRs1py/xiM yv4+6bkP 4Q23JvogQSXQ+YcQ6RRv9kvPmSYBuDhYtWfhD0iDjR85kxr47FiopURy8zPEWtCQLYoBGcahtIQZzfYA1s6+As1wNFVXGZ8muknsOaW092nFopTtvTCBWl6d68mBA1Y9et7P8av5CMC/juclqDKWnTFVV2mIktnCZDGRHMr70SK3tcMEnV9dj6TQqNMfhLDuuN61ajk1gbztiHuInyPA6DR66GpBrHTSNqxKjW8kSkGFyJdFUxdGzmR+qWiEahrmrFE5zJ/oZrrnPDT8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23/04/25 4:06 pm, Feng Tang wrote: > When running mm selftest to verify mm patches, 'compaction_test' case > failed on an x86 server with 1TB memory. And the root cause is that it > has too much free memory than what the test supports. > > The test case tries to allocate 100000 huge pages, which is about 200 GB > for that x86 server, and when it succeeds, it expects it's large than > 1/3 of 80% of the free memory in system. This logic only works for > platform with 750 GB ( 200 / (1/3) / 80% ) or less free memory, and may > raise false alarm for others. > > Fix it by changing the fixed page number to self-adjustable number > according to the real number of free memory. > > Fixes: bd67d5c15cc19 ("Test compaction of mlocked memory") > Signed-off-by: Feng Tang Not sure if fixes tag is needed. Acked-by: Dev Jain > --- > tools/testing/selftests/mm/compaction_test.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c > index 2c3a0eb6b22d..9bc4591c7b16 100644 > --- a/tools/testing/selftests/mm/compaction_test.c > +++ b/tools/testing/selftests/mm/compaction_test.c > @@ -90,6 +90,8 @@ int check_compaction(unsigned long mem_free, unsigned long hugepage_size, > int compaction_index = 0; > char nr_hugepages[20] = {0}; > char init_nr_hugepages[24] = {0}; > + char target_nr_hugepages[24] = {0}; > + int slen; > > snprintf(init_nr_hugepages, sizeof(init_nr_hugepages), > "%lu", initial_nr_hugepages); > @@ -106,11 +108,18 @@ int check_compaction(unsigned long mem_free, unsigned long hugepage_size, > goto out; > } > > - /* Request a large number of huge pages. The Kernel will allocate > - as much as it can */ > - if (write(fd, "100000", (6*sizeof(char))) != (6*sizeof(char))) { > - ksft_print_msg("Failed to write 100000 to /proc/sys/vm/nr_hugepages: %s\n", > - strerror(errno)); > + /* > + * Request huge pages for about half of the free memory. The Kernel > + * will allocate as much as it can, and we expect it will get at least 1/3 > + */ > + nr_hugepages_ul = mem_free / hugepage_size / 2; > + snprintf(target_nr_hugepages, sizeof(target_nr_hugepages), > + "%lu", nr_hugepages_ul); > + > + slen = strlen(target_nr_hugepages); > + if (write(fd, target_nr_hugepages, slen) != slen) { > + ksft_print_msg("Failed to write %lu to /proc/sys/vm/nr_hugepages: %s\n", > + nr_hugepages_ul, strerror(errno)); > goto close_fd; > } >