From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A312ACF58D4 for ; Fri, 20 Sep 2024 06:42:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3501E6B0085; Fri, 20 Sep 2024 02:42:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 300416B0088; Fri, 20 Sep 2024 02:42:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 216106B008C; Fri, 20 Sep 2024 02:42:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0497D6B0085 for ; Fri, 20 Sep 2024 02:42:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 80D47A1224 for ; Fri, 20 Sep 2024 06:42:55 +0000 (UTC) X-FDA: 82584173910.03.8C38712 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 7F7A380003 for ; Fri, 20 Sep 2024 06:42:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726814481; a=rsa-sha256; cv=none; b=GvWgv+2JQXc3+z3xf6voOZ0L/opllCdskz035cdQjbwEZdvcdvAGbswEGLFypuP3dWRqt+ Vu4BOfdMUvztZC+oMUMM/Itv8OqQa2V/ZaSXY92UBqP4CEfuzar0iu7b9iAjFVz+EE1rPC 5deRXBcOdpAAAfyyxPnFqok+b3do9Ec= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726814481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ZBeah9gmUfGkVISWXqgeUwx/xSkiFYzOR2h9rX3CYU=; b=npC//S70r+ROgAfLnKQGWUy7kNVOGftC0aqQ9dkjBuKDYLT0TYTYJSHJEfZeotFsp0lk4L flx1PpnHa4y0CG6OhshR0mwFgX6THHfataToN4EvDrYp6XFr2kGX7/Qi33GK4GwoGKge/O gDtTYcANizgreU/6JR1NEuWTm+mdPZA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D9D0CFEC; Thu, 19 Sep 2024 23:43:21 -0700 (PDT) Received: from [10.163.35.184] (unknown [10.163.35.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E5B7E3F66E; Thu, 19 Sep 2024 23:42:48 -0700 (PDT) Message-ID: <925a26e2-bd53-4bf4-b22d-7a0e11581376@arm.com> Date: Fri, 20 Sep 2024 12:12:47 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Move set_pxd_safe() helpers from generic to platform To: Dave Hansen , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Paul Walmsley , Palmer Dabbelt , Thomas Gleixner , Dave Hansen , David Hildenbrand , Ryan Roberts , x86@kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240920053017.2514920-1-anshuman.khandual@arm.com> <3309e9ca-458b-4b10-8409-9fe315b60ae2@intel.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <3309e9ca-458b-4b10-8409-9fe315b60ae2@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7F7A380003 X-Stat-Signature: coj3fxib3u73pn3yc669rrrs86q44m4z X-Rspam-User: X-HE-Tag: 1726814573-823427 X-HE-Meta: U2FsdGVkX19aUWVdIqIb8c5yr2nAsHsrc+pg6bGiHZ1Dib2Dx1KgIKIKa2+IjLpmkSjY976WcV8f3dr62cTh5vqDHbbrJ4Dc3uUDziGpqtt0HMz2QWsu13V8lpq7SpZdvAJg+A118MTZqYqQNMqqRWRvxbxgZZr8jtWt234SeF39X93dkVgdVF4uRevWaGBDXCrYiFOKvbN6Jdgsx32yBsd7uyeyaDITPbliRV7WfzvS3yZtJhiS97uGDAl4gS5ix/SNdB/hrSECgPzYm0vGWOAZch8jdi3UvPGfjNb44Dj2XNd3YUp0Nd19sR7TIHKA/OkMiEZsQeeXi6KSosRtE6rLeLVoEB2E/yKSsOC+7KQGkzH2RFK7KH9cxozXLiq7t+1oi7YmvU3Q63S5xgv7rYFTyZKR5BgcJqmlXRSpLxWqci9VlbJBpk07pxqnSJYsgctLEiboTXXvvmExhzqHkPeIhLcfrh4vUL0XrgTTlpl68U7s4iuWdQpo9UKZPFif5j88rAdSTW5h7RujQz8bxZ39zNpcYTFdphUEaafdlMxrhiNt6wi4RwBiXklrt1tYqnuGG5Tvo8TJLK55KE/g0axbupEq2aGTFuKfn3jQDt0ZHtMDSaKDOlwfeSjCgj+4f7FxFAulQc2FN8TdbtxL3Hw1+GHFJD6L8Ll+YhqFGh3fz15osZqJ0ZzKFhPKj8Hnj//2HCbxxiupZnnGZXUAxfHVSRaOUvm12Rd4TAqA9hn8epTu5Z38mIp+d65+VdPZ6P+ERLrJLmrJbn6M9ZfSppPLWgH9dF+tELaiqS59hA+bHyGmKxlwY+ZRBK7y5EX9YbIp/WuANDopBIie34VeOzwyuE/1dO2ayQhsPkatEUBSR8xOTb0O7yiHyjBwlG/3SA3QOnMY6mvyvx4gTKGBI7n9+scTc9W8HnAfzvw6XTAo2xZCTpfrZaaLczd5uQ11QZLR2CP1nlPv/RvIBPu bwWxY384 YiM7Gz4KNKOM4UYto/pDNJpkGNe6NVwRb3RYlj78FigjQVwfiux1V9ZNnFj/MIiljaILWmWRcyx4Dj9hhTHJQYSYGVuU3eQYMHzP0y0cU425biaZia4H29x87akKN6ZVzovQMctVryTCofboTUdFsrtJZt+neeQ3tJxmds4IQzF/V7QfG/Mlbw0zEq7P1mRwFfQi23RtZZE9qfCxIheyQw1YEzPqkSThK8BEFEj4pLrMFXRg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/20/24 11:19, Dave Hansen wrote: > On 9/19/24 22:30, Anshuman Khandual wrote: >> set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv >> platforms, do not need to be in the common memory code. Otherwise they just >> unnecessarily make the common API more complicated. This moves the helpers >> from common code to platform instead. > > I just did a quick grep and don't see any difference between the _safe > and normal variants. A quick grep didn't turn up any actual users. > > Did anyone actually double check that these are still needed on x86 in > the first place? arch/x86/mm/init_64.c #define DEFINE_ENTRY(type1, type2, init) \ static inline void set_##type1##_init(type1##_t *arg1, \ type2##_t arg2, bool init) \ { \ if (init) \ set_##type1##_safe(arg1, arg2); \ else \ set_##type1(arg1, arg2); \ } DEFINE_ENTRY(p4d, p4d, init) DEFINE_ENTRY(pud, pud, init) DEFINE_ENTRY(pmd, pmd, init) DEFINE_ENTRY(pte, pte, init) We had triggered a build problem after dropping off set_pte_safe() which seemed not to be used after normal grep. https://lore.kernel.org/linux-mm/202409131220.CJ5MlGCG-lkp@intel.com/