From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95907C02182 for ; Mon, 20 Jan 2025 18:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEC7A280001; Mon, 20 Jan 2025 13:57:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E75B06B0089; Mon, 20 Jan 2025 13:57:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA126280001; Mon, 20 Jan 2025 13:57:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A752D6B0088 for ; Mon, 20 Jan 2025 13:57:19 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 548521C61E1 for ; Mon, 20 Jan 2025 18:57:19 +0000 (UTC) X-FDA: 83028738198.16.23B1CAD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id C4F151C0005 for ; Mon, 20 Jan 2025 18:57:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RCtwdSid; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737399437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T/PRISBUXtei2V2ps4R5VHGPqzSFQpb6XowV6+9L2CQ=; b=GXHA9ZMdMi+q7iXKdD4Bhz/FdX6dKnfWiV61i/DcF9WVkF0DpX8IycLnCTXkQuHyedJGud iRYfdDbv0GUnF6FVMeiQGFzN7CPYYZ1EvPESfJ6yse9pzD8gdJipKUaNFFqzd/SHn5gMQB XnGfre5pJVBT+QCpuO1SFnnUMc6Me0M= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RCtwdSid; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737399437; a=rsa-sha256; cv=none; b=3/XrQReM4Hf6rAEKQQW3XnuiLqdQmo/YXUOQ/hrpOgFcNZTTs4l4lb3a1eow9O1MFLqnf7 C5C9UHou/RFl0340Pc49ptFwXMs3fDYWABRrQAj5/bobFNHuo0H2pBAhyRSXzsQSezUSHR psjX2bqGGn3fMrbDyLSFMtZqa35QMzk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737399436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T/PRISBUXtei2V2ps4R5VHGPqzSFQpb6XowV6+9L2CQ=; b=RCtwdSidyXzKuCraU5w67WkYAS04X1RGebnHt1V/XxYVtQ+sAQzHftnMkg3uzRJBfr9smR fsTI5j/1yq/45nAWn/dYriFfo01uh8CKInqC0Kmv1E84LVbbuj3Kt24g3g+pjjpcALvPbV 6LPocypumg1JqMEvF2hVJ8yNeVMPf6I= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-njxyR4DQOm2nzURDJcIE9A-1; Mon, 20 Jan 2025 13:57:14 -0500 X-MC-Unique: njxyR4DQOm2nzURDJcIE9A-1 X-Mimecast-MFC-AGG-ID: njxyR4DQOm2nzURDJcIE9A Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-385e3cbf308so2071905f8f.2 for ; Mon, 20 Jan 2025 10:57:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737399433; x=1738004233; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=T/PRISBUXtei2V2ps4R5VHGPqzSFQpb6XowV6+9L2CQ=; b=DNCvqGaU/SCG7f264nwgeBX6engui6bla+Bpi4evDaqeKblneE7R7pPSc5KgQkx/dM 1iuGVWGoHyv+PqJqlSQhSm3flpCkphSSXbrP4pkTPShTTB794Up3QELMCKu0UvNUN41z yB6f7ZpS4NUdMCwnen7KsKre5o8VIvnihOIgIr5pc5d8p4L/4MlrwPpRIDVP1IL0EPee 4FcAnHwy3bSV0ub8S9vqF2VMMjJpfTS+1JinCd7eakqfwl+bzweVjJjk4lNJFtkpLpLI VL3308UdmvXAyIbxzBPEGBuO6pgGVEDL66yEXfboA1mxMu42LHIkwSr/kMSIk0dSGKBi lwuQ== X-Forwarded-Encrypted: i=1; AJvYcCV8MVrgwUucO/JOdw0uDsAfr+Id6FBRnVSfHqpEJ6S6jWdZGp02lMhiPK77Nx3Sy6JLc2EhE8dYGg==@kvack.org X-Gm-Message-State: AOJu0YwMCrQtfceUKfKYzoxFLmnNJh2AXMXLWYiBf5j60a2gyhWSaXdO hJ3Pvo0+CtqOSV9g1Gqf6Wg39LKPqNqhOyNlZl90QxfoR4uPjYxzAKqr4xxYId6d7adz8lTjR+j gfGTR2BDJbDV/6NBRUoGkmo+GGFhuP63EtWn5Kq9uT/8ZjJEJ X-Gm-Gg: ASbGnctrmw9ETHtafbUbc64DZdZcy8P8ioC8lzY90HFfXF783YxMkuOC+ijzTsDeuXM dKIFmqt6289h96dyDnHynBOHDhXoSjuEA7CRdD6Ul1zsZmCWDESYk6iqShG5yzO+NqFrZkkfpy8 G1PdyVV6EFVbwBvbwd0qJHoq2Yzv1wdJrbGvz526AQLgUQPVuuuAQGupFAnj90RYsMVz3pr88AR B4igOvurSkzUdeAnnl0Guh+f+tYofznxOT4fVXxU7sTMBfZ+sfDXkB39YdsKyUvueKCcSKOSUlJ Qg5EU08Yu+DqlXmMFJCMKm/Q4PIZzMXUeaA1ZJOSNgNYVT72wpv+Sxe2LGQgd4bk6sesi8bvIw9 8qGKweREkWenGrZdFjOaa+A== X-Received: by 2002:a05:6000:2ce:b0:385:e2c4:1f8d with SMTP id ffacd0b85a97d-38bf565f06bmr12171178f8f.19.1737399433372; Mon, 20 Jan 2025 10:57:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhabdAO/UUc3UXqLouRsw96j3NCFrRpn1wkY/ppvQQo1T81apTh02yRjUc16yBGrGAqikslg== X-Received: by 2002:a05:6000:2ce:b0:385:e2c4:1f8d with SMTP id ffacd0b85a97d-38bf565f06bmr12171168f8f.19.1737399433031; Mon, 20 Jan 2025 10:57:13 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:e400:431d:9c08:5611:693c? (p200300cbc72ee400431d9c085611693c.dip0.t-ipconnect.de. [2003:cb:c72e:e400:431d:9c08:5611:693c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-437c74bf061sm207470795e9.17.2025.01.20.10.57.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 10:57:11 -0800 (PST) Message-ID: <9257fbb9-d26d-4028-896f-fb8cfad3ddad@redhat.com> Date: Mon, 20 Jan 2025 19:57:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm/damon: introduce DAMOS filter type hugepage To: Usama Arif , sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org References: <20250120181959.2564362-1-usamaarif642@gmail.com> <20250120181959.2564362-2-usamaarif642@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250120181959.2564362-2-usamaarif642@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Y3MPvt5KPgwvuPON2YrC5kgTz0UsO1Tg7bCUkNVfek0_1737399433 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C4F151C0005 X-Stat-Signature: pp8m74rqd1anmebuobocmrwa8bf7y498 X-Rspam-User: X-HE-Tag: 1737399436-407111 X-HE-Meta: U2FsdGVkX1/Ftk58jC5huyNe+WdRhAhuh3o0dRBcG3X6El77U1UCDzsrSWiQ1caUPV/xG/PBx4W/C0Xy+kJebjsJ/Wcaqb7zeIQBwVFywVp6bvqBv/V1CPnB0gPQymLRgFVhEEg79R1gt/pBuDmunwzNczOlnlb+D0N2WVOUA1xy7pKGhJJMoU91TdJgXiQNxkoe91ttzgyjyCnAG38AuEn0zFCqfowV2jBr4OA4jBwUYtCnfDctMbvhIYGdtVE3xfRfeBas8SLOBln4o/evVm9a+L/XlhAVIswLYRxTVzgTmMAwJ8u36qCzulc4apjP/N4puanEt3h9OOH1cUIuQUhsUSixgLaIiIbaRvVNzDrOaglKDBzOjJ3g47poMonWEpJp3vM/gC9ObwlOeLdG0SeCKA3NTydll80WY3eskwsBqHVawvWhkXoKVbJwZJjHcVzclfBfe1aTckq+htzyDefHouCGm9Nvomx+mxtzcBiWoIZA7PrBb0zqF94g7svnoxzLdJsg5S8kufmyc+WNPztHrs8MBKw6JwxjytYctWW8noI5Y7vRdmJcUJipJkjBAIkCRUbtLd/MuTGBZVmZBbzG0JZfoVduLC1RCuSqk4fsnMuX1ScvbemHVbb2q6pAvgvqqxmyAuPKhNFWu1FbDV1BgxXaxj88z+ncPp2mwXbh//jc+MZ5Bkn7Lpr6imZyj3Yw1JCgDHeq7EQtfklLR5u13FQV5TG7x8dXMpaqUDjQ1ypaDWCmC+3NERENGUvA2bEA/j6ZiWvKB5bZPo8hJgwa7Ch9nn5ZyWom8fIOCx+amQKo8eDY8PCAf1Ar7Zi1bz9BeXKDBcQq5NXfB0Po7UyuziRZ+2VNVo1XW4G8Ij2+8C7dthfTc7m+HLg4RW2HPUD7tMT7esEg4WoFq6cFH6YzJwsAt5xnI19vuf70LhLLb+khUfUJe13D6mJ9UzoC0rWq2SfP/dPYnzuZ6L+ 0CwoEsci H+jbQNTAyaZOKiCMi7ZAOYCRvqKEVdUdyqfmir81E4ORmiQB0L3ow85G+ZuQn12xDH1cwDNx5ec8xtTmRPOk9COFRIrShjL04I5ARXFiMyDEbcGJh71ROUT2lmzf4WzeyaX9MuV8koh80EzzkyaERyQd9gUrn9nMrukxetvWA/RmcngCtspiRv4VbTn/iFId7Tm6CqZOZzsUFBR+fmgEHnu0P5R/BnHvUREtuw2aUmzJv8YuVjnHlyLkMaAq2T360t7eOB68xHLjh5m+mPgNoE+7gCCl93Kh60FNU7P3ZifKo2eThDPp3czTZ147/DIAmGi/G4wfwsSoM3zr1p4HrPFMAgvquHun20J1se6sKHgbQoems8ewxS2Jinm1vcXqMiVgfkLJUdRb0hEI3tHrRnLrE+ji/FKYHBrgR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20.01.25 19:19, Usama Arif wrote: > This is to gather statistics to check if memory regions of specific > access tempratures are backed by hugepages. This includes both THPs > and hugetlbfs. > This filter can help to observe and prove the effectivenes of > different schemes for shrinking/collapsing hugepages. > > Signed-off-by: Usama Arif > --- > v2 -> v3: > - expose hugepage via sysfs even if the kernel is > built without hugepage support. DAMON will just > just return 0. (SJ Park) > > v1 -> v2: > - Wrap DAMOS_FILTER_TYPE_HUGEPAGE case with > CONFIG_PGTABLE_HAS_HUGE_LEAVES (SJ Park) > --- > include/linux/damon.h | 2 ++ > mm/damon/paddr.c | 5 +++++ > mm/damon/sysfs-schemes.c | 1 + > 3 files changed, 8 insertions(+) > > diff --git a/include/linux/damon.h b/include/linux/damon.h > index af525252b853..1d94d7d88b36 100644 > --- a/include/linux/damon.h > +++ b/include/linux/damon.h > @@ -326,6 +326,7 @@ struct damos_stat { > * @DAMOS_FILTER_TYPE_ANON: Anonymous pages. > * @DAMOS_FILTER_TYPE_MEMCG: Specific memcg's pages. > * @DAMOS_FILTER_TYPE_YOUNG: Recently accessed pages. > + * @DAMOS_FILTER_TYPE_HUGEPAGE: Page is part of a hugepage. > * @DAMOS_FILTER_TYPE_ADDR: Address range. > * @DAMOS_FILTER_TYPE_TARGET: Data Access Monitoring target. > * @NR_DAMOS_FILTER_TYPES: Number of filter types. > @@ -345,6 +346,7 @@ enum damos_filter_type { > DAMOS_FILTER_TYPE_ANON, > DAMOS_FILTER_TYPE_MEMCG, > DAMOS_FILTER_TYPE_YOUNG, > + DAMOS_FILTER_TYPE_HUGEPAGE, > DAMOS_FILTER_TYPE_ADDR, > DAMOS_FILTER_TYPE_TARGET, > NR_DAMOS_FILTER_TYPES, > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index c0ccf4fade24..224308140441 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -222,6 +222,11 @@ static bool damos_pa_filter_match(struct damos_filter *filter, > if (matched) > damon_folio_mkold(folio); > break; > +#if defined(CONFIG_PGTABLE_HAS_HUGE_LEAVES) > + case DAMOS_FILTER_TYPE_HUGEPAGE: > + matched = folio_size(folio) == HPAGE_PMD_SIZE; Can we directly embed in the name and the comments/docs that we are only talking about PMD size (both, THP and hugetlb)? DAMOS_FILTER_TYPE_PMD_HUGEPAGE or sth. like that. -- Cheers, David / dhildenb