From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E765C83F34 for ; Thu, 17 Jul 2025 15:31:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39348D0006; Thu, 17 Jul 2025 11:31:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F10EF8D0001; Thu, 17 Jul 2025 11:31:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4D918D0006; Thu, 17 Jul 2025 11:31:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CFFEF8D0001 for ; Thu, 17 Jul 2025 11:31:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8D7CE55EFD for ; Thu, 17 Jul 2025 15:31:16 +0000 (UTC) X-FDA: 83674145352.06.A615002 Received: from mail-internal.sh.cz (mail-internal.sh.cz [95.168.196.40]) by imf03.hostedemail.com (Postfix) with ESMTP id 180E020009 for ; Thu, 17 Jul 2025 15:31:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=cdn77.com header.s=dkim2019 header.b=mIoYXInm; dmarc=pass (policy=quarantine) header.from=cdn77.com; spf=pass (imf03.hostedemail.com: domain of daniel.sedlak@cdn77.com designates 95.168.196.40 as permitted sender) smtp.mailfrom=daniel.sedlak@cdn77.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752766274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D47TUbC6PKtN5Ps2F2w+d+aNYLg4bLwm/LXLz/LKsUU=; b=N5Tkpr1z7YUWmBwG7EUk+yR9X+SMKKuYKMu6tU6VkGlY0nR0f+mfnnXOirFo9Zul1dxfzV 3u1aOF8E4fpQUpQ3b2ydrzfVqhkzYh78MRpJuituhpIoMtrKfdDsKFe3+C4iiEdkI+Pu3F xvGM0Tl0N1d3y5ONR1GcgOCEbYUHNVg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752766274; a=rsa-sha256; cv=none; b=JG2eaJYcsE+S3t/TanuTfiZwsJaio0BCyWSHzcyEuDZ0Jc3Ia9YWPZtsC/2fbh9VNiB7++ 6/BEORcAOJ4dSSVpQIK0yQQx0+dGjs3gYv2Euck6gkAK5aBJbpAUfNXGv247tIDXCFmWWp sERYaWsdgVtoTnqw+zYPWhk2zYlMOrw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=cdn77.com header.s=dkim2019 header.b=mIoYXInm; dmarc=pass (policy=quarantine) header.from=cdn77.com; spf=pass (imf03.hostedemail.com: domain of daniel.sedlak@cdn77.com designates 95.168.196.40 as permitted sender) smtp.mailfrom=daniel.sedlak@cdn77.com DKIM-Signature: a=rsa-sha256; t=1752766269; x=1753371069; s=dkim2019; d=cdn77.com; c=relaxed/relaxed; v=1; bh=D47TUbC6PKtN5Ps2F2w+d+aNYLg4bLwm/LXLz/LKsUU=; h=From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References; b=mIoYXInm46EXNtvppVY8Jd/B952Un+Euw1eGLnofuqX7UYBK4pQWLYxYG3JWW33a+2g9+rFwWOlKCPrP7aHMXszhhePzwNEo5s8i/NbdLeRRENZNV8ojjsfh8K0kPwLDpygT6z8FmvK2VoG4G/pan1Fpxf7/QcTffwEF2Qyf3pE= Received: from [10.0.5.28] ([95.168.203.222]) by mail.sh.cz (14.1.0 build 16 ) with ASMTP (SSL) id 202507171731080833; Thu, 17 Jul 2025 17:31:08 +0200 Message-ID: <924f57a8-deaa-4f7d-93ee-4030e2445a01@cdn77.com> Date: Thu, 17 Jul 2025 17:31:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net-next 1/2] tcp: account for memory pressure signaled by cgroup To: Kuniyuki Iwashima , Shakeel Butt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Neal Cardwell , David Ahern , Andrew Morton , Yosry Ahmed , linux-mm@kvack.org, netdev@vger.kernel.org, Matyas Hurtik References: <20250714143613.42184-1-daniel.sedlak@cdn77.com> <20250714143613.42184-2-daniel.sedlak@cdn77.com> Content-Language: en-US From: Daniel Sedlak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CTCH: RefID="str=0001.0A00210E.687916CC.0038,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0"; Spam="Unknown"; VOD="Unknown" X-Rspamd-Queue-Id: 180E020009 X-Stat-Signature: x817xrz8353f15epbptfutohczd1igds X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752766273-590336 X-HE-Meta: U2FsdGVkX1/Pzpyye++yaJVqf+I9YbFY3YYlIS3qq1fazHzvbBGDX1vKNLkFE0ogdHsONZU+OGuNQqBlYr2E0X08GAZIJl9yV3UgZ+6I/ey4gTrfRA0jfg0PWUt2AOlvDLBxtxmJpIeWKfApm0maHMVnRWV0ErC1XEqI3EsQ8HoBRwBGgqWQcZUIkCE7of88N4ceteb4EigwX8g7+sXTim7lb22nO1hutcQdjsD4clmDp2HdQYc8/iq/ccCKLtv8wqfr7PoH1Y3obQYN0LBayktUmextRr/RJ4GhJFhGU5TRkQU6YtQH7UQN8p2TcnxZWXpYFBRjxSVXzvhusY/lKQLjulUTFqr+eZMef93gYaT4ySgVQ00Ws2iH6mGh8jD8zVkbIwqn9yPWaYU9CVCFPR3rwP5Gq01e3h1dk0MgTvT6NGtAkiz5FyOiCPdOqncBYK/MrBYW1xlR8iTGSSdsKTo7VU3HxMQwth0Jsgsq8DUG5dVAGpAt8F7x+iviWJlt13h+PR87sUA7aRLS8tnTCkAdtFVlKGtJ0xwZDD4tog1AoprpQNm4Q1sqOWrrCXM0TPCbbxgQIkAyg8UDIE5GKSisn/9NqfZu8rCDlC3/TEeEOiwPYlgSr90kwf+gWOK+N68PNYhC+tTStIDOb7CA+Ypv2ljhbev6NsEvGyEmDoi0bLo50+of6tQTo9r1oUaLK47FDkec7IhRM2OONW2b6WXsoiER7nFyAEozJRTBfGdMuO2yTLAn8qsThqIhKBKYcvFfL0l1REpoQaqk9yt2EU9HYUjNwUx7jgSfK6nLU8NSCR3pfjeFyasLQjmE7x3szxoHz7U47EGHhoXpp3PR23y3WOSe7QuXieqTuvCpll3CmLZBanwSwIixk1YKevZBq+fuNbvqodeVDRPrLVtXAvxEufiqnXtX0PxtzVkfWTeUBZshsRQP5gz7vu+inS1Ph87cLC84IIaFTWKSRSz u+4wmGPv krfE7X1gjW2PO+rKWjtSX8ZJ9J2TAN/41vEN1vW2Dy9Rj747y66EBapNL29+cLdYeyVSy74W9j0aHhc4bOitHgFlwb8s1W9LVCjHmWrTLp/3Z9t3byBBC9OIul3BOxqCy95F4LE6AGWtF2CchrnTL6LQHYIdqU1DMYpidKiOL1KOJ1PkeKvYBV6FFqm3t+q1Ha4mBzP4cdOZcM+rF1ij70CN1lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/16/25 8:07 PM, Kuniyuki Iwashima wrote: >> Incrementing it here will give a very different semantic to this stat >> compared to LINUX_MIB_TCPMEMORYPRESSURES. Here the increments mean the >> number of times the kernel check if a given socket is under memcg >> pressure for a net namespace. Is that what we want? > > I'm trying to decouple sk_memcg from the global tcp_memory_allocated > as you and Wei planned before, and the two accounting already have the > different semantics from day1 and will keep that, so a new stat having a > different semantics would be fine. > > But I think per-memcg stat like memory.stat.XXX would be a good fit > rather than pre-netns because one netns could be shared by multiple > cgroups and multiple sockets in the same cgroup could be spread across > multiple netns. I can move the counter to memory.stat.XXX in favor of this patch, if anyone has not started working on that yet? Or are you suggesting to keep this change and also add it to the memory.stat.XXX? Thanks! Daniel