From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCD2E77188 for ; Fri, 10 Jan 2025 15:41:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E77D28D0003; Fri, 10 Jan 2025 10:41:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0BF58D0001; Fri, 10 Jan 2025 10:41:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2C0A8D0003; Fri, 10 Jan 2025 10:41:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 9C0A18D0001 for ; Fri, 10 Jan 2025 10:41:12 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29FE5A0AC9 for ; Fri, 10 Jan 2025 15:41:12 +0000 (UTC) X-FDA: 82991955984.03.1E18E98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 9B2D2C0011 for ; Fri, 10 Jan 2025 15:41:09 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZuWBb9Oh; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736523669; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5yIGkbqejGa8BA3qWHg1c28D6Q7b3/Kgi7rVuOzpup4=; b=HfpIh25q+eCUmvTPbruuegDulhhcAalRhqvXHMXgoLCfIs3twni9qgjQZNy5kARh1yfqhG 5ATK8tIGym6L0JjbT76aXSSugAZpp9s8WAkNyxLO/OMfHleb6JHjqdm9T3RlCl7qdmJzBr 3WHEWcLs6T1s9CLtC5a2+lfwHhoAoII= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZuWBb9Oh; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736523669; a=rsa-sha256; cv=none; b=F2kDK6RIc66PJ6wcLoNESh+N2M0dJd+ajuVomimuNUCre+ieFVNFkS9rMR8H9+v6HCQkD3 QeT7tKvn2ffX5H72kqrLr5I7W3+jlNsM5MFVr4NvLM8uS7sILls6tDofjb1MMRXO/AqWLI i+oySnRqnaSn0565chnw4lse/vWnScU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736523668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5yIGkbqejGa8BA3qWHg1c28D6Q7b3/Kgi7rVuOzpup4=; b=ZuWBb9Oh42TCcKfPfkOLtH2C8KYqoaf0B2piFs9qkQXF4L5ojuTvRSALmyx7UWwRJwzf2e Cro0sgTuZd0mZsRY4VXDl+yfUDfOp31EQ+hfn60Or8gdaJhiBAzxal4IqHQIylJikH1r0s eBe9ZUq5tRSWQADgLFTqPnkj1AViwBY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-TYIFA-YlODaTWzK4oPrdVg-1; Fri, 10 Jan 2025 10:41:07 -0500 X-MC-Unique: TYIFA-YlODaTWzK4oPrdVg-1 X-Mimecast-MFC-AGG-ID: TYIFA-YlODaTWzK4oPrdVg Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38a891d2aa5so1190479f8f.0 for ; Fri, 10 Jan 2025 07:41:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736523666; x=1737128466; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5yIGkbqejGa8BA3qWHg1c28D6Q7b3/Kgi7rVuOzpup4=; b=Np6Mx3I3+CXj1kI/XwY4RI5qb2FmKsi4yjX4Ei67Qc1+Poy3f99b1cQpkmgsh85UgX HB/6l2Q0hM/1aZn+70svIdIGchhaYdZnT3tYwC6+oDkUoI5vqAAZnfxEUld+Ol71IHrv 0dAPmzQftuNh6/4etKFbIo6E7wWsJc7CvE2qS02cOCMWRkhI9r/lTseN1NqR6cUgt/az vg/vFAz3PuH1kwICGqByBSq2p+f33TwNzC57jIwBEj9sPKIubDlJsNYtuIoZjFSi9xOi O3/RRgTmELJyBr5YA6+ssIPzup5XD/RsvvR0PUfiK3FwfFHQFLjf0J9DJmq6IdRf+fDE So+g== X-Gm-Message-State: AOJu0YwXqwNyeWUHkJTF2QwFBM0McrkTsNG8jz8OcDPzN/8rJp6Jb/X4 v4dmjArmhJT3NTwU6+A8UR4lmO1g4+L8CKTJF1dkjTLeSYWpAnIydrWpTN7RaCl7PXaIWLEzQ5c N5EyN9O3pxKb8d5OqJrF6+cvVa2NqeYxp7woH+KjWJd/JtY+x X-Gm-Gg: ASbGncsERYn/of9gOMqtk54GwBcB1uMWmxbNAP90qkzbTlcNk5IBB5vf0yWFU1OknpH 62beblZv9ToHzCur1fJ+nU1RDFTE8gomoD06CNMBU9ljcNtFCOYMkpjeGA8C2Tjapgmu/rQb2yS UbNZlN5YmzzcaIA7wS8AZ3hdluaHy9fj2cESMu5mSRHmsvwqX4O/Cnh5qpzMuOiWDr+6IALkQfg Kde9WIDGFT2NwlJGdEta2/EL2sHuMlr+qbLaZtLhQoCrRIAD08TFzuh7L00aBprd8+RF3Fip7s1 Sw8wBXeOr89tXEqHSqodSBaOdLoOJEuOwsie6Y4dPWz+y6ITbJz/qSOpmp0IJYga+EGaFhGQzhC zZ2kdBbKr X-Received: by 2002:a5d:59a9:0:b0:386:3958:2ec5 with SMTP id ffacd0b85a97d-38a8b0faaccmr6028345f8f.28.1736523666442; Fri, 10 Jan 2025 07:41:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbc+g5+K7U7vbcDG96TnJZxZ4Dqa0b827MQwcuborGfLRGxzbaFboDvSK88tGlqBSpB21X/A== X-Received: by 2002:a5d:59a9:0:b0:386:3958:2ec5 with SMTP id ffacd0b85a97d-38a8b0faaccmr6028320f8f.28.1736523666088; Fri, 10 Jan 2025 07:41:06 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dcc8ddddsm79915705e9.0.2025.01.10.07.41.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 07:41:04 -0800 (PST) Message-ID: <9243dd8e-3f03-4ed5-bdcf-95c947c57849@redhat.com> Date: Fri, 10 Jan 2025 16:41:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] selftests/mm: virtual_address_range: Avoid reading VVAR mappings To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Andrew Morton , Shuah Khan , Dev Jain , Thomas Gleixner Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot References: <20250110-virtual_address_range-tests-v2-0-262a2bf3c3d0@linutronix.de> <20250110-virtual_address_range-tests-v2-3-262a2bf3c3d0@linutronix.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250110-virtual_address_range-tests-v2-3-262a2bf3c3d0@linutronix.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dL6gOCNzl8o5K0Ok1ImtYlxHzAL6EmipgsZ7QFKT8gA_1736523666 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9B2D2C0011 X-Rspam-User: X-Stat-Signature: q1wgor4iercm3ge9hhb7byxanjuusz4n X-HE-Tag: 1736523669-603901 X-HE-Meta: U2FsdGVkX1+NBOVUdEulh4aon0HINxU1EETwDltpEZ7JfVG9jEwrIgKjFQCCb2S69rTInp1l9Bw0AIVfTyVrLXDyhppyhrn5tiTel3KKnlKj841pVc+T8mNwDUyDlC3E2h52D1w1LK8zQd9SDNCIqNrvSooouojG9IchScfFVrsKsEayILYJEJrujrWvlHq278j8yYYGz5RmT546D9Iq8a/D7HJb3adcaf+KScN/SmBTqor3TmZr2snXDg9ylhJLqoz99rkJX22YkLzWBZNQxuQ5VqonsVh9A7lI0H1Pvadu5fcqNPPslJrOCjtWJYV5V0LPi/7gxOsrvHXRTSuTBvfTvFm6QqY2M5voC3r+Ghxt805FocLNEBHvs/MoL713Gxyx7QXxpl/w9c1A4l+whwRC9S5BvWU1CA26+g81PM/CCbapww6uwsQ0faVk1J+3GpBAH9n4/kHkl2DG/EvRuLVMOQHHqNCyOjBfaHNedXuJNa2UWvEPo0wV4ZKSF87nhuOFAXYpTGD3U16Ah4UlSrPpZXr4cckldFYGqCbQJKVwNAlUpGh5j1z86RtgMR0I/qOpnC0Rn0Jg5Q5aXtR848CQmGe9H1GlERLT/YU6/Eoh7RppUgong6gGCKWCntaRcJf68pOa7uBkelj/X693uszgUJJC1fo0i+jrqJUAcw+MW4OZZckk0RFxMm+VzkTbDhQMW70WpREsacMEv4CB3+lDQ4YLI3z/kohrAmRbNfDZFWx1D0EkmgrkxrrhIo4yQO0fNgKdem4OI8DdNuQCTdTIbzQA6H4ohtdC3Yql40C6Hem3zVuleU7V4gaLALluROqlau6jNmhNnq0UwfMwQMULX1JgPBpgCOweKO+frXy0dWh1IT2OaTFHuJoXxgKh4jW4YnuU9fE3+jX01rasY8NN3RW4ClPu3PBK7L5Wbuvnu//H45Lkq6dkmLhBe/FzJweCLjfzPZfJp9uT8DP wVYILLyQ CEFs0ND4mggWz43+gZ198OLop9dzgXH7TkVPFvfvmvUHyYjLbkH6arfrilIklM0tE4q9+shKvmmdrI/YOEcnEjQV0t/0DntGC/06Mxtpwt5yBLctoQmX5JfUo0ucCAz9IVFA/e6yMrNY876jfYflIy0X1/rdZyoIBngC4aECJ13Ue5BNNZZizDT++Kazh+cmgvCK76OA1Z+NXzzhb1+0sdUmrpQelqgKmLfIhlbS9wMhfI6wMG28PhIfqKrw80V3uzugrDeClP1Q+eyxD8gHxc4szcitnWaOARpV9dwL4h6Ab8NP2heNLC0Qmzi4sKA42EPEnnBC2iEcT4ChwaeMm5hROdBjNeiAWIVPBQc3XaZ86xxMrALb3kQZXQo1AbGDo9JKnhglkyj7hr7gXS4lWXPfoRPYty9dUxJ9wj+UWBo3uoqlEQgdZ9YDCYVoWfGWyAJMdmvgFiFJUXMLPR0gSjU9Io2lbX4tiipxVhS1a1CbsG2ReTPrdSjuarBdrmoMYi3W6wj5OJsMyaY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.01.25 14:05, Thomas Weißschuh wrote: > The virtual_address_range selftest reads from the start of each mapping > listed in /proc/self/maps. > However not all mappings are valid to be arbitrarily accessed. > For example the vvar data used for virtual clocks on x86 [vvar_vclock] > can only be accessed if 1) the kernel configuration enables virtual > clocks and 2) the hypervisor provided the data for it. > Only the VDSO itself has the necessary information to know this. > Since commit e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping") > the virtual clock data was split out into its own mapping, leading > to EFAULT from read() during the validation. > > Skip the various vvar mappings in virtual_address_range to avoid the issue. > > Fixes: e93d2521b27f ("x86/vdso: Split virtual clock pages into dedicated mapping") > Fixes: 010409649885 ("selftests/mm: confirm VA exhaustion without reliance on correctness of mmap()") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202412271148.2656e485-lkp@intel.com > Signed-off-by: Thomas Weißschuh > --- > tools/testing/selftests/mm/virtual_address_range.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > index 4fc1c21a5e218eaec4d059b75c31a21dd4e8a215..993990aba56fc986c42084ffa91973558aa07e87 100644 > --- a/tools/testing/selftests/mm/virtual_address_range.c > +++ b/tools/testing/selftests/mm/virtual_address_range.c > @@ -152,6 +152,10 @@ static int validate_complete_va_space(void) > if (prot[0] != 'r') > continue; > > + /* Only the VDSO can know if a VVAR mapping is really readable */ > + if (vma_name && !strncmp(vma_name, "[vvar", 5)) > + continue; I'm wondering if there is a more generic way ... but likely not when staring at /proc/self/maps. /proc/self/smaps would indicate this as VM_IO: "io" VM_DONTDUMP: "dd" VM_PFNMAP: "pf" Especially checking for VM_IO sounds reasonable ... -- Cheers, David / dhildenb