Re: [akpm-mm:mm-unstable 9/30] mm/memory-tiers.c:64:6: error: redefinition of 'folio_has_cpupid'

[Zi Yan <ziy@nvidia.com>]

[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]

On 23 Jul 2024, at 12:32, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
> head:   cecb3db438d76f7c1005fd52689809696a330474
> commit: c57ceb62609b36d1a01e8bdd894d032379999b75 [9/30] memory tiering: introduce folio_has_cpupid() check
> config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20240724/202407240024.Lhu1XDok-lkp@intel.com/config)
> compiler: sparc64-linux-gcc (GCC) 14.1.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240724/202407240024.Lhu1XDok-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202407240024.Lhu1XDok-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>>> mm/memory-tiers.c:64:6: error: redefinition of 'folio_has_cpupid'
>       64 | bool folio_has_cpupid(struct folio *folio)
>          |      ^~~~~~~~~~~~~~~~
>    In file included from mm/internal.h:11,
>                     from mm/memory-tiers.c:11:
>    include/linux/mm.h:1796:20: note: previous definition of 'folio_has_cpupid' with type 'bool(struct folio *)' {aka '_Bool(struct folio *)'}
>     1796 | static inline bool folio_has_cpupid(struct folio *folio)
>          |                    ^~~~~~~~~~~~~~~~
>
>
> vim +/folio_has_cpupid +64 mm/memory-tiers.c
>
>     53	
>     54	/**
>     55	 * folio_has_cpupid - check if a folio has cpupid information
>     56	 * @folio: folio to check
>     57	 *
>     58	 * folio's _last_cpupid field is repurposed by memory tiering. In memory
>     59	 * tiering mode, cpupid of slow memory folio (not toptier memory) is used to
>     60	 * record page access time.
>     61	 *
>     62	 * Return: the folio _last_cpupid is used as cpupid
>     63	 */
>   > 64	bool folio_has_cpupid(struct folio *folio)
>     65	{
>     66		return !(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) ||
>     67		       node_is_toptier(folio_nid(folio));
>     68	}
>     69	

The error has been reported by Lorenzo Stoakes at: https://lore.kernel.org/linux-mm/6effd690-3cf2-46bc-8061-2d19922ad4fa@lucifer.local/.
I will fix it in the next version.

Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]