From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 066EFC77B60 for ; Wed, 29 Mar 2023 23:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DB276B0078; Wed, 29 Mar 2023 19:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98C0A6B007B; Wed, 29 Mar 2023 19:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82CD86B007D; Wed, 29 Mar 2023 19:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FC096B0078 for ; Wed, 29 Mar 2023 19:33:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 585D780FB4 for ; Wed, 29 Mar 2023 23:33:43 +0000 (UTC) X-FDA: 80623540326.28.DC1189D Received: from esa5.hgst.iphmx.com (esa5.hgst.iphmx.com [216.71.153.144]) by imf02.hostedemail.com (Postfix) with ESMTP id D2A278000F for ; Wed, 29 Mar 2023 23:33:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=LZMxkIFh; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=iL0pOV79; spf=pass (imf02.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680132821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TlaulgggJ1UYomGkGAhVex0DHpTSa7AVrgYQKWm5mO8=; b=X7BWmP4mrft5fKEhxWXYy9BQ8bnjdqQPf38hZls226KYgbYhXXE23geIo8i+WQlt9FgM0E lWGS6o/0nLtUe1sKkOrCnCI213tKTccG+vGfpWBcandqb8yUNztcrfTOeIRRuU+cMj/Dhd L13h9FyA5dDxPp23LlBKNu6PnzbAxQ8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=wdc.com header.s=dkim.wdc.com header.b=LZMxkIFh; dkim=pass header.d=opensource.wdc.com header.s=dkim header.b=iL0pOV79; spf=pass (imf02.hostedemail.com: domain of "prvs=44543d287=damien.lemoal@opensource.wdc.com" designates 216.71.153.144 as permitted sender) smtp.mailfrom="prvs=44543d287=damien.lemoal@opensource.wdc.com"; dmarc=pass (policy=quarantine) header.from=opensource.wdc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680132821; a=rsa-sha256; cv=none; b=RdhmeptjFTQMDZFHsz+FMHo26PS5uVrPV2atvmGXxHn8l0abZ6SUBnjAP8eNnCzlZV0WKE /RkusUjiI+iRiY2rRe2LuQvlJgf3Me8ZNBShqqcGe/DuRF+BCTolrqWKK/MUrAHkgsbWpT J5zgoL5C19Hy1XzEoKclZJOIQ5kb9vA= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1680132820; x=1711668820; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=2XfkCsgwrNyUw6t3bN5epvi5ctQPl/PkBM51tAE2KI4=; b=LZMxkIFhvmE3CGmJctROf8J7EaYwhR6L5ejzcEq2xa1zXp50iy4QiSXr g4AlpLK7xs0iLQQ4bn26riQ0BfTqcdlQWBFrGTQ+VoThO8AcdMYzMKDO/ bcgflrGfA5jtUWhR6ysGA5ayQDMJAz19ElRPBQMIP2QULOWRXO7Ik0SYC DrXrMfWdqK8XJww1rTN1//vpiwVevKEnSMOIHwaUnqvQdOctG0t/uAEvn lFxY+yLiDr/o6jM2uaue288Xf3MI9UO2KQGyr3+5MwnFUHKMqTvb1bgxm xFZ3qq/8EJKXM0Kob8pSsl1QK7hs2ofkE5EbPucA1A69coEl98LGTc1fr w==; X-IronPort-AV: E=Sophos;i="5.98,301,1673884800"; d="scan'208";a="226648225" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 30 Mar 2023 07:33:39 +0800 IronPort-SDR: xvzpRApLOFzyAwPmi9h5xUS9BiCoYkNwH4y/GW/LmM/5RMwAkga888DhwmHAvQII9YtlZFXhTv YOFs4fAo/xcd74+UsbH0mkbIhViratsjltCBekAHnU9S0SuYCwtGxf911OTXluoDlszXtUstVy Lj/1txXEnkwGYA+87VDaUmHKGXeeCCuLtch0nMEVplWpk3ZqMVxJEhbFWOkZ/uJLOw6psmDQH0 rfK/IKeYCNWCZxLG3pHYHYH0+vynGd9wKLrio2yrgdMnr/1sMOzOdB7itPJI7YZaD/lnSxpugF +yQ= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 15:44:07 -0700 IronPort-SDR: a4z5iJn4H7xm+HZ2AItgsxOesOvpKj1maf4JvfXv4h/+15HIGxzuT8Jo/Sgolh/l50QGP5i1k3 6LlHl9yxXNjAb5ajQwMfXXsI4Wfx5rnldcMTyeaOK8BLnJBNUuOmy3/7jrv1uCq2cFnef8XM+N sF9MTkfvEHAp7seeA/UnPiQyccagGQhSCjKRQPgBAr5jMYhXqdBa9InUx7QV2nM2nu+ZHfTyzI ZyS8fO0OWpjMJL/lGdcTrJM2EzL3xQ+ayAEzbhfJtVMAnN3Ap8yk+j3/6zkALh844dEd+rG+2j K3w= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Mar 2023 16:33:39 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4Pn2tW0Hwqz1RtVn for ; Wed, 29 Mar 2023 16:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1680132818; x=1682724819; bh=2XfkCsgwrNyUw6t3bN5epvi5ctQPl/PkBM5 1tAE2KI4=; b=iL0pOV79abCn58O3GsYB3incxhwrPGLAZGI7X+0lqN4SQQeDOnB qJb7+62q5R7L5egPIr3c45AiogLxHvyE6Lwb4X+ABQD60bWF9q9d86DXH9mxAomK Qu2grIxrBMnxXiUCC9/WpTKWZywUMM3/M8INQgOE8mZwBHEVU6DB5WsHrjzo+Sn/ 1V6s1+NZHPGuYuWBRZO8OSKChosO5Hy1NGf3W1IvjZty3XmVtff6p8XfHJ30Gaoh 4l9C78DP+cf3gRR2ZbpYL8pkpDSGf79rjnBmncsC+8xVR7xVsQk0BA1KeF40WXti HbeBREtOM52B3AwqaTea8N47bzscm0SsNKg== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8jUpIwBUedru for ; Wed, 29 Mar 2023 16:33:38 -0700 (PDT) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4Pn2tR3Vpwz1RtVm; Wed, 29 Mar 2023 16:33:35 -0700 (PDT) Message-ID: <922e7921-c70c-cda6-aa5a-07ed44596d4b@opensource.wdc.com> Date: Thu, 30 Mar 2023 08:33:34 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 08/19] btrfs: repair: use __bio_add_page for adding single page Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D2A278000F X-Stat-Signature: m71bx5ujeqz867p9keen3azer755tf86 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680132820-691208 X-HE-Meta: U2FsdGVkX18pBMoB1XR9kUkXH5c0+553CvOh6sFO1Kpe12gwi2M01r5jp1ERRGz2YrTF7M7TgKheYR1wR6MNjqntprwxww47cNm6cuPHropOSYZJ3Cj3QJnCHrzsi7WYhqd9xvVTDuARtZW1VwV88BJ5C7Ucw/EZ47K8guyRL3kb/xxeNK7G1CYHbcNECe2I4w3FOtsJtgBk6bXfGwJZ3rxTuBBX08AecStI6lMU5lyiPoiNs9EI3iTKni4JCiweJYS9UF3LkfyR70YZmxM5TlJNjEKiCom+HD7cjhOeJCaa/XL2EpoETtyBKJgeUQIWZ5mQZvf6jPnY3aQbR+sPUDAkYvXz3v19ORQWSjjzOz6RJzDWK7v7oCYPW5tItlHvALsT7XFOG37WTopzLSEZjJ2CJt79D57gZgO+R5q9EeeDL5tQL8C+ASqr1pg98I4mkrLhHSQ2Fm6l5fRALQGC/N1nE7I8nMATOkyhre4WAEHeAa7hJ9Czgl4rVxqTdz6UUb46i72UnbB6A7OQ+F8V55CTSOedJggT0WrP+hYipscjYmJuX9wLPjcFYApkwEYhFuQbs8Jblkeo6xlfS2goLKI1I5aT6lemPtaah96ht3vmY6LHVFXNxusU1zMwulUfqOOcBi3HpmFRZOFoWQ2h/mOpqH6weIX8IA/5XCkp/uksELR6kYmXIH/j6tUCFJCgQYxNLdZJHphNdmZQuly6KzV6YQfOsUbdoonRZpvzXuKag1qb3MzP1M5kInu9+wte0QiAd2+639UD8tdATym7rAKI/RgT6glNHEV7F7s9t0nQ41jbIET0U6anXFK7DTzFfns1eJxcKGbhhOUCNKVtkDee63mawrYiCOo8yyfm+tBuMG76ZkuDqjwRm3YSU8gSqUNZ/NGprOptHvN3EFftEFwfQFOL7ELH/Hd6K3Up/sxsrv5kymAvUW+v8XUunfs3Z4GteQ27teVnE+00oog WBsuns5F 2af8Au55StExiqtraWrBnou6UHnrBpZ/2gOwfAmC0DcVHlNy76htT+073ryx/7RF4KNM6VhLaVbqHGBfS4sdHMRPw5d6U84/7GMv20CBmJ1/60tHl0thiVQL4RHf+31kwoA9dm5PRX/1mJQzUpjpb0sYol0e06cea8rO7x2/2lkZ4SofuMNKb9Ricyn2YOqmnwu+yRiZb+pbbRBTKTnPS/MAWUC/1tzBv7AdasoOcWZtxXDfqy1fyjP8d/B52v+6DzCTk0l/yLsuMM0l25KfIKNfTeKwqFa5ttt2hTVbiCnJEEvTANKFtEhkM6gpytEtRcbOF0czOj3uSbU5vAcLJ5H86TVBWyAAEeMDZPcITugPbnwhBQYMWrUI8fqtTjKHiByRsd+hNH5C1Itgpf1qmnXwlAdffg+cg/+mK4LrC2nIYAeuwYBKiahQg9fSPoghTBzGnUtvazcszRorVf07NK/FbQz0j7nWIA/znFuZPdbrKWx/UtgciR7QNzRQvQy4snEO9pYmXWYm6rZS6eR10JL/0BOYELQtGvubbwRd2wOLrUgX3V5PbBtkeUTF5EN+5SeFs7E6U6QVLRfZGBsRP2bm2FO8yfaC9RZvjvF1EzXu+geovI4fGTOh+/PkAFKkHKlm/NRv3A1frtgeXQd4qcpR10ACO1IE74cSAZ+1/cXGj4TyU/Oo8Qqiqyw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/30/23 02:05, Johannes Thumshirn wrote: > The btrfs repair bio submission code uses bio_add_page() to add a page to > a newly created bio. bio_add_page() can fail, but the return value is > never checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Damien Le Moal -- Damien Le Moal Western Digital Research