From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BB4EC021B8 for ; Tue, 4 Mar 2025 05:58:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D96D66B0082; Tue, 4 Mar 2025 00:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1FE16B0083; Tue, 4 Mar 2025 00:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBFB16B0085; Tue, 4 Mar 2025 00:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E2696B0082 for ; Tue, 4 Mar 2025 00:58:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4660BC15DB for ; Tue, 4 Mar 2025 05:58:48 +0000 (UTC) X-FDA: 83182814736.09.E159EA6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 806B7100002 for ; Tue, 4 Mar 2025 05:58:46 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741067926; a=rsa-sha256; cv=none; b=WwOIsz2nbjjbwJRCaPC+sEhtKLiHrZI6QY2dFa6VcEwRAB1E2ab27yO0/SKdH99HMGWNXG RVHBxUNn4BQ1b3nNNmZ7FaHfIS5kEkL+xRhH8Mo1a2/5mpCwaChsHuWl3HlAg+uDPt+ljg Ax04vTEtvCImlqSra4gXHr2vM6buIIA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741067926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SPap4qmtrc8YmrQ/1L/vvhHzzGihWFUqPg5on7afWYo=; b=rlJR/qufsgwXR5zYxyfUSBD8nxWawJVL3+LkcZrlSzhbmPIBZAoIhVxuF1bmFoT7DpSYcO MJ6M01rCr/pMEle50AkdXlgRTQxuutJvI9C7vjcl5nTNE0Bh+4hHxqzfY4r25BTuTA2NgW LKbvatg1ZG3/qSrRo4jIIUsmciisbU0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B70B1063; Mon, 3 Mar 2025 21:58:59 -0800 (PST) Received: from [10.162.42.65] (K4MQJ0H1H2.blr.arm.com [10.162.42.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 986CA3F5A1; Mon, 3 Mar 2025 21:58:43 -0800 (PST) Message-ID: <921fb496-ae14-4b6d-86a5-a18c492872f9@arm.com> Date: Tue, 4 Mar 2025 11:28:40 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Optimize __vmalloc_node_range_noprof function. To: Uladzislau Rezki , Liu Ye Cc: akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250303094410.437985-1-liuye@kylinos.cn> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 806B7100002 X-Stat-Signature: y4hztdpe1xqbf13bstiqzn78ik8x99un X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741067926-844866 X-HE-Meta: U2FsdGVkX1+DumpJm4zvEAADi1OCs2RWfZmhnaSDsysV/upAHZ5JrrxTmDFE4W9oH+32AiqFS6z5cIVi56zsavliusGTgIsXQ1DOTQHbxU1lrtenc0Td1NGNOk+hiOArh1Q171U15WRI/YwVhvL6hbxJHBO5vND5l5LXaypW5YDnYmGmmsFZDnf8voFr2AF8fmAUad3QCvEKaNh+PV/4b94Mxst/H0EVCO6pVSJ2deqeKcz0xBb3yBXPBHZavXZ0E2gk2wvT6hk3vrY2s3jki1ddKdPwfbnmvCOHhj2A/ZXy53/PUM2qFGkRS7PRzMi2AI1aVD2SK4vfw+ixJgu3zGSTNQliLXRp6WmsooXTmaEpkuWDCPMMe7rjWp9mMHzD1NNrZp1YE8KjX8sddn1H63NP1N3AduEgu8pAKoI4DYszrx58Mzj4aovqXP8kqVCaR8q1S1vLPGISahdR749Owo54oIDy9C0V3yqLV5DMSySZsyJbZvM1mXd3b6hfzVbrgc9QlcPga7C7eEWhtp5q0JfVdIe4IfzxnNViYbeuz9ArInOZaJiEeCoUOA2dLChe9l8/eMV9mwQGBA3zpZHt6qtMOaNRPK5JL6gDv2rGxhIyeN6GHUqcWNEN7CvYBNWHqjcN+zM0ntRgzwUnqDuatcEu2EVYM5TxZ7qORWDXdIHqvrJftMAQh2jh6vewhHrdJkbgji0PTX8Abe0gMVEt/pGkitswqsdds6O1WOQjT+CQfhx7J/JH7u6GtOA7SzRx0STnxe7iCuzTaA8Eu4vIE80Lw68TKTOaXp5DcW3dRNEhBUXT36jJQqKdhx4q81cebbpFiW2sOo9AqVNhpMIlZ0sdJi9w34yRoJLFNjlIy7YdmV74h++PhQoyR0FCTgnOVajvdk33VUmFq/nFlhpkoHkTmtStS4O3CAug3GN6NnNo2pP1IMsWywdGPjl6BpXrIhW/Z4+rCEuFoi9wGOr pB7S6kMY MQSksEAzjk8MAoPQYHugc88GdkyeM3yyFugB3YdLuA3RHtVdJvYI3f4hKtI3ycL2vFPTrGZIIUSFaO5RReBdtkUpiyi70v2pRXlIh0EpHyxole/PlHkbJIadxy4hrNUc8Qf/j1nt3Co1OsP5I+0Or7In8svaMVAb9t4Y0YfFzIfrKp88pP7eVGq+Hm5XworlSEDLa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03/03/25 9:39 pm, Uladzislau Rezki wrote: > On Mon, Mar 03, 2025 at 05:44:06PM +0800, Liu Ye wrote: >> The use of variables real_size and real_align in function >> __vmalloc_node_range_noprof is unreadable. Optimize it in four patches. >> >> Liu Ye (4): >> mm/vmalloc: Remove unnecessary size ALIGN in >> __vmalloc_node_range_noprof >> mm/vmalloc: Size should be used instead of real_size in >> __vmalloc_node_range_noprof >> mm/vmalloc: Remove the real_size variable to simplify the code in >> __vmalloc_node_range_noprof >> mm/vmalloc: Rename the variable real_align to original_align to >> prevent misunderstanding >> >> mm/vmalloc.c | 20 ++++++++------------ >> 1 file changed, 8 insertions(+), 12 deletions(-) >> >> -- > Let me double check it. Quick question, this series does not > introduce any functional change? Yeah, the cover letter subject is misleading. IMHO it should be more like "Refactor" instead of "Optimize". > > -- > Uladzislau Rezki >