linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dev Jain <dev.jain@arm.com>
To: Uladzislau Rezki <urezki@gmail.com>, Liu Ye <liuye@kylinos.cn>
Cc: akpm@linux-foundation.org, hch@infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] Optimize __vmalloc_node_range_noprof function.
Date: Tue, 4 Mar 2025 11:28:40 +0530	[thread overview]
Message-ID: <921fb496-ae14-4b6d-86a5-a18c492872f9@arm.com> (raw)
In-Reply-To: <Z8XUP10G3cTJlbuw@pc636>



On 03/03/25 9:39 pm, Uladzislau Rezki wrote:
> On Mon, Mar 03, 2025 at 05:44:06PM +0800, Liu Ye wrote:
>> The use of variables real_size and real_align in function
>> __vmalloc_node_range_noprof is unreadable. Optimize it in four patches.
>>
>> Liu Ye (4):
>>    mm/vmalloc: Remove unnecessary size ALIGN in
>>      __vmalloc_node_range_noprof
>>    mm/vmalloc: Size should be used instead of real_size in
>>      __vmalloc_node_range_noprof
>>    mm/vmalloc: Remove the real_size variable to simplify the code in
>>      __vmalloc_node_range_noprof
>>    mm/vmalloc: Rename the variable real_align to original_align to
>>      prevent misunderstanding
>>
>>   mm/vmalloc.c | 20 ++++++++------------
>>   1 file changed, 8 insertions(+), 12 deletions(-)
>>
>> -- 
> Let me double check it. Quick question, this series does not
> introduce any functional change?

Yeah, the cover letter subject is misleading. IMHO it should be more 
like "Refactor" instead of "Optimize".
> 
> --
> Uladzislau Rezki
> 



  reply	other threads:[~2025-03-04  5:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03  9:44 Liu Ye
2025-03-03  9:44 ` [PATCH 1/4] mm/vmalloc: Remove unnecessary size ALIGN in __vmalloc_node_range_noprof Liu Ye
2025-03-03 18:30   ` Uladzislau Rezki
2025-03-05  1:46     ` liuye
2025-03-05 10:02       ` Baoquan He
2025-03-05 10:06         ` Uladzislau Rezki
2025-03-06  1:32           ` liuye
2025-03-03  9:44 ` [PATCH 2/4] mm/vmalloc: Size should be used instead of real_size " Liu Ye
2025-03-03  9:44 ` [PATCH 3/4] mm/vmalloc: Remove the real_size variable to simplify the code " Liu Ye
2025-03-03  9:44 ` [PATCH 4/4] mm/vmalloc: Rename the variable real_align to original_align to prevent misunderstanding Liu Ye
2025-03-03 16:09 ` [PATCH 0/4] Optimize __vmalloc_node_range_noprof function Uladzislau Rezki
2025-03-04  5:58   ` Dev Jain [this message]
2025-03-05  1:33     ` liuye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=921fb496-ae14-4b6d-86a5-a18c492872f9@arm.com \
    --to=dev.jain@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuye@kylinos.cn \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox