From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48063C7115B for ; Mon, 23 Jun 2025 13:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D75516B00B2; Mon, 23 Jun 2025 09:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D261F6B00B6; Mon, 23 Jun 2025 09:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BED746B00B7; Mon, 23 Jun 2025 09:53:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id AC1906B00B2 for ; Mon, 23 Jun 2025 09:53:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2F06C8056D for ; Mon, 23 Jun 2025 13:53:38 +0000 (UTC) X-FDA: 83586808116.11.6045684 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf02.hostedemail.com (Postfix) with ESMTP id 3CAA28000A for ; Mon, 23 Jun 2025 13:53:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=w+k3rtvJ; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.169 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750686816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3K6FPu8xv2O6mOsMnZyCHRYplU2tK2S/oPBdlJF7GUw=; b=OF3eghZWHZlyzFS28dBnYNLEHlbTbDOMnnk1YZyDJpIJPlt+RQ5XCCb2sbrZjnXVwZVoXX y7RggohOfedGba8EiXAT+5aBe1Ne2aq3Dy0xtCP3YAy/YFUUnhs2bKhIUXDR7bP/6qtTN1 Tz2cpXNXeI7xHA/EPK22Cirnkx8xtM8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=w+k3rtvJ; spf=pass (imf02.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.167.169 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750686816; a=rsa-sha256; cv=none; b=3+M1cLSwK8zDxzJpe/kwoIwpEFuPkGQElKs+tV5gBOb4i39VPjMCzZPr4AdhB03BEut2fv Rrc8a9dYv5rrl8XIrqvQd2IB1FfnoxBfvPgigQ3JmdJzFxNDjc8UpMQqPmW10oari9VX8R FQqAJ864yXF8rBXpII3iUspXLcvRq40= Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-4067b7d7e52so848299b6e.2 for ; Mon, 23 Jun 2025 06:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750686815; x=1751291615; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3K6FPu8xv2O6mOsMnZyCHRYplU2tK2S/oPBdlJF7GUw=; b=w+k3rtvJbJMG8teoM6mCuWioso5O86vKQQoIdnTlZTPG6IwjemhyhsKQz1HHFfnJVX F3ywQlFEv+C/7QYxxyWhEwXcN1YsQ4mF/Vcj9wFYyti7Q36+eEJZ2p6ML/Khwnzzn+7T dSX7DhDGMgNQ/r7gR2ngtLB5a+cmALIWtCZPqwfw8t6dyUMU8SQncpSE1Cd2Pb5VJof1 7AGGV1TNdmLYAr7CslyP27adUYVaV1SdPLWecHama2B22jok4XCDIJr7XihtlAA8cGJm LFvybZMaS6WfKkfOhfZNTZLTXSHPDx8Xg05ABo8YjLGM+dSKbcL0fKnCWV1jV8PKZjMB nzfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750686815; x=1751291615; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3K6FPu8xv2O6mOsMnZyCHRYplU2tK2S/oPBdlJF7GUw=; b=XYtavLPy5u/tHeulPPcFgLKbp5Wx/xqj314z3VNzecVQ138EG0sCgc/L67qLiCvt1I A1CqNVFbWGvJ4FJzfUkhSHNMnTsMpnoM318W7ha1o4Bp77OtA7bfZWUN1WOPjBtyJyLX s38sJTv+aKOHhaZA6Pks2k10MmQ44yFOjCBfC3y7QEFf8XZKYfNocrUKVmlVjfGnH+ZL fdKN8t37SdaUSB0e1g3QwdWJe8pB1Rmm3fvTeU+AoIfnBY2t254DTN67hsb2o0+9W5xb QVo7SZS1AmIpfy4NLMDQEKid2h3AEv/T6BKB8JFCaEgNgS3MssYjJKeLs6lVT/tRx5PY 8E7w== X-Forwarded-Encrypted: i=1; AJvYcCVHoMEG7BnMcySvwECpLVM+9EVSbcNiMrOtvQJ+WC0KIIde7ZBv+ZknJcbdorC/AsyEEj6d/UcpPQ==@kvack.org X-Gm-Message-State: AOJu0YxPYsWcpWED9NFrgxo910w+IKQJYPLC+VNJiDT5lkxFZZF6/bNb gU1DRV/lwxox9hIyDBtcfOQ7vTChGPrcGsZM9xV9lMQIg8BLnvKMvQyl04ePuAkzqoA= X-Gm-Gg: ASbGncvh3OA6dpnTIsRzVL6X+FtGNjuLnjpJxV8osz7CjpDLnje9CEJ5qUAjWP1zw65 zvyu8jcMdr40MkOmLqABHIYjKhYJ6pBq9CTx5o53kbbyCzIK6rdMlZwuJRpn741hcvTDlZXZkVi 1eptKyCETYMG7KM7Q2xSu/5945X+IkI1zR0xsDpFIu8Duc4KiutfKVD+ClzVCxxFZ3GrE3SrikH Z7Bv2IURT1qPILRF5avmmKB8vVtbrXC+4kmT1lvfDenT0+/5MEjAqIZ+gWU1t4nNcaXRw/beNrd u2z9wwx8/o433yRB+J24eXl4FJf0MAMS6pisZAulrgpOIo2GBoOWN6Y8p6eW1kAXKFpPv8czpmy /N3g= X-Google-Smtp-Source: AGHT+IEqXwixIusFGOrWBDfBa1jltNWDM9f6X/YBAXgpQr8rertMKAekyzQDD4eMiV31CNpW761mAg== X-Received: by 2002:a05:6808:14cf:b0:40a:52cf:8870 with SMTP id 5614622812f47-40ac7106496mr10493462b6e.26.1750686814982; Mon, 23 Jun 2025 06:53:34 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:608c:e09c:db47:348]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6115b6c80adsm981061eaf.12.2025.06.23.06.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 06:53:34 -0700 (PDT) Date: Mon, 23 Jun 2025 16:53:33 +0300 From: Dan Carpenter To: Ryan Roberts Cc: Alexander Gordeev , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmalloc: leave lazy MMU mode on PTE mapping error Message-ID: <9214718e-97d0-4e8f-b223-59351e664707@suswa.mountain> References: <20250623075721.2817094-1-agordeev@linux.ibm.com> <107bfdb7-c8f5-45fa-872e-3e6928dc8025@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3CAA28000A X-Stat-Signature: 5oc6ywch8o973por1kyeocmece9gyiyy X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750686816-163359 X-HE-Meta: U2FsdGVkX1/PmUqva17ofIzvyuf8dA16OfXNR++8U24werYSyco2izCS88QAF+TZyt1JDWcIplvJYNienwyUNUee9Rp0liYZRg2D5fpRrejawXpBdEl1R2UYCIRdNQ96ZXUpSOCpMO1d5hwny6Z1rUHQnp5l3d9Em8F6chDGSSquPtu1Luu7+pJC8lD0u+KLcwuoCpD8dArLl1R9UY5nHOt29aeq0TX8StHe17xOlI9oJ0DvNPN9K/nEuejH5kUoEZ5Ip76LjCI5GqNnDx+m2x52NETaEC6wSToRKnk9N9gGy47DDBjm/t2IeF7BxxE90GIasxYkeWgNYZCmDIQKZKvT4tCgWS29BhcQdFzFBhb63G30Blnym7h0pmNHkvaYuQlplact60M2/JyyeAjZc44z9PsxHyophIaJmSPg+DSjKk5VcYGG/vgL7EixtP1z3CAVhsV4Has5nI+r8LSULvnkX/v8/2YRWjCqdUxuuUkqAMwI451stEfMPJ/DoPPyOSALeiyapm+GNXQAt+BtPDpD4qPAcvqs1idIW8134VfkflXfns9mPypL6Qs0kVyXLE5t2rsBrQoPYHjai5iokup8ToafVy4ZMu4LFw5BnZYRjBqO4BhrhHbnZRwkw/6GHBk+HjphssQouXDitNkZqY0VBpHFRgPeZ2ST5H+Xf+E3nFrIMsFwiTb6dQkGvy+Z4GvUt3gZjOMqoSnYabS3HnAg3RCDy2PqRROQYp/L75gYdOD3VyY2ZGRP8iz8ll0/BERa16Grpj+bu6MqGqbbdEGyl+YtEl7lK1gwONRZ5Qs6pAARvpDoX/YucKd1dNwc6rE3cr7d+XHoCMV7BMdV3Ngwk4wkru9d2fLL27DoRupDPDHhPRZIsnBxppzQvMkhWmHKnctE+XYw5tOQ/0JSZNY0SVSJMdEZcX2JIAjazbRQd710rZMcJJk9/pipVJ/uDQQVZsDsMI1ikr2Q3Qe 8Qat1hsx r4yZ9RFP6669Wxlf7WoJRzuFsrqFSsR3nACoIhkKIXKlRxjDWN65I8wsYMtz2kSMk1Fyx9NkniypctKf83YggaWX4ly2Q/qQRSwpdkufkxQcmLA5ZS2TBJSqqKAoOZuqb7t/kik/t6R59no+z46a+fuLs5FoB7ISY0OdrbxDkm+qQi9rFYiy4BjRnQb9BTrxyqy/nggIN/fP35idq25Uj79B0S9rfv8arqOc1R9FwIabUh/uLiIKuKhnD0QUolhTVzQg21BXUm7mdgGSOn8o9FKCt6v2P5r9EF2MwsbMTQrpNbIiKxJpe0XjM2Zjr4rLfi28dZTE6zxkfSFHLy2eP0U633O1CgTp0sDtZZUQWxNjCTPHR02EsWsRpLBbhDSAxVblweiU9slMdtNEbXMXAUeUQo0U2UmYfhF9tH7lW5IVUToaHjvXDzxR76CjI7UpgcEFz0/bgy2yqREk/OLKKn2k73yv5WeacEZBJ4MZxXkjbxaRMxzglIKFj8OB8R7DJ1Vur X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 02:31:48PM +0100, Ryan Roberts wrote: > On 23/06/2025 14:03, Alexander Gordeev wrote: > > On Mon, Jun 23, 2025 at 01:37:11PM +0100, Ryan Roberts wrote: > >> On 23/06/2025 08:57, Alexander Gordeev wrote: > >>> Function vmap_pages_pte_range() enters the lazy MMU mode, > >>> but fails to leave it in case an error is encountered. > >>> > >>> Reported-by: kernel test robot > >>> Reported-by: Dan Carpenter > >>> Closes: https://lore.kernel.org/r/202506132017.T1l1l6ME-lkp@intel.com/ > >>> Fixes: 44562c71e2cf ("mm/vmalloc: Enter lazy mmu mode while manipulating vmalloc ptes") > >>> Signed-off-by: Alexander Gordeev > >> > >> Ouch, sorry about that! The patch looks good to me so: > >> > >> Reviewed-by: Ryan Roberts > >> > >> I wonder an aditional Fixes: should be added for Commit 2ba3e6947aed > >> ("mm/vmalloc: track which page-table levels were modified") though? That's the > >> one that added the "*mask |= PGTBL_PTE_MODIFIED;" which would have also been > >> skipped if an error occured before this patch. > > > > Good catch! I think it certainly needs to be reported with Fixes > > and I even doubt whether your commit should be mentioned at all? > > Well I would certainly argue that my patch is broken as is. So happy to have 2 > Fixes: tags. But I'm not really sure what the rules are here... I would only list the older commit 2ba3e6947aed ("mm/vmalloc: track which page-table levels were modified"). The static checker warning came later, but it's not really the important bit. It's just one bug. We'll have to hand edit the commit if we want to backport it so that's a separate issue. regards, dan carpenter