From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE24C4167B for ; Wed, 13 Dec 2023 11:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E94076B0403; Wed, 13 Dec 2023 06:28:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E44196B0404; Wed, 13 Dec 2023 06:28:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE4A96B0405; Wed, 13 Dec 2023 06:28:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE6146B0403 for ; Wed, 13 Dec 2023 06:28:29 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 914198011B for ; Wed, 13 Dec 2023 11:28:29 +0000 (UTC) X-FDA: 81561571938.07.C94F920 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 441FC1C0025 for ; Wed, 13 Dec 2023 11:28:27 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NNCLHcQf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702466907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fS+7yRINBVGtuo9tGIsA36u1Z2Nb1cHq/G3Q4qr45HI=; b=P90hGZ1tvIDBg3U38nxadeb9dAw/6eM7Hrfk+4Vdte82niFpDfYzoni7YjJL5OY6DYJCJv RW4zn5V+HXJkX/bXKDZMOq/phu5A1Zz6g8xieWr7NySUVgzh/v0LZ5Rrn1iyTixidmSobc xnbjEH6sAYQzcOhKzaGgN4J0DiY5zEA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NNCLHcQf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702466907; a=rsa-sha256; cv=none; b=r/29fmHWC1mGNxIHXvPL3gd60NjvOUoPW2EQ0EpRQYYZTbRSH7MuaIrzVtaWiTec41vWUJ pFkKltE2TcKIfKElFPyqMP6UO+zM7iCQ7yVEVkacL8p3MSLMErSUtmMa2lzJmID0r2GwSt /uC66GKyqXwPrWHIuTbJR5/hbZesn44= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702466906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fS+7yRINBVGtuo9tGIsA36u1Z2Nb1cHq/G3Q4qr45HI=; b=NNCLHcQfcLZgLE7iq3F3EgC2uizxr6eXIt0JQlOa0I1G92WLNA6m1AoLR2GLxoDaeUCy5g KSRyJLTcbGEVDFcTfHPjh8GFoscY3U96o2aVUv+/Nc3yveoZIZIY0ZT/cjnNLMU6OpuGbV zyUmUON/EHhuQU5KHEWQA2InalByxYE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-Irb0DN1WP5K2tBseNbLvgw-1; Wed, 13 Dec 2023 06:28:25 -0500 X-MC-Unique: Irb0DN1WP5K2tBseNbLvgw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40c440f9595so21116205e9.2 for ; Wed, 13 Dec 2023 03:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702466904; x=1703071704; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fS+7yRINBVGtuo9tGIsA36u1Z2Nb1cHq/G3Q4qr45HI=; b=ci6Lno1kG+/w1goOvlLfYC4Zu2CMloa5WvF5E1cfag0FEueODjxo4kahZp3KUhUeQA o0OGzqEb8KF7t/ehNxiTHJrmrYd9DhqvTco4B1/aDcw+J57Oco9a+TGnafH6WSg0gsr3 xviO5Cl/ocr8IaEXG1OiiSfK5oyA/DjnZE72UUTi1JbHpf/btzKmf3R2RPraRSkRG8UT Ncg9zMH10nfR1aB2z+wtr6m3Clj4Wu6YKM1v9SVwDAKrPY7KdFKZ7MgHleFpqowDzPmE hf+Ts5A2tg/Q+Yp1kVMQV+Bt1Oa17VlLu0/jlAwjrfbSUeLY1xjGssGBne/vd1hTeCjy 5HIg== X-Gm-Message-State: AOJu0YwLHK6gRaUy+q3gI8DejwJHfpACXlqlsKUYRQae0tpHOCHvqL31 rPG94oTRNgtgL9afdVqKWfHH32ipVbbN6AIk3vibqd3EkHdvH34DvAlGMHahxWw6iismxBxEDeM rEobfs/dmqBY= X-Received: by 2002:a1c:7916:0:b0:40c:55a7:7735 with SMTP id l22-20020a1c7916000000b0040c55a77735mr1207654wme.118.1702466903836; Wed, 13 Dec 2023 03:28:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1mjGQOBCYuHBgjIh27p8c1t9JTad7fVIo1SEp83N5BR18M/E6y/0ZxBx2D5rTUojUwfHZ7w== X-Received: by 2002:a1c:7916:0:b0:40c:55a7:7735 with SMTP id l22-20020a1c7916000000b0040c55a77735mr1207645wme.118.1702466903440; Wed, 13 Dec 2023 03:28:23 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6e00:7e5:5f4d:f300:5d52? (p200300cbc7096e0007e55f4df3005d52.dip0.t-ipconnect.de. [2003:cb:c709:6e00:7e5:5f4d:f300:5d52]) by smtp.gmail.com with ESMTPSA id az23-20020a05600c601700b0040c0902dc22sm20448131wmb.31.2023.12.13.03.28.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 03:28:23 -0800 (PST) Message-ID: <92046e20-b05e-4710-93f5-4b64d41b86b6@redhat.com> Date: Wed, 13 Dec 2023 12:28:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: ksm: Remove unnecessary try_to_freeze() To: "Rafael J. Wysocki" , Kevin Hao Cc: linux-mm@kvack.org, Andrea Arcangeli , Andrew Morton , Pavel Machek References: <20231213090906.1070985-1-haokexin@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 441FC1C0025 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oqatzahskc736cxh88c9rbmbhsg1s3zt X-HE-Tag: 1702466907-590753 X-HE-Meta: U2FsdGVkX1/+Svjw0fYaUM6LSYAtBm1ZujciCxkPB1H6WAml1T0WdZ8loxuLFhDZaLt29kfleZWxPVFncgCryKBYw8JZ1nlNR6iJ9HqApzy6R90gHTxoGtQKqnAVRvQa/6PUO/r7NJZ29os5V20RGjCyZUzEp2xT+tj7UZWrw2rH0FUvhdE0a0cAWQtgggTTtjc+16u8Eq+seJQrhHMiDfnpz9n4aIIYrtBzWT4oklypNmecwMRF00MBU/61fXA51uC/8xn1vEfJhXK+Xhhbiqwe4WHwRu8qCeNgRyUZkEaVRbgiNCvzatreZZ/RpiLMYGUIYAgsSlifaJMupblKvE65nyzrQDUrrDCP9r9h+jHub5RSvpgJhns4IjYbLisoANF32hx4brVqDVVysi5Qri/8VzZAlhGDdcJxGVhjeGXEQNEXrkgUpUtDpdoSPRkT7LHIc8qVhua2ehPkPoz5+Q4foGRv1RwJZH0/R1N20PwnCw+mcZFk6Tbit/0qi6KfdF5gjPXuaj07LmC1GJ7f4uFrEa9m7mFl0CuWG8pKM+vjp2vOHJ5rKVyPccVnHd6aYeTtP9urCs0H7Rl4tZxC5m8PUiYzEfR5AInj6x/zhV7L7NlEwy6k0f9+YHXAvz/5V90u1xVH03nqXag/mqOHYzJZoKVW7QpBpWwOMAkCcUe3BZFIOuF7HIWN0Igq+aD2JqUS1M6EKGLlyT4YK4tklkHuGEuyxke7nvqgBZ4mNwLt8XvZK//gDxyw35qEVvmGCy+6eTWi536Py+ApdTfiQzGSiJUF3tnWoUSTHaREgM+aWxtyoIcSb0wwAPEJP9spBt+/J/yX4H+8n0bUEAUfZHiNasDcTydMYlmInQto5ZI6jI223yLqie3CWY3kXdjzVSCctYWrogVfEFPmljaPM7wHtp2t/5WTvnG5qCwUPn5XAoEOW4Er0/oDSO1M4FBZ95YF3XFGNvIJimPdiZr ms1Md9hu Rb3FROu1/4w34t8djrTN5w6p6KFohaIeaXxy/Q1PS/aHH9KjKNQr3YsyWqmGFPU7DJrGuHjwbeJP0gwLTU6j+jaqqju1aI9aMeYWomAK5y7fvb1Ak6MSk/9ZNptt+ZphrV2mlFhw4rWlxS0IwSEd723NSh85lZ6nko2+WkCH91L0yTNuxF1IGT4rsDqaao41rqQxEEwAUpCNKJ2XDjh1JsTIxSv5UPO8EzdDR0VVk6GnUtYsz+UjSN4KjnQpiHGb/JZILBLi0O/tPEnCMiNUfaaM7kWthcOwbD2VpIObQK9xsSUACZdRL6VOm1tXIwO23Kzn0gNLBu7ihuQLsFqTsmqvrpY9KY5ePWSESbuS9YkUipdfOUXvYZqQAqp9+ks7bk2prn2clPPJRGovp/pw4SgsPUhMZdwY1g2+OHr6UhwmWtgwSY+ArU6ldRKJiGedzyDRBpyzeWbWEn8IA0SInjsLynxGhx/bCI+cbe2hnRgTQsOo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.12.23 12:17, Rafael J. Wysocki wrote: > On Wed, Dec 13, 2023 at 10:09 AM Kevin Hao wrote: >> >> A freezable kernel thread can enter frozen state during freezing by >> either calling try_to_freeze() or using wait_event_freezable() and its >> variants. However, there is no need to use both methods simultaneously. > > The changelog doesn't match the patch IMV. > Staring at the code, I think it makes sense once one spots the existing "wait_event_freezable()" on the else path. -- Cheers, David / dhildenb