From: David Hildenbrand <david@redhat.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Kevin Hao <haokexin@gmail.com>
Cc: linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH] mm: ksm: Remove unnecessary try_to_freeze()
Date: Wed, 13 Dec 2023 12:28:21 +0100 [thread overview]
Message-ID: <92046e20-b05e-4710-93f5-4b64d41b86b6@redhat.com> (raw)
In-Reply-To: <CAJZ5v0h8awAJZAkvoUb9d9sck-E8cOF6QK+tjfzzNMn6Bh1JEw@mail.gmail.com>
On 13.12.23 12:17, Rafael J. Wysocki wrote:
> On Wed, Dec 13, 2023 at 10:09 AM Kevin Hao <haokexin@gmail.com> wrote:
>>
>> A freezable kernel thread can enter frozen state during freezing by
>> either calling try_to_freeze() or using wait_event_freezable() and its
>> variants. However, there is no need to use both methods simultaneously.
>
> The changelog doesn't match the patch IMV.
>
Staring at the code, I think it makes sense once one spots the existing
"wait_event_freezable()" on the else path.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-12-13 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 9:09 Kevin Hao
2023-12-13 11:17 ` Rafael J. Wysocki
2023-12-13 11:28 ` David Hildenbrand [this message]
2023-12-13 11:35 ` Kevin Hao
2023-12-13 11:37 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92046e20-b05e-4710-93f5-4b64d41b86b6@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=haokexin@gmail.com \
--cc=linux-mm@kvack.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox