From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74239C6FD1F for ; Tue, 2 Apr 2024 06:21:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 014866B0088; Tue, 2 Apr 2024 02:21:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0156B0089; Tue, 2 Apr 2024 02:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF50C6B008A; Tue, 2 Apr 2024 02:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BF9D96B0089 for ; Tue, 2 Apr 2024 02:21:30 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45EA11209DE for ; Tue, 2 Apr 2024 06:21:30 +0000 (UTC) X-FDA: 81963595140.30.143762F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf17.hostedemail.com (Postfix) with ESMTP id 0E20C40009; Tue, 2 Apr 2024 06:21:25 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712038888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/458t/ScS3yVdcAhHKiWnR70phdFTKJwgiY2J1oAZy4=; b=znosnPFM3W6cu3UMkeu+F5cPCn4u0GhlNyyDm42OUPFdnO2bI/vvkbeU8aQMHniSOYNCCx +H4qC4A/RNisPcCtBUsWFInaw3rr8ibVqdbegOgYtIxwRQ5dNvRbii6vh05Q6e/MOu/QRu pG+QewAkoSWRN9LMAx+VfnCmYNj7gEE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712038888; a=rsa-sha256; cv=none; b=5iZlkbzrBxDYM7oXYjy6KDYLDMM6Mu3QWsde++VvW9Bc8U7gZKs9CHjgDCdn3aAdMQwSlt Qr6+s/rM9PpnL0PygCq49M2M/bqCzZPhMmWFJmcc3iWPE+jK4OQ6UUCczWyNElokmYfcZw OiaX//+tdMX22vozCoO+8d0UTLhUSAQ= Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4V7yPj0g2GztRLl; Tue, 2 Apr 2024 14:18:49 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id DFC7D140158; Tue, 2 Apr 2024 14:21:21 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 2 Apr 2024 14:21:21 +0800 Message-ID: <9200de40-aee5-4aee-9b78-4b93e3442d5f@huawei.com> Date: Tue, 2 Apr 2024 14:21:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] mm: migrate_device: use more folio in __migrate_device_pages() Content-Language: en-US To: Vishal Moola CC: Andrew Morton , , Tony Luck , Naoya Horiguchi , Miaohe Lin , Matthew Wilcox , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , , Zi Yan , Jiaqi Yan , Hugh Dickins References: <20240321032747.87694-1-wangkefeng.wang@huawei.com> <20240321032747.87694-3-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Stat-Signature: sbwwwzbo9aj3chhehash4gernqqgynps X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0E20C40009 X-HE-Tag: 1712038885-39368 X-HE-Meta: U2FsdGVkX18jp+UCZGN4vgeddlp9qhJm1Suz8fUXTuc/d3+CHM3B6VmXvx+047xX741BygxRRkJ4hNq45jdDBLSx0pymCIpU6AbbsneqfHcZM4ljvWXgGC2U8Xfoh+lv5hODRXbrX+Fa7s4VJmlFi5M8p2VubeQ++mFYXHhxwUGxXpLmss54nsvyOBzVUCkFDEf6XhMWdv00riVop/AE92q04boXo8jEdUdAwL4UL+YQAB5/lU8b5qshqAVTUQWYcrS64mgNPYHe1I9JLkKn6j5xI4fr0aoq5XsWfkGOjlKk7qo4W94XJYEBgAYSdqGUAJ5XsMsBVaYvgZ/3vV3zLbWWqVLWrRfoiYb6wbqg6jqg4r2/SKI5CdM6TTMdeBfUynHqpmlvA/GM40+h0Z/M6vLNqT6VIfaZgBswlxzRo5uPqFiCv6GFNUkIg8MiJsfhFuUjqohSpwS/5zIiHEvUzM9p5gnLhdzP9MuUXuceN+4q48BNEjwEm13TkS4chNPpLgBlzOyob5DOtZsrc3sr2Ds6FNjLs57UxVp4QUtHCeowMqR3T8pYSQDKYXe6ZdgHNdLScB0vqgijfyFj0SGpGxCdvCrGij9JMkk6gljlvuxK6V8+XflN9SpgM8ZnPlrpAomyQr+Q7XwaaVbMiA8WXob9n+wGkqapzW0oodtCAoqpw/XmoxQi9CiWrkyXjmVPdMPb+hVDeJ/rhkx57HE01DxP9wugQnlGxpY/VquiFjfMTfGLnT4s4TuaTHb+vtXrCzLrduRedLdVWvCGZnE3KdXNBi2NAqwuyvtUC9ysdrlHb862Fwrc+5vrM8+QMwpX0seeYLHbkJDxLs4xlrCiknJod7mqiwJ2EVaAsRgnXWdwP9iVxt4bsdLwh00a/bS7xYV+DJwp1AeCUvB3RKVG+a25KzYqzIr6iPj2b70rntyYBY19d6IkatZBqys+DgmGhcmd+iHR8R1Hi0XLUwt UmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/2 2:22, Vishal Moola wrote: > On Thu, Mar 21, 2024 at 11:27:38AM +0800, Kefeng Wang wrote: >> >> if (!newpage) { >> @@ -728,14 +729,13 @@ static void __migrate_device_pages(unsigned long *src_pfns, >> continue; >> } >> >> - mapping = page_mapping(page); >> + newfolio = page_folio(newpage); > > You could save another compound_head() call by passing the folio through > to migrate_vma_insert_page() and make it migrate_vma_insert_folio(), > since its already converted to use folios. Sure, but let's do it later, we could convert more functions in migrate_device.c to use folios, thanks for your review, do you mind to help to review other patches, hope that the poison recover from migrate folio was merged firstly. > >> + folio = page_folio(page); >> + mapping = folio_mapping(folio); >> >