From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27742C77B73 for ; Mon, 17 Apr 2023 01:51:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BBD78E0002; Sun, 16 Apr 2023 21:51:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 444D48E0001; Sun, 16 Apr 2023 21:51:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E51D8E0002; Sun, 16 Apr 2023 21:51:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1B2AD8E0001 for ; Sun, 16 Apr 2023 21:51:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D3A9616033A for ; Mon, 17 Apr 2023 01:51:21 +0000 (UTC) X-FDA: 80689205562.02.2C09F9B Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf14.hostedemail.com (Postfix) with ESMTP id E2D2D100009 for ; Mon, 17 Apr 2023 01:51:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681696279; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tMfhjbm0QSGvAoE8Kr1KSvVjipBipThCrsxCLjJomfo=; b=4SZTaLFX9aFvm8CNWlXXChlEEyctfeamsBI+3PotGDLKaTVUqYb7xZQBHZCP7OSZ5BT4Pn URG5yxq1/MrBHFSzuQqcycxiZtbAVo8Y0O0jIQcvsAygYvawXbWetHMe/OsLOyA3xXf/cS TgvJqtP2G5Rqf/ncwVvtojoLgaYX03E= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681696279; a=rsa-sha256; cv=none; b=zKphoQQfyogThSfPv7ytkEixW8L3DTNe+6Yhx/zVwpzJc4saMw55+gFW5X6F0nMJQfa3N0 gOiNoewWgSk9iCdAXniY5i/3ionJyZCKrwZ/NkFetBw2yv1gp5qwRVCUcbZzcEdY+aZ4Ib slRSLnHHuT9Xa7/Bgax+tPzt+AT/UNw= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Q091m3GzbzL03l; Mon, 17 Apr 2023 09:48:28 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 17 Apr 2023 09:51:01 +0800 Message-ID: <91eded3b-0ad8-b092-bf17-7b34fd4ece65@huawei.com> Date: Mon, 17 Apr 2023 09:51:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] mm: rename reclaim_pages() to reclaim_folios() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , SeongJae Park , Hugh Dickins , References: <20230415092716.61970-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: E2D2D100009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: fuhr1wtmys9przaceqx7qceiycm4dya7 X-HE-Tag: 1681696277-593474 X-HE-Meta: U2FsdGVkX18XzshEfzaA8Q2HesC35EHHXwdM/SO7Q8FgmRh7zq/wqNZ8SRI/cAamiJtP0Xyjxa/uJwajECh7lOMZOLtiDKlzUCK6b/XSTjyPPWMS+Z9XElFhsLzMbUGsnj7mF765Q7d85695NGDPQ4QO5p+DrChhriIp227lZVWmONXaoGJSpNad1Ciy14qyD3hAHubSjS/WdcZJC/rbCv97YENR4z0HE4eF0x5zuWDpbgVB76yF7Potj9VvWw4eRDkmmaEDaWDP08GSSL3wI5gUBzHasK42cOEUewA9ZqpIVYvbSrbwPAC0Vmg57fE5DD0mfyDD7r3g9TqEP7WZVMJxbgakYcDibgka+w33JUhDufSHLLIEPfn57RGBvJ814hi1UCxwSfScabKRMqJWxjVG/VBkyFpjjmQpnZnpDSL/qVgAzAXpm8PVwNVQgguj3oYzEZ+sbKHiVXmO2UHzkGsQIHBXF+vd5cBwMrAvo3O411h1ufg5gj8Eo+nX8p1aM8IvUomUtT5kIDrpyYV3/otv2IcHnryEdqgwR/kjPnViosMeiDoibjvIctL7Mo413pbViGaUqHd2byjCfTvDNuS8XCyxjrdqBtBnIlGbzdYFtEsC6gndwQVwqzvvUq2ZHP3cDydaS3QonR0nK6d5EnKH60TB+EayRtl0momwtvi7l/OPw8d4FEgIL+Dv92xkNXXZIZlRXe99z/f+yAYT3kHl5HuKw12m33jq2N0i8FfR3CwM1EXQMAeuPV+EskdmWMU14YSGhyP67XADTTfdgp0gGShPMh5m1YQIomxb2GzvRzfOTbbXaeF0xRqAw3VBhp96ijDB90MqovYqufJ9NJjWVxP+kFacrbd+5KqRWD7jMDkf7RUNcqijhfFPvdGL1PIb1WT4JABYMlK78R5XdWsGYgEIjdHChNPjg4N1Pzat+NYy4HSbrt4+lg1NRVseReTpWgaJIDqg9iLP0S/ 77VKSaZd MfQ2bUO+MxCl/Q3ME/mVw4zSrqD4zKEShOEpYi2VcMORkDOY3jFtmscjVrIkGBh1wjOzjKcJkTXMC33+SQzcASutP596pgsY/ggvVPQCg4cxHfP808SRW/3ka+8UTuQFZ2CiVwwZR4IiEiwV8DyTa743mj8f33Y6gl4LRMaLO77b2e+rAZUtcYMItzc4XBtTbhCVe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/16 0:04, Matthew Wilcox wrote: > On Sat, Apr 15, 2023 at 05:27:16PM +0800, Kefeng Wang wrote: >> As commit a83f0551f496 ("mm/vmscan: convert reclaim_pages() to use >> a folio") changes the arg from page_list to folio_list, but not >> the defination, let's correct it and rename it to reclaim_folios too. > > I didn't bother. It's not inaccurate; we're reclaiming the pages > in the folios. OK, keep the name seems better, there is another similar issue in reclaim_clean_pages_from_list(), I will only unify the arg between definition and declaration.>