From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28EBDD3C533 for ; Thu, 17 Oct 2024 22:03:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B9FD6B007B; Thu, 17 Oct 2024 18:03:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 869A56B0082; Thu, 17 Oct 2024 18:03:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 709D66B0083; Thu, 17 Oct 2024 18:03:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D6786B007B for ; Thu, 17 Oct 2024 18:03:15 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 41EB1ACC32 for ; Thu, 17 Oct 2024 22:02:52 +0000 (UTC) X-FDA: 82684470540.18.BA9BC9E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 4AE7C18000D for ; Thu, 17 Oct 2024 22:03:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BtA8DQ2z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729202485; a=rsa-sha256; cv=none; b=FeEnaeWJ3aODa3xB4/5vmKRceoFgrqZncH//o2wFyHBMSdFFqXhyI9wZEzEmAtBTzHf4yN SmtauLxhKx7g2c+YqPjN3N/uH2tr/S2hbQOvjXnqw8iydOhMFOWhu0UKepUhyqrzkShu9A kiaIc8x4TarXIIYwUoq9hFcv5kLrDTQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BtA8DQ2z; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729202485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q32jQVNfQWmZ8cx9WKFEUdpOkI/CR11n+jzfccgmn8s=; b=1TXF8PYtTRfUAZGiSSItwbezeXVCTk9QSvpZVxz+00gCO5tSCk5ZpKtIAwn1KrC6lb00a5 ie3FqPoP6TmSimPwwzg8BQXyMiWsSDm21pjUOxNJcW96x2dUqTA32YNLEJRrGPgKIHFuaP 2VrYbdLGQFyRNB7sU3zyL0yNdQbNfLI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729202591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=q32jQVNfQWmZ8cx9WKFEUdpOkI/CR11n+jzfccgmn8s=; b=BtA8DQ2zUHkzwoS3PAJcMkjOjOH3aNiKfslzt4cMiZIIE5mpI/545a+fVn63LLVOxM79oH 86nR+HkbPYv8YH/uURw40rf9QuoLGxCjHZRqUo8ZbssPGiIGiNpQpQTxPjhno0I5X9kvUg S+uOi3MQH6UYuq9qPL7DlvQAdI7PRBo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-IDT63GR6MGisu_4EjncTKQ-1; Thu, 17 Oct 2024 18:03:08 -0400 X-MC-Unique: IDT63GR6MGisu_4EjncTKQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4315d98a75fso6267525e9.2 for ; Thu, 17 Oct 2024 15:03:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729202587; x=1729807387; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q32jQVNfQWmZ8cx9WKFEUdpOkI/CR11n+jzfccgmn8s=; b=YSwGwqIujCKCZxT+6WaaX+YeEmBe3xqrIUDD9ddK0EJmaQlJm2My06S9eLOApNxWJo 9tlaJoLJRo5W1m/s8VSagR7gJMhFOHwnvdLZfqL3L971tRady6opQztOLwvm6oWzDyb8 shVnijl+PDHy2KQ3Yxdb45fRtgjrwXjEixVvapTRtQDZDYfK6AScAk67R1r+hpZHsHw5 fzNdJa/mpHOmzh29CgweoMTYxVSDCHft75AybWEkZF+xBewLD3GabizmI3oOx3aX9igI xdinHkAakaycn5p+c3c5MsfmZrbg9GGDyEf1WshiPMmJkeViArm3LLUaoCwjVqeM4pvE BiZw== X-Forwarded-Encrypted: i=1; AJvYcCWAiruFQZPujOol8YbjLuFpEy+Stcezv49LYglj03RBakTGVaIaaFeONEl9vaFcOUS9+avrjueTqg==@kvack.org X-Gm-Message-State: AOJu0YzVbDAVlu1O+RlR/Zbep2AJ5zfLfE7a93oA08oYN4zjQpsbaGA5 qB5ICYerNQzLA777gWY9qxtdVjV1wAEUge5fs0nbdag29GhE5Rov/JLnv3sA3y4QGoetVDIdTOb rfgylMDSFfPMoiz3RC1G0cNs8vA5mL3bOPItGoA7TgKAHAONg X-Received: by 2002:a05:600c:c84:b0:42c:de34:34be with SMTP id 5b1f17b1804b1-4316161fafdmr1187545e9.3.1729202587483; Thu, 17 Oct 2024 15:03:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHH+W/QUgVbyEWw3+7M5otGW0OnSdtg+qrrtRnMJhvEDhrQraS5KJ681XlH0hst7j5DIuz9rw== X-Received: by 2002:a05:600c:c84:b0:42c:de34:34be with SMTP id 5b1f17b1804b1-4316161fafdmr1187405e9.3.1729202587071; Thu, 17 Oct 2024 15:03:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431606c64a9sm8374305e9.32.2024.10.17.15.03.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 15:03:05 -0700 (PDT) Message-ID: <91dbe5c9-68c3-4e92-a9c3-a3dad77d6dc2@redhat.com> Date: Fri, 18 Oct 2024 00:03:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: stop leaking pinned pages in low memory conditions To: John Hubbard , Alistair Popple Cc: Andrew Morton , LKML , linux-mm@kvack.org, Shigeru Yoshida , Jason Gunthorpe , Minchan Kim , Pasha Tatashin References: <20241016202242.456953-1-jhubbard@nvidia.com> <1f8dcae1-416e-43cf-8dda-5440e0db4c00@redhat.com> <87v7xqmmxt.fsf@nvdebian.thelocal> <52bd4862-d6ce-48f6-9bc2-0f7376a56115@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4AE7C18000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: buqkr76ecxm7aayaudyc364pc3wxqtrj X-HE-Tag: 1729202582-991249 X-HE-Meta: U2FsdGVkX1+r+M/wXOp4UUyo3wga1aYNI1EwjuFJLA5WjpnLDfhnkEv0ErglUloRCMvAQmbua/0H5cq4FtlVTBuMiLVZEW7TkLTd+px9Ynx5d9/g9YBwuC66kcwKib1x6x7oAcGr9Kqb9cjdkH0mDT0Rpjc+DleK2lcMWzlwj93vyvXMgK2pkphFm/8jHLgrf9+HtRuWn3MdmjoCXPz3s1/AzoDuDC28A4DZs3f6KsVNt4YCkd6LB0GFP5W5eISUBEIFgHj1t8PMLqjEu/AyoLTXdTQtsbtnL6t8NXgSbyZ1qI/z8nQ6QCEK5uUGN9ilsIbQxLnuocY3i0/WfHbcY6PHiX5cqrj0PzO/iPUv11Ne4iyFQsTphdUFftZ6aC9o0HXNl4eICEBtmNcf9l+RtsYc67Dc71Yt69Z9yssTz4QSot23iVcrdmVRHrE1XU2XQGkkACiWt2UxqWDfYM9zP4J4iUQaR6IrvprNz5L9f3MIZqI4Wkj7HFnyIKPU7QFyTsds1sfsf6fsVfwYN4bbr87RawnPD3e7hsfhNtO/sEpO71tmcd+mDYyj49sHq7SSyzE/MapfsiXjOMgNVKfwFeyAl3U2kpSAfh+yeOf5XjoeUqm7n3GQ4Ec82dlzXNB0evyFfxpACkHQhhhEYkP+vye3DjDdBMBnuV8fYLJhE9cPCt2cpB0tO/p04223EcgjeXxQ3FjWDNDSKaPJ2YNUlic0ZaIEHdI5ej21lnV30Kq5U+PzNp7or/OUCRL5Pc0K52q2AJUWWhh6UBaMKd8Jpwhs6skc40jVZzvRz+dNIh3qZ89YyvTMQ0Il0wDSW/pGvH5BTQ8xjlb1KIceSSdtSOX8zbCUKevHrEMrY5P7zoMHORhCwKr1ofPRDHWax14cWe1m6mCgiD4iRJpXUmXjXyc1Gl8qId6REIpby88mYSu/FgdaHnf4TeyPERwdzJOQbkpZ61TBYJLxjHx25Fj FdvRkNMl EX8vrLLsIy00Bvavi5ME0x6l5r8Ov9pHBUWXfyC1g7WjHLW+8I0j94ofox4roVzE/fYuFNpwPlGP3oiBaPnuUWgtSwhFSZPtYuiFBU+6RRTLLlf4pAN7QXW9YzYjHlWkILR7l9h7kGQysj8GpRkMXfxWbLEPnSOo0Bt1tlRFItw7g3wfKpPJ15EGVbF+SnE5q85ja74YLrkbh9EwKn8EFII0X3W34BV78cj6FgDz81xrQztmy3wsoSSy8bkclARFAK658DYHIQLZCoOIm1sRfqOE9rOK/FTolVXZDSY5lbKqBwRd4L6EjCAcUQUmRXMqWgx6TEFyN2CT2nIio4p3jQE/XJbJYiK/zYt5Le7zOl2tkTHE6Tt2fHvlwj9cJfplm/8JgObC2YnSoQUCTDex65cTo8IbVBpsEVayByTzdA6hzspoTYAOUo/0bZhBwRrkE0DwQamELsX8lInrcoxzi9/Hl1li9Ncs5tb1B X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.10.24 23:57, John Hubbard wrote: > On 10/17/24 2:47 PM, David Hildenbrand wrote: >> On 17.10.24 23:28, Alistair Popple wrote: >>> David Hildenbrand writes: >>>> On 16.10.24 22:22, John Hubbard wrote: > ... >>>>> +        if (rc != -EAGAIN && rc != 0) >>>>> +            unpin_user_pages(pages, nr_pinned_pages); >>>>> + >>>>>        } while (rc == -EAGAIN); >>>> >>>> Wouldn't it be cleaner to simply have here after the loop (possibly >>>> even after the memalloc_pin_restore()) >>>> >>>> if (rc) >>>>     unpin_user_pages(pages, nr_pinned_pages); >>>> >>>> But maybe I am missing something. >>> >>> I initially thought the same thing but I'm not sure it is >>> correct. Consider what happens when __get_user_pages_locked() fails >>> earlier in the loop. In this case it will have bailed out of the loop >>> with rc <= 0 but we shouldn't call unpin_user_pages(). > > doh. yes. Thanks for catching that, Alistair! I actually considered > it during the first draft, too, but got tunnel vision during the > review, sigh. > >> >> Ah, I see what you mean, I primarily only stared at the diff. >> >> We should likely avoid using nr_pinned_pages as a temporary variable that >> can hold an error value. >> > > OK, I still want to defer all the pretty refactoring ideas into some > future effort, so for now, let's just leave v1 alone except for fixing > the typo in the comment, yes? Fine with me! Acked-by: David Hildenbrand -- Cheers, David / dhildenb