linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Qian Cai <cai@redhat.com>, Huang Ying <ying.huang@intel.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [RFC] autonuma: Migrate on fault among multiple bound nodes
Date: Wed, 16 Sep 2020 17:29:41 +0200	[thread overview]
Message-ID: <91cfda06-0286-cb36-01fb-23cf28facee4@redhat.com> (raw)
In-Reply-To: <2fe2a22235a0474b4a3de939cc22c19affc945fd.camel@redhat.com>

On 16.09.20 15:39, Qian Cai wrote:
> On Wed, 2020-09-16 at 08:59 +0800, Huang Ying wrote:
>>  static int apply_policy_zone(struct mempolicy *policy, enum zone_type zone)
>> @@ -2474,11 +2481,13 @@ int mpol_misplaced(struct page *page, struct
>> vm_area_struct *vma, unsigned long
>>  	int thisnid = cpu_to_node(thiscpu);
>>  	int polnid = NUMA_NO_NODE;
>>  	int ret = -1;
>> +	bool moron;
> 
> Are you really going to use that name those days?
> 
> 

include/uapi/linux/mempolicy.h:#define MPOL_F_MORON     (1 << 4) /*
Migrate On protnone Reference On Node */

Not commenting the decision for that name. It's uapi ... and naming the
variable like the uapi flag seems to be a sane thing to do ... hmmm ...

-- 
Thanks,

David / dhildenb



  reply	other threads:[~2020-09-16 15:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  0:59 Huang Ying
2020-09-16  8:10 ` peterz
2020-09-16  8:46   ` Huang, Ying
2020-09-17  2:18   ` Huang, Ying
2020-09-16 13:39 ` Qian Cai
2020-09-16 15:29   ` David Hildenbrand [this message]
2020-09-16 15:35     ` Qian Cai
2020-09-17  3:11     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91cfda06-0286-cb36-01fb-23cf28facee4@redhat.com \
    --to=david@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@redhat.com \
    --cc=dave.hansen@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox