From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4482AC433F5 for ; Fri, 22 Apr 2022 10:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 530096B0074; Fri, 22 Apr 2022 06:26:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DFDD6B0075; Fri, 22 Apr 2022 06:26:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 381896B0078; Fri, 22 Apr 2022 06:26:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 260236B0074 for ; Fri, 22 Apr 2022 06:26:26 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9486D25419 for ; Fri, 22 Apr 2022 10:26:25 +0000 (UTC) X-FDA: 79384135530.17.F8CD41C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id 5A362C0029 for ; Fri, 22 Apr 2022 10:26:21 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37DEF1477; Fri, 22 Apr 2022 03:26:24 -0700 (PDT) Received: from [10.57.12.164] (unknown [10.57.12.164]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C18F3F766; Fri, 22 Apr 2022 03:26:18 -0700 (PDT) Message-ID: <91c64a80-3892-944d-4178-5b57a4f2899d@arm.com> Date: Fri, 22 Apr 2022 11:26:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] binfmt_flat: Remove shared library support Content-Language: en-US To: Arnd Bergmann , Geert Uytterhoeven Cc: Greg Ungerer , "Eric W. Biederman" , Kees Cook , Niklas Cassel , Damien Le Moal , Alexander Viro , Paul Walmsley , Palmer Dabbelt , Albert Ou , Mike Frysinger , "stable@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-riscv@lists.infradead.org" , Linux-Arch , linux-m68k , Linux ARM , Linux-sh list , Yoshinori Sato , Rich Felker , Sudeep Holla , Jesse Taube , Giulio Benetti , Patrice Chotard , Pierre-Yves MORDRET , Alexandre Torgue References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> <01b063d7-d5c2-8af0-ad90-ed6c069252c5@linux-m68k.org> From: Vladimir Murzin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5A362C0029 X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of vladimir.murzin@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vladimir.murzin@arm.com X-Stat-Signature: z3g6ihyxo7ggru3qeqk5gmtuaw3qtspw X-HE-Tag: 1650623181-867124 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/21/22 8:12 AM, Arnd Bergmann wrote: > On Thu, Apr 21, 2022 at 8:52 AM Geert Uytterhoeven wrote: >> On Thu, Apr 21, 2022 at 1:53 AM Greg Ungerer wrote: >>> On 21/4/22 00:58, Eric W. Biederman wrote: >>>> In a recent discussion[1] it was reported that the binfmt_flat library >>>> support was only ever used on m68k and even on m68k has not been used >>>> in a very long time. >>>> >>>> The structure of binfmt_flat is different from all of the other binfmt >>>> implementations becasue of this shared library support and it made >>>> life and code review more effort when I refactored the code in fs/exec.c. >>>> >>>> Since in practice the code is dead remove the binfmt_flat shared libarary >>>> support and make maintenance of the code easier. >>>> >>>> [1] https://lkml.kernel.org/r/81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org >>>> Signed-off-by: "Eric W. Biederman" >>>> --- >>>> >>>> Can the binfmt_flat folks please verify that the shared library support >>>> really isn't used? >>> >>> I can definitely confirm I don't use it on m68k. And I don't know of >>> anyone that has used it in many years. >>> >>> >>>> Was binfmt_flat being enabled on arm and sh the mistake it looks like? >> >> I think the question was intended to be >> >> Was *binfmt_flat_shared_flat* being enabled on arm and sh the >> mistake it looks like? >> >>>> >>>> arch/arm/configs/lpc18xx_defconfig | 1 - >>>> arch/arm/configs/mps2_defconfig | 1 - >>>> arch/arm/configs/stm32_defconfig | 1 - >>>> arch/arm/configs/vf610m4_defconfig | 1 - > > Adding stm32, mps2 and imxrt maintainers to Cc, they are the most active > armv7-m users and should know if the shared library support is used anywhere. Never seen shared library in use for flat format, so FWIW Acked-by: Vladimir Murzin # ARM > > Arnd