From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C76C83013 for ; Wed, 2 Jul 2025 06:37:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DCEA6B00CC; Wed, 2 Jul 2025 02:37:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58C456B00CE; Wed, 2 Jul 2025 02:37:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 453AA6B00CF; Wed, 2 Jul 2025 02:37:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 32D316B00CC for ; Wed, 2 Jul 2025 02:37:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A07D11D88ED for ; Wed, 2 Jul 2025 06:37:04 +0000 (UTC) X-FDA: 83618367168.16.3003BC2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 2CBF31C000C for ; Wed, 2 Jul 2025 06:37:02 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="D0q+Q1r/"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751438222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e2JLQ4fK2+X3LqYiHCFrb2hZfrmob7uCY/ShdeFWM+0=; b=RExih4YKlAqLZs/wGWwt63dYQ3yr4qEDEtHqMTmWFap0JHuBJmIhVU4rysAe5jUjw0i2yc BKWOwOZIzH1rkWmhinR6SdDktoB4aujtaQB2yzroIMRHoRIp9xylvSznujvjYm31GgpB1D v/HPhoB5eK7I32HM7qn7OSYqp+zoM3Q= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="D0q+Q1r/"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751438222; a=rsa-sha256; cv=none; b=eP/LhLPACzooVn+rSLQ3cATpnfTwIUEZQZgZ1VuNopA41UMdBanA6aDd4I1zGqZTEz9U9t FLXZJBwZMY2F4Hi9rMv+PkWBi/kkCL0F+mhVu53wlYJRYw9aXgCU/vwfb6Ip75ZwktdB1A q0mWTH4EBIyFvlkJwdUI+SZ+gbsqS3s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751438221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e2JLQ4fK2+X3LqYiHCFrb2hZfrmob7uCY/ShdeFWM+0=; b=D0q+Q1r/Forj+4QuhCllOj1ylztjIi4EPH1O2gRh6+X4w5PhaPDOPRiiMlhRvxF/gU3mGC CU+Sj1rjuz9hICLx19p6Pf9AYfVNOsZ6GsJbvRbK9KiFkbwFDBg6TwDisJVfnFEk3yntsU FFe+aam7Ptp3OGhqVuGEF+HF0VYvjyA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-30-56v8asg9OYmqcUTOLY3fIA-1; Wed, 02 Jul 2025 02:37:00 -0400 X-MC-Unique: 56v8asg9OYmqcUTOLY3fIA-1 X-Mimecast-MFC-AGG-ID: 56v8asg9OYmqcUTOLY3fIA_1751438219 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451d7de4ae3so31133315e9.2 for ; Tue, 01 Jul 2025 23:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751438219; x=1752043019; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e2JLQ4fK2+X3LqYiHCFrb2hZfrmob7uCY/ShdeFWM+0=; b=X6EjWcgQtBljqWrEIvI4u2XK2X+fO4Z52iOSfjrNccMH3fcztRuRNzOv+++ARC322z updOWEDrHPxbItXWkU4mZU2fE+KimzYMbylQiTIhKANZI/FMltDfU8ZkKF5AWEBXkqXZ uOgwuHx7Z+OoE6ixhL4FVHJMhnC9PI2nAJfgyLqNAXt1WiObkOnLDlr4lX/8GqP8hQbU yYeUp2euQbYoD2HSqoxStW9ZDp1klGSdDk1u32Tyc5U5NSLz2c8UwPPczBeC9bccdxoA xF9N2hLUEQbTu8yzV0nPN5jECQ7o9ImNva3rQEtgT6gWBwN9XhWN8JfQVXyBOokyrAN7 9dKg== X-Forwarded-Encrypted: i=1; AJvYcCW8cmc1GzJfEXyADqn6zuRDR9lHkIfYyvUSIX1kdqO/BV07TCATLbOEh2OuS4OMGRQziXA3WZF1kw==@kvack.org X-Gm-Message-State: AOJu0Ywr3EKfFe/3Nl2WOBKiYgGFw2S3Jn9a14J/AMvaeEDVMJ2Zp+eb F7x2OqyLHModc1P6cmgFdjU+DSGyo4OThyvUlYiIyuBGs/jOaZw7Lwu+INSji+5UxOMC3D9FHRv jDaZA00SU8kachLrVFqZgZ866XDLM2NPBn5nDiEJbuA/rCwRtvYhu X-Gm-Gg: ASbGnctIF9+yP15XnwxU28Ytnjfe4K350L5E4Es85UozRN9QWhPEic/5IodVD3Fux9o 50UQy87r2YYKzbyeURN8P6iqRDNPvsjp9jS+RK3ybpvJYN8Dxzefrv6ICtL6lWdiZmzJ6YGi+dj XTaZ8K0NpK3Kz7VHlyBE7H7nleiipbggmP0t+O4KhKM7MmyyC/YHtBHFQoZavC/lAgivRcRqmcI Hga9fxirgISlbtF0buBH4cpM0xHFgmP+Y/TrOOH/01JSlK7a+iwojTqfBqAjCySFiriZ5wwiOqQ IpTuALGYVAHYIciwiHPZ6k1a7Lat7biZj3DGFTzhAdBduMCQsCUBpbk= X-Received: by 2002:a05:6000:40de:b0:3a5:1c71:432a with SMTP id ffacd0b85a97d-3b1fe1e880bmr1028574f8f.14.1751438218648; Tue, 01 Jul 2025 23:36:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIfltopO+bLY0cpw22kH051hyHCvi/TFhbZP9pLqV20eG7s3Sf71U/Du4G+qzfsQpyKwTmtQ== X-Received: by 2002:a05:6000:40de:b0:3a5:1c71:432a with SMTP id ffacd0b85a97d-3b1fe1e880bmr1028545f8f.14.1751438218251; Tue, 01 Jul 2025 23:36:58 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e61fa4sm15240977f8f.97.2025.07.01.23.36.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 23:36:57 -0700 (PDT) Message-ID: <91b9bdfc-57b2-45ba-93f3-e91a95fb32a5@redhat.com> Date: Wed, 2 Jul 2025 08:36:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/memory_hotplug: activate node before adding new memory blocks To: Donet Tom , Hannes Reinecke Cc: Oscar Salvador , linux-mm@kvack.org References: <20250701114155.16452-1-hare@kernel.org> <20250701114155.16452-3-hare@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rbeCs4mewmxKxuk5K2pn9VG_W_vI97sqwq74CvqZ4oo_1751438219 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2CBF31C000C X-Stat-Signature: db865d3drgbnpuwkuysp6z7jduquqzos X-Rspam-User: X-HE-Tag: 1751438221-650181 X-HE-Meta: U2FsdGVkX19v4TWix3aBYdvru43VYV6hn0kLsC+ip7xbuvRXrpAQs3FTy7BK+vmJIAOzRxLloBpu0SzfTsHV8B5nzEO2/HyTu+LuN2e1Yh4WNbrwVrrhoYRuqioSj3QmdzBhwYbN7DezOu+u1T1StJfL4L8K7He4HllUSOW1ely4943uzQD5FseaTSe6MkO4p5KunpKKKMa66rUMudYbeTy1agH8p1teywScqGhwkNyVlZr0DI2DjaoD3LHrHqir+I0PLkxpCzKonH+OaLEPA70t5s7AhhGoglZHBalW8USFjuZFwD+kcCM2FbSSEZsWEI6Tm4bYG1VjvAJqaFMQQHysmIiflH3OxcYT0WCqjmhf7FkBOM9pe5sVJC0YlSeROYaWgfEx86hhTrXUq3wwgYMq0/ZDHvJ5s3RV3CZii/3dUtz5nX/j7dh29XTk1NdkeoSyDiNDihBsHa4YOR2fZy8IlOzX1gahfWYafO/u+0t/pX74ktEVHWPFPjIUPIHpY5qgyzTYuUWodkgkFPdMbpgUUwQZ3+HPy3f0LjqH+P37zHjYD4O5uZtD9WnQruetWyj+INqHmquF+RYvwpZ8vJsHwrSmRTi5HExOK+dxpdOKkSzu2dJ1EKpQBGZVvGb0eJSp1DQ6Jmq3LQwCoaZpPqGNUH7QC5yUMTQPSQt0Oi4n/Y3YmD2P2bynwfhNm2/xIdzsBRV9asnqvPMKj7inoVczs14nnkxeyG6KeY/iNALuDACdXHAB5ssreQGUNfHMODIBdVztCji17zLic4ViSPz3cYyfaGXyCgrGtQ4ZLu4K7MuZLCaMnLqHTFWdWRpY+3Mz05O/7w2VhxMflAah8nb1LgsKXb+ERluM/H5/uxeKcE/kPdOJsONJhBWv+SYTHcbrz9tqObAO0QCfoI2dlDC720VthVG/kC6HOGxQRRr3GvWab6XD7hPWAo7SmLZzCUZFGBLuZbooQN8wSQ5 cdPdt24I MheOa9qOPRsgDmxTSgrGu7yUAuDM8/n5NW36FycUHkmenpAdPKkXy9d6SIej0hVaSxW63C2ixhuQGPkGzsSQNUZBY+Zlpm9Q+cpXygoIwt03H2Q4vwbxl4vSMGGIPam4PU1Nh/2F9SnTAT83Om0Up17mtPqNO1lHPYbMXiF5QYiuCw6a2O2aAjto8GIZ+GZUu/Unx6ljOOXU0SwEqKvR/m1Tv0XObTx8IqmzWdAmDkzd0HmPlBBaDuKOqoNWCX+GkT7ne58kN2V5WUccebA3fCaCEQAWouw1wG/tg2r40lSduGD7BEdfcfz9M/vIep+fZAnUcBeSeHHH43CWBXZEAugGpPyRacuJgvW9Oxquu5CtvynvA9wbiL7eWXcekBGE52wecUAEfEOrLxeazqRqTGju8jKwkVaNAvJeX3ZUX8wtkgnI3lz4iJewrve6ibX2GAO3IrzIZbTyq4fqmH9zGiB9i7TgsP1iS6oa+qFq1C1pQRL2v65UErC1UNg0vRXtDVAWi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 08:25, Donet Tom wrote: > Hi Hannes Reinecke > > On 7/1/25 5:11 PM, Hannes Reinecke wrote: >> The sysfs attributes for memory blocks require the node ID to be >> set and initialized, so move the node activation before adding >> new memory blocks. This also has the nice side effect that the >> BUG_ON() can be converted into a WARN_ON() as we now can handle >> registration errors. > > Since this fixes the issue, should we consider adding a Fixes: tag? Yeah (I mentioned this to patch #1 only). And we should probably CC stable. I would assume the issue is fairly old. -- Cheers, David / dhildenb