From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7184CC3600B for ; Wed, 26 Mar 2025 12:46:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8578328007C; Wed, 26 Mar 2025 08:46:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 807C7280069; Wed, 26 Mar 2025 08:46:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6819F28007C; Wed, 26 Mar 2025 08:46:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4B794280069 for ; Wed, 26 Mar 2025 08:46:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 46EC61CCECF for ; Wed, 26 Mar 2025 12:46:38 +0000 (UTC) X-FDA: 83263676076.26.446DD27 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 79296160007 for ; Wed, 26 Mar 2025 12:46:35 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XphyBOtT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742993195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s77PIgFRT3AtQ1+X+1bT16Z9Vl7GBWDfTOwmyThXt4c=; b=U7fYJpymYMJ5nlxJ6efr3bLBSmq+lr7H1wpiB01JhOzEzwOIloAe0t4llBhJgMGHjLZgeF Al5erXBOY0eSSCljHGtjDpfWEx9oUDtO151VhRfJfXKcXxS5N/YI3e+2PxaEk2rFXQfJtU fQLBJaEmAVgD3S5w/mDQHZ/BZDJgbqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742993195; a=rsa-sha256; cv=none; b=Wl+uad4VQH7E6GM/spGX+mDTrnQR7MMDOl82U/BJoZx07tEQHQTTlIjVk0LQOVKsphwpMM Gb99VNK+lQa/a1AoD9J4bngHqL5e2MX7dEoCL2tn4gWDM5qJkSphHRXXfsqiXN5L8Ip+XT 1DUxWfnW7c/FpB6ivzgOncBh3Fle730= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XphyBOtT; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742993194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=s77PIgFRT3AtQ1+X+1bT16Z9Vl7GBWDfTOwmyThXt4c=; b=XphyBOtTj5NNYPtkyXwSOqk0Uq+wlfGVaneH3OoS/k002Hgj4rIcSP5Cj8RXGGVKHe6jL1 Sagf9omz87wnjIMFHbBzEyOkWpI2jkM9rHG/M4RDxLMy1hmADQIcT2UjrKe99n3WCs9BfR yU+Qdy66FCJ40tOHOQer87/+b3A2Z/A= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-UC-t8eqNMcmCqQFn-h98Ng-1; Wed, 26 Mar 2025 08:46:33 -0400 X-MC-Unique: UC-t8eqNMcmCqQFn-h98Ng-1 X-Mimecast-MFC-AGG-ID: UC-t8eqNMcmCqQFn-h98Ng_1742993193 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4775d202ae6so40652881cf.2 for ; Wed, 26 Mar 2025 05:46:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742993193; x=1743597993; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=s77PIgFRT3AtQ1+X+1bT16Z9Vl7GBWDfTOwmyThXt4c=; b=cRY1gB91jNkqUClE1HWMwe3z+PZePooHWt2duAbIBlrKgUL9xaMUldFXc++hF2Ds6N cMvIOueOetZkZj3NC8UKGAq8hKMVCxLLmDlEHdewHVLyD5qCob6ouFbL+h0A5jKuv5Th Nk3haR81Fr1LQBhBMrWwCg3b3kxi/cASBX97tsw4c3Qc/ucBOIGeF808ilvaSO1LcOOX QrL56Q6KMs/XN+JyKlaBarEvdMJ7+32DPUwclXA/GLZEo4mSod3MjOWURUO9FcCdqmSr nlvU2CHM0hH6XJHxrTDV6iUdpNDvMrCDBeZ3HSD2rvrPowtNK0c3s6Xn+fDQHhQxouUF n3sA== X-Gm-Message-State: AOJu0YzuFnXZ3Fb+4zPS7roE5smlnWKb53ZdgGerxdvOF07/KTDGvN12 UxzXAGq9afUZ4YieNHXfGnPLinuuRCpQ41m8E2cIvhbI1pE1lTUvpL85ZXAVCU+40wJlQymkL0d CyJytoQ/2pgWRefpYehfcDPnJyeE9bvWa0iGVWR5DwrPfFu17 X-Gm-Gg: ASbGncvVMhPtWeoRZB/Xr0ozT5nnTq8pBS5dljavxWUQhIWvRfGkV8FkENKjxffcb1O dx82zR20GEmKMn5Tf8CGfRI0mgFxZMSRqb/lxkaC+gkc4nPyxXnsHsPkku9staPhfU+NdYHOz32 uMxrRe8sdSD1e6VtDPEF/G2PO5N5tABjJYimsttQ0JqwhGSXuiYunnJfNqRSCoxuMIcztISr1Zk a3ho2udx+vqD4/hxxR8yiXF2oXBO/rBgRRL6xreqQUYILzyk42/xgLUTApccvq3HMDEEvV91VnS xiWnfTvTgPMM X-Received: by 2002:a05:622a:8c8:b0:476:a713:f792 with SMTP id d75a77b69052e-4771de76b37mr393709881cf.49.1742993193090; Wed, 26 Mar 2025 05:46:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzkqpqjEwPUTEAvDnO0P+5L0dcnCmpDb5RpBr8CRpdw+f+sjDwy6OQgYyXF4UGIgJUyGBQKQ== X-Received: by 2002:a05:622a:8c8:b0:476:a713:f792 with SMTP id d75a77b69052e-4771de76b37mr393709461cf.49.1742993192666; Wed, 26 Mar 2025 05:46:32 -0700 (PDT) Received: from [172.20.3.205] ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4771d51fec4sm71024641cf.52.2025.03.26.05.46.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Mar 2025 05:46:32 -0700 (PDT) Message-ID: <91ac638d-b2d6-4683-ab29-fb647f58af63@redhat.com> Date: Wed, 26 Mar 2025 13:46:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V4] mm/gup: Clear the LRU flag of a page before adding to LRU batch To: Jinjiang Tu , yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, aneesh.kumar@linux.ibm.com, liuzixing@hygon.cn, Kefeng Wang References: <1720075944-27201-1-git-send-email-yangge1116@126.com> <4119c1d0-5010-b2e7-3f1c-edd37f16f1f2@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4119c1d0-5010-b2e7-3f1c-edd37f16f1f2@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: y_dRNnfk2mhsL7XjczSKaeB8Yu3gqfjuKva-XQOrn68_1742993193 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 79296160007 X-Stat-Signature: 41hy45ueoigkpy8cki334kss3qz83k54 X-HE-Tag: 1742993195-382678 X-HE-Meta: U2FsdGVkX19fT1qW3cgWpvwR6d67jIUo5ykyOZjxSuaRqQ90MJVYyQvOmi9CGIiCMPv4qKDkqeWAxfUvXxpPSqmSyDi4UajwNp+DKdOuFuTKOY7s7rqjb2qz4QuRMzKatAV9R9chiXexV0y8rBfdVg1lXX5Pn2pBMIgTViWp15r1pXQ/4oFWTl47Znv4Bem6zNxRDoEfkbUGb4/0oTgaOACbWg71fzleb2Tc0pHuB41q4CZhMvylTDe0IqVYO5xKkQsZA21rEuGvEvc5tEwFhvVcXer7svM9Q3spuZ0HolaGC+Uu1adSNtDmNrA59KMcENAjDyEw6J+1iyB7N1Ck/Uh9Cj1W6S+I8r5tXVawpH8CNNGsMkrrHs/HxUxoUEkQ0GsBb1QmnB/EwLOUN/1vblYLofVFbOvw1mk0RoNlyca82wJ4SNX6KXaK7PuCbJUKCTNBdOih3PvAq4yOH08QO5hEKH4agAiMqE5zX5Bc4DW3UDbAC6opUrwcFsEk6uZASX8qldwu6VRpS1eFaMTv18CtZo1CxrgOGonuxXjoUdckS8M19nRMbGgE/EmVWdtJvabk7eH8KEhKxVmsfSyq+Sj6DJseFQEhDomOGp8K+28ZNDBwBRQg4aucXHPd40rt3BrLaRNgG+qi49+7EswyddWz2GKYRsnRgCSYDZzWAbURdkx2B+GuUas/yBj44FR6nHc7mXGs2026+RQhFYvYMRAtd76gVv/Ym5iAQLWgfUi+r+qGcohgtS830G+jLx4k7DIWhfTsGDEAzJdC6yiCfmPszzUQh2sT+2t1K1hi2XeEV+3ZB5QlNONenkhRe87FQRWHhAA/DDam2OmA5kfAYxqbABRka5OYWAPLKZKmDz12+bK3QFfFbVWACSXhsKVR+kPyLzcsYtfgSldv3OsKShFAVA4ycrkyvjOG9e6ARjQ+6KFNtB5AEhYsOUGEjIqhnJq2QxSq29k2rL1uo4/ CO4dsgtz Quwp1iHnSzr+zOgIgtzksI4O5sDfxkkF/BdH5+QjtsCEu2QbO2UD9lu8A4zjy5zaXwBNB5yGk0lj8awtg0Z2UYUEnXebJMl57ww+gQWaKuNHhIz5oIBIoFKICAGaFF9fgvgIOSXPyhAZvJHnfv+TJVB2FlpDyLxNhLoSIKcPfKB7OfHHpaHrDHMz3i/jJ8NntzaMMZqSPxv7fJVYxmJEXAVXJnPk0saE8k1X+llrdKcR1h+1taYTRcgNIb4yuOmClK4f3KfWumP3BU/cs94VGuPTND29ULO7FtUtL20ubYFrNgtrFL6Ra0IMYkiDOIuCqkc36ewz0joXcX4aarcC0/2M8CJS+x6XseGT7LiFZuNsTnMVBpVa9ISfo68/IY00e3uavGj/7jD4scSXBvM0JtMc26F8i+yKUF6XJ8vMPpgbkh04iDsCzTrj5Ya4DfTYX7BrY4Y/JNoJEmpGIZOHaJc7qmImsOX5crevc1i6GqQbp2flWm9lpvzOl2Yfb6AtvmiZRSyY2blaDnWnUwoDMsMTNCuE9AV9l49HX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.03.25 13:42, Jinjiang Tu wrote: > Hi, > Hi! > We notiched a 12.3% performance regression for LibMicro pwrite testcase due to > commit 33dfe9204f29 ("mm/gup: clear the LRU flag of a page before adding to LRU batch"). > > The testcase is executed as follows, and the file is tmpfs file. > pwrite -E -C 200 -L -S -W -N "pwrite_t1k" -s 1k -I 500 -f $TFILE Do we know how much that reflects real workloads? (IOW, how much should we care) > > this testcase writes 1KB (only one page) to the tmpfs and repeats this step for many times. The Flame > graph shows the performance regression comes from folio_mark_accessed() and workingset_activation(). > > folio_mark_accessed() is called for the same page for many times. Before this patch, each call will > add the page to cpu_fbatches.activate. When the fbatch is full, the fbatch is drained and the page > is promoted to active list. And then, folio_mark_accessed() does nothing in later calls. > > But after this patch, the folio clear lru flags after it is added to cpu_fbatches.activate. After then, > folio_mark_accessed will never call folio_activate() again due to the page is without lru flag, and > the fbatch will not be full and the folio will not be marked active, later folio_mark_accessed() > calls will always call workingset_activation(), leading to performance regression. Would there be a good place to drain the LRU to effectively get that processed? (we can always try draining if the LRU flag is not set) -- Cheers, David / dhildenb