From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E908CD75BCE for ; Thu, 21 Nov 2024 08:11:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76EE36B007B; Thu, 21 Nov 2024 03:11:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 71F146B0082; Thu, 21 Nov 2024 03:11:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5975F6B0083; Thu, 21 Nov 2024 03:11:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B1256B007B for ; Thu, 21 Nov 2024 03:11:34 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B7BEEAE61A for ; Thu, 21 Nov 2024 08:11:33 +0000 (UTC) X-FDA: 82809382404.14.5DAB4D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 731E618000F for ; Thu, 21 Nov 2024 08:11:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/j21Q+I"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732176629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j7c2yRYP0godLKKdOAgJYMv4rz+u6pVZgcG/16jBlNQ=; b=sd4aQB1+esohM6fxCI2RYPZx3QBiDQXqu/It5NMyj4jCAxPYUA+jntp6UhFawbbztHZg93 Xey1rOWoaMm/PG+xhZDcYErxCmONFmVnYty76xgXOl0rRTVUqzXVG2t1WO1YyfxaSFlfD8 +A+PF9chCOcTyofwoCETUkP787WRfXw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732176629; a=rsa-sha256; cv=none; b=rO5kfmyLakgb/bexXsxdm1SWZYXLyb5Ho9hqLUFqdbiixiGHm5mKe98a3LQwij785uKWtr yOi75gc8NXiWRqvsdRlqvO3pnkbdJ1J3e1kIJ4S2uHOSLSXlp8OCglAssczruiZNUbdho9 hcOXz1I+1oCRcJE9sOYEu65lsFcFJOs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="U/j21Q+I"; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732176690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j7c2yRYP0godLKKdOAgJYMv4rz+u6pVZgcG/16jBlNQ=; b=U/j21Q+IsjZPOZ1c1DnldW8cybr/lFE+HakUPPNZP69rtQu85gpkTE9MRZcbGvtVYrmtF7 fdPZLdk9gbbN/JCq6eIYW7HoP4nVcI0lsbUZjfBkXwe3VbRjAGtDQjPh7q9g7KbAJOCv7P 6l4LrDL+ZB2CXg4ejcb3dTxyTLVkFJQ= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-K59WaxsFMka1OtvuHN4owQ-1; Thu, 21 Nov 2024 03:11:28 -0500 X-MC-Unique: K59WaxsFMka1OtvuHN4owQ-1 X-Mimecast-MFC-AGG-ID: K59WaxsFMka1OtvuHN4owQ Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a9e0eb26f08so45541266b.0 for ; Thu, 21 Nov 2024 00:11:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732176687; x=1732781487; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=j7c2yRYP0godLKKdOAgJYMv4rz+u6pVZgcG/16jBlNQ=; b=MPyFcP2UL0j+xvcsF3yaxdf24ToXTCy9Zw78cKuCZyJqnWSDJ0xxNwOMUsypwN0OGq YNn3ZPCp89W3HrxGZqblFDdhHCiZqCZz209qOX6rvsuT5RVl5LoeWLFQfjKRF5S599w6 H0YdsBvQ4RHIIaE+m2HBcxSE+Z93q5qhI6jKVwUliiEpdmacboWZJmO4Pv19c/eFq36Y fv270f2n/ir1QqHfAbQ3iM2+rNKSVHzXQ8dN3rd2iiAK4Rtr68n2STktwoFIChfx8Vw2 vVqaInd7daLyXhtAJ8ripdvjpAuU4+p/YkCjddM5g4uarL51L12An598Mw/vrlFbFmt/ bzKQ== X-Forwarded-Encrypted: i=1; AJvYcCXlHsmN2oxWojfbocJNKUyTUx2zi9JGSzSRp4zjiz3ocz/aHRfS56WGT0RIYQp9EZlWIV0WH8knXg==@kvack.org X-Gm-Message-State: AOJu0YzI/meKbqd2Ge5xMOJUHE/M2MgSewHcz9en1OFkMbV1VkQc7cUG kXoq3xDMVWK518Jmx9saNV9kpMRVy0YuY/uA+BC54qn1j7rdSdJ/46Y8l5v+rGz1GPrtKitBg9F 8GHSWUsmdub47S5UoaVxV+iRHL8VYCk7MA+nnji4ixW2xYz88 X-Received: by 2002:a17:907:7ea5:b0:a9a:1918:c6c6 with SMTP id a640c23a62f3a-aa4dd53dab6mr500369166b.8.1732176687537; Thu, 21 Nov 2024 00:11:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IH1UxBW98t/86zlYyR3XA7RvuDh1PHWXkfY4E/qCph5vuLhp2/hlukVtaf5kqObRf1WCRpNvA== X-Received: by 2002:a17:907:7ea5:b0:a9a:1918:c6c6 with SMTP id a640c23a62f3a-aa4dd53dab6mr500367266b.8.1732176687183; Thu, 21 Nov 2024 00:11:27 -0800 (PST) Received: from [192.168.3.141] (p4ff231bf.dip0.t-ipconnect.de. [79.242.49.191]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825490c29fsm4121510f8f.32.2024.11.21.00.11.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Nov 2024 00:11:25 -0800 (PST) Message-ID: <91a621ea-d18a-4428-b1a5-943b4cf2c79e@redhat.com> Date: Thu, 21 Nov 2024 09:11:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/gup: handle NULL pages in unpin_user_pages() To: John Hubbard , Andrew Morton Cc: LKML , linux-mm@kvack.org, Oscar Salvador , Vivek Kasireddy , Dave Airlie , Gerd Hoffmann , Matthew Wilcox , Christoph Hellwig , Jason Gunthorpe , Peter Xu , Arnd Bergmann , Daniel Vetter , Dongwon Kim , Hugh Dickins , Junxiao Chang , stable@vger.kernel.org References: <20241121034933.77502-1-jhubbard@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241121034933.77502-1-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rnxarBTvo5Ou5bqFWPD03KitoYrfyNNLHQHOPqsPXbo_1732176688 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: chqghnqq471cqh7q7ugd8p8gru87p7qz X-Rspam-User: X-Rspamd-Queue-Id: 731E618000F X-Rspamd-Server: rspam02 X-HE-Tag: 1732176684-710029 X-HE-Meta: U2FsdGVkX1/T+lBaPwJaWSZg7J0gwyUyp9u4Qw4t47yyK2YUOQNG0av+zB3fJDXfwm7pWoH1VabDv6lhWuEaZ26zd/yC2rJ3PfUOihXe7jqS4bzAhO2D6VkKJTp85QTodIrNv1Kb9uQ+wTazzPN3pTAi8Md2Y/xD89Bby6NECziLrtrua1NAoUuIw6OAsGD9U3VREhOlurfOPMvPmgKcWnEo1o6waB4YnAZ9+Cx19oB8ZjUbPEGsKfi4DY5Cw/1X7OduOabbuEtmZczwZzZEVROWF28Ccn5mdHJ3yCNv46/lwy2u6O6W2n4lM7dx3nEOuprjAKTtsNSkRzmChrOtUpw/fM1ATDF2bQDA1AwD2rQa8KRjhnn0+0rRz9v8MDyywDt/gL4G6eZuwrILVERhZ9ySEIphLpDW+qHATt+MBhxaWceoTscT3s0VVYwIVHeROlsdlK2cGG6yTRMByKbW1MXxForjB7N02KM7Ru/X8Nycjk8aLEeEOpxD+lHuzQUImgl2Q4Dg82/QznKx9kSBg8Vn4gk8LQOGAMavVN4tRMItTL5PTfS9NLS7UrhSNJhJw2dqcQAYBOFxGt/U15DmAFN/poJiJHkwRuy/olAmAoGdGG3AT8f+I+uBSs/cqVTDMWazgV+euZ9hmRfX6GkjpiFvhWtwzcu8HnW7CwvIK97V5Emb8YZhoyGmZCkGZ5QvgRdnWYPzKxiGhtMTfsmjkTWry4N+Rd9FvIwKqhf6jlA4pJVmCtNBwrE4OM7kN5FzDHCrSi3FmfVl9YQG/8CP+1exRcSajzUnE7B7hvqJ1YDiLu7lc3vw3Nu5iewRB+WgzxLwKZ7n579YusYetvE3M/hmKJ8vVvnye/Gybs1Jb+gYVWW9upgZdB+3ryNX434zc4uUXaxMzaaClUd7+1eUsL7ONhgFdQHkuGC8kB51ubVEkq+ejniQXqdPVmD051qJV67sHGUR4SCrHCpzXBO DWPCPX7r fshfDQTY9q3PEDeLWvMABshCmxT3AIh1DxqxdcFKCEYkD8T+TuvzLXQDzyEnceHbC0fv4eXa6d9DFjdDhJql84bIonb2QAYZgnl9FOswm8XC+fPHESfqOLjM0xQ9EAr1NnMzOagZk7JTF/AR0pipvEXL4UfsDnqqChdfq6RRRn2mANl5dOkHOpucETb7P97WeqdhaPl0iPP1bNIQshkCVUstdxEnkd0uqXh0a14u/5HJr4rh6Qdq9hxWZlt0xRrNlK5pA25K3DCTL0NwjJ4Ss4YjBQYF6CNTUH4MD/K8/yiMQb1bj1mF8vVj9p1lRhaIxmcRinHx2yChLzD2mcyBKCC1v/YPtPt2w1t9mesiol1dd/d+vuy/NnpBsjGYWGXPYwI2isFqsutKOQ8BJ/j1Wng5HtQHNyw+eKqZ6T/W+tP4DJEgQHncz6y6w4w9RYqru0AT4cK91Rxx1w8UkD15Gj3yiH2IewsOAoAxXZsCMe/J666zR42MURb6po8On0z6u+3eBrACD1ZuVWsiHzi/a8Cmuv0H5guLcpgnz/N03wPy3AM6yfmtjEEV58ffNQP9w7JZQLvPWnT2W2LGe9/IYGn5EhkZkWIAs73ctTpSzUFObZO5hhYsjxvKlOc/Ej9CSDIUK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.11.24 04:49, John Hubbard wrote: > The recent addition of "pofs" (pages or folios) handling to gup has a > flaw: it assumes that unpin_user_pages() handles NULL pages in the > pages** array. That's not the case, as I discovered when I ran on a new > configuration on my test machine. > > Fix this by skipping NULL pages in unpin_user_pages(), just like > unpin_folios() already does. > > Details: when booting on x86 with "numa=fake=2 movablecore=4G" on Linux > 6.12, and running this: > > tools/testing/selftests/mm/gup_longterm > > ...I get the following crash: > > BUG: kernel NULL pointer dereference, address: 0000000000000008 > RIP: 0010:sanity_check_pinned_pages+0x3a/0x2d0 > ... > Call Trace: > > ? __die_body+0x66/0xb0 > ? page_fault_oops+0x30c/0x3b0 > ? do_user_addr_fault+0x6c3/0x720 > ? irqentry_enter+0x34/0x60 > ? exc_page_fault+0x68/0x100 > ? asm_exc_page_fault+0x22/0x30 > ? sanity_check_pinned_pages+0x3a/0x2d0 > unpin_user_pages+0x24/0xe0 > check_and_migrate_movable_pages_or_folios+0x455/0x4b0 > __gup_longterm_locked+0x3bf/0x820 > ? mmap_read_lock_killable+0x12/0x50 > ? __pfx_mmap_read_lock_killable+0x10/0x10 > pin_user_pages+0x66/0xa0 > gup_test_ioctl+0x358/0xb20 > __se_sys_ioctl+0x6b/0xc0 > do_syscall_64+0x7b/0x150 > entry_SYSCALL_64_after_hwframe+0x76/0x7e > > Fixes: 94efde1d1539 ("mm/gup: avoid an unnecessary allocation call for FOLL_LONGTERM cases") > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Vivek Kasireddy > Cc: Dave Airlie > Cc: Gerd Hoffmann > Cc: Matthew Wilcox > Cc: Christoph Hellwig > Cc: Jason Gunthorpe > Cc: Peter Xu > Cc: Arnd Bergmann > Cc: Daniel Vetter > Cc: Dongwon Kim > Cc: Hugh Dickins > Cc: Junxiao Chang > Cc: > Signed-off-by: John Hubbard > --- Thanks! Acked-by: David Hildenbrand -- Cheers, David / dhildenb