From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4077C02193 for ; Thu, 6 Feb 2025 03:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AC266B0089; Wed, 5 Feb 2025 22:31:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C306B008A; Wed, 5 Feb 2025 22:31:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223516B008C; Wed, 5 Feb 2025 22:31:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 054416B0089 for ; Wed, 5 Feb 2025 22:31:02 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 73DB84A8D9 for ; Thu, 6 Feb 2025 03:31:02 +0000 (UTC) X-FDA: 83088093564.22.C31E52D Received: from out-176.mta0.migadu.com (out-176.mta0.migadu.com [91.218.175.176]) by imf16.hostedemail.com (Postfix) with ESMTP id 7AEB018000D for ; Thu, 6 Feb 2025 03:31:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WdPx9+yl; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738812660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TbVCUPe1Kpjetdaa2IGozCJyxIGj2SBcKsrt9n290Rg=; b=mwS1zmbZ4nLCkFcMG1if2sUJPj9F+Hk2h9HSX+z/imd0j5jsJXSB2MzWZtYY/da6O/TDhN urXInf5UuE4e7bMADThyAFKWeK5p/yXA4KKat0FXpJTB9tEJBOB5cLLvWmkSqsPY1pfN8U w4McYcBHLcN1KDK8ZVZ2/6MT9hJTNZ0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=WdPx9+yl; spf=pass (imf16.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.176 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738812660; a=rsa-sha256; cv=none; b=gfpx0krSG1BR1IeP0Xkq6l1vBC0PGehS7uBqw00u7YL2tWp4BxSVxFnH66wioJasukG0lZ qYfnep+1LzhPBqh8ZOTqOiyqGceEJOdbV+M8KWzgumFSU/I4xAauKucQJ96DttBgQXtNfv buRGA1S1PqgKhWQnNMMrIpu0wyp5xbQ= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738812653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbVCUPe1Kpjetdaa2IGozCJyxIGj2SBcKsrt9n290Rg=; b=WdPx9+yl2jzGCg+wEaOxo0PtLFTahg1WJYEyQ0kI/HcP6TaPzL5zdfVuGXiXAAVGpRXkta /bP/RlVgzKbfkN1aZZ3pHjXQD34vTO//vhwLbnCPZNqLh4MHtA1MwJV5kGtPsBCJ7NuuFQ Q0DIA07HMuhJeFwZ/XF5XGb1ki5jaQM= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: A path forward to cleaning up dying cgroups? X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <7nqk5crpp7wi65745uiqgpvlomy3cyg3oaimaoz4fg2h4mf7jp@zclymjsovknp> Date: Thu, 6 Feb 2025 11:30:10 +0800 Cc: Johannes Weiner , Hamza Mahfooz , linux-mm@kvack.org, Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , =?utf-8?Q?Michal_Koutn=C3=BD?= , Michal Hocko , Allen Pais , Yosry Ahmed Content-Transfer-Encoding: 7bit Message-Id: <91D2E468-B89A-4DD7-B1B0-B892FA4482E3@linux.dev> References: <20250205180842.GC1183495@cmpxchg.org> <7nqk5crpp7wi65745uiqgpvlomy3cyg3oaimaoz4fg2h4mf7jp@zclymjsovknp> To: Shakeel Butt X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7AEB018000D X-Stat-Signature: dk59zmnityeyxwzu4dctq88s7s5ssto6 X-Rspam-User: X-HE-Tag: 1738812660-218835 X-HE-Meta: U2FsdGVkX188h2+hw2JP88lk9gcYe0+tNoInHRSWk9fKO1J36CPs3gpV6Cqq7SxtBY1yTz08PiywEUsR42TQo0S3N1/rI4YixE+GK1ctDoejcVXD0tvCD95v2j4x+D2RPDgUMrbC0LmMhBLasGdtkp+2FeWoOs7aJXsRP5DjtBxPeTI8sDbpGUIIqdKWiXeHKnCjwS5KbcNNuF1a1BHDFiFPoMtCjh+X+pNWRIxocYZntPnqUJfX1VLfASd85GV15QuvhC4nBi5ZixhmskAQgQRFp+OgQK2Rl4YZkQ97QbmMg3u4UphWQzZTXbEi+ials9PrLrDngZQiPaYOI7z2eOFcpyuLI8gIzJhZY3x/0lg2UkbVRBzONEHNLve3B4XlxoEIvVpsBv4jFVAQEgNd1U70CnvuCD8hjR1jlnyfcarLknLC4/+vQvcv7udEzqRaYuxvCCx1tN0F3ragUVFAKrZ2jwzqOtjPiWnwiu74UMNVKnaWP6hG5P6K+jDaRaueD0fK6Oa+xgEDomAYmr+mk0JvlExXROrCP5HnS9OmynOzshTm9LVYyWGOAODls8jnOyUc+XoR9T7DXVG1r43RrwiO8G3EjRnI0Rc/xLDA6Pogr3Ax26AV2HB0fnGXVEHHdck0f7TOALaVULwPytPEVUCQ4BYpH8QQI8mEzCHUVeP/DCNOL9AwJdO8/D+e9wwFgofoT1I5pE5SwYqTbnNWhjDzy7DhloiaF+Fok4fs/GUDoTx0XU4cOXrMNvxWoiAXGiAeor/AQdnbEfb1hFcsqKoLiUGBpfdCv8MCDHdCh90QTa6NT/7O2jzFdsVz9ZaO1+zkhEZUsF2DuBx8rqfmb/0wx7y1xX4yXTIL/KGFmeacMyZ0CBobhww6/OksK/ek4gTZuJO5HHBmU2RfPF0tHKZ8w+3u8aqNLN9GShjU328OaECh8FQSWvvaNL4kEMZUyHwmkxYB1V8wt6hTrET mgI293rc GcTmuazpzEcYXsnKVEb8StK3tWrC0RL0e+KypHkhE9w2jW0E0IbsWFKXR9sTx9LOsBlir9r000Ro8QuGCc/Ap9QFsHbXCW8RpF+E3B/y3IEE6aEDKX+spTn7nsWEb21hl3aZmxBQUFj86+z2xpq/lLaJDa6Eu3/DIIO7UAaSBqWfVma0grvZDdqXk5y+eESGRCObpxhSVjWPNSM/vvPIyC6b1wY2YAr7hoT8volblECtuG0Evl2JUU318YaemY7TEuyF9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Feb 6, 2025, at 02:46, Shakeel Butt wrote: > > On Wed, Feb 05, 2025 at 01:08:42PM -0500, Johannes Weiner wrote: >> On Wed, Feb 05, 2025 at 12:50:19PM -0500, Hamza Mahfooz wrote: >>> Cc: Shakeel Butt >>> >>> On 2/5/25 12:48, Hamza Mahfooz wrote: >>>> I was just curious as to what the status of the issue described in [1] >>>> is. It appears that the last time someone took a stab at it was in [2]. >> >> If memory serves, the sticking point was whether pages should indeed >> be reparented on cgroup death, or whether they could be moved >> arbitrarily to other cgroups that are still using them. >> >> It's a bit unfortunate, because the reparenting patches were tested >> and reviewed, and the arbitrary recharging was just an idea that >> ttbomk nobody seriously followed up on afterwards. >> >> We also recently removed the charge moving code from cgroup1, along >> with the subtle page access/locking/accounting rules it imposed on the >> rest of the MM. I'm doubtful there is much appetite in either camp for >> bringing this back. >> >> So I would still love to see Muchun's patches merged. They fix a >> seemingly universally experienced operational issue in memcg, and we >> shouldn't hold it up unless somebody actually posts alternative code. >> >> Thoughts? > > I think the recharging (or whatever the alternative) can be a followup > to this. I agree this is a good change. I agree with you. We've been encountering dying memory issues for years on our servers. As Roman said, I need to refresh my patches. So I need some time for refreshing. Muchun, Thanks.