From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E0CC4320A for ; Tue, 17 Aug 2021 07:17:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EDDB460E76 for ; Tue, 17 Aug 2021 07:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EDDB460E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6302F6B006C; Tue, 17 Aug 2021 03:17:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B8988D0001; Tue, 17 Aug 2021 03:17:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 459FA6B0073; Tue, 17 Aug 2021 03:17:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 294EA6B006C for ; Tue, 17 Aug 2021 03:17:53 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B1D5A18311447 for ; Tue, 17 Aug 2021 07:17:52 +0000 (UTC) X-FDA: 78483717984.31.9821703 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 55420501CCAE for ; Tue, 17 Aug 2021 07:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629184671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rf3UZ1ygefepa0+9j6MzSobnoEcFqDpKQ7TfnlJhrFM=; b=YHD4RXmSaIBAETtBkB0x6hAiwPVMMDGLyzyklqRmf7Rt1d/N5THAxi+DTtZbB6sJQwLNTZ 2STKKE89QEiTb7fAujk+v8qXZA/WNHJMqYVcn3AljIxZnawY13qlYBQqZKvuVsBFGHD1vD aQc75txXyIK094JxYz9CyL21Fvbgmtg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-104-fbMh4q_GPHGqp5o8tygmGw-1; Tue, 17 Aug 2021 03:17:50 -0400 X-MC-Unique: fbMh4q_GPHGqp5o8tygmGw-1 Received: by mail-wm1-f69.google.com with SMTP id z186-20020a1c7ec30000b02902e6a27a9962so647457wmc.3 for ; Tue, 17 Aug 2021 00:17:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Rf3UZ1ygefepa0+9j6MzSobnoEcFqDpKQ7TfnlJhrFM=; b=qqt0vfuCt1yt120VRq41ILOd8vym26qeswANW/6acHo7/g9IGoctd2jrHZ4qkwfxCQ 9K0rkr6ai2/l0Q6DurE8OFc6DOW60FiBfw0RFaJARUjH2zW1ORbZYNB46QBwSNKfutCn ExDe78V+4NZZt6JSMK1bXUyLObDdOPRJjRakjPbV/T6DCw/vRo3jz6gxIDmFYqBWwgIJ pcmECBCOAepsTqie7KPQLFbrz4KODpzz8nhZQOzFTb0XEB0NhUbCSIPC7ze41HK6acmS r+51xfbMwjdQCOFOBA3oyFg9utlEV0oEg38+6Ko5F96zGu0aN4C6G5FE5sg5Nw/TxKxg AuyA== X-Gm-Message-State: AOAM531jQcPEA8xYF0bBnW9yjkhyhQfRAoHD0AAywdnwrZ4R9MBV9F0K XSRU5XVtuW2Pt2GMZUrQf+RP5iBF3iv5bCvcdyKiWmbxb4N0XhFCw7bK78ncLUDFolPgogLtWfK vR5wIo3nBT3s= X-Received: by 2002:a1c:4e08:: with SMTP id g8mr1880526wmh.116.1629184669085; Tue, 17 Aug 2021 00:17:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxneaey6sOYZDvyNBPB+IbsKnxSHyfSd/4LlE95bb2u+osxqFP6LfAkCvBDN8Ofav3kjei/mQ== X-Received: by 2002:a1c:4e08:: with SMTP id g8mr1880497wmh.116.1629184668820; Tue, 17 Aug 2021 00:17:48 -0700 (PDT) Received: from [192.168.3.132] (p5b0c65c6.dip0.t-ipconnect.de. [91.12.101.198]) by smtp.gmail.com with ESMTPSA id v1sm1263581wrt.93.2021.08.17.00.17.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 00:17:48 -0700 (PDT) Subject: Re: [PATCH] mm: bootmem_info: mark __init on register_page_bootmem_info_section To: Muchun Song , akpm@linux-foundation.org, osalvador@suse.de, mhocko@suse.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210817042221.77172-1-songmuchun@bytedance.com> From: David Hildenbrand Organization: Red Hat Message-ID: <9198523b-a049-1c92-1818-989bab30628b@redhat.com> Date: Tue, 17 Aug 2021 09:17:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210817042221.77172-1-songmuchun@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 55420501CCAE X-Stat-Signature: cjahyedgxzx64wc3ando7bqm36i6xyjw Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YHD4RXmS; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1629184672-518708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.08.21 06:22, Muchun Song wrote: > The register_page_bootmem_info_section() is only called from __init > functions, so mark __init on it as well. > > Signed-off-by: Muchun Song > --- > mm/bootmem_info.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/bootmem_info.c b/mm/bootmem_info.c > index 5b152dba7344..f03f42f426f6 100644 > --- a/mm/bootmem_info.c > +++ b/mm/bootmem_info.c > @@ -39,7 +39,7 @@ void put_page_bootmem(struct page *page) > } > > #ifndef CONFIG_SPARSEMEM_VMEMMAP > -static void register_page_bootmem_info_section(unsigned long start_pfn) > +static void __init register_page_bootmem_info_section(unsigned long start_pfn) > { > unsigned long mapsize, section_nr, i; > struct mem_section *ms; > @@ -74,7 +74,7 @@ static void register_page_bootmem_info_section(unsigned long start_pfn) > > } > #else /* CONFIG_SPARSEMEM_VMEMMAP */ > -static void register_page_bootmem_info_section(unsigned long start_pfn) > +static void __init register_page_bootmem_info_section(unsigned long start_pfn) > { > unsigned long mapsize, section_nr, i; > struct mem_section *ms; > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb