From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A7B5E74AC4 for ; Tue, 3 Dec 2024 16:55:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2E876B008A; Tue, 3 Dec 2024 11:55:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB78D6B008C; Tue, 3 Dec 2024 11:55:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D307F6B0092; Tue, 3 Dec 2024 11:55:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B49786B008A for ; Tue, 3 Dec 2024 11:55:04 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2F7A11602B1 for ; Tue, 3 Dec 2024 16:55:04 +0000 (UTC) X-FDA: 82854247098.01.343E717 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 750F718000E for ; Tue, 3 Dec 2024 16:54:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="j5cvWj/y"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zZ8AH6d5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="j5cvWj/y"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zZ8AH6d5; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733244892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6iBXyybS3x4GBQ0mkYi2MGoLoo582oOF8aBi6WEjlsU=; b=PY1n/SG/FmzZWz97f5nFa3bkR5ySkshJeWj/0g56wdEG9c7W9+HEyKbCYpiCxtK2Lpeakx 1x8zVQY8YCOovgmQkfJXrhoqwZNhytCLHuMEzE69+vOFRs79fVMXWwgTU0PM3XqqLX0iWU kRQ6T6/9s8EXVprJwu5qK9dCeEa14xI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="j5cvWj/y"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zZ8AH6d5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="j5cvWj/y"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zZ8AH6d5; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733244892; a=rsa-sha256; cv=none; b=QgFvuC2lu/M/Oo7j8869jpmEegn4E5aRvcDkyYYwSg4/GSWjxlWbZxFYbEQgdpEc/rouQ0 J5XDq0ZCk1u1Sr5VtYd76z7jTSX1w9oGIr55h/EcoP0tjbiop5dVAFqMJljtsnJHyrklQx KDBU8sFwWwR+GKFXEi2WZYQ+kne5HqE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 289E21F451; Tue, 3 Dec 2024 16:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733244900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iBXyybS3x4GBQ0mkYi2MGoLoo582oOF8aBi6WEjlsU=; b=j5cvWj/yCtEAdS/I8xYx/NHFIQIYO6u26AiY0+qCph9PrE7qVx0nYTkFA26LlWFMJ4MBov VjoHTOvfeT3WLX/HQ4L4WFmmYWs7+3LAl6gx6vtBsXvoPhJEbEKspaU/OWIHEzxdXjp+Tp /QT6um/IpMrquj/uL4PoVLUlll4Uvo8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733244900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iBXyybS3x4GBQ0mkYi2MGoLoo582oOF8aBi6WEjlsU=; b=zZ8AH6d56u+xZb28AmzbcqYfniq9035iIB6FvZbGe/6lRaSs3gk02VJnMPt53UQnXgZ4oU mVLTjdAGOx0fy+Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1733244900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iBXyybS3x4GBQ0mkYi2MGoLoo582oOF8aBi6WEjlsU=; b=j5cvWj/yCtEAdS/I8xYx/NHFIQIYO6u26AiY0+qCph9PrE7qVx0nYTkFA26LlWFMJ4MBov VjoHTOvfeT3WLX/HQ4L4WFmmYWs7+3LAl6gx6vtBsXvoPhJEbEKspaU/OWIHEzxdXjp+Tp /QT6um/IpMrquj/uL4PoVLUlll4Uvo8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1733244900; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6iBXyybS3x4GBQ0mkYi2MGoLoo582oOF8aBi6WEjlsU=; b=zZ8AH6d56u+xZb28AmzbcqYfniq9035iIB6FvZbGe/6lRaSs3gk02VJnMPt53UQnXgZ4oU mVLTjdAGOx0fy+Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0ACA6139C2; Tue, 3 Dec 2024 16:55:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wzJMAuQ3T2cWZAAAD6G6ig (envelope-from ); Tue, 03 Dec 2024 16:55:00 +0000 Message-ID: <9186ea43-6d36-408b-b154-91d5c1912384@suse.cz> Date: Tue, 3 Dec 2024 17:54:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 01/15] mm/page_alloc: Cache page_zone() result in free_unref_page() Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, David Hildenbrand , Miaohe Lin , Muchun Song , Mel Gorman References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-2-willy@infradead.org> From: Vlastimil Babka In-Reply-To: <20241125210149.2976098-2-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 750F718000E X-Rspamd-Server: rspam12 X-Stat-Signature: kxqt6if4jbscp15ss3deephmtt6hcssm X-Rspam-User: X-HE-Tag: 1733244892-68823 X-HE-Meta: U2FsdGVkX1/PezwxXwrkle8Q4ncJu8kKDelNr3uL6703Ow+m+6F9xy8rMUpZyNskQX03etEMsBlfZNL/GpERvYEtV2ICSZf2ePpGyxEofyNO7b6cN1nTOyP74KaYRU2PKfXLnpllLaZeZF2bttC3lLYQ4KGz3kF0MNcnSFrDsTiH/PQvrVWmqSt4/szU14Xtg1Gn+NVuPPdOY5h+BG/VmGSY5rIfS3gzAiQlQehuwucJOAsfJH435FY+ESRNUMGX+sAGSbHu2V+jwXjUVmBmzrRs5nxi2YhdmEUPw3EA5y7slXc11f5YkXbvqHMPWXgDSHQligkfXvzqDu2ckBQAUl0DrSj/p+gExp893fKAPyBL9iJdhhgsNW7eeHX+WWAeiIb6tVsb0PzPZx1Q/s9Nnz/oHcMJfEpKNrs6GrpXDa6CTf/aou230lUsXWbDxgBcN4lQPvjnzufFX15fAZSvJIN3IlH1cY2Aw0Kk4M/XlWzOIawFrQz2x45pVsOTBx6Miw+1h0CmGiMkxp2hGkfFQIyhJYtws4BaUIR/q9gsqpcoU3S2gd0SfNzH6juZyUBna0elIOvdYb+KK1nnYQTQUR5shQvmfcYaUS53JLtS9QXpbSdXulnwEWEh9zg1HJLiCekr6Usdh/WisXiZOLTXgtah7n0tA4qNoAsTL6Avy5DVkFs9Qh+MziMG0QSiNkYlkj7tZe+fdQgcbgaEHE5W+k12uSIwptcg/QVBJQjTDpPf2zHgBZVUcoqLHLgzo9GJezLtacAb+RWFN1FTMSSlMZKhWq8G8ybhBQwZeygxniWoBqDCihit47nRkmrYaB6jJcNmToZmQ30+RZtWHel5LpUVkYyX5hRYuMGMTzC9wMKnPml2W9DGJSiifepp7X+EwYOvZ0vwkYmauazrZlQ3GPOZPAE3t5hnywocRcMnkZlE6SE2Xq+AXnTo5O90AH3J0de0uVkFKmdVOZwhcrg T/slaj4G 0/k7+avaRxWiaGmtQexJ4QXNRx/75foEYQhaKJPwa4BW+BhcXIdmoVB+fgqtXoSftuE92uS6L5tU3cjt1mKfxDH/esKcp6ZsHGluU3zUYO7/Q9ZJRe6eSQrTLLqcIsxNM4DM7r6SoiQSao6gAki8fVDHGJCco+37oBOAr6bxCt+zXhITmjfaXzGThJ8Mg77zCtb7Mqb7MGDvYitPSt3X029m5ct0Qkh1Vu4RLRVgFGOExo6KjCCzV9/U161Bi7SQktw86NENqCUO2LGgW8eZfDSt8drez0U1DjYgv1CbPqjh3XrNXvJkkrZFEDoe3jVvffdCDvSBwpaJgotLaP4z05MPIC8vduF9Msd1cd4YR2rw4w66T3FUrWssb6o+srCjE/QvyK6qFJw7avIV+JhnKoXXXyrRFBSjb7zH1C0DyhloRl3P63Cnh2DcwRfWiV+lw1jzW/pUIqFUNhJmCtygo+XLf7S1vZz/UVgTSrd6E713/GQ/E7nLEgsjemw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/25/24 22:01, Matthew Wilcox (Oracle) wrote: > Save 17 bytes of text by calculating page_zone() once instead of twice. > > Reviewed-by: Miaohe Lin > Reviewed-by: Muchun Song > Acked-by: Mel Gorman Should be without the extra u ^ > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index a8cd54c02f13..c40a0c29a89c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -2700,16 +2700,16 @@ void free_unref_page(struct page *page, unsigned int order) > * get those areas back if necessary. Otherwise, we may have to free > * excessively into the page allocator > */ > + zone = page_zone(page); > migratetype = get_pfnblock_migratetype(page, pfn); > if (unlikely(migratetype >= MIGRATE_PCPTYPES)) { > if (unlikely(is_migrate_isolate(migratetype))) { > - free_one_page(page_zone(page), page, pfn, order, FPI_NONE); > + free_one_page(zone, page, pfn, order, FPI_NONE); > return; > } > migratetype = MIGRATE_MOVABLE; > } > > - zone = page_zone(page); > pcp_trylock_prepare(UP_flags); > pcp = pcp_spin_trylock(zone->per_cpu_pageset); > if (pcp) {