From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78250C2BB3F for ; Mon, 20 Nov 2023 14:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12CBE6B03F4; Mon, 20 Nov 2023 09:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DCCF6B03F7; Mon, 20 Nov 2023 09:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE7496B0403; Mon, 20 Nov 2023 09:55:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DFC806B03F4 for ; Mon, 20 Nov 2023 09:55:47 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B4C25408AA for ; Mon, 20 Nov 2023 14:55:47 +0000 (UTC) X-FDA: 81478631934.21.9836273 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf17.hostedemail.com (Postfix) with ESMTP id CDA8F40023 for ; Mon, 20 Nov 2023 14:55:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Ndid4Neg; spf=pass (imf17.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700492145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=kGFXkVothP8GzTo2jzsCD/SdXLlf2F5wZiQpSoYT7RM=; b=TauW5qTczeh7iKKWG/jLXUDClg2jSUX2zxVhqS/B671UeBqdV5HXFBqrgbHfUCcQ4NQJpN dNVTD6v3lWSZOJn0vx2jo+T1vSNA2YRKFX1QL1725bXo2WOisnWlDR7ORA3Me29pTCJpq/ z9EcRGQZnCN4bWlUKDmAviYBwBogqYU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Ndid4Neg; spf=pass (imf17.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700492145; a=rsa-sha256; cv=none; b=P6zVCuj9aM6+aUIjolZa7FwZjzJ359XyNxfWXlROPoKvIlfat9vNBjc3QK4k4MguNnruIZ mJuTnVxxh/70zDreHI7e8+BMHa5qXON/bFCaryt1OzHWnNeVIJMCI/sIbmPAMxctZYfx0u foiJtlTAD1ZCVMA3OhxC0vqwK7LoXOs= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40a5a444c3eso13914565e9.2 for ; Mon, 20 Nov 2023 06:55:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700492143; x=1701096943; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=kGFXkVothP8GzTo2jzsCD/SdXLlf2F5wZiQpSoYT7RM=; b=Ndid4Nego7P4pcggu2/KG9+0bZmSSEdVZE5YZ/9zmsT9e6FVcQbdbIkJlrDoboq4IK tPLCwUPH2uHY5JSWrnBA88yut4Hriek20rGraXPNmki/jZxgHnkvf5/5rFpu06W2WIIp AJa7P+4742SVMXkuRpYu3b8bgyF4rTf2DYuYK5+TAR7KkZ/ByeCuiWFBCLAhX9bdedF2 woEr/bdLN4nGsNO2lw3z671XFjfByNrv8JMRlfBj4HK1p5ChrqhaQopjHqj06IGd68lx TmC6i6f6a2DtxCz4FlL/RZws0dobVglKEYDRU0ju7zZLW0hOI3AcMdmL6ApXkYTEzJnQ tfGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700492143; x=1701096943; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kGFXkVothP8GzTo2jzsCD/SdXLlf2F5wZiQpSoYT7RM=; b=Aw9eownGWc+1DGqxK0HkEFb0UWE4sNwnWw5ZQ5IlV/sVhmhgOtJWWIvZH4vPeqFzfs NPboVmMcGimTCF8nn3b+zkhMYmFC7PaBhEpjtvhvMxxnoYGrZ2xKpqoRXksnQI9sNlVL m/WTMqwseMyatkryaTQQaOS6/OlJUfsELavsPpQKduZv8dD/ySLBqCWazXXThfuRMD1a 7S3CBBa/cVmsmmLVnKPISqlZCvdt2CET50cFWq43mmihv47/khi7nmsJWIXPe3LGoz5o BBwb6Gi0wyDqEIPN7MoYfz9w6oMFugXg0C1sifkiBgxjpU1r28SR1kLZb4taBXo5DEeW ak9g== X-Gm-Message-State: AOJu0YzBkAtobqxMFzpSnX2BaRSIBVuX2hk7491WNOtIUHrawyh2Qrwi 8bYCtpcbjm/0c5EYjc4bCj/c3w== X-Google-Smtp-Source: AGHT+IFdemXx/VBd55p8WW6PTbADwdmABtmyFhPv5LoMpcPkl7d+s0athPBnib8Bo4DNxgkN7RrcTQ== X-Received: by 2002:a05:6000:1845:b0:32f:9ad3:860f with SMTP id c5-20020a056000184500b0032f9ad3860fmr5696667wri.52.1700492143135; Mon, 20 Nov 2023 06:55:43 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id c15-20020adfe70f000000b0032da8fb0d05sm11408245wrm.110.2023.11.20.06.55.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:55:42 -0800 (PST) From: Dan Carpenter X-Google-Original-From: Dan Carpenter Date: Mon, 20 Nov 2023 09:55:40 -0500 To: oe-kbuild@lists.linux.dev, Kairui Song , linux-mm@kvack.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper Message-ID: <918235dd-44d0-470e-aad2-5001ac947cb8@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231119194740.94101-4-ryncsn@gmail.com> X-Rspamd-Queue-Id: CDA8F40023 X-Rspam-User: X-Stat-Signature: n3tm1aihtdnwk4dswzgw1uprnza9w6bc X-Rspamd-Server: rspam01 X-HE-Tag: 1700492144-657897 X-HE-Meta: U2FsdGVkX19pJpADD6hTNjnSOaw9i29H9IVU8ic9Tib4NMj3HX/aVuz9k2/Ih6OX6ozVxogZRhnXpiGyq6wr0bdnD9EztAOklkSTmm/jT619tTVhFXD+U+SPRreXoxGKTrp47YFCiSwlTBc/UhAcQtBKXxrgLy2rQI8cBRGj4mD+EJ3rBRYwhtwPDJhmZEuWZBgBJBGGDlf2KXIkmzx/BECaWo25q3RHHhxkyeKzwbyIwDvBdaXTIbqQm4eeYVlij+MnJN3zXuxszQ9GuxQk5Ame792Qo41RtolTaxxnZvhP80t0oO0bdPrWMLS16a1kkPpMKN3eb1NLx+1Vc8ZAt3GCOoxjlH+2DW121lz/lPOaUbKNbQQ8gs3hBXUAyzjn3mqvacOwl/t7GxoKcXKsfWGqW8RBO2nQFZsZLwiA0Vtmhs8XwMyBf/QtGk7Nf+lFUcp9Mj5ZBCUDeO5SXzxOXJHnOpgSk94EF9olAcLi6ZI0Rk2ruCbiv2wH4kQCcpSFzEmq9A2et/BKQV4yPU/hbvE0aLKrIW0+ifw35chVaZ1d8X8vbElilopV45ccH8K9yP7oKUNOxbfJOESpoBDcPTTgWn4+gmMxmWGxLEWIzz2pJQhbhchgCBv0zViosLiI9/TYPkZsmIIhR4KghICPNpg5JsGT0Y7zVbIaYJdLsEsEJb37x5FaLG1RCECmmxRMT6Kr+zZZn+XaQMoHsRMGPIdr2wYvrsAsk64HFRaNwEQ/RPir1CtLB59tJ6mRHzPIe0kRzzKbvPd9mwHUzT6iLDn6gMrJ3o1pFK7NYmMIC1jmi9UwdVIk+NJpFM0LeTox3yUfkLXM6UWGvil4xRQ0csZhDtvGsBJfIRlT9/1fhPf4H6eUNLH/K/f8HLIJExHGPLtk9ZXxITm6SXGGo39u4GmJ310MNhuD81WYke9hNWs972GytXlITp783Hp68dvAtlWRfC6oeympbdLnoGq tsY6UNZM dd9aPyObKqoB88kQRXMxxk1bdJj9ti1L6kWKTrfze/NDNkv4RxRACI6pVFOjAdzIjRTn4z1itlTizzQRmMAv3GqSlvaHG8fbow41Ic17NvZHypCkVYUh05B5I8NDRqc+YJZMkJnL1HU8Cl8pblO9LfTsnvtzSpQFFH6daFTA10x+GQ33phVaY+v9bzvgWfRa/Aq/NNAigop2Xjm9zxpcWvT8rmjRT42IpN9guzuCXlPG8yysw5BQAPKAqe/pgX4N3KzzotJYyVHiT8pnKa5tivii8h8MV2tbaF+sBoUfhdFPNKNplodgufPiwyUGLRbMoYANUUiCKiObDkXlZw4BmSD0ktWYpmM63U6A8uUahqcVznamdH6x8CYffBnKlCeUE2UA4Vt92ZkbvMgy8IakNnD91it8rW55ctBfVP5ULs+QJOgxZY9ZdRYaHm+QD2wxpPxmDfQIaAGSSgaUuEF5nPhHZchgavp7KTDOHxngYObe1WSZJNbQeMsk0FFJJqItj+badLTdZDXe8KKR7pVtUWhU5WNoMnS8Mu0yOcMVWlRsofvA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-swap-fix-a-potential-undefined-behavior-issue/20231120-035926 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231119194740.94101-4-ryncsn%40gmail.com patch subject: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper config: um-randconfig-r081-20231120 (https://download.01.org/0day-ci/archive/20231120/202311201135.iG2KLShW-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce: (https://download.01.org/0day-ci/archive/20231120/202311201135.iG2KLShW-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202311201135.iG2KLShW-lkp@intel.com/ smatch warnings: mm/swap_state.c:881 swapin_no_readahead() warn: use 'gfp_mask' here instead of GFP_KERNEL? vim +/gfp_mask +881 mm/swap_state.c 19f582d2684e47 Kairui Song 2023-11-20 856 /** 19f582d2684e47 Kairui Song 2023-11-20 857 * swapin_no_readahead - swap in pages skipping swap cache and readahead 19f582d2684e47 Kairui Song 2023-11-20 858 * @entry: swap entry of this memory 19f582d2684e47 Kairui Song 2023-11-20 859 * @gfp_mask: memory allocation flags 19f582d2684e47 Kairui Song 2023-11-20 860 * @vmf: fault information 19f582d2684e47 Kairui Song 2023-11-20 861 * 19f582d2684e47 Kairui Song 2023-11-20 862 * Returns the struct page for entry and addr after the swap entry is read 19f582d2684e47 Kairui Song 2023-11-20 863 * in. 19f582d2684e47 Kairui Song 2023-11-20 864 */ 19f582d2684e47 Kairui Song 2023-11-20 865 struct page *swapin_no_readahead(swp_entry_t entry, gfp_t gfp_mask, 19f582d2684e47 Kairui Song 2023-11-20 866 struct vm_fault *vmf) 19f582d2684e47 Kairui Song 2023-11-20 867 { 19f582d2684e47 Kairui Song 2023-11-20 868 struct vm_area_struct *vma = vmf->vma; 19f582d2684e47 Kairui Song 2023-11-20 869 struct page *page = NULL; 19f582d2684e47 Kairui Song 2023-11-20 870 struct folio *folio; 19f582d2684e47 Kairui Song 2023-11-20 871 void *shadow = NULL; 19f582d2684e47 Kairui Song 2023-11-20 872 19f582d2684e47 Kairui Song 2023-11-20 873 folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0, 19f582d2684e47 Kairui Song 2023-11-20 874 vma, vmf->address, false); 19f582d2684e47 Kairui Song 2023-11-20 875 if (folio) { 19f582d2684e47 Kairui Song 2023-11-20 876 __folio_set_locked(folio); 19f582d2684e47 Kairui Song 2023-11-20 877 __folio_set_swapbacked(folio); 19f582d2684e47 Kairui Song 2023-11-20 878 19f582d2684e47 Kairui Song 2023-11-20 879 if (mem_cgroup_swapin_charge_folio(folio, 19f582d2684e47 Kairui Song 2023-11-20 880 vma->vm_mm, GFP_KERNEL, s/GFP_KERNEL/gfp_mask/? 19f582d2684e47 Kairui Song 2023-11-20 @881 entry)) { 19f582d2684e47 Kairui Song 2023-11-20 882 folio_unlock(folio); 19f582d2684e47 Kairui Song 2023-11-20 883 folio_put(folio); 19f582d2684e47 Kairui Song 2023-11-20 884 return NULL; 19f582d2684e47 Kairui Song 2023-11-20 885 } 19f582d2684e47 Kairui Song 2023-11-20 886 mem_cgroup_swapin_uncharge_swap(entry); 19f582d2684e47 Kairui Song 2023-11-20 887 19f582d2684e47 Kairui Song 2023-11-20 888 shadow = get_shadow_from_swap_cache(entry); 19f582d2684e47 Kairui Song 2023-11-20 889 if (shadow) 19f582d2684e47 Kairui Song 2023-11-20 890 workingset_refault(folio, shadow); 19f582d2684e47 Kairui Song 2023-11-20 891 19f582d2684e47 Kairui Song 2023-11-20 892 folio_add_lru(folio); 19f582d2684e47 Kairui Song 2023-11-20 893 19f582d2684e47 Kairui Song 2023-11-20 894 /* To provide entry to swap_readpage() */ 19f582d2684e47 Kairui Song 2023-11-20 895 folio->swap = entry; 19f582d2684e47 Kairui Song 2023-11-20 896 page = &folio->page; 19f582d2684e47 Kairui Song 2023-11-20 897 swap_readpage(page, true, NULL); 19f582d2684e47 Kairui Song 2023-11-20 898 folio->private = NULL; 19f582d2684e47 Kairui Song 2023-11-20 899 } 19f582d2684e47 Kairui Song 2023-11-20 900 19f582d2684e47 Kairui Song 2023-11-20 901 return page; 19f582d2684e47 Kairui Song 2023-11-20 902 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki