From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Kairui Song <ryncsn@gmail.com>,
linux-mm@kvack.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
"Huang, Ying" <ying.huang@intel.com>,
David Hildenbrand <david@redhat.com>,
Hugh Dickins <hughd@google.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@suse.com>,
linux-kernel@vger.kernel.org, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper
Date: Mon, 20 Nov 2023 09:55:40 -0500 [thread overview]
Message-ID: <918235dd-44d0-470e-aad2-5001ac947cb8@suswa.mountain> (raw)
In-Reply-To: <20231119194740.94101-4-ryncsn@gmail.com>
Hi Kairui,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-swap-fix-a-potential-undefined-behavior-issue/20231120-035926
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20231119194740.94101-4-ryncsn%40gmail.com
patch subject: [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper
config: um-randconfig-r081-20231120 (https://download.01.org/0day-ci/archive/20231120/202311201135.iG2KLShW-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231120/202311201135.iG2KLShW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311201135.iG2KLShW-lkp@intel.com/
smatch warnings:
mm/swap_state.c:881 swapin_no_readahead() warn: use 'gfp_mask' here instead of GFP_KERNEL?
vim +/gfp_mask +881 mm/swap_state.c
19f582d2684e47 Kairui Song 2023-11-20 856 /**
19f582d2684e47 Kairui Song 2023-11-20 857 * swapin_no_readahead - swap in pages skipping swap cache and readahead
19f582d2684e47 Kairui Song 2023-11-20 858 * @entry: swap entry of this memory
19f582d2684e47 Kairui Song 2023-11-20 859 * @gfp_mask: memory allocation flags
19f582d2684e47 Kairui Song 2023-11-20 860 * @vmf: fault information
19f582d2684e47 Kairui Song 2023-11-20 861 *
19f582d2684e47 Kairui Song 2023-11-20 862 * Returns the struct page for entry and addr after the swap entry is read
19f582d2684e47 Kairui Song 2023-11-20 863 * in.
19f582d2684e47 Kairui Song 2023-11-20 864 */
19f582d2684e47 Kairui Song 2023-11-20 865 struct page *swapin_no_readahead(swp_entry_t entry, gfp_t gfp_mask,
19f582d2684e47 Kairui Song 2023-11-20 866 struct vm_fault *vmf)
19f582d2684e47 Kairui Song 2023-11-20 867 {
19f582d2684e47 Kairui Song 2023-11-20 868 struct vm_area_struct *vma = vmf->vma;
19f582d2684e47 Kairui Song 2023-11-20 869 struct page *page = NULL;
19f582d2684e47 Kairui Song 2023-11-20 870 struct folio *folio;
19f582d2684e47 Kairui Song 2023-11-20 871 void *shadow = NULL;
19f582d2684e47 Kairui Song 2023-11-20 872
19f582d2684e47 Kairui Song 2023-11-20 873 folio = vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0,
19f582d2684e47 Kairui Song 2023-11-20 874 vma, vmf->address, false);
19f582d2684e47 Kairui Song 2023-11-20 875 if (folio) {
19f582d2684e47 Kairui Song 2023-11-20 876 __folio_set_locked(folio);
19f582d2684e47 Kairui Song 2023-11-20 877 __folio_set_swapbacked(folio);
19f582d2684e47 Kairui Song 2023-11-20 878
19f582d2684e47 Kairui Song 2023-11-20 879 if (mem_cgroup_swapin_charge_folio(folio,
19f582d2684e47 Kairui Song 2023-11-20 880 vma->vm_mm, GFP_KERNEL,
s/GFP_KERNEL/gfp_mask/?
19f582d2684e47 Kairui Song 2023-11-20 @881 entry)) {
19f582d2684e47 Kairui Song 2023-11-20 882 folio_unlock(folio);
19f582d2684e47 Kairui Song 2023-11-20 883 folio_put(folio);
19f582d2684e47 Kairui Song 2023-11-20 884 return NULL;
19f582d2684e47 Kairui Song 2023-11-20 885 }
19f582d2684e47 Kairui Song 2023-11-20 886 mem_cgroup_swapin_uncharge_swap(entry);
19f582d2684e47 Kairui Song 2023-11-20 887
19f582d2684e47 Kairui Song 2023-11-20 888 shadow = get_shadow_from_swap_cache(entry);
19f582d2684e47 Kairui Song 2023-11-20 889 if (shadow)
19f582d2684e47 Kairui Song 2023-11-20 890 workingset_refault(folio, shadow);
19f582d2684e47 Kairui Song 2023-11-20 891
19f582d2684e47 Kairui Song 2023-11-20 892 folio_add_lru(folio);
19f582d2684e47 Kairui Song 2023-11-20 893
19f582d2684e47 Kairui Song 2023-11-20 894 /* To provide entry to swap_readpage() */
19f582d2684e47 Kairui Song 2023-11-20 895 folio->swap = entry;
19f582d2684e47 Kairui Song 2023-11-20 896 page = &folio->page;
19f582d2684e47 Kairui Song 2023-11-20 897 swap_readpage(page, true, NULL);
19f582d2684e47 Kairui Song 2023-11-20 898 folio->private = NULL;
19f582d2684e47 Kairui Song 2023-11-20 899 }
19f582d2684e47 Kairui Song 2023-11-20 900
19f582d2684e47 Kairui Song 2023-11-20 901 return page;
19f582d2684e47 Kairui Song 2023-11-20 902 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-20 14:55 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-19 19:47 [PATCH 00/24] Swapin path refactor for optimization and bugfix Kairui Song
2023-11-19 19:47 ` [PATCH 01/24] mm/swap: fix a potential undefined behavior issue Kairui Song
2023-11-19 20:55 ` Matthew Wilcox
2023-11-20 3:35 ` Chris Li
2023-11-20 11:14 ` Kairui Song
2023-11-20 17:34 ` Chris Li
2023-11-19 19:47 ` [PATCH 02/24] mm/swapfile.c: add back some comment Kairui Song
2023-11-19 19:47 ` [PATCH 03/24] mm/swap: move no readahead swapin code to a stand alone helper Kairui Song
2023-11-19 21:00 ` Matthew Wilcox
2023-11-20 11:14 ` Kairui Song
2023-11-20 14:55 ` Dan Carpenter [this message]
2023-11-21 5:34 ` Chris Li
2023-11-22 17:33 ` Kairui Song
2023-11-19 19:47 ` [PATCH 04/24] mm/swap: avoid setting page lock bit and doing extra unlock check Kairui Song
2023-11-20 4:17 ` Chris Li
2023-11-20 11:15 ` Kairui Song
2023-11-20 17:44 ` Chris Li
2023-11-22 17:32 ` Kairui Song
2023-11-22 20:57 ` Chris Li
2023-11-24 8:14 ` Kairui Song
2023-11-24 8:37 ` Christopher Li
2023-11-19 19:47 ` [PATCH 05/24] mm/swap: move readahead policy checking into swapin_readahead Kairui Song
2023-11-21 6:15 ` Chris Li
2023-11-21 6:35 ` Kairui Song
2023-11-21 7:41 ` Chris Li
2023-11-21 8:32 ` Kairui Song
2023-11-21 15:24 ` Chris Li
2023-11-19 19:47 ` [PATCH 06/24] swap: rework swapin_no_readahead arguments Kairui Song
2023-11-20 0:20 ` kernel test robot
2023-11-21 6:44 ` Chris Li
2023-11-23 10:51 ` Kairui Song
2023-11-19 19:47 ` [PATCH 07/24] mm/swap: move swap_count to header to be shared Kairui Song
2023-11-21 6:51 ` Chris Li
2023-11-21 7:03 ` Kairui Song
2023-11-19 19:47 ` [PATCH 08/24] mm/swap: check readahead policy per entry Kairui Song
2023-11-20 6:04 ` Huang, Ying
2023-11-20 11:17 ` Kairui Song
2023-11-21 1:10 ` Huang, Ying
2023-11-21 5:20 ` Chris Li
2023-11-21 5:13 ` Chris Li
2023-11-21 7:54 ` Chris Li
2023-11-23 10:52 ` Kairui Song
2023-11-19 19:47 ` [PATCH 09/24] mm/swap: inline __swap_count Kairui Song
2023-11-20 7:41 ` Huang, Ying
2023-11-21 8:02 ` Chris Li
2023-11-19 19:47 ` [PATCH 10/24] mm/swap: remove nr_rotate_swap and related code Kairui Song
2023-11-21 15:45 ` Chris Li
2023-11-19 19:47 ` [PATCH 11/24] mm/swap: also handle swapcache lookup in swapin_readahead Kairui Song
2023-11-20 0:47 ` kernel test robot
2023-11-21 16:06 ` Chris Li
2023-11-24 8:42 ` Kairui Song
2023-11-24 9:10 ` Chris Li
2023-11-19 19:47 ` [PATCH 12/24] mm/swap: simplify arguments for swap_cache_get_folio Kairui Song
2023-11-21 16:36 ` Chris Li
2023-11-19 19:47 ` [PATCH 13/24] swap: simplify swap_cache_get_folio Kairui Song
2023-11-21 16:50 ` Chris Li
2023-11-19 19:47 ` [PATCH 14/24] mm/swap: do shadow lookup as well when doing swap cache lookup Kairui Song
2023-11-21 16:55 ` Chris Li
2023-11-19 19:47 ` [PATCH 15/24] mm/swap: avoid an duplicated swap cache lookup for SYNCHRONOUS_IO device Kairui Song
2023-11-21 17:15 ` Chris Li
2023-11-22 18:08 ` Kairui Song
2023-11-19 19:47 ` [PATCH 16/24] mm/swap: reduce scope of get_swap_device in swapin path Kairui Song
2023-11-19 21:12 ` Matthew Wilcox
2023-11-20 11:14 ` Kairui Song
2023-11-21 17:25 ` Chris Li
2023-11-22 0:36 ` Huang, Ying
2023-11-23 11:13 ` Kairui Song
2023-11-24 0:40 ` Huang, Ying
2023-11-19 19:47 ` [PATCH 17/24] mm/swap: fix false error when swapoff race with swapin Kairui Song
2023-11-19 19:47 ` [PATCH 18/24] mm/swap: introduce a helper non fault swapin Kairui Song
2023-11-20 1:07 ` kernel test robot
2023-11-22 4:40 ` Chris Li
2023-11-28 11:22 ` Kairui Song
2023-12-13 2:22 ` Chris Li
2023-11-19 19:47 ` [PATCH 19/24] shmem, swap: refactor error check on OOM or race Kairui Song
2023-11-20 7:04 ` Chris Li
2023-11-20 11:17 ` Kairui Song
2023-11-19 19:47 ` [PATCH 20/24] swap: simplify and make swap_find_cache static Kairui Song
2023-11-22 5:01 ` Chris Li
2023-11-19 19:47 ` [PATCH 21/24] swap: make swapin_readahead result checking argument mandatory Kairui Song
2023-11-22 5:15 ` Chris Li
2023-11-24 8:14 ` Kairui Song
2023-11-19 19:47 ` [PATCH 22/24] swap: make swap_cluster_readahead static Kairui Song
2023-11-22 5:20 ` Chris Li
2023-11-19 19:47 ` [PATCH 23/24] swap: fix multiple swap leak when after cgroup migrate Kairui Song
2023-11-20 7:35 ` Huang, Ying
2023-11-20 11:17 ` Kairui Song
2023-11-22 5:34 ` Chris Li
2023-11-19 19:47 ` [PATCH 24/24] mm/swap: change swapin_readahead to swapin_page_fault Kairui Song
2023-11-20 19:09 ` [PATCH 00/24] Swapin path refactor for optimization and bugfix Yosry Ahmed
2023-11-20 20:22 ` Chris Li
2023-11-22 6:46 ` Kairui Song
2023-11-22 6:43 ` Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=918235dd-44d0-470e-aad2-5001ac947cb8@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mhocko@suse.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=ryncsn@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox