From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 169B4C433EF for ; Thu, 17 Mar 2022 04:53:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 462078D0001; Thu, 17 Mar 2022 00:53:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 411566B0072; Thu, 17 Mar 2022 00:53:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D99F8D0001; Thu, 17 Mar 2022 00:53:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 1B1D56B0071 for ; Thu, 17 Mar 2022 00:53:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id DF2371211AE for ; Thu, 17 Mar 2022 04:53:00 +0000 (UTC) X-FDA: 79252658520.06.9C067EE Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf27.hostedemail.com (Postfix) with ESMTP id 73A434001B for ; Thu, 17 Mar 2022 04:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=XYhITqjVeQlf/f3mSnwwESbB4qHWGV3aRRTvRnzQdQs=; b=pGGdcaDHsyzjVZrrU+UzpWdJNu hvjK8tyYNByZ+3ybiA+ybjlaecuYesJ31VMdFS4wi5lrqBgHtQvwbIVXA+TQlwYkLOxJxiYuDMfQ6 ALs9XqY/3/fHiJiGHc7woSCZ7OkAe0Esltuo2qv/NKb9mwZ1MUNI5HY3bX9UztPay62vTyDmwyg+K 5R7dgNDRWaLDvNpxB03l4LXRI4zfPWON83PwF04bcx/GNWwZ9JwI0TP3ECyIB035GqookHgczIeQj 2s4rGJVwPjiuMwwrh2ilsdqxxGfRkJNHCpwJCYBngQ2+ZsmG8PGie7M2jzMw6GYdFOtP49Uoc9CD5 mJGubA8A==; Received: from [2601:1c0:6280:3f0::aa0b] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUi82-001mfa-Ip; Thu, 17 Mar 2022 04:52:50 +0000 Message-ID: <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> Date: Wed, 16 Mar 2022 21:52:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU) Content-Language: en-US To: Andrew Morton Cc: broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, linux-um , paulmck@kernel.org, Richard Weinberger , Johannes Berg References: <20220317004304.95F89C340E9@smtp.kernel.org> <0f622499-36e1-ea43-ddc3-a8b3bb08d34b@infradead.org> <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org> From: Randy Dunlap In-Reply-To: <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=pGGdcaDH; dmarc=none; spf=none (imf27.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=rdunlap@infradead.org X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 73A434001B X-Stat-Signature: 9xmd4taoxwqp1anbsnue7t1nfhybhbqr X-HE-Tag: 1647492779-891007 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/16/22 21:30, Andrew Morton wrote: > On Wed, 16 Mar 2022 21:21:16 -0700 Randy Dunlap wrote: > >> >> >> On 3/16/22 17:43, Andrew Morton wrote: >>> The mm-of-the-moment snapshot 2022-03-16-17-42 has been uploaded to >>> >>> https://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> https://www.ozlabs.org/~akpm/mmotm/ >>> >>> This is a snapshot of my -mm patch queue. Uploaded at random hopefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus release (5.x >>> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in >>> https://ozlabs.org/~akpm/mmotm/series >> >> >> UML for x86_64, defconfig: >> >> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0, >> from ../include/linux/compiler.h:248, >> from ../include/linux/kernel.h:20, >> from ../include/linux/cpumask.h:10, >> from ../include/linux/energy_model.h:4, >> from ../kernel/sched/fair.c:23: >> ../include/linux/psi.h: In function ‘cgroup_move_task’: >> ../include/linux/rcupdate.h:414:36: error: dereferencing pointer to incomplete type ‘struct css_set’ >> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v) >> ^~~~ > > Works For Me. I tried `make x86_64_defconfig' and `make i386_defconfig' too. > > Can you please share that .config, or debug a bit? $ make ARCH=um SUBARCH=x86_64 defconfig This fixes the build error for me when CONFIG_PSI=n. --- include/linux/psi.h | 3 +++ 1 file changed, 3 insertions(+) --- mmotm-2022-0316-1742.orig/include/linux/psi.h +++ mmotm-2022-0316-1742/include/linux/psi.h @@ -53,6 +53,9 @@ static inline int psi_cgroup_alloc(struc static inline void psi_cgroup_free(struct cgroup *cgrp) { } + +#include + static inline void cgroup_move_task(struct task_struct *p, struct css_set *to) { rcu_assign_pointer(p->cgroups, to); -- ~Randy