From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E50C83030 for ; Mon, 30 Jun 2025 20:39:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73E9C6B0096; Mon, 30 Jun 2025 16:39:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EE606B00B9; Mon, 30 Jun 2025 16:39:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DD7E6B00BA; Mon, 30 Jun 2025 16:39:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4DDC96B00B9 for ; Mon, 30 Jun 2025 16:39:44 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD6881CD0AE for ; Mon, 30 Jun 2025 20:39:43 +0000 (UTC) X-FDA: 83613233046.16.D7A3B02 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf30.hostedemail.com (Postfix) with ESMTP id 9120B80012 for ; Mon, 30 Jun 2025 20:39:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MAxpMf3b; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751315981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ko/DC/Spbot/cYFTF5zvw0BGrGoEF7EgB3/619ysaOw=; b=KIH3vkt2naOxgAfsXtDqr2am3zhb2bu7fTBzNXNDVdK6zEKf7vu29LdaFxNxmpdtGSm/Q2 uNuu5QUmuH6MEyeMRGskVeh/JU2JBv8wVeuOmcWz55cNu2wYPNZ72UQCQ4piwCFQ9xr8LN 02TDRykw9ibp9AVNTwaoOqyoOqZOnt8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751315981; a=rsa-sha256; cv=none; b=mFtKQI/QebBgUKONZWm20AwponjBSdd1RArH6nIkPmFhelCjjQDJnOK4UwalBrngZMRl2R 2jKdhOX8bPWsjNJpQsDjHnNUGsSGs3qzsZSJUc5bJ6i3heOD7SCvByzEXgvhL8f/l1PBk1 TKMITticew6E/byrBf4iJgbG34u5sCg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MAxpMf3b; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751315981; x=1782851981; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=wDFle6cS6LLazj0UeAegEB0AGKta1t1L7gnLMPRaoRQ=; b=MAxpMf3bRSxgd+2oCPxt7aDuzLDePLRs0l3bHjETEGHTaWg3cM36xb+7 GWt3yj2odJAmJtx4H0rCuWKYEoF9EkQyHy3YcMO/GzGThuWl8nrm5bBfD X/Ni/GaWoqWZDfhhRKbkvAm4ozSA6QDZVGn8fVmEg+svEUPn/zP/yNqXs ezsbJxnGpHtL1pJmuyF7PTfHyw8J4pQKzDa9RWNk0Y9RD1rBdPq1o9QUx 7HOixpwEc7t9srTQHuLuSuNPQmQbm42ZqxJhbn21imkRXmRK8VrLTmL9N 7+8xeLqPSgDvP2pnqA3jnp4XivvH316RRszEhRwkduC/MgWbR3/Oll/DL Q==; X-CSE-ConnectionGUID: KkMywAnaQL2UUfMMJI2jkA== X-CSE-MsgGUID: Kf5Zau/KQBiFHtU/8lR5Vw== X-IronPort-AV: E=McAfee;i="6800,10657,11480"; a="70986225" X-IronPort-AV: E=Sophos;i="6.16,278,1744095600"; d="scan'208";a="70986225" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2025 13:39:39 -0700 X-CSE-ConnectionGUID: YdRTeGd9QsOM7jud+94s5g== X-CSE-MsgGUID: MQ+jz3/TRVGgdj1ng3tT8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,278,1744095600"; d="scan'208";a="159073190" Received: from spandruv-mobl4.amr.corp.intel.com (HELO [10.125.109.134]) ([10.125.109.134]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2025 13:39:38 -0700 Message-ID: <9179e1cd-d635-4e70-931e-4a85c2e6932b@intel.com> Date: Mon, 30 Jun 2025 13:39:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/mm: Disable hugetlb page table sharing on non-PAE 32-bit To: Jann Horn , Dave Hansen , Andy Lutomirski , Peter Zijlstra Cc: Muchun Song , Oscar Salvador , Vitaly Chikunov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org References: <20250630-x86-2level-hugetlb-v1-1-077cd53d8255@google.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250630-x86-2level-hugetlb-v1-1-077cd53d8255@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9120B80012 X-Stat-Signature: ehyp3zeyfhbobkt47axdihenf3exf7zd X-HE-Tag: 1751315980-901282 X-HE-Meta: U2FsdGVkX19tH5LIrAKYGBDQLGDFsrPWrvCJ1KYPiKzaOPiLhAk3uaGqJnW1I5S2pEpqQTjhLd0Og2tWO2mKDEls38zqdFyF1IyOMujmP/8w64cIKWEWDv3o/WtbHU+FSHOhBVxPsSFDDN9oH+BMeG3eKfGxGCLUsWWIlGfw9xrWSsasGV/S0iKUd12IQrEcenqEPZ6gO7r46kFe3uQvgktv7wXcctOK4+NHc9audCEbx95HVrI9Diq7v4jJW1TJpa9OnVH3JxAyLg/6OnJgyypZJggXyAE2ZDhvvQ2qC54PgvGHRBf0pdxL++sqiRdqP+KxfTstAQcINqn2wv98Y+kLCOudMcV8/mV6eN4PocG987l9aOxOKPRTksb5RBl/Hl7hA47JdulI+tJgiEibLq1OEkZ30knV7Egm2w64ftWh7mZfoMs9FUexwfzEtXuilIb7gVKTte3Jbl6H5qodB33OHiW6ph97nF0Ujvet6Qr6z6YeFYqRLXkN02gUOODPd/w6bUb8OJP4U2Rf6auayox6JWXvRAGqHQMCrp8KnBHuvrYWPsMQMmMF30uKQVtk/dvFSw0hqrRjCuETqQFcVo9LEQ0hbrpU2/Cgx4TNqqeOFvmXRGyGmaxqyL1vXXyxUzxxMrERmLghZB8ma6CQfTxjLSLOxBB0ku/RsfOAGbeiBoWLEq1lz9vp9yfbNVr3h3XbjqyYRLfAH+zpmxCyokLK8q9efcCAL5OlphwEZc9dsEYKYDymOdDIlOUwVsEqpVOOzuUIdzPfA6TYXnW9bqAN63bZRlaLuLRBtDbk2ZL5i3rkjc9ES78PESC1+uHr/R5XDihY+H7M0EuaGxcMBiQQL7Vf1SVHB0m7EaS1g8Mecf5fkV3PggNVYAYbM53RgXT84Dh3VeQ5NUPxkNCpMTsTiaLj2Lk2LaoJ6w4TzWzCFx2nFqTx8tnDv5FgH8DUkCFlUw7v8xjAMOrZbSB MloEynhy eG1FFnOJ0cTmWAeAEmWqcw/oc4fw783U4/llITvBdq4IH+RfHMCTe33zNPGJPyIEpZfPUiuajGlVEEUxoSBlrFcVU7OLQo5znhY2whXu011TKhPgGwJgotAxIVbftwG5bLju+9zxAMq3/gukmAPcW43qE0E8ffyOkfQxzWfK1dd/wY9pgaJMWWFgXooCGISRqDGLjKG8FEyjtDHY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/30/25 12:07, Jann Horn wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -147,7 +147,7 @@ config X86 > select ARCH_WANTS_DYNAMIC_TASK_STRUCT > select ARCH_WANTS_NO_INSTR > select ARCH_WANT_GENERAL_HUGETLB > - select ARCH_WANT_HUGE_PMD_SHARE > + select ARCH_WANT_HUGE_PMD_SHARE if PGTABLE_LEVELS > 2 > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANT_OPTIMIZE_DAX_VMEMMAP if X86_64 > select ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP if X86_64 Does pmd sharing really even work on 32-bit? Just practically, you only ever have 3GB of address space and thus 3 possible PGDs that can be used for sharing (with the 3:1 split configured). You presumably need *some* address space for the binary to even execve(). The vdso and friends go somewhere and we normally don't let anything get mapped at 0x0. I think that leaves _maybe_ one slot. Barring something some specific and compelling actual use case, this should probably just be: select ARCH_WANT_HUGE_PMD_SHARE if X86_64