From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E8C4CFB448 for ; Mon, 7 Oct 2024 16:00:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E65AA6B0093; Mon, 7 Oct 2024 12:00:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E16046B0096; Mon, 7 Oct 2024 12:00:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDCEC6B009B; Mon, 7 Oct 2024 12:00:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AE3B06B0093 for ; Mon, 7 Oct 2024 12:00:18 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF039ACA69 for ; Mon, 7 Oct 2024 16:00:17 +0000 (UTC) X-FDA: 82647268074.11.CC56ECC Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf28.hostedemail.com (Postfix) with ESMTP id 45748C0020 for ; Mon, 7 Oct 2024 16:00:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=IsWojIfZ; spf=pass (imf28.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728316683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eExNazOhskV8Uvc8HH++Glv06Zz7Hodk6/32xJvZsWA=; b=xgkJXz40B2V2hobzjfZzs8A3EaCjJDfe/YPaBEEIxy3sPuy+6iI/Dj1rB/2Wi5QKPwPzhQ R/BCp4vqwWBQVo7GH9Mk98B0BsNezFH0pxcMNe0WouJuG02fX1wK7am4wNKrNw8mv/uiXB Yn3NDNtvHFj9WO4RtJ9b0BiEZe9oGMw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728316683; a=rsa-sha256; cv=none; b=B583JXqnLJQYiM/GiVWTf2UmEr1nQiXEGZTs4dQKOGeNoQruPlX35ZDruhHK1yq3nXmbuh FmgEwMPzFQ3Wfxa0WeA761ekuqlPFHUPaQjypd5wLAAELwl9M7Dp4ctGutnEVpqMD4pLn0 HwAEoWAshhkFHwBXORtQbpGdL3BTgW4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=IsWojIfZ; spf=pass (imf28.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1728316815; bh=eExNazOhskV8Uvc8HH++Glv06Zz7Hodk6/32xJvZsWA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IsWojIfZdzry04bEasa0qDTfAFXQo9Potsx65xsZz4dvlE1K50AZq/+g5PWXZaoUv ukUkP5mNn7XYtwkNUHkOSZNJmc2WDp4NzT3hOhuENfltqFKOdGyHC/bNrq9cXjPXWr nXJcPTBnN+rNj6wf0Ve5ywmefhYci/uZjtjI+1GY= Received: by gentwo.org (Postfix, from userid 1003) id 2F76340473; Mon, 7 Oct 2024 09:00:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 2E25340264; Mon, 7 Oct 2024 09:00:15 -0700 (PDT) Date: Mon, 7 Oct 2024 09:00:15 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Hyeonggon Yoo <42.hyeyoo@gmail.com> cc: Vlastimil Babka , "yuan.gao" , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/slub: Avoid list corruption when removing a slab from the full list In-Reply-To: Message-ID: <916bea8e-0e79-c561-f8e8-b3c7fa026161@gentwo.org> References: <20241007091850.16959-1-yuan.gao@ucloud.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 45748C0020 X-Stat-Signature: tgkpipgoj3wioe3edzgeu4pfprqr3jof X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1728316816-586758 X-HE-Meta: U2FsdGVkX1+xDmm2mxjCMRWi3tQACCcNPlVxz+RlxAz+J8Egvum6opWdntJ59ya0aRTsiAaWFZlJNhKLMCKJ5vep28+JYPBB/KyycDdGPMM4Bc1MSLVhFl8hNQAT5f78HPI9hSpViznP47ByiRBojAD6cX2JCB2rK4JyyPrMOkAeszcx/SifAEuVQoHBmovgBnksrNmzrHMIT+Zj8CZZwXnZC41JQoAG7Opa5r/hGgSYpHgidUN//58TjXFwzIV509X6KX7kQi22GQkU9yNclU5dcX8HenaehpTYjBgCLMD2d+e62yKZd+knUdBLfJTfYHkWhy6/nzPDFp+EQf3Kq5qKd1uBDtxlCkdXYsu+u+IFYrX7QY+XhZSxFLtq1q1PwlxfFbDcf9d9ALogWjFew8eiKqHPfRalUEjbCKggk6vImP6+cRxO8SiYwIO/mPVMk/wJ7T9dsVYHXUbaLHsMu/wYJypfBqW23g4h+kAt/L1iN4NLXqPIH1IhylES53B0fyOyIXxsWYQjQAOrgakyAag4UlZ19+/2CUjqYUIB0owhRidFdBhTdmGl/tXr2TzXYmx7bvT6glyAEAYxj6depmOGijYBuYxhO04dFGnVWueG3jlRbbgQQSEZE7ubupbvmk+bnLWO11EttXiiB5LGW4YadSFX3kMUfR05fcydZBxZuFwnW9RU82fve8h2LoJa6eeunUzrRLFGjx/AodECCk+0WyE0NlxH8lBwKPGC8BueIXv+tq3bW4n0khFA/20Bv1eTzN51nKnag7wUrtoQUeIXexx9iTyIIqyfs57sHWC3uWHZBcL4dMHuTCXaNOOM/b8u3tYlkdF/QmH+RwvPoDcZ0cJxtBpHpURSOhpqYCihfROFuu0IcmLgjhCCiZLv847ds3vsZ2+9p+n12v/Rss+aMqvS2O4ZXZ/me6cCRkVntVDiGIw/vYDiixFO77iELAqgLo83D9AqrfA8apu 6SYvl5hR YJfyvrOyBbk5GMNqIPhuyEabnLh9BUOAc99Ffj8/D9n9dQvlCrHhcfH/1VB87PtKEdX0Bz89pMXp19RLri6JwhydWHU9YRmSEW+Sbit8CNEAZTf8POiFn9orx3HhnD+wDAfyaK0Y0nEslP7Yi9AP+tNk5bYaE7NrgpE5bs8FzGpPq6UDKEyYcLNcIJ4/7DwNs3B7JE386o2llI2zKv0m7q4W4PVTIJe+QRWhgXWDThYwhkkXb7TeHmzPhqBGHmVbKMzUvNy4QhlTPFzKBbaeqUCNbLEs4ihxQ4gZpyPtKncmWmFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 8 Oct 2024, Hyeonggon Yoo wrote: > > Is it possible to determine which commit introduced this issue, for a > > stable cc? > > By code inspection I suspect it's around when SLUB's first introduced in 2007, > more specifically commit 643b113849d8 ("slub: enable tracking of full slabs"). > Even v2.6 kernels do not seem to handle this case correctly. Yes this is an error that was there in the beginning. Its a rare condition that only occurs when debugging is enabled so its difficult to trigger IRL. > > Also in addition to what Hyeonggon proposed, we should perhaps mark > > these consistency-failed slabs in a way that further freeing of objects > > in them will also don't actually free anything, and thus not move the > > slab back from full to partial list for further reuse. > > Yeah I was thinking of that too. > Right. Stop any processing on the slab page with metadata corruption.