From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E19C4320A for ; Tue, 31 Aug 2021 08:54:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EC0046101C for ; Tue, 31 Aug 2021 08:54:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC0046101C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=natalenko.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 81DD98D0001; Tue, 31 Aug 2021 04:54:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CD9F6B0072; Tue, 31 Aug 2021 04:54:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BAF68D0001; Tue, 31 Aug 2021 04:54:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 5F33F6B0071 for ; Tue, 31 Aug 2021 04:54:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 17E331802EC31 for ; Tue, 31 Aug 2021 08:54:32 +0000 (UTC) X-FDA: 78534764784.01.9A497D4 Received: from vulcan.natalenko.name (vulcan.natalenko.name [104.207.131.136]) by imf26.hostedemail.com (Postfix) with ESMTP id 5BA8A20019C0 for ; Tue, 31 Aug 2021 08:54:30 +0000 (UTC) Received: from spock.localnet (unknown [151.237.229.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vulcan.natalenko.name (Postfix) with ESMTPSA id 51D49BC4F2F; Tue, 31 Aug 2021 10:54:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=natalenko.name; s=dkim-20170712; t=1630400066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+HEGSe2ebXbBVDzslGRlT9ConeGmSo+zB76IgfFO5a8=; b=Jc0kkFdHTyeEuAAHC+pULbrOXwbhq/7J0KOb5SeUSFtbv9x6/0JyeyCWYb1Mr/vMHaGqjT cEjB5MRsf0KYRpRCKdDD2WWGI0W1k8ituYxTtgsWHQiRj4lmYsbvvtu+UQCJuV+uycHWf8 WrvN6HdSF0LkCBFbz7sAnrhRSGqdM2w= From: Oleksandr Natalenko To: akpm@linux-foundation.org, Miaohe Lin Cc: vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linmiaohe@huawei.com Subject: Re: [PATCH 2/6] mm/page_alloc.c: simplify the code by using macro K() Date: Tue, 31 Aug 2021 10:54:24 +0200 Message-ID: <9161665.bUqNH3lxUD@natalenko.name> In-Reply-To: <20210830141051.64090-3-linmiaohe@huawei.com> References: <20210830141051.64090-1-linmiaohe@huawei.com> <20210830141051.64090-3-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=natalenko.name header.s=dkim-20170712 header.b=Jc0kkFdH; spf=pass (imf26.hostedemail.com: domain of oleksandr@natalenko.name designates 104.207.131.136 as permitted sender) smtp.mailfrom=oleksandr@natalenko.name; dmarc=pass (policy=reject) header.from=natalenko.name X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5BA8A20019C0 X-Stat-Signature: dpg7f6zy6tqj4ajuwj3qfq3dhkgz3bzq X-HE-Tag: 1630400070-734922 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello. On pond=C4=9Bl=C3=AD 30. srpna 2021 16:10:47 CEST Miaohe Lin wrote: > Use helper macro K() to convert the pages to the corresponding size. > Minor readability improvement. >=20 > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index dbb3338d9287..d3983244f56f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8134,8 +8134,7 @@ unsigned long free_reserved_area(void *start, void > *end, int poison, const char } >=20 > if (pages && s) > - pr_info("Freeing %s memory: %ldK\n", > - s, pages << (PAGE_SHIFT - 10)); > + pr_info("Freeing %s memory: %ldK\n", s, K(pages)); >=20 > return pages; > } > @@ -8180,14 +8179,13 @@ void __init mem_init_print_info(void) > ", %luK highmem" > #endif > ")\n", > - nr_free_pages() << (PAGE_SHIFT - 10), > - physpages << (PAGE_SHIFT - 10), > + K(nr_free_pages()), K(physpages), > codesize >> 10, datasize >> 10, rosize >> 10, > (init_data_size + init_code_size) >> 10, bss_size >> 10, > - (physpages - totalram_pages() - totalcma_pages) << (PAGE_SHIFT=20 =2D 10), > - totalcma_pages << (PAGE_SHIFT - 10) > + K(physpages - totalram_pages() - totalcma_pages), > + K(totalcma_pages) > #ifdef CONFIG_HIGHMEM > - , totalhigh_pages() << (PAGE_SHIFT - 10) > + , K(totalhigh_pages()) > #endif > ); > } (my concern is not quite within the scope of this submission, but I'll ask= =20 anyway) Given we have this: ``` git grep '#define K(x)' v5.14 v5.14:drivers/base/node.c:#define K(x) ((x) << (PAGE_SHIFT - 10)) v5.14:drivers/net/hamradio/scc.c:#define K(x) kiss->x v5.14:kernel/debug/kdb/kdb_main.c:#define K(x) ((x) << (PAGE_SHIFT - 10)) v5.14:mm/backing-dev.c:#define K(x) ((x) << (PAGE_SHIFT - 10)) v5.14:mm/memcontrol.c:#define K(x) ((x) << (PAGE_SHIFT-10)) v5.14:mm/oom_kill.c:#define K(x) ((x) << (PAGE_SHIFT-10)) v5.14:mm/page_alloc.c:#define K(x) ((x) << (PAGE_SHIFT-10)) ``` Shouldn't this macro go to some header file instead to get rid of define=20 repetitions? Thanks. =2D-=20 Oleksandr Natalenko (post-factum)