From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C44D6DDEA for ; Fri, 15 Nov 2024 10:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0F536B008C; Fri, 15 Nov 2024 05:05:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0AB6B0092; Fri, 15 Nov 2024 05:05:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 838D86B0093; Fri, 15 Nov 2024 05:05:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 636EA6B008C for ; Fri, 15 Nov 2024 05:05:10 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D85BC1415A2 for ; Fri, 15 Nov 2024 10:05:09 +0000 (UTC) X-FDA: 82787894280.08.183B879 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 45DE91C000E for ; Fri, 15 Nov 2024 10:04:47 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Go9HeyQD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731664928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1kAKAvwdmdjiltkVd6qbqhCfl7VUxLedhiq8NASCwc=; b=DuAeNHh0FcGL+b6xhIv+Q8fDVSJvmvL4qKgRfICySSKmZFUJeF9Y3tnXng9K6DTwoJWc7C AWY993xZMMUvRrdNbIYCTxspcJzvWuq3kQBlHaBmfEvMRREG2Bv4NLJVm/28Hs6AIgYR/t h0Froi8aaIptWE26c5QOs1i+pQmxTJw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Go9HeyQD; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731664928; a=rsa-sha256; cv=none; b=vrra+ixb2ioPLUCBuqpX2ZrKQRAZ/DZHcYWOEpEegPWYGgCeBXNktyP16EjfebOoQ9AoEo tDrIdX51HODR1xWYVivVMiveie+DB83lj6Oib4VYuvM9LxOy+Q5O05mAX8Oo379SxBiA0u ctRNAysem43k0/PpokvLeR5D6a3NcT0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731665106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g1kAKAvwdmdjiltkVd6qbqhCfl7VUxLedhiq8NASCwc=; b=Go9HeyQDaeeUacwm2Xhgg8YTmpyNJVvU7/Zzjmbt2SAXARQcOu37GJRpjJAVWyR0KWU6M3 N0jtvQm0XAb0vXdGO33b2BANCcJi+/7a9MxGUReHwBwS0cDtpTfCozLcfNuNid6o0GBsKi ru5R494tunnWuhlEKF3b5OxgaDhYGxg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-V83I-muGPAmFSv-CDzGXNA-1; Fri, 15 Nov 2024 05:05:02 -0500 X-MC-Unique: V83I-muGPAmFSv-CDzGXNA-1 X-Mimecast-MFC-AGG-ID: V83I-muGPAmFSv-CDzGXNA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4315cefda02so3861595e9.0 for ; Fri, 15 Nov 2024 02:05:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731665101; x=1732269901; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=g1kAKAvwdmdjiltkVd6qbqhCfl7VUxLedhiq8NASCwc=; b=sLWaRb6pQkSY6XP31SE5cEJdKouSIRvhu/GMV8JZWADCDlqbUCM6OcVR7MsUTTWoUP R4VSNm1sHtpI2ACVjbS0rBt1sUXuO5C9tbE5H/EvbuVFRAk4kg5pG7iFyci1vyzLExMB eISL5Vdqd+5gRlSeSxIdAn91fkg6EwcTMI5VJA7u7J+D0YKZxVxnBHi1btCfz80hSnL4 4CE9ASfcaaHvQE/4/KgX+LcZ+aw5fW2qTHHQZWok69lnZkJsR1wAhkozWQm8lGxpf2AH HNu6O4979z9TWaGDpeER9eTS1TIEEBqF+eTgy53g60xkZl9avfB8Ieso4Zrg11ivYxHD YS7A== X-Forwarded-Encrypted: i=1; AJvYcCU1eRDsUyeb7aWDlyykquSqlGPDhUatg/GYGg8Gx3mNAf0UX33pUh3I1QkCqF3ateahPXKWJy1aNw==@kvack.org X-Gm-Message-State: AOJu0Yyoj9IER+KJwePG0GXYhoBwAN4h0PrQN2FUh8+zNl9Nczplr1aE N/OGKlH9kUuze8JdEdaOPRH6msK6q3ZS7A73vg25zaY+rnRw84/yGUfAfCFcHBO5W6X9mveQidS LIvrPGNZwRLM27nZpAYnxOitZG+7nMWVLPvIl4+mSUEc844uv X-Received: by 2002:a05:600c:3b2a:b0:431:6153:a246 with SMTP id 5b1f17b1804b1-432df726227mr16479715e9.13.1731665101489; Fri, 15 Nov 2024 02:05:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IEEz5+u3ZRZYo78oPclwnT1nZIiEdnYHBaxqmzIQBER+J7j/3O0koftmeu3voXxmbcw6vb7sQ== X-Received: by 2002:a05:600c:3b2a:b0:431:6153:a246 with SMTP id 5b1f17b1804b1-432df726227mr16479215e9.13.1731665101094; Fri, 15 Nov 2024 02:05:01 -0800 (PST) Received: from ?IPV6:2003:cb:c721:8100:177e:1983:5478:64ec? (p200300cbc7218100177e1983547864ec.dip0.t-ipconnect.de. [2003:cb:c721:8100:177e:1983:5478:64ec]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432da2444e7sm53797785e9.4.2024.11.15.02.04.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Nov 2024 02:04:59 -0800 (PST) Message-ID: <9160c6b4-f8a0-431d-8a21-ead510a887a1@redhat.com> Date: Fri, 15 Nov 2024 11:04:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: S-RhYJq55xBmmlFif6e7mkMuzoJL6NxbJbmTTLz9604_1731665101 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 45DE91C000E X-Stat-Signature: g3xbhdmokzwi3zwdby1dutyws1u5ufwf X-Rspam-User: X-HE-Tag: 1731665087-889664 X-HE-Meta: U2FsdGVkX18deD8wNgL+6QAk7FvHK/mz0LpFtuUMMenKp55W+0zeNoy3XTD7u7NzhcuHzNSVSTLGIdLwdfrHqMNtsjCdrUwElm/FMetrR/MTAQLG5SiMP+QQc8+vMZaxzYeD03RMHoXFfeQ9bPT3o26aaZXDmZ7lXbzXs/6GPGGt6gNhfDLXNUo3I2AsYHvE5QPE4EbE+4vDQWLcaYqjIaG9MVEwK/wga0mOHOYZqRi2NRo36ZypTw4+W5hIlUC4r2j6ZtBiyV/CHYuzTysJvm9EYeXJmMnNxfQGhUJUigRXkCZfJTsmiQNiDCUDwMk+ngIcrHaDtb53tJqbjhalHkhlG5T6P2rQ+qHHa/z8DtltZTgz8FTL/lj4jxz/HhS0m3xvwa2EBM30ADavM/gAFBavJ9oLgKjumgfUbIUX4HJJwDm5xae7M+gpKkqrVtFvCL2WplFm3Jr1tgoknrbZX0hqtvdtQI6IFvcG8NP4bscR2brPvnL0A8nA47v6xWGCcEP3FiQ4Zmt9l2+Ve2LoKkBHpm+UM5idlL5FhK4/CxS6MxND9py1zpxOFiCnrnFfvtwWCM/R6+qmpsIUnHqCSszX9eTZqZ75gEASBT60U5VdWmEABlGmT8L+sS1VRv4IaF5HfctQtlJFLHT94PssnkNxPRVXytGyEczAtEd/E5QhOuia4C8hAgKeEPZaHCLMbxFuR7m0VqmdzZhjKVFc5pztMOwDfcWcnPeuJqfYO1ICTWF9/5VjKTk9knMQNLvyBV9rKWiNZ7FAdoGQ43mWG9Wt1Tut1Fi6tq/p2sXd2vtKg5Qlnh0BtPZss9iUGfiVSjbHJpmsB+ZS4bgwstoeGULwe0IrNHgF/TQ1cQbM1mac2IzYSpuX5H+9VXKlGQE1jIXF6sB0NrMa6nDWqjbeLwiUbHZHH8tDSFDXNmP620OBSZrw7GSCfvv+WlrliQ1bUN3gZYpDe9+BShd7riM 0HBpc7SI geprmPzcYVLW0EXX+wJlmTfrsEi44l682HyKNGzlHNJWz9+ULkgWCVOmRYDFM1bY9/vSU5p3O5WdRvcA97CXKz1kL6DSsiKSvdLZPaWKdoeUUWMdvkDZYCbojdbw2+k9kIxW1AXPLf9QAtix/7nV3dc5UuKXhRhMFCItnCHIVgwrJLskbLEPhdLSBLp1fYlWOAeDi1TnRtC3EDPQi57TYylugDI/VibDimIoEdIdRrlPpRE38eRm1LlFn8Puw+tOkh+WMiMffh/FFaWfskmgpLlE0E8tC2TTMTnUK7GBXLmOYYmbUbvmsPKHyVj69gw2QXfgWEeN6PuLQ0FomvbLISxloTUFwK1bhJJUfTGkz7bH0Kv2446CpVsuAkAJqsvo7asuZrDFiQRq/cNFEuSzElWfKhxxU8tZIJpZUTaRkiaorTj119wQxzgkp59d6unDq39bz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000070, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.11.24 10:32, Baoquan He wrote: > On 10/25/24 at 05:11pm, David Hildenbrand wrote: >> Let's use our new mutex instead. > > Is there reason vmcoredd_mutex need be replaced and integrated with the > vmcore_mutex? Is it the reason the concurrent opening of vmcore could > happen with the old vmcoredd_mutex? Yes, see the next patch in this series. But I consider this valuable on its own: there is no need to have two mutexes. I can make that clearer in the patch description. -- Cheers, David / dhildenb