From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75ADEC02182 for ; Fri, 24 Jan 2025 02:43:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA4B28002D; Thu, 23 Jan 2025 21:43:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B79AA28002A; Thu, 23 Jan 2025 21:43:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A40F328002D; Thu, 23 Jan 2025 21:43:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8649F28002A for ; Thu, 23 Jan 2025 21:43:50 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 322D21C7E48 for ; Fri, 24 Jan 2025 02:43:50 +0000 (UTC) X-FDA: 83040800220.13.52DC6D1 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf13.hostedemail.com (Postfix) with ESMTP id 29F9120004 for ; Fri, 24 Jan 2025 02:43:45 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WHVtA9zr; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737686627; a=rsa-sha256; cv=none; b=NAs5nk8T2EAc9SLVg1WSTIWWBi3i6t5YDfLU/pIiBNgdB/maHaPXWEdecdZ5tQWIFKS+4g eJT4Ii10Gn3MQjB1pnXUCnkGlAQV02OM+tXibiRo+2HyCoWMbc5cKvXlED8nvF5T67RUC1 QDDQoPbR48/mJauvMg53TEFSH9dm/+o= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=WHVtA9zr; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737686627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aAEVMfSL85K0Fb818rr6S6+agwwVsO1oxeV+co+SL/A=; b=zdnDb00t7qxB5sdJoXoqxz1alzSqbybG+OdIM7z8nLyUBWkfU6QjNVyt1XTaSsxtIQ0Lii NAZ2dhj/B2NAFQHuxMPqm/x8nTlcRsoDnyEBllGNJ7YhSecpLqFu07fJeZ3Opb1nxkyff2 nuDfnYSSlCIEoNJKXpXgoMtMuUlXKb0= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2167141dfa1so30283525ad.1 for ; Thu, 23 Jan 2025 18:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1737686624; x=1738291424; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aAEVMfSL85K0Fb818rr6S6+agwwVsO1oxeV+co+SL/A=; b=WHVtA9zrIOKohKXnbRC4VF5V1XAxB9XiH3NuPeJ8TTlWP7YV5JmCPiDop4G/fMpS/1 w6e6aglYTT765qExvGEgXfxCfzABOZ97EIqTyPP3uHBr0im13UvBSaExRr1rhKDwxhkX 2vTYxaVw0C8SjMOptit8N5hy5vPT5dfyuNldkTTKEMjMRE3Xx5n2lmfHSDvPQApVnTjR ++6VLIXN89kBu7fasVvCeKB6zHhXR8pYGfrkjVfdhVqCV0yAPRNej6Q7Mb1YI4wqHSEx zM3lheKRiA9Z4R4cfWqu7hWecUOE0rIY3zdHiru0RD+9RMkOoBfNyT9FLg67q9KqEcBh YR6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737686624; x=1738291424; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aAEVMfSL85K0Fb818rr6S6+agwwVsO1oxeV+co+SL/A=; b=tzYcwDQo4+96dm6BlJWr8FfOINx10KovIILe14Rq3Dwcj0FJlJmyqr0vCB4nH9j4Vh mmahS+qZt5j77viaEAa9vFSy6Z7z+LMSP/tC+JGxSx47Z4aT8QD9Rv0KVRxqV04SLvMX SC7M303Lv0mwpNwpASKI7mz2Sqf7Fd3b9qBZ3qZKTPzlTBfeL8nYRazJw5YByHnjc9dI u+vi0lximRIdGXEzsKP+IjYApXuZ0ULkAtCLur3rG03dRpSVhTUf8ywroq0i+PMUrUoS 9NRoGbFTqSMsqECcBxtVdG8bkZiCpbVeji0ZIQdZrOwQEOsH2ir+ev9sHiyUnPNM4/wy JCsg== X-Forwarded-Encrypted: i=1; AJvYcCUbHr4lI8VEg1MAZJGS12BY4LZt/plSj9lg543hGABCcvMXU5lAe8Hu8kBZp2HC53T+3mCBvyJlFA==@kvack.org X-Gm-Message-State: AOJu0YzKnlr9JCQqn9sxXuyIkMcGrf2bPAPNjkAJxEOmVEoLSbhK7V7g qW/v4+c/eFFmnPCklMUgO79i4BxY66fzfMpLzCvDYF3yobUEMOI+mLGGyyUC/EU= X-Gm-Gg: ASbGnct3/V0y7IkgjfS3A9XVzMSDDWFqY+14/yzH4si3mOMFVnACOYEG7yHdDI/UI2B DJ4TGJkw2MMIXifG3E9sBz3sLy4XWGeiTLPJsSuflvHa9akZVXIT4yWgSDLlMN20Sa5HdeQe7Ye KZQBhTvM0Xj9XXP2DVhdAcLT0lIdt3PKthY0UKeJJy3loyvjOCNYvFBj9UJoIZyTmrZS0I6lh00 iuLuZELGR0vf3tTCVZdDJ95DknzIkGJ8J8ARVNFHbI/w7iizhkMHWNNpYQOMiQI22N80gzOnug4 SSX6NQQecRI1/zWG1RvsCH6HIqZkTA== X-Google-Smtp-Source: AGHT+IHTWa6ZCDsSKDB8q4F0CTBJysKJhjEmOkLroQcS07omC9+DalweP+QvYBIrAKMtnEtGr9eVNQ== X-Received: by 2002:a17:903:228f:b0:216:33f0:58d5 with SMTP id d9443c01a7336-21da4a9ddc2mr25531815ad.17.1737686624071; Thu, 23 Jan 2025 18:43:44 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da424f368sm5862405ad.257.2025.01.23.18.43.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 18:43:43 -0800 (PST) Message-ID: <915e19a9-204c-4a22-b132-6ae5fac3e270@bytedance.com> Date: Fri, 24 Jan 2025 10:43:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390/mm: Add missing ctor/dtor on page table upgrade To: Alexander Gordeev Cc: Kevin Brodsky , Gerald Schaefer , Heiko Carstens , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton References: <20250123160349.200154-1-agordeev@linux.ibm.com> Content-Language: en-US From: Qi Zheng In-Reply-To: <20250123160349.200154-1-agordeev@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 29F9120004 X-Stat-Signature: se3t8hogopi9boiyqgei9hcme5sihxgc X-HE-Tag: 1737686625-830667 X-HE-Meta: U2FsdGVkX19D5Jxtu5XHOca4A6vY/Od9Rlfnb59QFizerAexVS7677GCqRYmkpvYfNUu82K0wNDrln0xsQZ2B+lOBMaz2fC6fi6IxW+9jXpPLgJdnikiseqZSaJSqaVKmFcL4MCPw/kACAES2wvCbADsOochZFEpjKKCn9SyIArvATZWyXowZzSiQ/EmLeZg5PAGeIZ7eEDBzPM069R9o+d7JqRIZcQK2K9lwVKFuLSWCDpNJHDvQkKwUS7spigjIj0WqkoBTbEvjDeG6s455ZYx3SWwqxz2HDtGJi6zexyn6WqcDXH7X6VpZKcZT/TYTflB/vLS7scTwj5rnZfPeO/xydK04iQGjckPbImjI8FKihno2ZZK/QqqQv0hFF2A0VkxOeVsvKUyckUQ7+KBTsblMSBTGLbel6PSiTCiRDdCXK+7u2J1F/22o4njWx5MKoyIo2OyAdANjwDEzX611lL/H3alSkhqAT6RWRbxL++aAuOGVq8KFufmmqpVQqhV9PSIR3EFGH20tuA8vVta0EmP9m0r9FJF/5jzuJ3fwB4MgWMEsLTQ7nnIJdKkW+JQSIV+dt5HJyfAKyrG0+QycMTJowYIdmngkKjfGA8drgjxPQjLr5tfeyG/j4MZdCeUsarI5atmruXhcqNrrCtb/FtD8TOhABAkls4xTBb7M4MW8U6ouCDhqKRQyK1akU12r5JNeAVguJTDtYkQDmRHnN6RF9QeLyhvjWDVVU8OMnCv5TDU3VxToSuBQBLvftrTvd4pJXzv2MalZ8PkDX2HI4SSg+vkV2ZHd3aIl8GPJsSKBeYF0ATA4Upm7z67jeN43X9tgTb8f4tcKokjIjBirbGCvY0ffhlpg8Hh7t4xOGZZUBleZJt7szzDt6iH5loweQYea/BKYFGeh13zhV4A+Jdi0T24Y5mJb9KWggIgETXyRi6JeEBZXq+8ThWzPKuS0b8vop51RxLsUlRos2h TYzGk9kX RyzZ6n9Hm7v1Y9I2iAKHeoS3DxxLTN4sNU2ZaOAWFc0YM9Hfyw8SZFdfjIJ3gFOqW0fd2tREZBvEjSjL1feChlAIWBgYCAwdtl1c0Rqco5eJF9UzPq5IsHvbpJ+tB7AthDpNRib0M/tYFd1LkPfRr/KE2IW8V6fQDceAs2ymmpFssuAxZx/IrpyVrkV1KscF67QVgslNih1mOZlapgQUAFe5pWFIMUyatuvzWT70Qy7axgh+z4SEt5CcRVF2C5VRjcCv8+OxQKwUmBlKiDE89B88Bt00+bte91Cu9qP6SNNFlXo8d29Uvab0/tblw5GTscgxHm4UdKRZ+jO96tnG33MP4bFPS3u6uHynkpCjmmcF1eGSPoSi/8ZgGWUNm33vzVIhbV56dSUJE/flo3I88rg//5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/24 00:03, Alexander Gordeev wrote: > Commit 78966b550289 ("s390: pgtable: add statistics for PUD and P4D > level page table") misses the call to pagetable_p4d_ctor() against > a newly allocated P4D table in crst_table_upgrade(); > > Commit 68c601de75d8 ("mm: introduce ctor/dtor at PGD level") misses > the call to pagetable_pgd_ctor() against a newly allocated PGD and > the call to pagetable_dtor() against a newly allocated P4D that is > about to be freed on crst_table_upgrade() PGD upgrade fail path. > > The missed constructors and destructor break (at least) the page > table accounting when a process memory space is upgraded. > > Reported-by: Heiko Carstens > Closes: https://lore.kernel.org/all/20250122074954.8685-A-hca@linux.ibm.com/ > Suggested-by: Heiko Carstens > Fixes: 78966b550289 ("s390: pgtable: add statistics for PUD and P4D level page table") > Fixes: 68c601de75d8 ("mm: introduce ctor/dtor at PGD level") > Signed-off-by: Alexander Gordeev > --- > The patch is against: > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git next-20250123 > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-stable > --- > arch/s390/mm/pgalloc.c | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Qi Zheng Thanks!