* [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
@ 2025-12-26 6:38 Weilin Tong
2025-12-26 6:52 ` Barry Song
0 siblings, 1 reply; 6+ messages in thread
From: Weilin Tong @ 2025-12-26 6:38 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon
Cc: linux-arm-kernel, linux-kernel, Andrew Morton, David Hildenbrand,
linux-mm, baolin.wang, Weilin Tong
Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
large folios requiring swapping also exist in other page size configurations
(e.g. 64K). Without this config, large folios in these kernels cannot be swapped
out.
Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
Signed-off-by: Weilin Tong <tongweilin@linux.alibaba.com>
---
arch/arm64/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 93173f0a09c7..58f7b4405f81 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -120,7 +120,7 @@ config ARM64
select ARCH_WANT_LD_ORPHAN_WARN
select ARCH_WANTS_EXECMEM_LATE
select ARCH_WANTS_NO_INSTR
- select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
+ select ARCH_WANTS_THP_SWAP
select ARCH_HAS_UBSAN
select ARM_AMBA
select ARM_ARCH_TIMER
--
2.43.7
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
2025-12-26 6:38 [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes Weilin Tong
@ 2025-12-26 6:52 ` Barry Song
2025-12-26 8:18 ` Weilin Tong
2025-12-26 8:31 ` Weilin Tong
0 siblings, 2 replies; 6+ messages in thread
From: Barry Song @ 2025-12-26 6:52 UTC (permalink / raw)
To: Weilin Tong
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Andrew Morton, David Hildenbrand, linux-mm, baolin.wang
On Fri, Dec 26, 2025 at 7:39 PM Weilin Tong
<tongweilin@linux.alibaba.com> wrote:
>
> Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
> large folios requiring swapping also exist in other page size configurations
> (e.g. 64K). Without this config, large folios in these kernels cannot be swapped
> out.
>
> Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
I no longer recall why this was not enabled for sizes other than
4 KB in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64"), but
it appears to be fine, and the swap cluster size should also be
more friendly to PMD alignment.
#ifdef CONFIG_THP_SWAP
#define SWAPFILE_CLUSTER HPAGE_PMD_NR
#define swap_entry_order(order) (order)
#else
#define SWAPFILE_CLUSTER 256
#define swap_entry_order(order) 0
#endif
>
> Signed-off-by: Weilin Tong <tongweilin@linux.alibaba.com>
> ---
> arch/arm64/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 93173f0a09c7..58f7b4405f81 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -120,7 +120,7 @@ config ARM64
> select ARCH_WANT_LD_ORPHAN_WARN
> select ARCH_WANTS_EXECMEM_LATE
> select ARCH_WANTS_NO_INSTR
> - select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
> + select ARCH_WANTS_THP_SWAP
> select ARCH_HAS_UBSAN
> select ARM_AMBA
> select ARM_ARCH_TIMER
> --
> 2.43.7
Thanks
Barry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
2025-12-26 6:52 ` Barry Song
@ 2025-12-26 8:18 ` Weilin Tong
2025-12-26 8:31 ` Barry Song
2025-12-26 8:31 ` Weilin Tong
1 sibling, 1 reply; 6+ messages in thread
From: Weilin Tong @ 2025-12-26 8:18 UTC (permalink / raw)
To: Barry Song
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Andrew Morton, David Hildenbrand, linux-mm, baolin.wang
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
在 2025/12/26 14:52, Barry Song 写道:
> On Fri, Dec 26, 2025 at 7:39 PM Weilin Tong
> <tongweilin@linux.alibaba.com> wrote:
>> Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
>> large folios requiring swapping also exist in other page size configurations
>> (e.g. 64K). Without this config, large folios in these kernels cannot be swapped
>> out.
>>
>> Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
> I no longer recall why this was not enabled for sizes other than
> 4 KB in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64"), but
> it appears to be fine, and the swap cluster size should also be
> more friendly to PMD alignment.
>
>
> #ifdef CONFIG_THP_SWAP
> #define SWAPFILE_CLUSTER HPAGE_PMD_NR
> #define swap_entry_order(order) (order)
> #else
> #define SWAPFILE_CLUSTER 256
> #define swap_entry_order(order) 0
> #endif
>
Thank you very much for taking the time to review this patch during the holiday. Wishing you a happy holiday as well!
I appreciate you pointing out this optimization.
We initially noticed the issue because, on ARM64 kernels with 64K page size,
if large folios are used in shmem, they cannot be swapped out as a whole during shmem_writeout()
due to the config limitation,
and are forced to split instead—which is something we wanted to avoid.
It seems that this change will help enable better swap operations for large folios. Thank you again for your feedback!
>> Signed-off-by: Weilin Tong<tongweilin@linux.alibaba.com>
>> ---
>> arch/arm64/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 93173f0a09c7..58f7b4405f81 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -120,7 +120,7 @@ config ARM64
>> select ARCH_WANT_LD_ORPHAN_WARN
>> select ARCH_WANTS_EXECMEM_LATE
>> select ARCH_WANTS_NO_INSTR
>> - select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
>> + select ARCH_WANTS_THP_SWAP
>> select ARCH_HAS_UBSAN
>> select ARM_AMBA
>> select ARM_ARCH_TIMER
>> --
>> 2.43.7
> Thanks
> Barry
[-- Attachment #2: Type: text/html, Size: 4722 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
2025-12-26 8:18 ` Weilin Tong
@ 2025-12-26 8:31 ` Barry Song
2025-12-26 8:40 ` Weilin Tong
0 siblings, 1 reply; 6+ messages in thread
From: Barry Song @ 2025-12-26 8:31 UTC (permalink / raw)
To: Weilin Tong
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Andrew Morton, David Hildenbrand, linux-mm, baolin.wang
On Fri, Dec 26, 2025 at 9:18 PM Weilin Tong
<tongweilin@linux.alibaba.com> wrote:
>
>
> 在 2025/12/26 14:52, Barry Song 写道:
>
> On Fri, Dec 26, 2025 at 7:39 PM Weilin Tong
> <tongweilin@linux.alibaba.com> wrote:
>
> Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
> large folios requiring swapping also exist in other page size configurations
> (e.g. 64K). Without this config, large folios in these kernels cannot be swapped
> out.
>
> Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
>
> I no longer recall why this was not enabled for sizes other than
> 4 KB in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64"), but
> it appears to be fine, and the swap cluster size should also be
> more friendly to PMD alignment.
>
>
> #ifdef CONFIG_THP_SWAP
> #define SWAPFILE_CLUSTER HPAGE_PMD_NR
> #define swap_entry_order(order) (order)
> #else
> #define SWAPFILE_CLUSTER 256
> #define swap_entry_order(order) 0
> #endif
>
>
> Thank you very much for taking the time to review this patch during the holiday. Wishing you a happy holiday as well!
>
> I appreciate you pointing out this optimization. We initially noticed the issue because, on ARM64 kernels with 64K page size, if large folios are used in shmem, they cannot be swapped out as a whole during shmem_writeout() due to the config limitation,
> and are forced to split instead—which is something we wanted to avoid.
>
> It seems that this change will help enable better swap operations for large folios. Thank you again for your feedback!
Right, I believe this is the correct direction. Just double-check that
the MTE-related functionality works. Take a look at commit
f238b8c33c6738 ("arm64: mm: swap: support THP_SWAP on hardware with MTE").
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
2025-12-26 8:31 ` Barry Song
@ 2025-12-26 8:40 ` Weilin Tong
0 siblings, 0 replies; 6+ messages in thread
From: Weilin Tong @ 2025-12-26 8:40 UTC (permalink / raw)
To: Barry Song
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Andrew Morton, David Hildenbrand, linux-mm, baolin.wang
在 2025/12/26 16:31, Barry Song 写道:
> On Fri, Dec 26, 2025 at 9:18 PM Weilin Tong
> <tongweilin@linux.alibaba.com> wrote:
>>
>> 在 2025/12/26 14:52, Barry Song 写道:
>>
>> On Fri, Dec 26, 2025 at 7:39 PM Weilin Tong
>> <tongweilin@linux.alibaba.com> wrote:
>>
>> Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
>> large folios requiring swapping also exist in other page size configurations
>> (e.g. 64K). Without this config, large folios in these kernels cannot be swapped
>> out.
>>
>> Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
>>
>> I no longer recall why this was not enabled for sizes other than
>> 4 KB in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64"), but
>> it appears to be fine, and the swap cluster size should also be
>> more friendly to PMD alignment.
>>
>>
>> #ifdef CONFIG_THP_SWAP
>> #define SWAPFILE_CLUSTER HPAGE_PMD_NR
>> #define swap_entry_order(order) (order)
>> #else
>> #define SWAPFILE_CLUSTER 256
>> #define swap_entry_order(order) 0
>> #endif
>>
>>
>> Thank you very much for taking the time to review this patch during the holiday. Wishing you a happy holiday as well!
>>
>> I appreciate you pointing out this optimization. We initially noticed the issue because, on ARM64 kernels with 64K page size, if large folios are used in shmem, they cannot be swapped out as a whole during shmem_writeout() due to the config limitation,
>> and are forced to split instead—which is something we wanted to avoid.
>>
>> It seems that this change will help enable better swap operations for large folios. Thank you again for your feedback!
> Right, I believe this is the correct direction. Just double-check that
> the MTE-related functionality works. Take a look at commit
> f238b8c33c6738 ("arm64: mm: swap: support THP_SWAP on hardware with MTE").
Thanks, I will take a look.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes
2025-12-26 6:52 ` Barry Song
2025-12-26 8:18 ` Weilin Tong
@ 2025-12-26 8:31 ` Weilin Tong
1 sibling, 0 replies; 6+ messages in thread
From: Weilin Tong @ 2025-12-26 8:31 UTC (permalink / raw)
To: Barry Song
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Andrew Morton, David Hildenbrand, linux-mm, baolin.wang
在 2025/12/26 14:52, Barry Song 写道:
> On Fri, Dec 26, 2025 at 7:39 PM Weilin Tong
> <tongweilin@linux.alibaba.com> wrote:
>> Currently, ARCH_WANTS_THP_SWAP was limited to 4K page size ARM64 kernels, but
>> large folios requiring swapping also exist in other page size configurations
>> (e.g. 64K). Without this config, large folios in these kernels cannot be swapped
>> out.
>>
>> Here we enable ARCH_WANTS_THP_SWAP for all ARM64 page sizes.
> I no longer recall why this was not enabled for sizes other than
> 4 KB in commit d0637c505f8a ("arm64: enable THP_SWAP for arm64"), but
> it appears to be fine, and the swap cluster size should also be
> more friendly to PMD alignment.
>
>
> #ifdef CONFIG_THP_SWAP
> #define SWAPFILE_CLUSTER HPAGE_PMD_NR
> #define swap_entry_order(order) (order)
> #else
> #define SWAPFILE_CLUSTER 256
> #define swap_entry_order(order) 0
> #endif
Thank you very much for taking the time to review this patch during the
holiday.
Wishing you a happy holiday as well!
I appreciate you pointing out this optimization. We initially noticed
the issue because,
on ARM64 kernels with 64K page size, if large folios are used in shmem,
they cannot be
swapped out as a whole during shmem_writeout() due to the config
limitation, and are forced
to split instead — which is something we wanted to avoid.
It seems that this change will help enable better swap operations for
large folios.
Thank you again for your feedback!
>> Signed-off-by: Weilin Tong <tongweilin@linux.alibaba.com>
>> ---
>> arch/arm64/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 93173f0a09c7..58f7b4405f81 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -120,7 +120,7 @@ config ARM64
>> select ARCH_WANT_LD_ORPHAN_WARN
>> select ARCH_WANTS_EXECMEM_LATE
>> select ARCH_WANTS_NO_INSTR
>> - select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES
>> + select ARCH_WANTS_THP_SWAP
>> select ARCH_HAS_UBSAN
>> select ARM_AMBA
>> select ARM_ARCH_TIMER
>> --
>> 2.43.7
> Thanks
> Barry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-12-26 8:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-26 6:38 [RFC PATCH] arm64: Kconfig: enable ARCH_WANTS_THP_SWAP for all pagesizes Weilin Tong
2025-12-26 6:52 ` Barry Song
2025-12-26 8:18 ` Weilin Tong
2025-12-26 8:31 ` Barry Song
2025-12-26 8:40 ` Weilin Tong
2025-12-26 8:31 ` Weilin Tong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox