From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9985EE7719D for ; Fri, 10 Jan 2025 15:14:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15AA96B00C0; Fri, 10 Jan 2025 10:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10B1D6B00C1; Fri, 10 Jan 2025 10:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF9B6B00C2; Fri, 10 Jan 2025 10:14:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D0ABC6B00C0 for ; Fri, 10 Jan 2025 10:14:13 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3488044077 for ; Fri, 10 Jan 2025 15:14:13 +0000 (UTC) X-FDA: 82991887986.08.A3CADBA Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf23.hostedemail.com (Postfix) with ESMTP id 81FDC140017 for ; Fri, 10 Jan 2025 15:14:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eCoP11xK; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736522051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jls6JRw5AcblcCQNS1mpTOOTRuPIJymLrC7CTMmFPGk=; b=WQaDui3OSc2iiY7ao9mpyZBLqUOfILa/Hyf5619OFHfMoJM2GxazXks5YTX2FWtmzRpl4V aYF4TFRwTrDWhPZSsP7MMyP7/vxMYnMLZAjfOJ/HxDkszgCO/gSL184cqtMH3jNz2ZMBy9 jR8qzy/YQyvjrEqloY13ahhe2XbORNE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eCoP11xK; spf=pass (imf23.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736522051; a=rsa-sha256; cv=none; b=cAmgN0B41ZFaacclF16pkT1bwQ7LSfD3I5Lp+m3EV05QrENAJGAwN0fDe6Paf27MYzSpm5 hit6IVnH3SSAmd3lOJT8nnPBPdXUT3SsF1iJHN7Pj+bvvv4Re+GgXJT2yTVE3m/L2LGsT0 jqzFIZ8qOBHRylDQtHyjVwhqtuy12BU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736522050; x=1768058050; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=jls6JRw5AcblcCQNS1mpTOOTRuPIJymLrC7CTMmFPGk=; b=eCoP11xKa13E5iRCanpH2aYGYA82bl4IFCw/FQfwCFH66bqYcWfrmsA/ UVK7+zf4wydvu4VUCAr2liiWudgedYU1tyI4uO53yGBvejcs76uiNFRta LQz9mTaUgwYMtfoWuuAyuEyNTjONQ1kImKiGJW2Aqaqouhv55oOVnqiMi helf2In+0DpjZw8eIkdcRlmX65wQDSRxa1E5Cfp85/aHAdTmr8i0+NB2V rJMnIKk/pyHy1gYsMpgeoA0jCODXCXcAb7g/BWAVlsBok2jNXzMH/RDha Fr8UhRdlPjNajB4i5m3zxpYshXNOAp/Zq8tIM8I4E5QI05IpC+7NDlbBL w==; X-CSE-ConnectionGUID: M20r1yU6QsyVfXbhZ92JZw== X-CSE-MsgGUID: Qw97DKxpT72JK74dCVmJ6Q== X-IronPort-AV: E=McAfee;i="6700,10204,11311"; a="47392346" X-IronPort-AV: E=Sophos;i="6.12,303,1728975600"; d="scan'208";a="47392346" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2025 07:14:08 -0800 X-CSE-ConnectionGUID: KbABNTiNTEiu9L5jwY+Wvw== X-CSE-MsgGUID: F+BivIWOTOG17gWEl8LA5g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="104271568" Received: from bjrankin-mobl3.amr.corp.intel.com (HELO [10.124.222.149]) ([10.124.222.149]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jan 2025 07:14:07 -0800 Message-ID: <915c9c4e-75a7-4c4e-90a5-9a3de93bec1d@intel.com> Date: Fri, 10 Jan 2025 07:14:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/12] x86/mm: use INVLPGB for kernel TLB flushes To: Nadav Amit Cc: Rik van Riel , the arch/x86 maintainers , Linux Kernel Mailing List , kernel-team@meta.com, Dave Hansen , luto@kernel.org, peterz@infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Andrew Morton , zhengqi.arch@bytedance.com, "open list:MEMORY MANAGEMENT" References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-7-riel@surriel.com> <855298e6e981378c3afeab93b8c3cb821a7a5b88.camel@surriel.com> <426011a9-1fbc-415c-bac7-df5d67417df3@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Stat-Signature: 5rqzj6mo15dinx7u43frowozguro73mo X-Rspamd-Queue-Id: 81FDC140017 X-Rspam-User: X-HE-Tag: 1736522050-442882 X-HE-Meta: U2FsdGVkX1/djblXrrCd2QmPKETBVPokGXkymoGVeh6nXDd9egScmHHXQpa5yssLLWjO3EnV6r7c8Ffhfa1yr6Xkq3/zieC9vGEZ7bfvY8+1DMbToKUynHuklS78lpQPpSJlvT40wBxvlbZDMhNG7l7MUtTppZs/7bt2XtrK8KasuLFwC1AikN+XmuP9H4CegfdWLe1cjFNxi5waGNZxcmy05TpKRaqa5KeNNYBm1F1UBNG0OOAsTs7VPay7XlHr35fUwW87n0E6F2az403xd5OgxSuy/UgYednM91/HLvNJgzEZW9JQthf/0w1JhPix1YVW4OZohgZs4QMwiWjvuYF5ylWC5XDiOcORk9qUmQBqt+EbjrfqfvdbXRhgYtTww0l2ud6oQKlCDidatxaVHNJegwLY38liW+IFW33NgpHieuJLiOSy7xznAvheBTSzEmEvIw/6bi7hx3pYJBxISuTtkrtcQpWIZkONZvkj6He8Su8i4Is3WZPcsCMT4npByGnCjDbsb+nkniKz9LeZ8yp+JANaxb+cjh00qw/wkgi8SYswpDrgLqLMydlB1sOMHEzqM5wUuL6biYDEjO9Z3R9G8aPkeInhEENqFPAk/zFILEtAdLQMCdpOvv+Dx5nqDdCpK5x9QFkxzfAmvhui2krSYVhAVKr/I1I7hDIfZOqez/tptOVXkL10cuC0U3IcvzIUAgmk+LwU9c8Gm4wt7w5/e6Hv8H21eYshRmNLtAgL0hNufK3iLRAC72ScvG3+bZNnEDxfE19TINr69eFKgFnrvuMfJC8MAOqOW8W8wz6zG3qI+xiQ1yu0V8EIFMMklOREJUmqudCe1HtYetJfvkmc5h4Z4zuynOnPgRNGSw4FejAGxgZLTGcKdcr/hHEt5bri4P6dBiVtS9MY9eYIWOMeg6R0KnVY9z3GE05TZ0sFzu3UBG6rvKcNTjzJBXausaSmpbqB6uPvMWp1gVy pY0ggfdb AOHCQkeNUNaE2FP7TB3donLDLY4WQKwZP0vWYwkY2mdhAtJQnb+EXRs1q0R3P0+BY3TH8cBBmQz2Xjn+jrc0ZKach4A2/0+5uf9Up6Yz0MRPbrubHmUMT/o1AtwNWlMKH2lAsKFI/CHcaxKTT8YNGSlTpcAnaQw8UUzvrUVTG4L5SZ2rXH64HNDJdFsa6TD4lq7hJhegMr2WUNUsVV+dl3LoEhvn6iqXdy0IFTgvBzKL9lRgcuW7nIMJbLEu2nUnRMK5dhgzY6DkiZPtmbss1kiw/wCSe1pMR/0aMwFUnZfz2kyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/9/25 22:07, Nadav Amit wrote: > This is not my reading. I think that this reading assumes that besides > the broadcast, some new “range flush” was added to the TLB. My guess > is that this not the case, since presumably it would require a different > TLB structure (and who does 2 changes at once 😉 ). Reading it again, I think you're right. The INVLPG and INVLPGB language is too close. It would also _talk_ about invalidating a range rather than just incrementing an address to invalidate. I think the key thing we need to decide is whether to treat a single INVLPGB(stride=8) more like a single INVLPGB or eight INVLPGBs. Measuring a bunch of invalidation looks should tell us that.