From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6815EC4332F for ; Thu, 8 Dec 2022 15:11:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 893868E0003; Thu, 8 Dec 2022 10:11:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 844598E0001; Thu, 8 Dec 2022 10:11:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70DF68E0003; Thu, 8 Dec 2022 10:11:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 616DB8E0001 for ; Thu, 8 Dec 2022 10:11:05 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F168408B3 for ; Thu, 8 Dec 2022 15:11:05 +0000 (UTC) X-FDA: 80219476890.10.1803BD2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 038C710001D for ; Thu, 8 Dec 2022 15:11:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iDg69xSV; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670512263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fTPq3+bamwK6HxKeQ7SzbQhXZk/lPm5rXf0GTvDYG4M=; b=0ZBGBtJGlgxlxAADz2KQPVwZyM0VOH19gwMjS6h28wZtg2cB3hOfOv3NBDuG4S3XGETAle +4VZyMv2msuAmwBTL5vd/xcm8JkPKM2YxQNtgTGbsCpCe3G0RmwfPU4QMtW1P1EBBULzmo S7yaR2GDXEYIWjFD/F8X1VIY666+vKE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iDg69xSV; spf=pass (imf05.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670512263; a=rsa-sha256; cv=none; b=I4UanTclGIZUnbDLHEAvXUbadRqNCAHiN1X+bSSEcrl4s2RZWJYmu/OSrGXyAYw8pCImEV 0mnyLupLIcIZvkie7HovBBjfpQUGdbW7m9wjPz31+jsADySkWo8v8olkcrSWKXo22E2AMa zo7U8Cq1muOq9sIl9QRsL9Nsgg44O3U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670512262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fTPq3+bamwK6HxKeQ7SzbQhXZk/lPm5rXf0GTvDYG4M=; b=iDg69xSVRjlKF1BEbf9hEKXgc0e3qZLjAsY2o1FjtnUQl/xYil15O8CNyilHL00r7Fm1QH LxICP60wocGfQk+plfZT3fSdtIGeRF8duyNliBvtoTSugNJfjmrAW/Z1AiT2BHa26yULhl KsH9/CBv62OM7Q4zOF2Y06iZHcGzSS8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-142-IjPGidOsOkWXmOeVeKEMEg-1; Thu, 08 Dec 2022 10:11:00 -0500 X-MC-Unique: IjPGidOsOkWXmOeVeKEMEg-1 Received: by mail-ej1-f71.google.com with SMTP id qk16-20020a1709077f9000b007c080a6b4ddso1341660ejc.18 for ; Thu, 08 Dec 2022 07:11:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:to:content-language:subject:cc:user-agent :mime-version:date:message-id:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z7QM7VnSXhYRErVFWrMtPHxAXgKBFpUIn8aruAsuTMU=; b=JoOyzhdgZ+jwp6/P02fTLybKnRzNA7/K5HKayBn7lU1R3sXJZt3gCqr7JVzxHIGkVm Oy3+lZn+wcVXMCNOhzD/BEbTa0yYENFso5VmxwZySG+B3Zmwi+znLM5DYknareUOZYP5 I7h3qvjzn4MeGR+pRyMlxyb6x4xRJpgbLNTQcjJwpCxJY14ZgukNIUku2GECRya5lypv VcBWG+ZhOR6Wqu8jcnGIc6NeGLk+sLSyJ7cz80TF3Q89uXRCHnP2jo4jW1Ck7o7S0Gks KRAh9dkxs1AqWq9siYKtbGYIzDo3ASqUhQTpoEiPGGCoSydcObeps2QZym4TjjIGPI24 w0wA== X-Gm-Message-State: ANoB5pknmHRrtWkJwg9q0BD2xP49zQXZMiNoqclqqIlM28NuwM4jG8fw LLnbcEuVuzuSZr0/aZqP84QBLMdn1wKty39BfNjBkwdj10g5CjGtu6kpeh2AMlA/jiSNRWMFCDu UiJti5X+r9HI= X-Received: by 2002:a17:907:a642:b0:78d:f459:716f with SMTP id vu2-20020a170907a64200b0078df459716fmr2934194ejc.26.1670512259450; Thu, 08 Dec 2022 07:10:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5IGUZ5lODuEXEkdl2sifutp1yzBSbWNlQQMCsSoX5qjQsBxqxpoOb+IGlUPhytcgMBjKSfAw== X-Received: by 2002:a17:907:a642:b0:78d:f459:716f with SMTP id vu2-20020a170907a64200b0078df459716fmr2934176ejc.26.1670512259236; Thu, 08 Dec 2022 07:10:59 -0800 (PST) Received: from [192.168.41.200] (83-90-141-187-cable.dk.customer.tdc.net. [83.90.141.187]) by smtp.gmail.com with ESMTPSA id 12-20020a170906300c00b007c10d47e748sm3084109ejz.36.2022.12.08.07.10.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 07:10:58 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <9153be2e-76bc-3760-be31-4f0f96acd38c@redhat.com> Date: Thu, 8 Dec 2022 16:10:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: brouer@redhat.com, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 26/26] mlx5: Convert to netmem To: "Matthew Wilcox (Oracle)" , Jesper Dangaard Brouer , Ilias Apalodimas References: <20221130220803.3657490-1-willy@infradead.org> <20221206160537.1092343-2-willy@infradead.org> In-Reply-To: <20221206160537.1092343-2-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------YEHMoPqAHhhES2QDvyijB1bA" Content-Language: en-US X-Rspamd-Queue-Id: 038C710001D X-Stat-Signature: gipojtzj68kkhso8w7j95uozdewhrppx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1670512262-580029 X-HE-Meta: U2FsdGVkX18V9R5q8WeucoFXC5EEk7uNGxZuBsL1IjqFn6z/HpaME+BR3pDEuJTnviprAQ309jAydS3dVOLm+TUoa1s2q73X5Cp65HmbG0u4yBx7TJW58ZUQJI6QFUCcyN+3wEygPC9I+WITIbQ/DIO4O/tRBDGfOSE1X1KkviA/6AlEm8YMF+PHAhbowXq5vqOccg+JgTSIlMQG6paUKPhzlqfkQ8q5gQrvORgFmAqnmwencgri10ZONtiWs2j/qH6sHOh/8JpRHihlvugC3x4ChUCpc0L5rT2Rtgdui4sTkcu8qSJME3g3tKoCVIGR4yLDjr0LynuXgR8sbLv5FaPe3Ga5JkAd2K6nwCSrX0jWmJAmWw2Gem0IPNL3Qx7268YaN8nKKsSoG2mteqi3QXYZSJ5DfzWuHNglrhjkIaMctxc3U971et4KxeAM30Qzx7dv70jhyiEmXNmhCP8WTVPrrPriZSMyA+33uwPfpzCHupiuWXKE6RXkVQp+BqTwLj/DbkruVzSX4aO0CefUx/J6KrYefxOhKrMOxHN9H99QcL86j5bqES5/x6QwqYlqAjKuCLZkkBXGsf7Rouf/QaNP6eGwDlVS0KUHnClsDj9pO4XM42d7Sbe0w0MeyrBoVub8yBW0n8jPFaWwolemsA+Sd4ZRqacA4LMT4mVM9oipwSly1z9c/NartysrjMppIN5rhdqWT2X9OZJ+CRGW2q7N8cAEMVcWAYAg9+0M3/Clr4jqxcPKynxtwu9aMxo/S/KEu3BGzZP/1+xvgxBagHTRFHxO+gH99Tf6HyAq0vX16Q2kV2B0GM6Rc0kf4JmnZjjWALAHE2I8N7lseipD2ODeXKlfIfZR9TQQfiwzwpHVFQcWYnFrN0aTxP63hOWybn6ZwwJerlOP4hnQZENU/mpJv1R5dxUlCbaF5PRHFwVICq6/QHH74j2XpAnb83NG4S9/8cfF2UU7rdA6OJQ Y9WSdjK2 s2AVwoRYOB1ys1D3sDY8vmNWckN4d+FYgs7YES/I/gksh3x2bkHzhEIF7GzdNudzwr/7QJvJo/qStP7vCi2mvuYmVBO4cPOeSgZzrKFr7tsazP8T/T6TIJab5+yuK4yv9Vp05kYxzKdEXA+77L3n5b7Aj7/hT0wlrDsZmltYV+i8tyRX7bacym7qH3/QDiptiQ/uCcaOzap6RgV/iAy7OJWVC3JuJ/a152nJHKnXO/CoviBwG+WnzqAQJbSus70I9S2kH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is a multi-part message in MIME format. --------------YEHMoPqAHhhES2QDvyijB1bA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/12/2022 17.05, Matthew Wilcox (Oracle) wrote: > Use the netmem APIs instead of the page_pool APIs. Possibly we should > add a netmem equivalent of skb_add_rx_frag(), but that can happen > later. Saves one call to compound_head() in the call to put_page() > in mlx5e_page_release_dynamic() which saves 58 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > drivers/net/ethernet/mellanox/mlx5/core/en.h | 10 +- > .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 4 +- > .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 23 ++-- > .../net/ethernet/mellanox/mlx5/core/en/xdp.h | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_main.c | 12 +- > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 130 +++++++++--------- > 6 files changed, 93 insertions(+), 88 deletions(-) This doesn't compile... patch that fix this is attached. (I've boot it, but not run any mlx5 XDP tests, yet) --Jesper --------------YEHMoPqAHhhES2QDvyijB1bA Content-Type: text/plain; charset=UTF-8; name="27-mlx5-fix" Content-Disposition: attachment; filename="27-mlx5-fix" Content-Transfer-Encoding: base64 bWx4NTogZml4IHVwIHBhdGNoCgpGcm9tOiBKZXNwZXIgRGFuZ2FhcmQgQnJvdWVyIDxicm91ZXJA cmVkaGF0LmNvbT4KClNpZ25lZC1vZmYtYnk6IEplc3BlciBEYW5nYWFyZCBCcm91ZXIgPGJyb3Vl ckByZWRoYXQuY29tPgotLS0KIGRyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29y ZS9lbi90eHJ4LmggfCAgICAyICstCiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1 L2NvcmUvZW4veGRwLmMgIHwgICAgMyArKy0KIDIgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L21l bGxhbm94L21seDUvY29yZS9lbi90eHJ4LmggYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5v eC9tbHg1L2NvcmUvZW4vdHhyeC5oCmluZGV4IGFhMjMxZDk2YzUyYy4uNjg4ZDNlYTlhYTM2IDEw MDY0NAotLS0gYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW4vdHhy eC5oCisrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9lbi90eHJ4 LmgKQEAgLTY1LDcgKzY1LDcgQEAgaW50IG1seDVlX25hcGlfcG9sbChzdHJ1Y3QgbmFwaV9zdHJ1 Y3QgKm5hcGksIGludCBidWRnZXQpOwogaW50IG1seDVlX3BvbGxfaWNvX2NxKHN0cnVjdCBtbHg1 ZV9jcSAqY3EpOwogCiAvKiBSWCAqLwotdm9pZCBtbHg1ZV9wYWdlX2RtYV91bm1hcChzdHJ1Y3Qg bWx4NWVfcnEgKnJxLCBzdHJ1Y3QgbmV0bWVtICpubWVtKTsKK3ZvaWQgbWx4NWVfbm1lbV9kbWFf dW5tYXAoc3RydWN0IG1seDVlX3JxICpycSwgc3RydWN0IG5ldG1lbSAqbm1lbSk7CiB2b2lkIG1s eDVlX3BhZ2VfcmVsZWFzZV9keW5hbWljKHN0cnVjdCBtbHg1ZV9ycSAqcnEsIHN0cnVjdCBuZXRt ZW0gKm5tZW0sIGJvb2wgcmVjeWNsZSk7CiBJTkRJUkVDVF9DQUxMQUJMRV9ERUNMQVJFKGJvb2wg bWx4NWVfcG9zdF9yeF93cWVzKHN0cnVjdCBtbHg1ZV9ycSAqcnEpKTsKIElORElSRUNUX0NBTExB QkxFX0RFQ0xBUkUoYm9vbCBtbHg1ZV9wb3N0X3J4X21wd3FlcyhzdHJ1Y3QgbWx4NWVfcnEgKnJx KSk7CmRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUv ZW4veGRwLmMgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW4veGRw LmMKaW5kZXggOGU5MTM2MzgxNTkyLi44NzhlNGU5ZjBmOGIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMv bmV0L2V0aGVybmV0L21lbGxhbm94L21seDUvY29yZS9lbi94ZHAuYworKysgYi9kcml2ZXJzL25l dC9ldGhlcm5ldC9tZWxsYW5veC9tbHg1L2NvcmUvZW4veGRwLmMKQEAgLTMyLDYgKzMyLDcgQEAK IAogI2luY2x1ZGUgPGxpbnV4L2JwZl90cmFjZS5oPgogI2luY2x1ZGUgPG5ldC94ZHBfc29ja19k cnYuaD4KKyNpbmNsdWRlICJlbi90eHJ4LmgiCiAjaW5jbHVkZSAiZW4veGRwLmgiCiAjaW5jbHVk ZSAiZW4vcGFyYW1zLmgiCiAKQEAgLTE4MCw3ICsxODEsNyBAQCBib29sIG1seDVlX3hkcF9oYW5k bGUoc3RydWN0IG1seDVlX3JxICpycSwgc3RydWN0IG5ldG1lbSAqbm1lbSwKIAkJX19zZXRfYml0 KE1MWDVFX1JRX0ZMQUdfWERQX1hNSVQsIHJxLT5mbGFncyk7CiAJCV9fc2V0X2JpdChNTFg1RV9S UV9GTEFHX1hEUF9SRURJUkVDVCwgcnEtPmZsYWdzKTsKIAkJaWYgKHhkcC0+cnhxLT5tZW0udHlw ZSAhPSBNRU1fVFlQRV9YU0tfQlVGRl9QT09MKQotCQkJbWx4NWVfcGFnZV9kbWFfdW5tYXAocnEs IG5tZW0pOworCQkJbWx4NWVfbm1lbV9kbWFfdW5tYXAocnEsIG5tZW0pOwogCQlycS0+c3RhdHMt PnhkcF9yZWRpcmVjdCsrOwogCQlyZXR1cm4gdHJ1ZTsKIAlkZWZhdWx0Ogo= --------------YEHMoPqAHhhES2QDvyijB1bA--