From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F58C54E65 for ; Wed, 21 May 2025 23:47:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 43C9A6B007B; Wed, 21 May 2025 19:47:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ED396B0083; Wed, 21 May 2025 19:47:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC256B0085; Wed, 21 May 2025 19:47:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C2E76B007B for ; Wed, 21 May 2025 19:47:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E61CC1785 for ; Wed, 21 May 2025 23:47:07 +0000 (UTC) X-FDA: 83468553294.20.987A883 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf13.hostedemail.com (Postfix) with ESMTP id 7C05320003 for ; Wed, 21 May 2025 23:47:05 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZIWZ4qXf; spf=pass (imf13.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747871225; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sRl5UoFXBWBhlff+4RMnGLgcFMuNhbpLtXyzr1qDabc=; b=oZzR09ET5eVfBy8Im1VWaSGsQIHTsGuEjBOUMI0kRjH1KR42ya5vg20CkfJ5gfxaZ2zGrs TeTB4mwdCnD9iH69BnnQorTUCbH2Xd/A+TYxJ3BKu77OC2uGiGhRDdhHL3XbmjbghKE94v 9lP0B3cuiP5+wn+ZsQK3JZz6Qpb9YXs= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZIWZ4qXf; spf=pass (imf13.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747871225; a=rsa-sha256; cv=none; b=5s3octunzjM2eZ6bnPjk64G5+nOY9SGBDoyGLW4Nna8rUAXzAmGEBq1hHnFQOqvzXWpVe/ q3fBYNIyEz/cvtVFBMAgyT8pShkhVOFyCQdFVRCNx9rdPGD/ESxOFJkZoZkgWNZKTbUmPg Ca/VS8S9v/zpjhdyQqc6siy+ofB9yi8= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-742c9563fd9so3754955b3a.3 for ; Wed, 21 May 2025 16:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747871224; x=1748476024; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sRl5UoFXBWBhlff+4RMnGLgcFMuNhbpLtXyzr1qDabc=; b=ZIWZ4qXfVNgz3fwRwajyeGXpbcezduWkv2HpohH/Ui03pFK73E6wN8kAZ2k6dSNAvh 8w187ZE9iaiOlCSBAcGfSZwFb0z2LNY9eOdYAiB05VVo9dOKSXbpZ1RzFN7+nnuNUN7A h1L5zUHN4WZcJ06NflBwbeKExSdKbwllaTIa610Kkv9xeEqc66yhU8A4neycbIIy1jCm 2NssV9OhpR7O/SLB2B82UqT9G2UBzrGEBSRT3jCfcBgpIVsGcwdS5jYiX87EyqCktqQu 36IaHXpyZVGA+EtWwm1zwxq9+mly3zfyCtc7ZaLwJv9UaBYnfXN88uPsCSgUDkmXuNtA jq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747871224; x=1748476024; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sRl5UoFXBWBhlff+4RMnGLgcFMuNhbpLtXyzr1qDabc=; b=J9D503D/fKG14sc3hkvXJK57rKsQID2Z8QKd6ctSWFygKa7yXFh4BD+yH1UwqQz9Zl mxTWcwo/WW03GpcAXOh9gq3T2Q6z8t3CJ19lwI8lV2dTnDURFFkMslg7OOaRAd4mUvAf RYzYZyGOjhNgYQuezmO+dlKgJXSPGKgh7+qCN6KZ1gubnTDY/Bq7bBmwLMuFjcnJoYYU mVDxRQYP8NU/f5Kefxr0hC8XPzge6xk/V2uvc8qOWDUl68ATSPujY/bLb/F8612lmR+c 4O6v0TUYV8ncTMwlw0s18mymlHHxh7c1XvLr87AlfhZ0dSk2YoWMjYKQw522tdJ5yXkj 5dtg== X-Forwarded-Encrypted: i=1; AJvYcCX+oGGJyYVAYB9FS87ZVn37zjQ4dysfa5UwFByae/QvZonQJ5zYmoNnn2b3HkS+0qVTNNyOBvyC1A==@kvack.org X-Gm-Message-State: AOJu0Yy579GyNczvCweceHgdZ9PyZq8U8c/1LtIG+H2yHrLsm/3usp/K IqxR7E4ba7auUKBwStEeQjYsfrjlLkhOOobv55HuLivkrT+klMqvrEQR X-Gm-Gg: ASbGncvD0vIOSEzkqqn1FA5w2AqpD7oSHZLxHcr6bI35iuzUxBFoZUVoI/aQf1VS/DZ hfhI5UmpF0PITBFBbGFjraTwl1JV5y2fpnblWTXhzuy9pR2QYm6tiwkMsw/4o1omwfqRLM5Nr9z Hv39HoXAsOP3fDvPIqP29yzELUtjdAeXRVcj8J1DL600AZh/af3kOhrxpjKXEUxpadCitEw0q53 l0OLRq7zGkmPJ+To4onNbEcsMgA9CjLyquwOMXSpMD0f9PlzTO9+a6QBEur27a/+FDXZcrNbT3P ONrRsHH7XDCRTg45KVpwfl6Vy5BSuLyr3h4Ty90SlGRMqRmUQ/EtWZVzNGyTf6pItsTFOkYTUL/ vMmd8N5P26rExglT5kb57Vw== X-Google-Smtp-Source: AGHT+IFpmGP8PXJrewf0QIOeukhOjrHtY0pSwwTqGyQPEVHBdRSkaE6V9yXrLL5dYQILdBR8dfXnIg== X-Received: by 2002:a05:6a20:c6c9:b0:1f5:7710:fd18 with SMTP id adf61e73a8af0-2170cc70700mr31020612637.17.1747871224143; Wed, 21 May 2025 16:47:04 -0700 (PDT) Received: from [192.168.2.117] (c-67-188-127-15.hsd1.ca.comcast.net. [67.188.127.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-742a9829b9dsm10117474b3a.88.2025.05.21.16.47.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 May 2025 16:47:03 -0700 (PDT) Message-ID: <9151095d-98dc-4497-9a64-b2eb7f8f96ea@gmail.com> Date: Wed, 21 May 2025 16:47:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [OFFLIST PATCH 2/2] cgroup: use subsystem-specific rstat locks to avoid contention To: Shakeel Butt , Klara Modin Cc: Tejun Heo , Andrew Morton , Alexei Starovoitov , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vlastimil Babka , Sebastian Andrzej Siewior , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team References: <20250428174943.69803-1-inwardvessel@gmail.com> <20250428174943.69803-2-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7C05320003 X-Stat-Signature: dfqmouuddwyiwjekz74xnmzcrxekj7hb X-Rspam-User: X-HE-Tag: 1747871225-749633 X-HE-Meta: U2FsdGVkX1+G1GTOwXZAVZFq1t/MxSSOJ71m8aH7fXel/+xe9MnhdExhWeqh/+f8rfyXIyPeZTmiDi6d4jeb0u9aKC+BTHsGLsq9/JqM3PYVjYtK+oaqBoflm4s+Tn1XuZyQXRy4K0pfeMYhAbZeVOpirA5ZEpvqVLgYwP+5/6yVez86z7Vk1APQ+46xltUdasr2Tm6jdRJaPTnGgpnQwJX6l35EyduJp/8ZnZGa9LmCVAGNu4VY9wqubAzbeJtkloFvIGRnMma+lFewqP8WyYNs31PR6w+/nn8QcrJkvJDYcKx2+1UiQ7j4R4Xc0rgVg7UuH2eSfq1SaYbhJjXoZ2wvWhpxH1wrx2Nc03Lpq7HWKyQA1sGU67em4RFGW/IrOZ0Q+jgQIaAfwPauH7T2Eq01FGRrYv3bj9/QRqvHsBc9XA2DXdMY2/zBAFijdDZxllGSChqQJfwM5PlUlyexMJroHrF7gJhtRmM/+bEKdl7tPoPqHArwOkUWyiHkx5weuT4vHLpEmMNLV0EuzD97bbVKqpZJDt1vBj9+dDwtkjr9gJy9JFUrTBuay/xgxiqcASk0qiBrgjGBbleT70GQxF4T7P4WSGAb5oANYbrMLcNdsxFONN3qYiSid1pcwkpyzKhS17P4Pe3tD9hKO/CJuPGfiNFW0Z6HkeLeKnYkOvGB+His9/6KT9K4SMhvbPfOjrX1gxUO6UWUvqDwV5sEmhbziMKRH9SReu/EqkNGDzOAOfeWg+ngS4hhjscFpV3ZeAP9BGASlvDYuPfcvo2LYL3qFV5k1o1IDEO9q2CZfScA8BGSCSbX3H2iykJOLQJmSuwSqUuQ8+TRChZJl2aT/UVSdWF1N3FyATaYpFyRVE4a/PJ3DbtZ7ds/FSrOhiSoDz5xjGLBXiPyHoZLCUQlYnisA3dziI0kYJDAc4lKWBgctEGamGvWNR1NnyflMIti5HGlNL8gzvuhDK3lzrN jW4pV/36 xVMmHvN6xKtArWskiKDcAyXNi3nlf4uweWT6LSABq6ABhO5oLZv+fdQprurqQMI09pVkGpmACQRk0KshNDbiTMM67jiiINZFWOFaDLcsFroWo5+H6tvI8UZIvu+q0gBTcingr1v/645q1ZgjVUXsYNv1XIEcAoug/Pyp1a22aCFMv/0BmYDUMPkuWX4DzD4fmuwU21tWUa023FXTjRnb5HqbBXJpss61CY3mziLjUjXxOGYK23tpOEbpHbEqf+dS5Gis7ozwr9N/Hhd03xzDLGo0Gf4SbXmXAjiDtOjAdlCVnebcY6+WIEr0wWD3zYtv+b7ow48yr6KKLIzpPSLkbWnxzaXFUnAQccM+d99TqGE7trp6yMI6yXRHtoEHzcYTCITuhlXro7GAOckZ5zvAPrGA6Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/21/25 4:33 PM, Shakeel Butt wrote: > On Wed, May 21, 2025 at 04:23:44PM -0700, Shakeel Butt wrote: >> On Thu, May 22, 2025 at 12:23:44AM +0200, Klara Modin wrote: >>> Hi, >>> >>> On 2025-04-28 23:15:58 -0700, Shakeel Butt wrote: >>>> Please ignore this patch as it was sent by mistake. >>> >>> This seems to have made it into next: >>> >>> 748922dcfabd ("cgroup: use subsystem-specific rstat locks to avoid contention") >>> >>> It causes a BUG and eventually a panic on my Raspberry Pi 1: >>> >>> WARNING: CPU: 0 PID: 0 at mm/percpu.c:1766 pcpu_alloc_noprof (mm/percpu.c:1766 (discriminator 2)) >>> illegal size (0) or align (4) for percpu allocation >> >> Ok this config is without CONFIG_SMP and on such configs we have: >> >> typedef struct { } arch_spinlock_t; >> >> So, we are doing ss->rstat_ss_cpu_lock = alloc_percpu(0). >> >> Hmm, let me think more on how to fix this. >> > > I think following is the simplest fix: > > diff --git a/kernel/cgroup/rstat.c b/kernel/cgroup/rstat.c > index 7dd396ae3c68..aab09495192e 100644 > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c > @@ -511,7 +511,10 @@ int __init ss_rstat_init(struct cgroup_subsys *ss) > int cpu; > > if (ss) { > - ss->rstat_ss_cpu_lock = alloc_percpu(raw_spinlock_t); > + size_t size = sizeof(raw_spinlock_t) ?: 1; > + > + ss->rstat_ss_cpu_lock = __alloc_percpu(size, > + __alignof__(raw_spinlock_t)); Thanks for narrowing this one down so fast. Would this approach be more straightforward? if (ss) { #ifdef CONFIG_SMP ss->rstat_ss_cpu_lock = alloc_percpu(raw_spinlock_t); #endif Since on non-smp the lock functions are no-ops, leaving the ss cpu lock can perhaps be left NULL. I could include a comment as well explaining why. > if (!ss->rstat_ss_cpu_lock) > return -ENOMEM; > }