From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D6DC6FD18 for ; Wed, 19 Apr 2023 11:31:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 506718E0003; Wed, 19 Apr 2023 07:31:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B66E8E0001; Wed, 19 Apr 2023 07:31:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358E48E0003; Wed, 19 Apr 2023 07:31:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 259DF8E0001 for ; Wed, 19 Apr 2023 07:31:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DB8081A01E5 for ; Wed, 19 Apr 2023 11:31:06 +0000 (UTC) X-FDA: 80697924132.30.8EA2B40 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 587471C0020 for ; Wed, 19 Apr 2023 11:31:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/jDl74i"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681903863; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dPuQPsleEjjBeSq0BvDdXkwF3D8bnmU80K+kHEWN1i0=; b=LWQMWSaRjylkEFbBQUVhHv6d9J3d2h2UdEN7diZCvf8Z4bl2LMvx9scc7/HII56qsskcYH m7C7W16ig5ItEJq1npDpjSgQonwvjUb5F1ib900TmeNllj/SJP06CK+brbPdq9Rgg9EMAC AxX8bxhq30TWn6Mz22UNrsFA2OWAyvQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="S/jDl74i"; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681903863; a=rsa-sha256; cv=none; b=Yj8yFtxcS6V1Jdc3a0sZEaswB3N+rQ9EucWHZw7qNQ3zqxRnYGVibDGYMCm2FXNiq6G8Cl gD4xXyA/pPhpth/sBjxzzkyGHuTs1VRamoviIqeBqycXXans8a5bKAwroEklsvRdn8i3Oj mkMk8LVrcSLA3sH9mDY+OBGbVlQykWk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681903862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dPuQPsleEjjBeSq0BvDdXkwF3D8bnmU80K+kHEWN1i0=; b=S/jDl74isdKbaLWMnU5Ag4ajZ9OX3Zpnll/Y9HOXypP/ClW8YpGe3zq1F4pp2WFqMLl0/E yjoovhOxnSKOtII4B6orjOmxapGZHThrAtRb3hKICvf5hfA7Bw1nx1qvWYTbKd3uXaX02t CIqPeeyxoPNOC8LYhOI7dTYnJDAf8RU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-n_GWVhK5PfOuBhW8fJD_ew-1; Wed, 19 Apr 2023 07:31:01 -0400 X-MC-Unique: n_GWVhK5PfOuBhW8fJD_ew-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-2fbb99cb244so1022285f8f.3 for ; Wed, 19 Apr 2023 04:31:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681903860; x=1684495860; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dPuQPsleEjjBeSq0BvDdXkwF3D8bnmU80K+kHEWN1i0=; b=XY7Ckhso75fJr6iM8P5uDA8KTMfPNZJ+heZVc9rcrV2kpoGO8Y18Rb/sF5ILtRVKwd VXo8JoXAJSpZLtl9sG/QIYh1FxY8s/pPXCE0f9qcUwypHyXKOXBIruitWNfT6vWiyhdu Hx9FV4uM58HZBHxwJ9i8cp1EsgavESvRbjqc4gT74mL2fzT/Nfuk/eH22JxPu3rjkR2+ IhDhGJKE9q9AAEj42N7JeALdTfkdUpNcQjkUwXSxUR5V9ZGh2/nbIa1AFhPGyWfVgEpW OP2QI19qi3+QFcaG4csbtlA8zjMKNPHWnX59qFWt7SWtxBb/ApGfKxQUNv2O3WKNnn/z ATrQ== X-Gm-Message-State: AAQBX9eJCC6/khsxHPCuvSCgIG4gqU1bJhnDoRVLCO+yu3uWoHHVjetX t2GF0cCzi1i0G67HZd3OeGnTKdHzMERBRnj4PftxEtDme3MCDvRYlBASUdwfp8XxZ9YdnJ6YdOC iRWaI7zH7GEc= X-Received: by 2002:a5d:69d0:0:b0:2fe:c0ea:18ad with SMTP id s16-20020a5d69d0000000b002fec0ea18admr1723939wrw.47.1681903860458; Wed, 19 Apr 2023 04:31:00 -0700 (PDT) X-Google-Smtp-Source: AKy350bzhkcwsfhrSQkvGUIm/JW8RoVL0p90cvfrRI4bamTYUVPg7DxfHt0wqA8rK9Mz1QlqY1RVnA== X-Received: by 2002:a5d:69d0:0:b0:2fe:c0ea:18ad with SMTP id s16-20020a5d69d0000000b002fec0ea18admr1723910wrw.47.1681903860074; Wed, 19 Apr 2023 04:31:00 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:7b00:7c52:a5fa:8004:96fd? (p200300cbc70b7b007c52a5fa800496fd.dip0.t-ipconnect.de. [2003:cb:c70b:7b00:7c52:a5fa:8004:96fd]) by smtp.gmail.com with ESMTPSA id v17-20020a1cf711000000b003f16fdc6233sm1880494wmh.47.2023.04.19.04.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 04:30:59 -0700 (PDT) Message-ID: <914e826e-3fab-4540-d3a1-24ca39b1cf0a@redhat.com> Date: Wed, 19 Apr 2023 13:30:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Peter Zijlstra Cc: Marcelo Tosatti , Frederic Weisbecker , Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, vschneid@redhat.com, dhildenb@redhat.com, alougovs@redhat.com, jannh@google.com, Yang Shi References: <20230404134224.137038-4-ypodemsk@redhat.com> <20230405195226.GB365912@hirez.programming.kicks-ass.net> <20230406132928.GM386572@hirez.programming.kicks-ass.net> <20230406140423.GA386634@hirez.programming.kicks-ass.net> <20230406150213.GQ386572@hirez.programming.kicks-ass.net> <248392c0-52d1-d09d-75ec-9e930435c053@redhat.com> <20230406182749.GA405948@hirez.programming.kicks-ass.net> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode In-Reply-To: <20230406182749.GA405948@hirez.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 5hb1ckphcpz5jwj1egedpt5sjobjctkh X-Rspam-User: X-Rspamd-Queue-Id: 587471C0020 X-Rspamd-Server: rspam06 X-HE-Tag: 1681903863-129765 X-HE-Meta: U2FsdGVkX1+KG7zizc0U95bcNNi4EdliYGgLv2QSwAawdCAls3PpjB9mfYYrAQgU/D9mscWYTvqHHhsvNhUfhxG/OytatkTGvRw8VxiyLnn4ishC0Uu5ADHM7I8KCGjYL6/mhE+DEOmMnI0odKeLo3MwrXyh2proqg8EpysveFihHO80GSHp24S2V9m4VEQJOFwmzI2NbgCpF8WLw7SuuXNgbP6xG13XaOULMhE7rTjpPpmdTmRw3u9LP4c9Yvtr2Z7oS7hcjA0fdJ9zZ0mI8QPVXejUPYQo7UaPamZaSd6O/gcmvs9ll5D5+deuGeMqsAkeefWDqgRFYEzfqalWZKT59L0/tH29Tot0iVwmal5j5B+EJibQSW3FvYuDPU5h7Akg/r+U9qV7w9ESeK1RYKB9/u/TIS+yOb2gFgdOaS9EFJVV0GAVW2biSlYy4g/sOe/qIGGnTP62RpTvdBggGlmFmC1+VksUeJAZedUDwL2Hq7BBR6TPZUEdCmewjRMUFYCTPSWmjz7vM6Wofxtmaev3FKdqoDs7sQuVVnIMOZC6sPPn62FnSukzHXPW2B0ZrJnta4XSRk0EK2ZmNneTXp1BunBZtpL5sWjC9dRFSQCjCYnJLlGzOr353KnkMOGtypX/zR8bQtBJe2awCMyBbA4J0DGE8QjSr2DGiQaobT9aF4v+cifhtRbgLKr8owL+sRwSQ3Wx+q5o5Bpxo3r3EZur38aeLPyJuCpGaeRmBj2E6nE+gP69ZmiDMNrgvbbXEPmWh9WEGgCFHnxFjCreeXvawLgh7iXxF3K4SgzUKVxMOAdH4RuB9WbBcUi0+SvqYkN2uR6k/1FfyU3IAhWPVKjbEXlZbnJAsvD9dClOmYEaNJ5iRcyoSVmY6HdSjzZ0vbViGUcgnxtWKoRqqUaeAD86HvZ7qiJzW7ErUxbnc3B1HriR8fLq2MkM1f6v9PerlFukzXlk8QngLVTtH/Q TtA6Jb29 CypN4M9gJo/ZFP1gM+JOy4rbyZM5BUa4pV2kdSOkeqjbUP7OfVHUk8uswsjdBkT+8qwBp52ge/t/h0hmCZFC6vbXvRcp+g5kn8qUA/WEo1xO3gG0yzkVb/ZXF7hEOIpqqLuki5g7iAdMfVsfcalYtpGcE0hPQ7wSvyjofZcs1Kaknyy+6EM4lwzCcsn9fFPjcUXvGIzKTmGulsXp6X8xXS/FPBufcVoJ9crTBMELopMtdHO3kXB5mMmMLM4yP1gTWUF0Ak47T/2G9YPhxXpFf04tl+U0xbaHxZSbyqOFPTHusZJ6ExFEk87gNtke6sgV7eds2OWOMWYVP4di8utAMVgBofjotd4pQB+3+MxJo0dzuC6zun7yifjio9zfeA/dDhawb+2S45Dt3EPhELaA1MQQrxdm0LszR4RN7YHQse6I7rCZ9umoXviAI+xEwqSrC87E0I3zg1GF82FqOFcKbU97bgFoKtGmW18mEDcAXqf0oxX0nAO4Lr5q5A9p5/BtkskdwuVCdgiGt07XMh6UXegv0BJ3BxYO6r3v5Kl9FJXN0ZooXwwlVkQ7nl7zrW3NK6zNWrfER3q8Wu/lPKyfp3tpYxZXesayyFStCfRjUWNDmz8llW4wxoh9QSjs2W2Mio3NOAlC7pqFQjRe6inkSxh43LA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.04.23 20:27, Peter Zijlstra wrote: > On Thu, Apr 06, 2023 at 05:51:52PM +0200, David Hildenbrand wrote: >> On 06.04.23 17:02, Peter Zijlstra wrote: > >>> DavidH, what do you thikn about reviving Jann's patches here: >>> >>> https://bugs.chromium.org/p/project-zero/issues/detail?id=2365#c1 >>> >>> Those are far more invasive, but afaict they seem to do the right thing. >>> >> >> I recall seeing those while discussed on security@kernel.org. What we >> currently have was (IMHO for good reasons) deemed better to fix the issue, >> especially when caring about backports and getting it right. > > Yes, and I think that was the right call. However, we can now revisit > without having the pressure of a known defect and backport > considerations. > >> The alternative that was discussed in that context IIRC was to simply >> allocate a fresh page table, place the fresh page table into the list >> instead, and simply free the old page table (then using common machinery). >> >> TBH, I'd wish (and recently raised) that we could just stop wasting memory >> on page tables for THPs that are maybe never going to get PTE-mapped ... and >> eventually just allocate on demand (with some caching?) and handle the >> places where we're OOM and cannot PTE-map a THP in some descend way. >> >> ... instead of trying to figure out how to deal with these page tables we >> cannot free but have to special-case simply because of GUP-fast. > > Not keeping them around sounds good to me, but I'm not *that* familiar > with the THP code, most of that happened after I stopped tracking mm. So > I'm not sure how feasible is it. > > But it does look entirely feasible to rework this page-table freeing > along the lines Jann did. It's most probably more feasible, although the easiest would be to just allocate a fresh page table to deposit and free the old one using the mmu gatherer. This way we can avoid the khugepaged of tlb_remove_table_smp_sync(), but not the tlb_remove_table_one() usage. I suspect khugepaged isn't really relevant in RT kernels (IIRC, most of RT setups disable THP completely). tlb_remove_table_one() only triggers if __get_free_page(GFP_NOWAIT | __GFP_NOWARN); fails. IIUC, that can happen easily under memory pressure because it doesn't wait for direct reclaim. I don't know much about RT workloads (so I'd appreciate some feedback), but I guess we can run int memory pressure as well due to some !rt housekeeping task on the system? -- Thanks, David / dhildenb