From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E955CD128A for ; Wed, 10 Apr 2024 13:38:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D28D56B00CA; Wed, 10 Apr 2024 09:38:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB17E6B00CB; Wed, 10 Apr 2024 09:38:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B04A26B00CC; Wed, 10 Apr 2024 09:38:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C5626B00CA for ; Wed, 10 Apr 2024 09:38:34 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 572EA1205C2 for ; Wed, 10 Apr 2024 13:38:34 +0000 (UTC) X-FDA: 81993726948.27.D0CAE6D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by imf21.hostedemail.com (Postfix) with ESMTP id A06701C0018 for ; Wed, 10 Apr 2024 13:38:29 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VsYuPaOy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712756310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Clk4n7iDjlQC1CWk/xMboXF/je1CdNhyT445ZmM8Umo=; b=b+FfccNDHZZIRS7HnzuQ6RD65VYZ0tubwktM9CaUjLFU+LV54qUQ4aIW3pcVIg2wtZ53dZ 29QgsHIbCTkbXSPl39YsJKeHgibVm+BRp+rr6URC62q1qg5VArp/Co9v8HCT8V+0ESeSSW OmK+Y07snndBAVaAQk3MEWA5lo5YqIc= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=VsYuPaOy; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf21.hostedemail.com: domain of aleksander.lobakin@intel.com designates 198.175.65.19 as permitted sender) smtp.mailfrom=aleksander.lobakin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712756310; a=rsa-sha256; cv=fail; b=fCESQRCWaGuWF8jI3o3QSwBypqefFbB4r1GEsjeT5L+jWK6NanRMCFz2PofxPIP2odDN24 0dZNOnlbE3E9bCu2JxvvtUPFdFEn3QlfWfisYF7lm3wUlIhN5jLwHgCaA9y+2hoqHlQ9bS kTyKRGD+I0Mq8XV2av3o8mXK9eLBC/4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712756310; x=1744292310; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YIBhwAHcURy/rNJOHApcXy5uZxajWKN6gwZF8eqCuk8=; b=VsYuPaOybq9FYwq78ENjQlexixKuoaT6iVc5WI6rjIiUd6JNOuouD0Xn 85XrgIyxLOA3WV2o4no6j7EioHAtGmcgD7bzSk0NI58RFSocCztMh1e7J 7DwgS3O6r1cr/ByUTapSme3wjFGaL2qi5TYvsol7UcDpycdURI/k/QvW5 fi9KcRC3mw/M01WRFOLN4ACsl4nOzQrls18eSuSaQU1Qz0dZ3agMibnJ4 fKTEFlA0SQ/QmapnRrl6G3yrTbnN5rteqtU1ttZt/tGAA6u7PEjQZp9FX pignSb/S3WEc+fI79iQ3o2QdP5V+YXBIbr0oL3rzaFTVIuhCkoS4yTiY7 Q==; X-CSE-ConnectionGUID: OVoJYMZqT9enToG7UxJOQw== X-CSE-MsgGUID: 9lM69F9GSbe0LbK3TNaLRg== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="7991167" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="7991167" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 06:38:28 -0700 X-CSE-ConnectionGUID: YdLevt0QS7+H2ddvqSvLwg== X-CSE-MsgGUID: FXa2pJdrQhqtQRJQDSkjnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25191478" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 06:38:27 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:38:27 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:38:26 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 06:38:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 06:38:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZG8CsVLlWkFiIjQRS4YoNU/PAgG/q75paiVwIsZtoLCqEyITrzHw+kZlNsTyMgsVvByNr6DmLdTDFYtJ3HuQO7qtofcf38WhsSJWgfV3aGdtXwnGiGV8/0LrjO7L94IWgfpL9E7pNzMBqOj3aQE306lZPmzrkXxl9RLQOKMszPRaPVHUM6xfXdWCiHh9e0+CAkye+fY3062FHT0XxXVGohugc6cklxmeBIiHhMs/9iz0xWLqzBAYni39K0bbxXrvky9eAnijLDSUA4ZNWcWCHQfquL27NraR81n89eV3Q6+hhTEnjZZNx7PujaU2zWabvzi+pgteaNO9xyBo6bdeBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Clk4n7iDjlQC1CWk/xMboXF/je1CdNhyT445ZmM8Umo=; b=mz578UHQIgWZG137pGiPEaWIPY1F1XFIhxQzsJLNiVo2x3rIoeUfAggsRdKgz2NEOMVIr4620SFKBTO7e5fOY5bY/sxboL3JuOjba9D9SnoGEPKHiGVjmPDhCDw1Kkibh6fJKgv/3nQ+PZmBJaI4XvFOaa0ZIPARH80tRx4DSWgoC6UJiiZXFgBkA3uG7PejWHuTIffA3b2J/pRkClneXy2UlrRECE1vyunAsAq5sgrzPkLTIPljVD3pqVT+GlOmqdoVF5p8ISBKzTre2lRJR1ZOcvWz3urFK3A4MjfD3YzIrQedyRJVUrjO+80ibubNCzkLUMlWaNq1kInaV6AhnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) by DS7PR11MB7932.namprd11.prod.outlook.com (2603:10b6:8:e5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7430.46; Wed, 10 Apr 2024 13:38:24 +0000 Received: from DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9]) by DS0PR11MB8718.namprd11.prod.outlook.com ([fe80::654c:d66a:ec8e:45e9%6]) with mapi id 15.20.7452.019; Wed, 10 Apr 2024 13:38:24 +0000 Message-ID: <91486cf6-c496-4459-8379-257383d031a1@intel.com> Date: Wed, 10 Apr 2024 15:36:13 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management To: Kees Cook CC: Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <20240405212513.0d189968@kernel.org> <1dda8fd5-233b-4b26-95cc-f4eb339a7f88@intel.com> <755c17b2-0ec2-49dd-9352-63e5d2f1ba4c@intel.com> <202404090909.51BAC81A6@keescook> From: Alexander Lobakin Content-Language: en-US In-Reply-To: <202404090909.51BAC81A6@keescook> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::15) To DS0PR11MB8718.namprd11.prod.outlook.com (2603:10b6:8:1b9::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB8718:EE_|DS7PR11MB7932:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7TMWdTwgCamGdsNbjKuAty/O06tUUYM02iUGINbMvwo8+IVY33IWMbJgm4BK6qk6BWS4Fsi/CPTifWJA2VUmOyF5eeKV3KPLfwIBJ9FbicmF8H0hJjOnzCx9pHg0APmeq5VxfXdstFvej2rnjsIkgNtUNZQZM83LzEDS5/180pbtKAC5kG+CKAg/uTA4ev+b1sa8kunKOvc21AaRsDYmrMOAd3EdjRUkHKemIEHDSbK9qSdVNxnRS8uqD0Kz2LwBCAv1Rc3hcBKCW0rapG/89/WiZTMUbzYzkBcL8fT5RVa+FC0aAkIGbl6I4ERPpGe8W4YYOxsd8lqkQg9e9vdCKAes06t8UQRvrXlv25VUzFakdKO4c++TnMaQchfNreEqtIIg4OaWjm2zlZ5de58Le7cHZCnv+SsuIe9kXrKGojdk7CclVn5iu7rG0RDq/hSBctgR+3N05tU+A8yfug+G5igRhJCcKh0Th+1zIo5g2lYueEM4TcsYmo4NqgsP0y8oyu+aLKqo4mdGNH0wFCgr9eDiWh3lyvre8+BYOi4nwQ/dL2i6ZxWTA6fXurP+A47THGkQO7umhtS4mobAWyMeJ+hL6ZhMq0slDtUCEswrjiivb4XKbFGKLqr/dDQeVqh3cfmUKEjJcixJg/lGuLhFbFYqMBIM9jAJybZOROeVhZE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB8718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(7416005)(376005)(366007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MllYdDE1OWtFM0pEcWFjZ2ZPdS9pZ0MvWVR4T1ZQNUg0a0lpQmYzeWFQcmxk?= =?utf-8?B?UFJmRjlRNW9udFZDaXUzTzdtQmtJaGFMMjQ4ZDdZM1hLUExQVENJN3BoMkR4?= =?utf-8?B?L0FVTzdieGdQQ0hVdS84cTF1NlNqUkd2VkJjak52bElwbmlXZ093UzBUWWM2?= =?utf-8?B?UzExTGNLVTFsc3RadHdNNWpUSUdMRFZKTkZyYWRCall5REVaTm1qbmF1Z0xu?= =?utf-8?B?VWVLMms0N2ZkZDFZdkNXdHU1ZjQ5S2EyK01BSENwNGFycEpqaFk3Mk5lYmhw?= =?utf-8?B?KytJV2JNdWhSUnRQUkNYQzMvRkJrMU0wL1NTejZCc0M0dkpGZ0g2QW1GOHZ0?= =?utf-8?B?L2t6djRSMDladTZDYjRzQXkza1RKMk9Ed1Y4T24zZjlWb1NUeTIwZ3pvRU1F?= =?utf-8?B?WFBYeENjSlZXcHVXQWZPVitNWFE3anJQYlN5Q3RKUVFBd1BTcDI5UUI0RXdw?= =?utf-8?B?NkZXMWNtSE9zd01pSm9IZ3BzTlBIUnl0Z1NwaktZSUtkNXd5dVRQZ3lJQXlN?= =?utf-8?B?WDVUVHZPbnp4d3FQdHhiT252ZkJLbElsaERhQVMrOUU2MCtPajVQTkZmcjlv?= =?utf-8?B?Z3NEK2hZNWpVRTFXemRUeTE4OWpRUTA2elhmdklPT21aWkJBV2JjaVZ6K3B2?= =?utf-8?B?UkdHRkRoTzFZTE1EbCtteGNEYzE4bW1ZdkVrb0d4SVB3VWlUaENnNGtuQ0Nh?= =?utf-8?B?K2RLWEZJR04wNG4zcENIcldLQmZOTVI0cnZTTXlPMGkrdmJNaFdTd01xamRN?= =?utf-8?B?aFRvUzk4ZGlOb0EyZFFZZDVGYVFvdlRqVk16Y2xwemJIZFZ0aU1LSzR6ejNa?= =?utf-8?B?OFhlSEhJT2s4dkk5d2dLRmRzT01Yek1MRExkcDNaM0hKdVRwRms2WENsOW1i?= =?utf-8?B?eFBteWQyUzBoekhVUmpYZGZGTkJSSEVRWG1CSVVVMnhxdmFHdDcyVTJidmox?= =?utf-8?B?TnBLaHZpR0x1Z0dkUjhSaklNYzNzcFczc2tLNy9IVDhnS1ZYaVA3UWV4UXo3?= =?utf-8?B?ZWZQMmw0dm8rc2FwUE1NUUk0YThQMTkwZko2am02emJWRTRhZmcydnVkdEtY?= =?utf-8?B?bE5IaWcvTCtBcldtYjk5MlFiUnRGemJUUThaQjRteWMxczg1N3dhRmZuTGhV?= =?utf-8?B?Zm9YSnBEV09yUkNHRkNMbHlWRXNVd1ZhUkNhT0VMdmcwZkxZTElQVjQ3TmZM?= =?utf-8?B?aFh6eTgxK092TVdwM0FzNU9tc25ENnN1N3RzT1lleHgveHZwbHd3b0g1c2p3?= =?utf-8?B?bnc2NGN3WG9JODk2alhSVzJPZFZHaDdiRktRMmNXRFhCV3JWMVFMc1p1emN4?= =?utf-8?B?czRNdkQ0OWZHYU40Qzhodi9aT245Y3lDbGN2VG41Q2dPbWR0U2NBZmREOFhv?= =?utf-8?B?NVkySTFQcWFOT1ZjWEJ6ckY5WFJBWXNCTEtOT3FGNEU5NGVTazF0Z2ZCa25x?= =?utf-8?B?NGY2S1NUZVczUFc4eXFyVE0xaVVlSkoyblE0TlZ2VUpXRzVMZjlLNEdzaGVl?= =?utf-8?B?SVpjaDNDL3lRTzA5cGd3YndvNU12TEg2QlYzNUR0WVd2bFg3UXpqS3FHa09m?= =?utf-8?B?QjRjZDVJR2o3Q0hxNDQ4MFk1TkU1V2VoZ3lHbWZrenJYWW5ubjcyRFlXZFVT?= =?utf-8?B?VmFiMS9oZU81N1VWTWgwYi9HcCtnMkljQmtDWldOWC9iUEltcUR5QTBoTUdE?= =?utf-8?B?L0FhMloxNU1MMjZjcWsyeVliaTlCNlcza2RSeEoxK0VMRHppVmFkeStUeGg4?= =?utf-8?B?eGdIOHhLc3RhMFBCTDdYSkVaTlNranUxZzZObE50cWs0c0lleWJEN1ZMYWdn?= =?utf-8?B?WTc1ZkxIV1FkY3Zjb1ZvTnZ2bGIvbnJtQ1QrSHNZeEZQaVFacXMydmxCeTA2?= =?utf-8?B?K0xCZ1I4eURLMVV1SFdqbmdiemEwOGNIckxPSXhxN1lhSnNOZkxrelZJaUZm?= =?utf-8?B?bXdhMDNvUVowcWdlRVlIc1JwVWg2bFZkazJJU1BYY2lGOVVNczkxRmVENTVz?= =?utf-8?B?QTZ4YWZ6cHNZaWZTUFZoaHVZb1VmNDNoZFFwT0J6aUFOQmpKNDllV2RZeWRD?= =?utf-8?B?T2dwQ1ZrTEE3aU5nUGVQLy9Pd2lZR1ZPN1B4THpzNm9KVFFtMmZ0SFlUd0VV?= =?utf-8?B?bWhFTmRlbS84OS9nZVZHTVViK29hZmRBSmtOWmFZT012dmIraUhJWVlmYUhB?= =?utf-8?B?bUE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e9d312b9-eb38-434c-1610-08dc59637e8a X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:38:24.0617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +cKITuaKihKS3J8yUSSx1QUZhywZ10+Yz524QAYr7KrWIjl+51Qp/JP0hUMF0mCH/lqDAy15H6qT5OzsvAp0FtY97i11hEtdR0PJ5sy4MSU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7932 X-OriginatorOrg: intel.com X-Rspamd-Queue-Id: A06701C0018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 54w94j53m8hsoajukz96hstzajpc5z91 X-HE-Tag: 1712756309-398090 X-HE-Meta: U2FsdGVkX18o5XHA2UwCNw6HVz7Zn1av6qJbJeIwYVop2d2wjB5M7D/Zr3E3YJLRmX7ynFsOhm3qxz1FEIfFsP4tRtYC1aVNqwyGauuyHbhBmqxIxKcnJM9zGuHCps7jVkG7xwV8RWaZeK8+nse37CvNaRX/ql7fVbQ5fIS6/X6n2ZbOUevs/fOS644BQ8k5c028KTB95EGPB8Yi3m76lkfEVpBGH7TQZYvtkdcJKtbirg9/y1kG8D5rAQ2lBPOGQPcwfYhY1n6bx3r0ARk9Spe8/EBqINzEefdd+xzzMQ3rfv8qygX1fDeOQzYRVt+yBsDRJ8K61F/hPoNbNm6hgb+4F/p3rL1vhG+Wg6yMTqwZ49SVjwr9/qwzr/SL3wU/uGkknDsBWMRhb9dE5nMAQRo3MHkICKKjrXcKZ1O7HQeTJmzBYZzKxqaJmnUIlXEH2mkuFpeXHbElIraTVWNZOKgyIi3tnPvNvdTjxGplFotSup2GxUZeLqvEGRhViAGNNyrBrvJSlGi7tKy8GqDq/U9JIpPpWdvzNH8EtYHZn01Q1EeUIy5i/WKtgfI/zFoyw8zTNReKAf4O1+Bvi1OChjj3IljFYjiuhXPBAaRXSyWkt63jHttEq5YPdx/APCRJ4xCjf4GJbY6D0q+P9f7v6P9e7yHnfWWGZ+IA51LgbCxsPDVuFNZwx6hsPELSzkFd4JHuhqB1umCH4eVBv76kKyRM5gcjZQCD+9K2lp2MjBN4LaQoxBpuemrodUWUISc0g6dxfaQ6425kUMuCnspXMr+vngJhYONtMqaydP7yA5Ym1+uk+62HF9txz6vRy1srsP6fKCdrbE6Aiz6ZnNwvmtt+43Nlksn22pH1Un15l1lrOACNLrx+Cux6oIVMmAbTNE9FYru10Dodsxu+xJAc69ZmkUegQGQCbOGiDTEjIDDXGG89TzVunIle1Hx54DCPG7GiOE2anjQV09BBvkp YQg1nxMd 4I+z1Vmg0b92IR40tejGwCeraXI6+E6h8zw0/ooKTIPXYKSKrRkFxH1uopnDahkmaMhMD1Fnolpm+LQUHoui+m6wLEWoUmAyhwh2P/IZYkS0NN2nDf5eY/sjeECPys08tjVSNJrOaMoye71y+j8noGbBUJXaDmhhZUaf3OaYzoIsilTcp/fryRIgmFytbAlLVaTcCaN8yYWuRbV+6U6658VNZZ3K/RXnD7568YFgxMgr89uesM++HPCzCYd8Q4hxoitwa/BaKunsJ0PLDYNJIuL7b9c2v4vIHCkJvK86IHPCIK/SOABpIKM0dzoFv9HZ0yhKGl5rc7G+A04WnSa+m23oZpD5+o5FcvB+27o87bwjZMHQZg4F5dIxpSHQAJRSY/m+7ToShwd2UDH43Y0st2ENAJWK9QW1wNPprZLlSiv8BWIVDhZnRZusuErMqz2fxPbNl+Q7CSIJX43w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Kees Cook Date: Tue, 9 Apr 2024 09:17:53 -0700 > On Mon, Apr 08, 2024 at 11:45:32AM +0200, Alexander Lobakin wrote: >> From: Alexander Lobakin >> Date: Mon, 8 Apr 2024 11:11:12 +0200 >> >>> From: Jakub Kicinski >>> Date: Fri, 5 Apr 2024 21:25:13 -0700 >>> >>>> On Thu, 4 Apr 2024 17:44:00 +0200 Alexander Lobakin wrote: >>>>> +/** >>>>> + * struct libeth_fq - structure representing a buffer queue >>>>> + * @fp: hotpath part of the structure >>>> >>>> Second time this happens this week, so maybe some tooling change in 6.9 >>>> but apparently kdoc does not want to know about the tagged struct: >>>> >>>> include/net/libeth/rx.h:69: warning: Excess struct member 'fp' description in 'libeth_fq' >>> >>> Oh no, maybe we should teach kdoc to parse struct_group*()? >> >> scripts/kernel-doc apparently can handle them... >> >> + Kees >> > > Ah, hm, scripts/kernel-doc throws away the early arguments of > struct_group_tagged, but I suspect it needs to create a synthetic member > for the tag. i.e. instead of: > > struct_group_tagged(tag, name, members...) > > becoming > > members... > > it needs to become > > struct tag name; > members... > > It seems this is the first place anyone has tried to document the tagged > struct name! :) It makes sense and TBH I expected kdoc to warn that an element description is missing :D > > Does this work? I haven't tested it... > > diff --git a/scripts/kernel-doc b/scripts/kernel-doc > index 967f1abb0edb..64a19228d5dd 100755 > --- a/scripts/kernel-doc > +++ b/scripts/kernel-doc > @@ -1151,7 +1151,8 @@ sub dump_struct($$) { > # - first eat non-declaration parameters and rewrite for final match > # - then remove macro, outer parens, and trailing semicolon > $members =~ s/\bstruct_group\s*\(([^,]*,)/STRUCT_GROUP(/gos; > - $members =~ s/\bstruct_group_(attr|tagged)\s*\(([^,]*,){2}/STRUCT_GROUP(/gos; > + $members =~ s/\bstruct_group_attr\s*\(([^,]*,){2}/STRUCT_GROUP(/gos; > + $members =~ s/\bstruct_group_tagged\s*\(([^,]*,)([^,]*,)/struct $1 $2; STRUCT_GROUP(/gos; This one does not. We need to exclude ','s from the groups... + $members =~ s/\bstruct_group_tagged\s*\(([^,]*),([^,]*),/struct $1 $2; STRUCT_GROUP(/gos; That one is fine. $members: include/net/libeth/rx.h:91: warning: struct libeth_fq_fp fp; STRUCT_GROUP( struct page_pool *pp; struct libeth_fqe *fqes; u32 truesize; u32 count; ); enum libeth_fqe_type type:2; bool hsplit:1; bool xdp:1; u32 buf_len; int nid; So you almost fixed it :D Which tree this should go through? Should I include this patch to this series with libeth or it's better to push this through kees/linux and then pull to net-next? > $members =~ s/\b__struct_group\s*\(([^,]*,){3}/STRUCT_GROUP(/gos; > $members =~ s/\bSTRUCT_GROUP(\(((?:(?>[^)(]+)|(?1))*)\))[^;]*;/$2/gos; Thanks, Olek