From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F60C636CC for ; Wed, 8 Feb 2023 14:26:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94F996B0071; Wed, 8 Feb 2023 09:26:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FEFD6B0072; Wed, 8 Feb 2023 09:26:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79F646B0073; Wed, 8 Feb 2023 09:26:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6B78E6B0071 for ; Wed, 8 Feb 2023 09:26:04 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 17E7240E93 for ; Wed, 8 Feb 2023 14:26:04 +0000 (UTC) X-FDA: 80444349048.27.75028CC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 5A6D740013 for ; Wed, 8 Feb 2023 14:26:00 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpxTIHXd; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675866360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/IvLCuOLaRze8Czufp82bc2FCFd6M2+RNhdIbbv5WRk=; b=jcTPHczcOZUj7WUIDQ1fPuvMSAbcYwxb9GAS05CPwsP9oOIW+aJ71HHA50TVIw3C0OStfw s/HsKKf8gKRO23e10v88/dFUie97TsVWwMhShpoYXTOH6CHvMcvIkYTrZuVCBVoO/4Lvor kP3g9/RVu0iH5wuF8aP4N01ndW5C0tQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bpxTIHXd; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675866360; a=rsa-sha256; cv=none; b=swYfhAN78UwzyyV/TxKbq1qw3jR+JeNZOLDA5aQvrgb7xaW+QaKsqd15ETE6E0dWVpzWGP 1tQnpJvZZpgFkudVwBIaozabIqtIu7Bf+UJbxQ0nJvWo+5fCtEI6DERLxZltY5dRj9Y+wN nCdDgufGofGvhV5g2piZ9OEUiidc99g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675866359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/IvLCuOLaRze8Czufp82bc2FCFd6M2+RNhdIbbv5WRk=; b=bpxTIHXdPnMNxvhgdpy2fy1/vp+YAQeoKLKd2WBBBkanJHlVapt8b6ndUP/nxX8FDy2sUR dUUQLUCE/J0DlZ/UTHyv0m6qWtRE2a/MRee1364CBjpDN+pL83htmspFGwd0lZ3X8ixznj Fb8u91VFM2ssxzHjLe597pxinzJYrlg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-608-7p8FdgwtOqST4QhyBbMjeg-1; Wed, 08 Feb 2023 09:25:58 -0500 X-MC-Unique: 7p8FdgwtOqST4QhyBbMjeg-1 Received: by mail-wm1-f70.google.com with SMTP id ay19-20020a05600c1e1300b003dc54daba42so8973081wmb.7 for ; Wed, 08 Feb 2023 06:25:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/IvLCuOLaRze8Czufp82bc2FCFd6M2+RNhdIbbv5WRk=; b=FQNkFZYWeMbiZARdx+1d4A86b/byExnISprkPwo3smMDITjVi9hp0ObMAY8Ke+xg/Y ZnR98rrtlMcpEzph+1tFBvyZflHDOT4z9dLkD+7sUYwg1irsDCOugedFzj1++eWW0whT 64gg9lK32gr1Ig3sykLVLeMlbwfo52Hc44bjY5YD47yOeh0DNgKi1Hc0H0smuLU2PGKQ 1Knk9DVwTZX9Sm29j2GsxWibhrpT/a5MSmS4ulsyKaxdp2jjpSgUq8nZZAylKogsruCs wM2hoZ116LTzdE7pvUP1gZoW7FAZ9A65ebG1cVaRhS8B1MZQwgdpuFxUa0iZ7DOJtGC4 3Iaw== X-Gm-Message-State: AO0yUKVE5uLSuZBLMoo+QrumyFdfVecy1FHcG3z3rW/MJz3o5GwLjeVw d0lwj6iUZ/yKMfMZLuGEkkhch5cJeFNI8Rt/qmPpdzad5NOEdraAkcdjta9462lc42Ls5sNZlw3 KHvRjop39P9+tAElw X-Received: by 2002:a05:600c:a295:b0:3da:1e35:dfec with SMTP id hu21-20020a05600ca29500b003da1e35dfecmr6748556wmb.4.1675866357150; Wed, 08 Feb 2023 06:25:57 -0800 (PST) X-Google-Smtp-Source: AK7set+f7X82tVp6vRNf525B+IF2AUQeVlBcbi4PT0MtfnRzlvQ/OYdb11jclNocdF+m4jTYRHPLZQ== X-Received: by 2002:a05:600c:a295:b0:3da:1e35:dfec with SMTP id hu21-20020a05600ca29500b003da1e35dfecmr6748543wmb.4.1675866356920; Wed, 08 Feb 2023 06:25:56 -0800 (PST) Received: from ?IPV6:2003:cb:c704:b300:758c:6214:cd51:8ab0? (p200300cbc704b300758c6214cd518ab0.dip0.t-ipconnect.de. [2003:cb:c704:b300:758c:6214:cd51:8ab0]) by smtp.gmail.com with ESMTPSA id h33-20020a05600c49a100b003de77597f16sm1907620wmp.21.2023.02.08.06.25.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Feb 2023 06:25:56 -0800 (PST) Message-ID: <912208c4-695b-b3bf-4b67-4e2cea37568b@redhat.com> Date: Wed, 8 Feb 2023 15:25:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 02/13] mm/gup: remove obsolete FOLL_LONGTERM comment To: Jason Gunthorpe Cc: Alistair Popple , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" References: <2-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <2-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ttur344taytzgsf3fcyybybx91oziiqt X-Rspamd-Queue-Id: 5A6D740013 X-HE-Tag: 1675866360-659191 X-HE-Meta: U2FsdGVkX19l57bRbgpGnTjxJewmkVdbwHCFuBitRR7Bs9TNNaIAf8Vwpp22UNP6BnZaBEH8OhjZ6ykfPRy5lA3xtzPYnLHsc36ubcnVNh2gBmPsS8XfNZ/SxMD1VeK3inTtasw0Ci2N8EjaI9m7gyxwKVs4Mc0XbgyDy09bUiptD4eBgkND6yFTiAnbHc6tjQjHU9X/6dAXpTBJ16NluzOaVHtBTm7nH3q3vq2wzs3MbDoMu4WCiVOxWaVjGmgElcHmDYW1ISn+Ce9XXQAq79VkzO8OtiOxUZgJgSbOoBkOk3CTk14JLXTUXnu7WyLtqIMpZ8D9eF/QVc2zRbr3Y/EzaBDfR80ItgavkenDgAg/N/Tdf6Azcj51cikYSPpnq2zs06/zYXs0tYXTIeky9fmZFWB8xiZJiZ6pDiXbbGc3q5uakPgHDAG7Yn/UFMWswS71wmHDvv9tyHhtp+gdIbCMrNkk+jXBnr+LRXB0zAQevqQeJK6A37v8SJM8EsjpL0QEM8Nt7t2m6ZyYzZUGMoIqn2vjyPVsd8CYYcfLNICeCmU9l+/xnpwL99CLy8Sgtg7dZjFMRclpMqApYAsZGDwL17Jq2BzMo1tgtkHg7w6tu2briA3oF7S5z1JAn26g5LaWl+IVUB4OTBk/Sk+9D68VthF22QTuOmgHehviW5ZRZzSIwglXDBnniZ6aAHmRAlrGE4ogvgfqwSE+9U6uUFzt6Q/YNuO32tgQWXwh7YrWmMCwAODt5P9wgL1CizySV50X8vh+sqpb28UWueBs8xynl0c5eoZnPh89Bgo0FSn8AwBwfeN3QaaA/mzVJjSDVILcoemDFTrcV8DPWqVf3CKB+tlk8Po3++hqAWUT/HsSR97LLdp7Rsv5W/XQW3IIM5sG/PiVU44UAwiV+4BOOs5Ff78sA7eh/ufaBJQXo2XfCrRhLXdgYbKPl9mNReVUbSpWBi5B43LE6FfPUX9 Uejy0iEB Z9JGRZ/G0BY6H9NACTMu0GSZ4qo5hQdGz5fEq8TOGHuRPIwyNx0L/MgkBTRUPkOMu4Zbxrb3EIFqgr7rd1OgIDAmAqhTGR08T+yUsDyF6Ccp81LAauy76/mRr1Mql+3uc1NKUKXcqUwAmsoQ+GndjYzxOs4LhIc8Wr7QWMDranzvoavM9F4ilqnvBAcjNHKjuow5Gtsq1PQD6wzdJAezRaw+HezKojUW+w/7iJG6j8bPEOm2nT1ZbS1E9rwBO4DA7iagHfUU3uQl4Qdx9HKIvUq2/ksTuskTvBX4EYOki0asYhsnZa4qJmSmqH38LEmkN+b58gtSqvwn1k46Z5YRAB4AyZNdS5EvM7qPbn6kvt9ineITqdskajunozCkz/5UGgVmBtbFOH3Nvrlw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 21:34, Jason Gunthorpe wrote: > These days FOLL_LONGTERM is not allowed at all on any get_user_pages*() > functions, it must be only be used with pin_user_pages*(), plus it now has > universal support for all the pin_user_pages*() functions. > > Signed-off-by: Jason Gunthorpe > --- > include/linux/mm_types.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index a689198caf7408..8971a40c120e38 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -1052,12 +1052,6 @@ typedef unsigned int __bitwise zap_flags_t; > * specifically failed. Filesystem pages are still subject to bugs and use of > * FOLL_LONGTERM should be avoided on those pages. > * > - * FIXME: Also NOTE that FOLL_LONGTERM is not supported in every GUP call. > - * Currently only get_user_pages() and get_user_pages_fast() support this flag > - * and calls to get_user_pages_[un]locked are specifically not allowed. This > - * is due to an incompatibility with the FS DAX check and > - * FAULT_FLAG_ALLOW_RETRY. > - * > * In the CMA case: long term pins in a CMA region would unnecessarily fragment > * that region. And so, CMA attempts to migrate the page before pinning, when > * FOLL_LONGTERM is specified. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb