From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A1EC43461 for ; Mon, 14 Sep 2020 03:19:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B54C1214F1 for ; Mon, 14 Sep 2020 03:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B54C1214F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E47416B0055; Sun, 13 Sep 2020 23:19:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8186B005A; Sun, 13 Sep 2020 23:19:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBF446B005C; Sun, 13 Sep 2020 23:19:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B2C2D6B0055 for ; Sun, 13 Sep 2020 23:19:01 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 773A0180AD801 for ; Mon, 14 Sep 2020 03:19:01 +0000 (UTC) X-FDA: 77260210482.10.road50_0b03c4e27105 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 431AF16A0BE for ; Mon, 14 Sep 2020 03:19:01 +0000 (UTC) X-HE-Tag: road50_0b03c4e27105 X-Filterd-Recvd-Size: 2926 Received: from huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 03:19:00 +0000 (UTC) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8AAEA707EE2375575932; Mon, 14 Sep 2020 11:18:55 +0800 (CST) Received: from [10.174.178.86] (10.174.178.86) by smtp.huawei.com (10.3.19.214) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 14 Sep 2020 11:18:53 +0800 Subject: Re: [External] Re: [PATCH v3] mm: memcontrol: Add the missing numa_stat interface for cgroup v2 To: Muchun Song , Chris Down CC: , Johannes Weiner , , Michal Hocko , Vladimir Davydov , Andrew Morton , Shakeel Butt , Roman Gushchin , Cgroups , , LKML , Linux Memory Management List , kernel test robot References: <20200913070010.44053-1-songmuchun@bytedance.com> <20200913170913.GB2239582@chrisdown.name> From: Zefan Li Message-ID: <91184891-6a12-87a2-5a82-099a637b072f@huawei.com> Date: Mon, 14 Sep 2020 11:18:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.86] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 431AF16A0BE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/9/14 11:10, Muchun Song wrote: > On Mon, Sep 14, 2020 at 1:09 AM Chris Down wrote: >> >> Muchun Song writes: >>> In the cgroup v1, we have a numa_stat interface. This is useful for >>> providing visibility into the numa locality information within an >>> memcg since the pages are allowed to be allocated from any physical >>> node. One of the use cases is evaluating application performance by >>> combining this information with the application's CPU allocation. >>> But the cgroup v2 does not. So this patch adds the missing information. >>> >>> Signed-off-by: Muchun Song >>> Suggested-by: Shakeel Butt >>> Reported-by: kernel test robot >> >> This is a feature patch, why does this have LKP's Reported-by? > > In the v2 version, the kernel test robot reported a compiler error > on the powerpc architecture. So I added that. Thanks. > You should remove this reported-by, and then add v2->v3 changelog: ...original changelog... v3: - fixed something reported by test rebot