From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872D6C3DA4A for ; Thu, 1 Aug 2024 03:32:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21CBA6B009C; Wed, 31 Jul 2024 23:32:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CCDD6B009D; Wed, 31 Jul 2024 23:32:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BB926B009F; Wed, 31 Jul 2024 23:32:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E8D8F6B009C for ; Wed, 31 Jul 2024 23:32:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 84F161A0699 for ; Thu, 1 Aug 2024 03:32:39 +0000 (UTC) X-FDA: 82402254438.14.844B746 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by imf23.hostedemail.com (Postfix) with ESMTP id DE31814000C for ; Thu, 1 Aug 2024 03:32:34 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of yangerkun@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=yangerkun@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722483116; a=rsa-sha256; cv=none; b=aebYkvTLDsg7te6bk6EZXiIQLCcLfk8kYFSWoxfozq4zjemDMO4dOIwUx6o5x0kjIX4FpN cF/7innfMe1GVlxPPCUce4Ax0V3CLEbAvs9ZbatmbwBs6/AuTDvuYnKHboA1yc3itfv+OC oafy/9KUR/igG82LNOD8nuGwZEbN7/U= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf23.hostedemail.com: domain of yangerkun@huaweicloud.com designates 45.249.212.56 as permitted sender) smtp.mailfrom=yangerkun@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722483116; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BPrzeFS7ywA9bn8StiK+wz6BrittGRecTgUn2IfKyx0=; b=0K2vKCYkg09VcRtFyPYSNpZI2/bUB9v9YkSR+8TiHDJTEA/2rY7L14WMx12Rj0xwEL5zQV cW/N5+UsCkKECSX24+li4PFrFnv2xEfWnBN96eMsOJE5cwzDDYBavRKp1AHl8zQb9Qc5vv mZ0RVen+beQ8ZeuDWPQhkHaTOid1/f0= Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4WZDzh3lPjz4f3jXV for ; Thu, 1 Aug 2024 11:32:16 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 7B4331A0359 for ; Thu, 1 Aug 2024 11:32:29 +0800 (CST) Received: from [10.174.177.210] (unknown [10.174.177.210]) by APP4 (Coremail) with SMTP id gCh0CgBXfoTJAatmIou8AQ--.18102S3; Thu, 01 Aug 2024 11:32:27 +0800 (CST) Message-ID: <9107aa4d-c888-3a73-0a07-a9d49f5ec558@huaweicloud.com> Date: Thu, 1 Aug 2024 11:32:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir To: Christian Brauner , chuck.lever@oracle.com, jack@suse.cz, yangerkun Cc: hughd@google.com, zlang@kernel.org, fdmanana@suse.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, viro@zeniv.linux.org.uk References: <20240731043835.1828697-1-yangerkun@huawei.com> <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> From: yangerkun In-Reply-To: <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBXfoTJAatmIou8AQ--.18102S3 X-Coremail-Antispam: 1UD129KBjvJXoW7uw48Cw1DGr48Gr45JFy8AFb_yoW8XFWrpa ykGw4DKr4DXF1UG3929FnruFyFgan3Jr13K34DXw4kZryYgr93KFyI9r4Yga4vkr9a9w42 qF43t3s5GF1xZFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Ib4IE77IF4wAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4I kC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWU WwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr 0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWU JVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJb IYCTnIWIevJa73UjIFyTuYvjxUF1v3UUUUU X-CM-SenderInfo: 51dqwvhunx0q5kxd4v5lfo033gof0z/ X-Rspamd-Queue-Id: DE31814000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qnqwojcgrgs8kfawcn7qedne16koyb84 X-HE-Tag: 1722483154-540830 X-HE-Meta: U2FsdGVkX18qg6b3ORRMXL6/KQSEVowHCd+n8G+Zcf4oyo/aWxV7vHV4g7OgkINUzeNv+WrgF7msX6pLFvU3AC9iJkiQ/mIWw+x0W3a1i/avdn/je43rLT7qOONo+HtxhBLUn7IgW65R2bH0m+efnsTunIZkyK3/Bkx66thKkIVOjWTXgmRIrl/KBpz9oelJS3o6axS/CdE+q1lCRLYzG96kIs1wnW/kt6zQsl1UDwHumlERd2J+dkxKoh5gJNZfSRSROszFQsjRRA9A7GLzwTBLMoiz/uL4f8MQuPN1PTj1RS7cLkYY1Ywh+siHt2jTSlbnls8iMLLusMSP5ExEU6eW7KDXcoXqouzKxM9BSYEo3Sawcfx4F8S5o1jeMZd3a1tQnBxQj2Jvsz8knU4J5iOSzoBK/OUunmimCUHFnxb/r6d3iKKPK31q/FPcXsvrdLqwEh73LyAQIrf1U/hwcwNn0FQoZxkDTtJsqqB8bK5NSS/Jkaly3wUvKOp5R42dUeAXdoQCqX2++IAwIYNito062qxB0b3x5nvzphi286OerKUJ1wZlNmJfCkXi5cM7B0iuyuQm7bb3zPdPcYSKtoNepJVfTRWBz+0Qel4+51vr44cLDO+eSnf3DrOx2rpkoYIf+eI1k1n7obMS/8qyQ4KSurqMQ+rWoESV7aqi4k7VSfnV6iBClV8qbfkTi7nJp9qWg2ixkg6XI2Fi17NWBh5SpcPvZDwBb3eBONGoRmrL2XWGvwudm46G/+IBxbex6OIDKWS+cyQilzRU0TRD9LEhRFTs0ZV9z220wlU42W1vC2SbF99frj7vLVabuLN8GLRvB4ryeRcV+v9/XeEdnAdYodarGdWKVdynmqq+OOLovHeREhIbxEs6xhPp79+1Tc/RG6kSpZsDIDJdykaFCvqrxXZlVrdnHSdpVYeB3jHAyaHIPlE9CBQY5IYYhMQZNJtiF+6cN+LfwYaijer vEzM3OcH gmb1cYZV7oa/gtzFqBrQ+hiYhclmQyePSEsa1cVy2oclR9HwU/sgK87Kx5LPEsgrgApftIgvOyBjveAIMT5vnxyMrNpGiWZIO1qu/gaJSMgf9s8Mg+FTaceiVgb+9ep63SJVea6CqYc7YdMrbcc6I49/IrIjRl2LsRWCvqqNXMNL+MIPmWBlSDNk9f3UqgRw1XUKRHFUh73x+eH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! 在 2024/7/31 22:16, Christian Brauner 写道: > On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: >> After we switch tmpfs dir operations from simple_dir_operations to >> simple_offset_dir_operations, every rename happened will fill new dentry >> to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free >> key starting with octx->newx_offset, and then set newx_offset equals to >> free key + 1. This will lead to infinite readdir combine with rename >> happened at the same time, which fail generic/736 in xfstests(detail show >> as below). >> >> [...] > > @Chuck, @Jan I did the requested change directly. Please check! Thanks for applied this patch, the suggestions from Jan and Chuck will be a separates patch! > > --- > > Applied to the vfs.fixes branch of the vfs/vfs.git tree. > Patches in the vfs.fixes branch should appear in linux-next soon. > > Please report any outstanding bugs that were missed during review in a > new review to the original patch series allowing us to drop it. > > It's encouraged to provide Acked-bys and Reviewed-bys even though the > patch has now been applied. If possible patch trailers will be updated. > > Note that commit hashes shown below are subject to change due to rebase, > trailer updates or similar. If in doubt, please check the listed branch. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git > branch: vfs.fixes > > [1/1] libfs: fix infinite directory reads for offset dir > https://git.kernel.org/vfs/vfs/c/fad90bfe412e